)]}'
{"id":"openstack%2Fplacement~661182","triplet_id":"openstack%2Fplacement~master~Ida78cfabe59a03d65f50545e0a6859abaa0e5d40","project":"openstack/placement","branch":"master","topic":"trivial","hashtags":[],"change_id":"Ida78cfabe59a03d65f50545e0a6859abaa0e5d40","subject":"Trivial: Fix comment for LEFT join","status":"MERGED","created":"2019-05-24 04:58:08.000000000","updated":"2019-05-24 19:13:58.000000000","submitted":"2019-05-24 19:13:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"661182-1558725238424-a4b174ff","meta_rev_id":"e19ba6be0fc041cba96c6ddcb95b065fcf1ae290","_number":661182,"virtual_id_number":661182,"owner":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-24 19:13:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-24 14:00:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-05-24 14:00:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-24 14:00:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-24 13:51:30.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-05-24 14:00:32.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-05-24 19:13:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9b8d31a5a61ba8495d2d47006123e65db707a322","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-05-24 04:58:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d223ab2ccc39b224c3d4fa70c08c42a97b8a5a05","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 07:00:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/82/661182/1/check/grenade-py3/71104c4/ : SUCCESS in 54m 20s\n- tempest-full-py3 http://logs.openstack.org/82/661182/1/check/tempest-full-py3/ae06b43/ : SUCCESS in 1h 50m 12s\n- openstack-tox-docs http://logs.openstack.org/82/661182/1/check/openstack-tox-docs/62c63a9/html/ : SUCCESS in 4m 18s\n- openstack-tox-cover http://logs.openstack.org/82/661182/1/check/openstack-tox-cover/208032d/ : FAILURE in 5m 51s\n- openstack-tox-lower-constraints http://logs.openstack.org/82/661182/1/check/openstack-tox-lower-constraints/85ba645/ : SUCCESS in 4m 52s\n- openstack-tox-pep8 http://logs.openstack.org/82/661182/1/check/openstack-tox-pep8/f69870b/ : SUCCESS in 6m 15s\n- openstack-tox-py27 http://logs.openstack.org/82/661182/1/check/openstack-tox-py27/e81428e/ : SUCCESS in 4m 24s\n- openstack-tox-py36 http://logs.openstack.org/82/661182/1/check/openstack-tox-py36/4778ae3/ : SUCCESS in 5m 20s\n- openstack-tox-py37 http://logs.openstack.org/82/661182/1/check/openstack-tox-py37/7742760/ : SUCCESS in 4m 53s\n- openstack-tox-functional http://logs.openstack.org/82/661182/1/check/openstack-tox-functional/bd4a4f5/ : FAILURE in 3m 53s\n- openstack-tox-functional-py36 http://logs.openstack.org/82/661182/1/check/openstack-tox-functional-py36/3e2c2f4/ : FAILURE in 4m 34s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/82/661182/1/check/placement-nova-tox-functional-py36/b4286a8/ : SUCCESS in 13m 46s\n- placement-perfload http://logs.openstack.org/82/661182/1/check/placement-perfload/4d9480f/ : SUCCESS in 3m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"587e73d7e4b7bc56f5ad5a69a274930a4aa18564","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-24 08:23:29.000000000","message":"Patch Set 1:\n\nthe failures are from os-resource-classes which is fixed by https://review.opendev.org/#/c/661131/\n\nwhen that merges this should be good","accounts_in_message":[],"_revision_number":1},{"id":"28d59c5c08dd64f75dc72f98b5916e7d045d302d","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-24 08:26:11.000000000","message":"Patch Set 1:\n\nThis is a good example of docs getting out of sync with code because they are effectively both code, but in different forms. I agree that the SQL comments sometimes help to understand what is being assembled but they are fragile to this kind of thing.\n\nIn that past I\u0027ve wondered if our query generators should be methods of their own, with unit tests that evaluate the generated sql and then those tests would be the explainers.\n\nThat sounds like a lot of work we don\u0027t really have time for now, but maybe someday.","accounts_in_message":[],"_revision_number":1},{"id":"40875fd8e96a10fb0eb74461b09c250a57ed6988","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-24 13:51:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"918e2b971f810f40d84cc05f391a2d8a420f4ff3","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-24 14:00:20.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"b60baedd462e5794493770738ffc67804eafcff1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-24 14:00:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a4ee0fe43bfb8e7451c68fe9d486f6ff1eda294f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 17:37:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/82/661182/2/check/grenade-py3/79831bb/ : SUCCESS in 59m 21s\n- tempest-full-py3 http://logs.openstack.org/82/661182/2/check/tempest-full-py3/3eeeae2/ : SUCCESS in 1h 25m 19s\n- openstack-tox-docs http://logs.openstack.org/82/661182/2/check/openstack-tox-docs/739ace7/html/ : SUCCESS in 4m 23s\n- openstack-tox-cover http://logs.openstack.org/82/661182/2/check/openstack-tox-cover/8b48446/cover/ : SUCCESS in 5m 18s\n- openstack-tox-lower-constraints http://logs.openstack.org/82/661182/2/check/openstack-tox-lower-constraints/4de89f6/ : SUCCESS in 5m 32s\n- openstack-tox-pep8 http://logs.openstack.org/82/661182/2/check/openstack-tox-pep8/cd9b8fb/ : SUCCESS in 5m 02s\n- openstack-tox-py27 http://logs.openstack.org/82/661182/2/check/openstack-tox-py27/d4637e2/ : SUCCESS in 3m 51s\n- openstack-tox-py36 http://logs.openstack.org/82/661182/2/check/openstack-tox-py36/6be038a/ : SUCCESS in 5m 37s\n- openstack-tox-py37 http://logs.openstack.org/82/661182/2/check/openstack-tox-py37/fd61a88/ : SUCCESS in 6m 05s\n- openstack-tox-functional http://logs.openstack.org/82/661182/2/check/openstack-tox-functional/9695eae/ : SUCCESS in 5m 36s\n- openstack-tox-functional-py36 http://logs.openstack.org/82/661182/2/check/openstack-tox-functional-py36/e6a270b/ : SUCCESS in 6m 53s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/82/661182/2/check/placement-nova-tox-functional-py36/21fc70b/ : SUCCESS in 11m 26s\n- placement-perfload http://logs.openstack.org/82/661182/2/check/placement-perfload/43d89e8/ : SUCCESS in 4m 09s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"47b3c7cf3d3914a113ef8c060bef5b6930cc6335","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 17:37:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"4fc4946fb1f4a5e3fcbb9a8f685bf9ed0412a150","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 19:13:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"234f53c887d937525a5b18ac9fd72866b0c999e5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-24 19:13:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/82/661182/2/gate/grenade-py3/1816a40/ : SUCCESS in 59m 51s\n- tempest-full-py3 http://logs.openstack.org/82/661182/2/gate/tempest-full-py3/377c81e/ : SUCCESS in 1h 27m 07s\n- openstack-tox-docs http://logs.openstack.org/82/661182/2/gate/openstack-tox-docs/0a61ca3/html/ : SUCCESS in 5m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/82/661182/2/gate/openstack-tox-lower-constraints/80a8337/ : SUCCESS in 5m 00s\n- openstack-tox-pep8 http://logs.openstack.org/82/661182/2/gate/openstack-tox-pep8/a9b1143/ : SUCCESS in 4m 13s\n- openstack-tox-py27 http://logs.openstack.org/82/661182/2/gate/openstack-tox-py27/07a8bd5/ : SUCCESS in 4m 14s\n- openstack-tox-py36 http://logs.openstack.org/82/661182/2/gate/openstack-tox-py36/e28f324/ : SUCCESS in 4m 50s\n- openstack-tox-py37 http://logs.openstack.org/82/661182/2/gate/openstack-tox-py37/366316c/ : SUCCESS in 6m 31s\n- openstack-tox-functional http://logs.openstack.org/82/661182/2/gate/openstack-tox-functional/b9bca14/ : SUCCESS in 5m 58s\n- openstack-tox-functional-py36 http://logs.openstack.org/82/661182/2/gate/openstack-tox-functional-py36/0c6aeed/ : SUCCESS in 5m 51s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/82/661182/2/gate/placement-nova-tox-functional-py36/cb3b2d2/ : SUCCESS in 10m 55s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"aeb65d4cd9fe8f052233a4daf5dd6dfdbc1f1b8e","revisions":{"57e3328055879d1c786132cf8cbd9f9fb492657f":{"kind":"REWORK","_number":1,"created":"2019-05-24 04:58:08.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/82/661182/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/82/661182/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/661182/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/661182/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/661182/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/82/661182/1"}}},"commit":{"parents":[{"commit":"4d05bb8f0bcf3974105ab30825993fccc6b096d0","subject":"Fixups from removing null provider protections","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4d05bb8f0bcf3974105ab30825993fccc6b096d0"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-21 19:36:10.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-21 19:42:07.000000000","tz":0},"subject":"Trivial: Fix comment for LEFT join","message":"Trivial: Fix comment for LEFT join\n\nThis patch fixes some comments `LEFT` to `INNER`\non SQL queries.\n\nChange-Id: Ida78cfabe59a03d65f50545e0a6859abaa0e5d40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57e3328055879d1c786132cf8cbd9f9fb492657f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/57e3328055879d1c786132cf8cbd9f9fb492657f"}]},"branch":"refs/heads/master"},"aeb65d4cd9fe8f052233a4daf5dd6dfdbc1f1b8e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-05-24 14:00:20.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/82/661182/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/82/661182/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/661182/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/661182/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/661182/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/82/661182/2"}}},"commit":{"parents":[{"commit":"d878d82b6b39839dd2956770b6207d2d930e9a4f","subject":"Merge \"Canary test for os-traits version\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d878d82b6b39839dd2956770b6207d2d930e9a4f"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-05-21 19:36:10.000000000","tz":0},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-24 14:00:20.000000000","tz":0},"subject":"Trivial: Fix comment for LEFT join","message":"Trivial: Fix comment for LEFT join\n\nThis patch fixes some comments `LEFT` to `INNER`\non SQL queries.\n\nChange-Id: Ida78cfabe59a03d65f50545e0a6859abaa0e5d40\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/aeb65d4cd9fe8f052233a4daf5dd6dfdbc1f1b8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/aeb65d4cd9fe8f052233a4daf5dd6dfdbc1f1b8e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}