)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ac5678bb94d222ca2295211598be6a61370f813","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add olso.middleware.cors to conf generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CORS configuration settings are available to placement, so we"},{"line_number":10,"context_line":"should include them in the sample and docs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I15587af6a302f87b4159c819a8046ab489b684ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_da0b3fd3","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":54},"updated":"2019-05-28 18:00:50.000000000","message":"Note to reviewers (but mainly self):\n\nThese opts are registered in deploy.py [1] as opposed to conf.register_opts [2] where I expected them.\n\nThere\u0027s a comment above [1] that may be explaining why we have to do it there. Or it may be explaining why we have to do the bit below it, and the actual opt registration could in fact be at [2]. If that\u0027s the case, can we please do that?\n\n[1] https://opendev.org/openstack/placement/src/branch/master/placement/deploy.py#L46\n[2] https://opendev.org/openstack/placement/src/branch/master/placement/conf/__init__.py#L29","commit_id":"7db2e29325a0d06483296076bd1baf2fc8675f78"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"68d9836213bc03308ed94b0890e18e5c91a17108","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add olso.middleware.cors to conf generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CORS configuration settings are available to placement, so we"},{"line_number":10,"context_line":"should include them in the sample and docs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I15587af6a302f87b4159c819a8046ab489b684ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_c067c6e8","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":54},"in_reply_to":"bfb3d3c7_12fa13bc","updated":"2019-05-29 09:32:52.000000000","message":"https://review.opendev.org/661922","commit_id":"7db2e29325a0d06483296076bd1baf2fc8675f78"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ac3d72dc23c532c3e04b1e53d2fa9a7c2786ce19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add olso.middleware.cors to conf generator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CORS configuration settings are available to placement, so we"},{"line_number":10,"context_line":"should include them in the sample and docs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I15587af6a302f87b4159c819a8046ab489b684ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_12fa13bc","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":54},"in_reply_to":"bfb3d3c7_da0b3fd3","updated":"2019-05-29 08:42:36.000000000","message":"I can\u0027t remember exactly, but what\u0027s there is probably a result of gymnastics to avoid confusion with global config and nova\u0027s config (it was the [cors] section from nova.conf at the time). Now that placement globally (hah) doesn\u0027t use global config and doesn\u0027t need to worry about nova it can probably be simplified in the way you describe. In fact I\u0027ll try right now shall I?","commit_id":"7db2e29325a0d06483296076bd1baf2fc8675f78"}]}