)]}'
{"id":"openstack%2Fplacement~661922","triplet_id":"openstack%2Fplacement~master~I8481b3016de19e1617810cb3d3efa092560dfbb7","project":"openstack/placement","branch":"master","topic":"cd/fix-cors-config","hashtags":[],"change_id":"I8481b3016de19e1617810cb3d3efa092560dfbb7","subject":"Modernize CORS config and setup","status":"MERGED","created":"2019-05-29 09:32:22.000000000","updated":"2019-06-10 17:12:41.000000000","submitted":"2019-06-10 17:12:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"661922-1560186761430-8840775f","meta_rev_id":"03cf9be32509a5c115192937f60e0636b2b2df82","_number":661922,"virtual_id_number":661922,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2019-05-29 10:21:03.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-06-10 17:12:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2019-05-30 00:58:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-05-29 10:15:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-06-10 13:31:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-06-10 13:31:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-29 10:15:24.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-05-30 00:58:46.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-06-10 13:31:29.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-06-10 17:12:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"83d20cbaefdc539b57342996ce1fae82e153a880","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-29 09:32:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c1b26d80865a740869bb3c9c09360ff14e6661e3","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-05-29 10:15:24.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nYes please on the consolidated registration. The rest is Greek to me.\n\nIt would be nice to see the nova dsvmZ run against this before it lands, but that may be more trouble than it\u0027s worth these days.","accounts_in_message":[],"_revision_number":1},{"id":"a0d76743fabbcd5104a3ee1dda7004c756ab95d5","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-05-29 10:21:03.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e It would be nice to see the nova dsvmZ run against this before it\n \u003e lands, but that may be more trouble than it\u0027s worth these days.\n\nAs far as I can tell, the nova in devstack/tempest/grenade does not exercise/touch CORS so unless we are thinking this change is going to magically turn CORS on (it won\u0027t) there should be no impact.","accounts_in_message":[],"_revision_number":1},{"id":"574ebe90569170f2b3602de74ec6154fd0ced3f7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 14:03:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/22/661922/1/check/grenade-py3/d593a28/ : SUCCESS in 46m 06s\n- tempest-full-py3 http://logs.openstack.org/22/661922/1/check/tempest-full-py3/2f1539c/ : SUCCESS in 1h 31m 33s\n- openstack-tox-docs http://logs.openstack.org/22/661922/1/check/openstack-tox-docs/6f8ff09/html/ : SUCCESS in 4m 02s\n- openstack-tox-cover http://logs.openstack.org/22/661922/1/check/openstack-tox-cover/1645f0e/cover/ : SUCCESS in 5m 42s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/661922/1/check/openstack-tox-lower-constraints/8baa1c7/ : SUCCESS in 4m 53s\n- openstack-tox-pep8 http://logs.openstack.org/22/661922/1/check/openstack-tox-pep8/bc6a383/ : SUCCESS in 4m 12s\n- openstack-tox-py27 http://logs.openstack.org/22/661922/1/check/openstack-tox-py27/497b8ec/ : SUCCESS in 4m 00s\n- openstack-tox-py36 http://logs.openstack.org/22/661922/1/check/openstack-tox-py36/abff578/ : SUCCESS in 4m 05s\n- openstack-tox-py37 http://logs.openstack.org/22/661922/1/check/openstack-tox-py37/7a110bc/ : SUCCESS in 4m 46s\n- openstack-tox-functional http://logs.openstack.org/22/661922/1/check/openstack-tox-functional/53b221d/ : SUCCESS in 5m 00s\n- openstack-tox-functional-py36 http://logs.openstack.org/22/661922/1/check/openstack-tox-functional-py36/4a63c52/ : SUCCESS in 4m 46s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/22/661922/1/check/placement-nova-tox-functional-py36/86f44e2/ : SUCCESS in 10m 19s\n- placement-perfload http://logs.openstack.org/22/661922/1/check/placement-perfload/d22d472/ : SUCCESS in 3m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"27b37335934db3048949b47c364d3f56f848d93d","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-05-30 00:58:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"044994dd6fe133bf5711dae80ccfd3b6b668661c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-10 13:31:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8e61c9b7e11046f597965c3eb05040f4a689909a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-10 13:31:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"24375cba79a34f6e580be988578315a4bd65500c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-10 17:12:41.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/22/661922/1/gate/grenade-py3/0074f0b/ : SUCCESS in 1h 00m 12s\n- tempest-full-py3 http://logs.openstack.org/22/661922/1/gate/tempest-full-py3/a93d74a/ : SUCCESS in 1h 52m 02s\n- openstack-tox-docs http://logs.openstack.org/22/661922/1/gate/openstack-tox-docs/e4b6c38/html/ : SUCCESS in 4m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/22/661922/1/gate/openstack-tox-lower-constraints/7dd5cb0/ : SUCCESS in 5m 26s\n- openstack-tox-pep8 http://logs.openstack.org/22/661922/1/gate/openstack-tox-pep8/13dd0a7/ : SUCCESS in 4m 16s\n- openstack-tox-py27 http://logs.openstack.org/22/661922/1/gate/openstack-tox-py27/d57fe49/ : SUCCESS in 4m 41s\n- openstack-tox-py36 http://logs.openstack.org/22/661922/1/gate/openstack-tox-py36/36e1e51/ : SUCCESS in 5m 12s\n- openstack-tox-py37 http://logs.openstack.org/22/661922/1/gate/openstack-tox-py37/d0219e1/ : SUCCESS in 8m 18s\n- openstack-tox-functional http://logs.openstack.org/22/661922/1/gate/openstack-tox-functional/811d205/ : SUCCESS in 9m 50s\n- openstack-tox-functional-py36 http://logs.openstack.org/22/661922/1/gate/openstack-tox-functional-py36/286fa9b/ : SUCCESS in 5m 47s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/22/661922/1/gate/placement-nova-tox-functional-py36/8aacf56/ : SUCCESS in 10m 44s","accounts_in_message":[],"_revision_number":1},{"id":"655f0e8e642921c92482d8840f752e6a7c8e580c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-10 17:12:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fc35e3112e92648080994c5388ce510bfb4b0a9d","revisions":{"fc35e3112e92648080994c5388ce510bfb4b0a9d":{"kind":"REWORK","_number":1,"created":"2019-05-29 09:32:22.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/22/661922/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/22/661922/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/661922/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/661922/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/22/661922/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/22/661922/1"}}},"commit":{"parents":[{"commit":"c81f62d50177792af2304aff735bc107f57bee30","subject":"Merge \"Use trait strings in ProviderSummary objects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c81f62d50177792af2304aff735bc107f57bee30"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-29 09:12:17.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-05-29 09:31:14.000000000","tz":60},"subject":"Modernize CORS config and setup","message":"Modernize CORS config and setup\n\nIn the early days of placement, the CORS middleware\u0027s config\noptions were registered out of band with other options, probably\ndue to efforts to use non-global config and avoid conflicts with\nnova\u0027s use of the same settings. Now that placement always uses\nnon-global config, we can change setup back to something more\nnormal.\n\nAt the same time a gap in header-visibility defaults is corrected.\n\nThe updated test confirms header visibility. When the \u0027allow_headers\u0027\nconfiguration setting in fixtures/gabbits.py is removed, it fails.\n\nChange-Id: I8481b3016de19e1617810cb3d3efa092560dfbb7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/fc35e3112e92648080994c5388ce510bfb4b0a9d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/fc35e3112e92648080994c5388ce510bfb4b0a9d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}