)]}'
{"placement/objects/allocation_candidate.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"73b221ea1eae9ef558308e10a9f90381963cefc5","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    :param requested_resources: dict, keyed by resource class ID, of amounts"},{"line_number":462,"context_line":"                                being requested for that resource class"},{"line_number":463,"context_line":"    :param provider: ResourceProvider object representing the provider of the"},{"line_number":464,"context_line":"                     resources."},{"line_number":465,"context_line":"    \"\"\""},{"line_number":466,"context_line":"    resource_requests \u003d ["},{"line_number":467,"context_line":"        AllocationRequestResource("}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_24a56fa2","line":464,"updated":"2019-06-14 09:08:59.000000000","message":"doc missing for suffix","commit_id":"eb07913442974102b36b8127db8491a742f5eee1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"49ae4ac2afca7276d4e13661f485cd34f53b9db6","unresolved":false,"context_lines":[{"line_number":847,"context_line":"            # ]"},{"line_number":848,"context_line":"            # to this:"},{"line_number":849,"context_line":"            # areq_combined(arrX, arrY, arrZ, arrM, arrN, arrQ)"},{"line_number":850,"context_line":"            # Note that this discards the information telling us which"},{"line_number":851,"context_line":"            # RequestGroup led to which piece of the final AllocationRequest."},{"line_number":852,"context_line":"            # We needed that to be present for the previous filter; we need it"},{"line_number":853,"context_line":"            # to be *absent* for the next one (and for the final output)."},{"line_number":854,"context_line":"            areq \u003d _consolidate_allocation_requests(areq_list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_5fa4f44a","line":851,"range":{"start_line":850,"start_character":1,"end_line":851,"end_character":77},"updated":"2019-06-29 17:01:39.000000000","message":"this is no longer true","commit_id":"eb07913442974102b36b8127db8491a742f5eee1"}],"placement/tests/functional/db/test_allocation_candidates.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ef8ac8196e9e9bb99186617a05f20be21d2d004f","unresolved":false,"context_lines":[{"line_number":2924,"context_line":"        # in this case, should keep the results at 4 since they are defined to"},{"line_number":2925,"context_line":"        # be different when they have different suffixes even if they have the"},{"line_number":2926,"context_line":"        # same resource provider, the same resource class and the same desired"},{"line_number":2927,"context_line":"        # amount."},{"line_number":2928,"context_line":"        self.assertEqual(4, len(alloc_cands.allocation_requests))"},{"line_number":2929,"context_line":""},{"line_number":2930,"context_line":"    def test_nested_result_count_none(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_55d0b91f","line":2927,"updated":"2019-06-07 20:56:09.000000000","message":"✔","commit_id":"e61e88c153692032a0757d2465faf07b5322f424"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ef8ac8196e9e9bb99186617a05f20be21d2d004f","unresolved":false,"context_lines":[{"line_number":2952,"context_line":"        }, group_policy\u003d\u0027none\u0027)"},{"line_number":2953,"context_line":"        # 4 VF providers each providing 2, 1, or 0 inventory makes 6"},{"line_number":2954,"context_line":"        # different combinations, plus two more that are effectively"},{"line_number":2955,"context_line":"        # the same but satisfying different suffix mappings."},{"line_number":2956,"context_line":"        self.assertEqual(8, len(alloc_cands.allocation_requests))"},{"line_number":2957,"context_line":""},{"line_number":2958,"context_line":"    def test_nested_result_count_different_amounts(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_35c5055c","line":2955,"updated":"2019-06-07 20:56:09.000000000","message":"✔","commit_id":"e61e88c153692032a0757d2465faf07b5322f424"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ef8ac8196e9e9bb99186617a05f20be21d2d004f","unresolved":false,"context_lines":[{"line_number":2981,"context_line":"        }, group_policy\u003d\u0027isolate\u0027)"},{"line_number":2982,"context_line":"        self.assertEqual(4, len(alloc_cands.allocation_requests))"},{"line_number":2983,"context_line":""},{"line_number":2984,"context_line":"    def test_nested_result_suffix_mappings(self):"},{"line_number":2985,"context_line":"        \"\"\"Confirm that paying attention to suffix mappings expands"},{"line_number":2986,"context_line":"        the quantity of results and confirm those results."},{"line_number":2987,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_5595193f","line":2984,"updated":"2019-06-07 20:56:09.000000000","message":"This seems like just a superset of test_nested_result_count_isolate -- any reason we need both?","commit_id":"e61e88c153692032a0757d2465faf07b5322f424"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"81a4259a5cc7f0a448789a5f589ae33f2500341f","unresolved":false,"context_lines":[{"line_number":2981,"context_line":"        }, group_policy\u003d\u0027isolate\u0027)"},{"line_number":2982,"context_line":"        self.assertEqual(4, len(alloc_cands.allocation_requests))"},{"line_number":2983,"context_line":""},{"line_number":2984,"context_line":"    def test_nested_result_suffix_mappings(self):"},{"line_number":2985,"context_line":"        \"\"\"Confirm that paying attention to suffix mappings expands"},{"line_number":2986,"context_line":"        the quantity of results and confirm those results."},{"line_number":2987,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_798a8abf","line":2984,"in_reply_to":"9fb8cfa7_5595193f","updated":"2019-06-10 09:28:48.000000000","message":"Basically explicitness. If we had slow tests I\u0027d worry about duplication, but we don\u0027t, and in this case we\u0027ve got two similar tests which are about different things, even though some of the assertions that confirm that aboutness are the same.\n\nAlso, chronologically this test was created before the other. The others were created as a result of working on the new bugs that working on this one found.","commit_id":"e61e88c153692032a0757d2465faf07b5322f424"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"73b221ea1eae9ef558308e10a9f90381963cefc5","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                ],"},{"line_number":902,"context_line":"                ..."},{"line_number":903,"context_line":"             ]"},{"line_number":904,"context_line":"        :param candidates: The result from AllocationCandidates.get_by_requests"},{"line_number":905,"context_line":"        \"\"\""},{"line_number":906,"context_line":"        # Extract/convert allocation requests from candidates"},{"line_number":907,"context_line":"        observed \u003d []"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fb8cfa7_24800ff5","line":904,"updated":"2019-06-14 09:08:59.000000000","message":"doc missing for expected_suffix","commit_id":"eb07913442974102b36b8127db8491a742f5eee1"}]}