)]}'
{"id":"openstack%2Fplacement~665448","triplet_id":"openstack%2Fplacement~master~I45a6f73b17dbbce8fde931e90ab2cbea3e8bfcad","project":"openstack/placement","branch":"master","topic":"story/2005889","hashtags":[],"change_id":"I45a6f73b17dbbce8fde931e90ab2cbea3e8bfcad","subject":"DNM: Separate mapping vs no-mapping code paths","status":"ABANDONED","created":"2019-06-14 18:23:43.000000000","updated":"2019-09-11 12:01:20.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ad3fb27ca8507a662fe4b15391f808140a32182b","_number":665448,"virtual_id_number":665448,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-06-15 05:39:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-06-14 18:44:29.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-14 18:44:29.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-06-15 05:39:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"81772ee263d0de0b723eb92455bc7f4fbba7bb80","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-14 18:23:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f9ebbbe5be5e9577e0190c8246d0891d4a425f5c","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-14 18:44:29.000000000","message":"Patch Set 1:\n\nI guess you didn\u0027t like the idea of profiling.\n\nMy guess is this will narrow the profiling search path, but there will still need to be profiling because the target for highest performance is \u0027placement latest\u0027.\n\nAlso, you could get potentially useful info by comparing:\n\n* added hashing: http://logs.openstack.org/85/662785/7/check/placement-perfload/cbad533/logs/placement-perf.txt\n* added output processing: http://logs.openstack.org/45/662245/10/check/placement-perfload/5ff7a9d/logs/placement-perf.txt\n\nLast week we were seeing some numbers as low as .5\n\nOf course then there\u0027s the fact that VMs and clouds are horrible places to do anything serious about performance comparisons.\n\nWhich brings us back to profiling...\n\nBut yes, this will help narrow things some","accounts_in_message":[],"_revision_number":1},{"id":"e420309bba085d7c459f905f6bfea4dd667fd581","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-15 05:39:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/48/665448/1/check/grenade-py3/d6b9c5c/ : SUCCESS in 1h 12m 49s\n- tempest-full-py3 http://logs.openstack.org/48/665448/1/check/tempest-full-py3/a0fd452/ : SUCCESS in 1h 37m 21s\n- openstack-tox-docs http://logs.openstack.org/48/665448/1/check/openstack-tox-docs/50d1c1d/html/ : SUCCESS in 3m 52s\n- openstack-tox-cover http://logs.openstack.org/48/665448/1/check/openstack-tox-cover/507ac75/cover/ : SUCCESS in 5m 15s\n- openstack-tox-lower-constraints http://logs.openstack.org/48/665448/1/check/openstack-tox-lower-constraints/1055600/ : SUCCESS in 4m 15s\n- openstack-tox-pep8 http://logs.openstack.org/48/665448/1/check/openstack-tox-pep8/c47242a/ : SUCCESS in 4m 13s\n- openstack-tox-py27 http://logs.openstack.org/48/665448/1/check/openstack-tox-py27/827b27a/ : SUCCESS in 4m 22s\n- openstack-tox-py36 http://logs.openstack.org/48/665448/1/check/openstack-tox-py36/87e79b1/ : SUCCESS in 4m 30s\n- openstack-tox-py37 http://logs.openstack.org/48/665448/1/check/openstack-tox-py37/26cc8c0/ : SUCCESS in 5m 17s\n- openstack-tox-functional http://logs.openstack.org/48/665448/1/check/openstack-tox-functional/7ff6f94/ : SUCCESS in 5m 44s\n- openstack-tox-functional-py36 http://logs.openstack.org/48/665448/1/check/openstack-tox-functional-py36/668c0c1/ : SUCCESS in 4m 39s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/48/665448/1/check/placement-nova-tox-functional-py36/e24b286/ : SUCCESS in 9m 41s\n- placement-perfload http://logs.openstack.org/48/665448/1/check/placement-perfload/3519e21/ : SUCCESS in 7m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"693d52f6685246cfa72195212ca26eedeadd60f6","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-11 12:01:20.000000000","message":"Abandoned\n\nThis is not how we do","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ca62db8b6828816dd295333d74e6f48418925440","revisions":{"ca62db8b6828816dd295333d74e6f48418925440":{"kind":"REWORK","_number":1,"created":"2019-06-14 18:23:43.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/48/665448/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/48/665448/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/48/665448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/48/665448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/48/665448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/48/665448/1"}}},"commit":{"parents":[{"commit":"942643eef08267b8b2d8537df8c8ba97c53eeebf","subject":"Merge \"Implement allocation candidate mappings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/942643eef08267b8b2d8537df8c8ba97c53eeebf"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-14 18:17:30.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-14 18:17:30.000000000","tz":-300},"subject":"DNM: Separate mapping vs no-mapping code paths","message":"DNM: Separate mapping vs no-mapping code paths\n\nThe referenced story speculates that performance degradation since\nintroduction of microversion 1.34 (mappings in allocation candidate\nresults) [1] may be due to (a) increased object hashing cost and/or (b)\nthe new data processing in the output.\n\nThis commit separates the pre- and post-mapping data handling\ncompletely, which should eliminate (b) for microversions prior to 1.34.\n\nIf the performance goes back to previous levels, (a) is not to blame,\nand we may wish to merge (some variant of) this patch.\n\nIf the performance is unaffected, (a) is the culprit and should be\ninvestigated further.\n\nIf somewhere in the middle, we may wish to merge (some variant of) this\npatch as well as investigating (a).\n\n[1] https://review.opendev.org/#/c/662245\n\nChange-Id: I45a6f73b17dbbce8fde931e90ab2cbea3e8bfcad\nStory: #2005889\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/ca62db8b6828816dd295333d74e6f48418925440"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/ca62db8b6828816dd295333d74e6f48418925440"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}