)]}'
{"id":"openstack%2Fplacement~666281","triplet_id":"openstack%2Fplacement~master~I4aee9de5b19045e6e773349e8f77ccb7f359d360","project":"openstack/placement","branch":"master","topic":"story/2005918","hashtags":[],"change_id":"I4aee9de5b19045e6e773349e8f77ccb7f359d360","subject":"Remove overly-verbose allocation request log","status":"MERGED","created":"2019-06-19 13:03:17.000000000","updated":"2019-06-20 12:35:06.000000000","submitted":"2019-06-20 12:35:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"666281-1561034106411-83facb33","meta_rev_id":"a5b22f123ddd8f7c643f846964b53bfe72356bd0","_number":666281,"virtual_id_number":666281,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-06-19 16:41:00.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2019-06-20 12:35:06.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-06-20 11:02:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2019-06-19 19:40:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2019-06-20 11:02:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-19 13:03:45.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-19 13:03:45.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-06-19 19:40:28.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-06-20 11:02:09.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-06-20 12:35:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"04a7ce62061953465ae233a9b887a388be04552b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-19 13:03:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0e068806b8141a16bf9c581251aadbb3190214a1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-19 13:04:56.000000000","message":"Patch Set 1:\n\nIf this log message is important for some reason, please say so and we\u0027ll just keep it, but I couldn\u0027t think of specific way in which it was adding useful info.","accounts_in_message":[],"_revision_number":1},{"id":"54dfbf58d82067b389258fd3d4b223e97739fc01","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-19 13:58:49.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nTBH this doesn\u0027t seem super onerous to me, at debug level, if my cloud is big. But suggestion inline for taking a little bit of the sting off.","accounts_in_message":[],"_revision_number":1},{"id":"47336541a7a9e99f854cea739fc562b9d520f8df","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-19 14:13:56.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e TBH this doesn\u0027t seem super onerous to me, at debug level, if my\n \u003e cloud is big. But suggestion inline for taking a little bit of the\n \u003e sting off.\n\nIn the example where I discovered this, 100 GET /ac requests led to \u003e29000 lines of this emission.\n\nWhile the numbers are annoying enough, what is more annoying is that it is not clear to me what value even 1 emission gives us. What is a debugging going to be able to do with that information. All we have is a root uuid and a count of allocation requests. What can I do with that?\n\nUnless we can come up with concrete use for it, I think we should kill it, even if TRACE[1].\n\n(We\u0027ve not yet broached the lower levels and I think doing so for just this would be bogus. Either it is useful, or it is not.)","accounts_in_message":[],"_revision_number":1},{"id":"b536d685212a5e868c557061a03ccc27fa53cd54","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-19 14:14:28.000000000","message":"Patch Set 1:\n\nSorry, forgot to also say: What value would a summary at intervals provide?","accounts_in_message":[],"_revision_number":1},{"id":"dbfdc0993541b9aa82117a43814feffc433d2876","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-19 16:41:00.000000000","message":"Patch Set 1:\n\nHave a look at the 95M log file on http://logs.openstack.org/95/665695/8/check/placement-nested-perfload/6617312/logs/placement-api.log for a bit more info on why this might be overkill\n\nIf we remove these lines it shrinks to 7.9M (which still seems like a lot but there is a lot going on)","accounts_in_message":[],"_revision_number":1},{"id":"84cb58459acd96e70735ec01dce9a402fe26d5bc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-19 19:01:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/81/666281/1/check/grenade-py3/523b944/ : FAILURE in 13m 23s\n- tempest-full-py3 http://logs.openstack.org/81/666281/1/check/tempest-full-py3/92234eb/ : FAILURE in 9m 39s\n- openstack-tox-docs http://logs.openstack.org/81/666281/1/check/openstack-tox-docs/429b767/html/ : SUCCESS in 5m 46s\n- openstack-tox-cover http://logs.openstack.org/81/666281/1/check/openstack-tox-cover/a08b6c8/cover/ : SUCCESS in 10m 08s\n- openstack-tox-lower-constraints http://logs.openstack.org/81/666281/1/check/openstack-tox-lower-constraints/066864c/ : SUCCESS in 4m 37s\n- openstack-tox-pep8 http://logs.openstack.org/81/666281/1/check/openstack-tox-pep8/34b75e9/ : SUCCESS in 5m 40s\n- openstack-tox-py27 http://logs.openstack.org/81/666281/1/check/openstack-tox-py27/4943fa1/ : SUCCESS in 4m 43s\n- openstack-tox-py36 http://logs.openstack.org/81/666281/1/check/openstack-tox-py36/e025789/ : SUCCESS in 6m 25s\n- openstack-tox-py37 http://logs.openstack.org/81/666281/1/check/openstack-tox-py37/470e4b7/ : SUCCESS in 5m 21s\n- openstack-tox-functional http://logs.openstack.org/81/666281/1/check/openstack-tox-functional/cb34d84/ : SUCCESS in 6m 04s\n- openstack-tox-functional-py36 http://logs.openstack.org/81/666281/1/check/openstack-tox-functional-py36/13449bb/ : SUCCESS in 6m 33s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/81/666281/1/check/placement-nova-tox-functional-py36/b0b650f/ : SUCCESS in 12m 34s\n- placement-perfload http://logs.openstack.org/81/666281/1/check/placement-perfload/febb2d5/ : SUCCESS in 7m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c718135cc0749d4293849dcbbb14efa12610d15d","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-19 19:40:28.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e What is a debugging going to be able to do with that information. All we have is a root uuid and a count of allocation requests. What can I do with that?\n\nIMO the interesting piece of information is knowing how many candidates are coming from each host. In the examples you\u0027ve shown, it\u0027s always 1, because either not nested or limiting to a single NUMA by trait. Seeing \u003e1 tells me I could be hitting NUMA nodes, or multiple sharing providers, or whatever.\n\nIf I turned on DEBUG, presumably it\u0027s because I\u0027m trying to debug something. Like why I never seem to land an instance on host X. Seeing 0 here in particular tells me that the final trait check failed me.\n\nBUT\n\nthe debug logs in _check_traits_for_alloc_request cover that. (Note that those will probably also jangle your \"overly verbose\" nerve when we\u0027re using traits to narrow down to a small number of hosts in a large cloud.)\n\nAnd in any case I\u0027m really just playing devil\u0027s advocate here. +2 we can remove this message.\n\n\u003e What value would a summary at intervals provide?\n\nNot sure what you mean by \"intervals\". I was suggesting one summary message at the end of _alloc_candidates_multiple_providers saying \"got $c candidates across $r roots\". This would show up right after [1] which says the same thing; so different numbers tell me how much filtering _alloc_candidates_multiple_providers actually did.\n\nThat could be done in a fup, though.\n\n[1] https://opendev.org/openstack/placement/src/branch/master/placement/objects/research_context.py#L529-L533","accounts_in_message":[],"_revision_number":1},{"id":"790f4d97377f0c67e4397bea6c1ed6494c8b945e","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-19 19:42:36.000000000","message":"Patch Set 1:\n\nrecheck rax apt mirror?","accounts_in_message":[],"_revision_number":1},{"id":"fdcabad7bea3a02ba82af595d4821cb63f31fc18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 00:59:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/81/666281/1/check/grenade-py3/1b4031b/ : SUCCESS in 57m 05s\n- tempest-full-py3 http://logs.openstack.org/81/666281/1/check/tempest-full-py3/2272b9e/ : SUCCESS in 1h 31m 55s\n- openstack-tox-docs http://logs.openstack.org/81/666281/1/check/openstack-tox-docs/831ac91/html/ : SUCCESS in 3m 54s\n- openstack-tox-cover http://logs.openstack.org/81/666281/1/check/openstack-tox-cover/66dfdc3/cover/ : SUCCESS in 5m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/81/666281/1/check/openstack-tox-lower-constraints/46a01dd/ : SUCCESS in 4m 29s\n- openstack-tox-pep8 http://logs.openstack.org/81/666281/1/check/openstack-tox-pep8/c659f80/ : SUCCESS in 4m 01s\n- openstack-tox-py27 http://logs.openstack.org/81/666281/1/check/openstack-tox-py27/2adc438/ : SUCCESS in 4m 30s\n- openstack-tox-py36 http://logs.openstack.org/81/666281/1/check/openstack-tox-py36/fa80033/ : SUCCESS in 4m 47s\n- openstack-tox-py37 http://logs.openstack.org/81/666281/1/check/openstack-tox-py37/9b27901/ : SUCCESS in 4m 35s\n- openstack-tox-functional http://logs.openstack.org/81/666281/1/check/openstack-tox-functional/c997333/ : SUCCESS in 4m 53s\n- openstack-tox-functional-py36 http://logs.openstack.org/81/666281/1/check/openstack-tox-functional-py36/a76093f/ : SUCCESS in 4m 28s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/81/666281/1/check/placement-nova-tox-functional-py36/42d9012/ : SUCCESS in 12m 38s\n- placement-perfload http://logs.openstack.org/81/666281/1/check/placement-perfload/98e807c/ : SUCCESS in 6m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b10e4ececad4b5dd9ff405fc18dc765709781b8a","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-06-20 11:02:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"42b209af6bcf7be278db9a418a8e9576f3cb15bb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 11:02:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"78a07bbeb1aff0ae387f05783eb69a03005fbd7e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 12:35:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"b0a4cb5c1f41cca4f77002cd43f91531072d2ba1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 12:35:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/81/666281/1/gate/grenade-py3/7d08b6b/ : SUCCESS in 56m 38s\n- tempest-full-py3 http://logs.openstack.org/81/666281/1/gate/tempest-full-py3/ecbbe21/ : SUCCESS in 1h 31m 41s\n- openstack-tox-docs http://logs.openstack.org/81/666281/1/gate/openstack-tox-docs/46447c0/html/ : SUCCESS in 4m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/81/666281/1/gate/openstack-tox-lower-constraints/618568d/ : SUCCESS in 5m 12s\n- openstack-tox-pep8 http://logs.openstack.org/81/666281/1/gate/openstack-tox-pep8/f175008/ : SUCCESS in 11m 29s\n- openstack-tox-py27 http://logs.openstack.org/81/666281/1/gate/openstack-tox-py27/e1ab67d/ : SUCCESS in 11m 27s\n- openstack-tox-py36 http://logs.openstack.org/81/666281/1/gate/openstack-tox-py36/da3d24a/ : SUCCESS in 4m 13s\n- openstack-tox-py37 http://logs.openstack.org/81/666281/1/gate/openstack-tox-py37/f7d3e3e/ : SUCCESS in 4m 46s\n- openstack-tox-functional http://logs.openstack.org/81/666281/1/gate/openstack-tox-functional/90f35b4/ : SUCCESS in 4m 53s\n- openstack-tox-functional-py36 http://logs.openstack.org/81/666281/1/gate/openstack-tox-functional-py36/4e13ed3/ : SUCCESS in 4m 28s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/81/666281/1/gate/placement-nova-tox-functional-py36/1d08d3b/ : SUCCESS in 11m 20s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e1aec515f621291a6bf76a32f106e9dcc285985f","revisions":{"e1aec515f621291a6bf76a32f106e9dcc285985f":{"kind":"REWORK","_number":1,"created":"2019-06-19 13:03:17.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/81/666281/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/81/666281/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/81/666281/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/81/666281/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/81/666281/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/81/666281/1"}}},"commit":{"parents":[{"commit":"9de03e1b17ddc202532757bb221ee81f02f89bbe","subject":"Uniquify allocation mappings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9de03e1b17ddc202532757bb221ee81f02f89bbe"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-06-19 12:58:57.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-06-19 12:58:57.000000000","tz":60},"subject":"Remove overly-verbose allocation request log","message":"Remove overly-verbose allocation request log\n\nIn I952d5229d6c40588cde6197683117a7e19127939 an \"got %d\nallocation requests under root provider %s\" log message was added.\nIt reports a log line for every allocation request under every\nroot provider in the candidates. In a large but sparsely used\ncloud this generates a large number of log lines (see the identified\nstory for more details and links to examples), well more than 75%\nof the lines in a log.\n\nThe information added by this particular line is not nearly as\nuseful as the other lines added in the change identified above.\nSo here, in this change, it is removed.\n\nChange-Id: I4aee9de5b19045e6e773349e8f77ccb7f359d360\nStory: 2005918\nTask: 34179\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/e1aec515f621291a6bf76a32f106e9dcc285985f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/e1aec515f621291a6bf76a32f106e9dcc285985f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}