)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"79399319faa9ef0c900c0184abfdcab362259d7b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for granular member_of flowing down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a simple addition to demonstrate that \"aggregates flow down\""},{"line_number":10,"context_line":"works for granular as well as unsuffixed member_of. It was prompted by"},{"line_number":11,"context_line":"[1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.opendev.org/#/c/662191/5/doc/source/specs/train/approved/2005575-nested-magic-1.rst@302"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_6f715c44","line":10,"range":{"start_line":9,"start_character":46,"end_line":10,"end_character":19},"updated":"2019-06-25 09:39:01.000000000","message":"Don\u0027t be so sure.\nI left my comments in code docs in https://review.opendev.org/#/c/666488/.","commit_id":"bff3e5e777c72571e0dfd3b4186dc463b9857423"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7f8e39e37cdb7a6bd28163b95547b973a5979191","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a test for granular member_of flowing down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a simple addition to demonstrate that \"aggregates flow down\""},{"line_number":10,"context_line":"works for granular as well as unsuffixed member_of. It was prompted by"},{"line_number":11,"context_line":"[1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.opendev.org/#/c/662191/5/doc/source/specs/train/approved/2005575-nested-magic-1.rst@302"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_0f245bae","line":10,"range":{"start_line":9,"start_character":46,"end_line":10,"end_character":19},"in_reply_to":"9fb8cfa7_6f715c44","updated":"2019-06-25 14:35:26.000000000","message":"Thanks Tetsuro. Rather than abandoning this, I added a test that properly and explicitly shows we don\u0027t flow aggregates down from the root for granular request groups.","commit_id":"bff3e5e777c72571e0dfd3b4186dc463b9857423"}],"placement/tests/functional/gabbits/allocation-candidates-bug-1792503.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4b2e43568b21a958e2407c3b03589c92973f4e19","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":19,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":20,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":21,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: get allocation candidates with aggregate A"},{"line_number":24,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026member_of\u003d$ENVIRON[\u0027AGGA_UUID\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_18cf1180","line":21,"updated":"2019-06-19 22:38:32.000000000","message":"unrelated fixup, forgive me?","commit_id":"bff3e5e777c72571e0dfd3b4186dc463b9857423"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"79399319faa9ef0c900c0184abfdcab362259d7b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":19,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":20,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":21,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: get allocation candidates with aggregate A"},{"line_number":24,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026member_of\u003d$ENVIRON[\u0027AGGA_UUID\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_cfa728bc","line":21,"in_reply_to":"9fb8cfa7_18cf1180","updated":"2019-06-25 09:39:01.000000000","message":"Good catch. I don\u0027t mind about this so much.","commit_id":"bff3e5e777c72571e0dfd3b4186dc463b9857423"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"79399319faa9ef0c900c0184abfdcab362259d7b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- name: get allocation candidates with aggregate C granular"},{"line_number":52,"context_line":"  GET: /allocation_candidates?resources1\u003dVCPU:1\u0026member_of1\u003d$ENVIRON[\u0027AGGC_UUID\u0027]"},{"line_number":53,"context_line":"  response_json_paths:"},{"line_number":54,"context_line":"      # Aggregate C is *NOT* on the root, so we should get only NUMA1_1"},{"line_number":55,"context_line":"      # here that is only the rp in aggregate C."},{"line_number":56,"context_line":"      $.allocation_requests.`len`: 1"},{"line_number":57,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_1_UUID\u0027]\"].resources.VCPU: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_0fa220af","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":41},"updated":"2019-06-25 09:39:01.000000000","message":"Rather than that, in the first place, \"aggs on root span the whole tree\" policy does NOT apply to granular requests. Can we update the comment accordingly?","commit_id":"bff3e5e777c72571e0dfd3b4186dc463b9857423"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7f8e39e37cdb7a6bd28163b95547b973a5979191","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- name: get allocation candidates with aggregate C granular"},{"line_number":52,"context_line":"  GET: /allocation_candidates?resources1\u003dVCPU:1\u0026member_of1\u003d$ENVIRON[\u0027AGGC_UUID\u0027]"},{"line_number":53,"context_line":"  response_json_paths:"},{"line_number":54,"context_line":"      # Aggregate C is *NOT* on the root, so we should get only NUMA1_1"},{"line_number":55,"context_line":"      # here that is only the rp in aggregate C."},{"line_number":56,"context_line":"      $.allocation_requests.`len`: 1"},{"line_number":57,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_1_UUID\u0027]\"].resources.VCPU: 1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_0f0bfb23","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":41},"in_reply_to":"9fb8cfa7_0fa220af","updated":"2019-06-25 14:35:26.000000000","message":"Done","commit_id":"bff3e5e777c72571e0dfd3b4186dc463b9857423"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f9158fc0b5f906c704bea08e5a8d98cb50df022f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":19,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":20,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":21,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: get allocation candidates with aggregate A"},{"line_number":24,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026member_of\u003d$ENVIRON[\u0027AGGA_UUID\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_5807d81d","line":21,"range":{"start_line":21,"start_character":58,"end_line":21,"end_character":59},"updated":"2019-07-08 16:40:18.000000000","message":"Is this change related to this patch?","commit_id":"38d3d5d1c6215527f7bb0414e8cea2a50e19c53a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"00f4bf5ad4fe7012409416c708172b12e77ab5e6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":19,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA1_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":20,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_1_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":21,"context_line":"      $.allocation_requests..allocations[\"$ENVIRON[\u0027NUMA2_2_UUID\u0027]\"].resources.VCPU: 1"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: get allocation candidates with aggregate A"},{"line_number":24,"context_line":"  GET: /allocation_candidates?resources\u003dVCPU:1\u0026member_of\u003d$ENVIRON[\u0027AGGA_UUID\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_f65a3a4e","line":21,"range":{"start_line":21,"start_character":58,"end_line":21,"end_character":59},"in_reply_to":"7faddb67_5807d81d","updated":"2019-07-09 22:46:53.000000000","message":"nope, latent bug fixed along the way.","commit_id":"38d3d5d1c6215527f7bb0414e8cea2a50e19c53a"}]}