)]}'
{"id":"openstack%2Fplacement~668307","triplet_id":"openstack%2Fplacement~master~Ifb687698dd1aa434781d06c7f111d8969120bf71","project":"openstack/placement","branch":"master","topic":"story/2006068","hashtags":[],"change_id":"Ifb687698dd1aa434781d06c7f111d8969120bf71","subject":"Fix rg-rp mappings with group_policy\u003dnone","status":"ABANDONED","created":"2019-06-29 19:37:09.000000000","updated":"2019-07-03 22:13:30.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"00fef4ef76dc00fef25cd128a22f9e7f0040a61e","_number":668307,"virtual_id_number":668307,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2019-06-29 22:04:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-06-29 20:56:26.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":-1,"date":"2019-07-03 11:59:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-29 22:04:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-07-03 11:59:41.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"}],"messages":[{"id":"fc022b97ed437bfa125fc7b18bcfeac3ffa678f2","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-29 19:37:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf826eb8e0ce6c4106a0af451da9218200f31d8b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-06-29 19:48:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f5b8ffa71d12dadce9c14912ae41602b31a42f1c","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-29 20:25:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"af849474b603b277b2fbcd42d74710c4362da0ec","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-29 20:56:26.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"dbdbf35cdc3003b14d04536cdd43d3da4f74824b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-29 22:04:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/07/668307/2/check/grenade-py3/d2139d7/ : SUCCESS in 58m 42s\n- tempest-full-py3 http://logs.openstack.org/07/668307/2/check/tempest-full-py3/5d386f6/ : SUCCESS in 1h 33m 02s\n- openstack-tox-docs http://logs.openstack.org/07/668307/2/check/openstack-tox-docs/43030ac/html/ : SUCCESS in 4m 07s\n- openstack-tox-cover http://logs.openstack.org/07/668307/2/check/openstack-tox-cover/11bf0b5/cover/ : SUCCESS in 5m 09s\n- openstack-tox-lower-constraints http://logs.openstack.org/07/668307/2/check/openstack-tox-lower-constraints/a9eb11c/ : SUCCESS in 5m 05s\n- openstack-tox-pep8 http://logs.openstack.org/07/668307/2/check/openstack-tox-pep8/7196670/ : SUCCESS in 5m 15s\n- openstack-tox-py27 http://logs.openstack.org/07/668307/2/check/openstack-tox-py27/3336fe8/ : SUCCESS in 3m 31s\n- openstack-tox-py36 http://logs.openstack.org/07/668307/2/check/openstack-tox-py36/7e657f8/ : SUCCESS in 4m 03s\n- openstack-tox-py37 http://logs.openstack.org/07/668307/2/check/openstack-tox-py37/3b4e3fb/ : SUCCESS in 4m 10s\n- openstack-tox-functional http://logs.openstack.org/07/668307/2/check/openstack-tox-functional/77fba4e/ : SUCCESS in 4m 22s\n- openstack-tox-functional-py36 http://logs.openstack.org/07/668307/2/check/openstack-tox-functional-py36/9c8a1ef/ : SUCCESS in 4m 11s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/07/668307/2/check/placement-nova-tox-functional-py36/018ad52/ : SUCCESS in 10m 35s\n- placement-nested-perfload http://logs.openstack.org/07/668307/2/check/placement-nested-perfload/f1f5db7/ : SUCCESS in 15m 52s (non-voting)\n- placement-perfload http://logs.openstack.org/07/668307/2/check/placement-perfload/8dd1bf5/ : SUCCESS in 7m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4f8e27fda8c3cfff833c4fa61d35ebf0a91d9239","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-29 22:22:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7b11b5b03eadb998e6ab54fb68e2a43b0ba910cc","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-01 16:26:27.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nThis works, but I\u0027m not super pleased with the way it is implemented. Unless we\u0027re in a rush, I think we should explore the followups and I\u0027ll see if I can do a quick version that puts the suffixes on the AR instead of the ARR or some other thing that quashes my concerns about ARR getting out of hand.\n\nif we are in a rush, then sure","accounts_in_message":[],"_revision_number":2},{"id":"459f70f805c3c4d9353b3a8c3a4fb8d08b27f7a7","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-03 11:59:41.000000000","message":"Patch Set 2: Code-Review-1\n\nAssuming it is correct and not going to cause a raft of problems, I\u0027d prefer we use https://review.opendev.org/#/c/668302/","accounts_in_message":[],"_revision_number":2},{"id":"40b5e28ea855de7bed7d67fb8e2020cea9a74e2b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-03 22:13:30.000000000","message":"Abandoned\n\nIn favor of https://review.opendev.org/#/c/668724/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"71da565ec0cdebd285d31b35a4fd775846278a6a","revisions":{"bc84093f67d410f9e8b80e3e199287d5bc1316e7":{"kind":"REWORK","_number":1,"created":"2019-06-29 19:37:09.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/07/668307/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/07/668307/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/07/668307/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/07/668307/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/07/668307/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/07/668307/1"}}},"commit":{"parents":[{"commit":"c2f420c2c235db73d7631ee45ad2833ae724b97a","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c2f420c2c235db73d7631ee45ad2833ae724b97a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 19:35:48.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 19:35:48.000000000","tz":-300},"subject":"WIP: Fix rg-rp mappings with group_policy\u003dnone","message":"WIP: Fix rg-rp mappings with group_policy\u003dnone\n\nThis works at the API level, but weird things are happening before that.\nInvestigating...\n\nChange-Id: Ifb687698dd1aa434781d06c7f111d8969120bf71\nStory: #2006068\nTask: #34785\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/bc84093f67d410f9e8b80e3e199287d5bc1316e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/bc84093f67d410f9e8b80e3e199287d5bc1316e7"}]},"branch":"refs/heads/master"},"71da565ec0cdebd285d31b35a4fd775846278a6a":{"kind":"REWORK","_number":2,"created":"2019-06-29 20:25:40.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/07/668307/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/07/668307/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/07/668307/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/07/668307/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/07/668307/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/07/668307/2"}}},"commit":{"parents":[{"commit":"c2f420c2c235db73d7631ee45ad2833ae724b97a","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c2f420c2c235db73d7631ee45ad2833ae724b97a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 19:35:48.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 20:22:41.000000000","tz":-300},"subject":"Fix rg-rp mappings with group_policy\u003dnone","message":"Fix rg-rp mappings with group_policy\u003dnone\n\nUnder the bug in the referenced story, [restated] below,\n_consolidate_allocation_requests was copying the first\nAllocationRequestResource it saw for a givin rp+rc, and subsequently\njust adding resource amounts to it, thereby losing the suffix\n(RequestGroup) information from the 2nd+ AllocationRequestResourceZ for\nthat rp+rc.\n\nThis commit resolves the bug by changing\nAllocationRequestResource.suffix (previously a single string) to\n.suffixes (a set() of strings), and fixing\n_consolidate_allocation_requests to properly add to that set when\nmerging AllocationRequestResourceZ for a given rp+rc combination.\n\nThe handler code to produce the rg-rp mappings is modified accordingly\nto handle multiple suffixes (instead of just one) per\nAllocationRequestResource.\n\n[restated]\nGET /allocation_candidates\nwith group_policy\u003dnone\nand two request groups\nwhich consolidate to land on the same provider\nshould generate RequestGroup-to-ResourceProvider mappings with two\nentries: one from each request group to the (same) provider.\n\nHowever, under the referenced bug, only one mapping was returned.\n\nChange-Id: Ifb687698dd1aa434781d06c7f111d8969120bf71\nStory: #2006068\nTask: #34785\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/71da565ec0cdebd285d31b35a4fd775846278a6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/71da565ec0cdebd285d31b35a4fd775846278a6a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}