)]}'
{"id":"openstack%2Fplacement~668309","triplet_id":"openstack%2Fplacement~master~I5e61c5aa1b384c1cd8cd14a49f69e09c726cf880","project":"openstack/placement","branch":"master","topic":"story/2006068","hashtags":[],"change_id":"I5e61c5aa1b384c1cd8cd14a49f69e09c726cf880","subject":"Move combining into AllocationRequestResource","status":"ABANDONED","created":"2019-06-29 20:45:25.000000000","updated":"2019-07-03 22:13:59.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"87ccd390663eae81a01bda5634fc6ffdd65eeea8","_number":668309,"virtual_id_number":668309,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2019-06-29 22:19:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-29 22:19:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f18b31f8b489aea92adc67543229ff4c4716dba7","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-29 20:45:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6687963027e17b4e28f917c5135e2f76c7f1ec28","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-29 22:19:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/09/668309/1/check/grenade-py3/3e51375/ : SUCCESS in 56m 49s\n- tempest-full-py3 http://logs.openstack.org/09/668309/1/check/tempest-full-py3/c0120fe/ : SUCCESS in 1h 28m 58s\n- openstack-tox-docs http://logs.openstack.org/09/668309/1/check/openstack-tox-docs/d30e738/html/ : SUCCESS in 5m 33s\n- openstack-tox-cover http://logs.openstack.org/09/668309/1/check/openstack-tox-cover/a39cbd4/cover/ : SUCCESS in 4m 47s\n- openstack-tox-lower-constraints http://logs.openstack.org/09/668309/1/check/openstack-tox-lower-constraints/05f10d1/ : SUCCESS in 4m 31s\n- openstack-tox-pep8 http://logs.openstack.org/09/668309/1/check/openstack-tox-pep8/7ff4f6b/ : SUCCESS in 3m 29s\n- openstack-tox-py27 http://logs.openstack.org/09/668309/1/check/openstack-tox-py27/1602d77/ : SUCCESS in 5m 53s\n- openstack-tox-py36 http://logs.openstack.org/09/668309/1/check/openstack-tox-py36/05aeb30/ : SUCCESS in 5m 59s\n- openstack-tox-py37 http://logs.openstack.org/09/668309/1/check/openstack-tox-py37/9fd6867/ : SUCCESS in 6m 41s\n- openstack-tox-functional http://logs.openstack.org/09/668309/1/check/openstack-tox-functional/1f1fb5b/ : SUCCESS in 6m 20s\n- openstack-tox-functional-py36 http://logs.openstack.org/09/668309/1/check/openstack-tox-functional-py36/8f6a0ef/ : SUCCESS in 6m 27s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/09/668309/1/check/placement-nova-tox-functional-py36/aacbbe2/ : SUCCESS in 12m 51s\n- placement-nested-perfload http://logs.openstack.org/09/668309/1/check/placement-nested-perfload/5ebac86/ : SUCCESS in 18m 51s (non-voting)\n- placement-perfload http://logs.openstack.org/09/668309/1/check/placement-perfload/e89a325/ : SUCCESS in 7m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8b366735e798a2089ea41d300b5c2df5048c3a53","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-03 22:13:59.000000000","message":"Abandoned\n\nNo longer needed since predecessor [1] is abandoned.\n\n[1] https://review.opendev.org/#/c/668307/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f5a1dee08e8d350e24719d426d1cfe8d871339a1","revisions":{"f5a1dee08e8d350e24719d426d1cfe8d871339a1":{"kind":"REWORK","_number":1,"created":"2019-06-29 20:45:25.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/09/668309/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/09/668309/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/09/668309/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/09/668309/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/09/668309/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/09/668309/1"}}},"commit":{"parents":[{"commit":"71da565ec0cdebd285d31b35a4fd775846278a6a","subject":"Fix rg-rp mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/71da565ec0cdebd285d31b35a4fd775846278a6a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 20:40:12.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 20:40:12.000000000","tz":-300},"subject":"Move combining into AllocationRequestResource","message":"Move combining into AllocationRequestResource\n\nThe fix for story 2006068 via Ifb687698dd1aa434781d06c7f111d8969120bf71\nincluded creating a __copy__ method in AllocationRequestResource to deal\nwith the way _consolidate_allocation_requests was merging\nAllocationRequestResourceZ with the same rp+rc. That smelled a bit of\ntight coupling, so this commit does it a different way: by creating a\nstatic AllocationRequestResource.combine() method to house that logic.\n\nChange-Id: I5e61c5aa1b384c1cd8cd14a49f69e09c726cf880\nRelated-Story: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f5a1dee08e8d350e24719d426d1cfe8d871339a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f5a1dee08e8d350e24719d426d1cfe8d871339a1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}