)]}'
{"id":"openstack%2Fplacement~668310","triplet_id":"openstack%2Fplacement~master~I5469ce9c8bd35800d095a6026857e00888bcff03","project":"openstack/placement","branch":"master","topic":"story/2006068","hashtags":[],"change_id":"I5469ce9c8bd35800d095a6026857e00888bcff03","subject":"Inline AllocationRequestResource.__copy__ logic","status":"ABANDONED","created":"2019-06-29 20:53:26.000000000","updated":"2019-07-03 22:14:16.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e4f4c4f839773b41b8c8a2110b3f23fe471a63b2","_number":668310,"virtual_id_number":668310,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"date":"2019-07-02 00:21:14.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-07-02 02:47:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2019-07-01 00:21:30.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-01 16:33:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-01 00:21:30.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-07-01 16:33:19.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-07-02 02:47:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9b83a5154658a0dd321059ddd1c90baefa5ace1d","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-06-29 20:53:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"04581f8073fce2e69ce559c43d5b9a79357af90f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-29 22:44:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/10/668310/1/check/grenade-py3/8a48011/ : SUCCESS in 1h 01m 04s\n- tempest-full-py3 http://logs.openstack.org/10/668310/1/check/tempest-full-py3/52cd9a5/ : SUCCESS in 1h 49m 33s\n- openstack-tox-docs http://logs.openstack.org/10/668310/1/check/openstack-tox-docs/65618aa/html/ : SUCCESS in 3m 46s\n- openstack-tox-cover http://logs.openstack.org/10/668310/1/check/openstack-tox-cover/2592808/cover/ : SUCCESS in 7m 26s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/668310/1/check/openstack-tox-lower-constraints/cf8fe93/ : SUCCESS in 5m 42s\n- openstack-tox-pep8 http://logs.openstack.org/10/668310/1/check/openstack-tox-pep8/8c86065/ : SUCCESS in 5m 12s\n- openstack-tox-py27 http://logs.openstack.org/10/668310/1/check/openstack-tox-py27/1c4d01c/ : SUCCESS in 6m 27s\n- openstack-tox-py36 http://logs.openstack.org/10/668310/1/check/openstack-tox-py36/86b43b8/ : SUCCESS in 5m 41s\n- openstack-tox-py37 http://logs.openstack.org/10/668310/1/check/openstack-tox-py37/d5152fb/ : SUCCESS in 5m 59s\n- openstack-tox-functional http://logs.openstack.org/10/668310/1/check/openstack-tox-functional/c984e7c/ : SUCCESS in 5m 59s\n- openstack-tox-functional-py36 http://logs.openstack.org/10/668310/1/check/openstack-tox-functional-py36/e4b76ce/ : SUCCESS in 5m 30s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/10/668310/1/check/placement-nova-tox-functional-py36/68c6f6d/ : SUCCESS in 10m 08s\n- placement-nested-perfload http://logs.openstack.org/10/668310/1/check/placement-nested-perfload/9255fb5/ : SUCCESS in 15m 25s (non-voting)\n- placement-perfload http://logs.openstack.org/10/668310/1/check/placement-perfload/3235b95/ : SUCCESS in 6m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fc44bf000c61585fd4d0227af05cd706b5113871","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-07-01 00:21:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"dcbf7ba4efe72db81335734b26b2617c8a7d0fd6","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-01 16:33:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\napart from the comment within, I prefer this to the two other options","accounts_in_message":[],"_revision_number":1},{"id":"4265187859ec03dd43ca2ccf8e65422bc0b92ee8","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-01 16:51:03.000000000","message":"Patch Set 1:\n\nThe performance on this one is considerably better http://logs.openstack.org/10/668310/1/check/placement-perfload/3235b95/logs/placement-perf.txt\n\nwhich might be a node thing, so I\u0027m gonna recheck it","accounts_in_message":[],"_revision_number":1},{"id":"fcc52926ba4fe5cb9689c802a725f69923628a3c","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-01 16:51:09.000000000","message":"Patch Set 1:\n\nrecheck perf","accounts_in_message":[],"_revision_number":1},{"id":"b9dac03c2715c3e523e584dd97d98fd774f11367","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 00:15:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 http://logs.openstack.org/10/668310/1/check/grenade-py3/8f2b205/ : FAILURE in 42m 14s\n- tempest-full-py3 http://logs.openstack.org/10/668310/1/check/tempest-full-py3/df58597/ : SUCCESS in 1h 41m 04s\n- openstack-tox-docs http://logs.openstack.org/10/668310/1/check/openstack-tox-docs/3769b8d/html/ : SUCCESS in 6m 08s\n- openstack-tox-cover http://logs.openstack.org/10/668310/1/check/openstack-tox-cover/6511d62/cover/ : SUCCESS in 7m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/668310/1/check/openstack-tox-lower-constraints/1317ea5/ : SUCCESS in 7m 01s\n- openstack-tox-pep8 http://logs.openstack.org/10/668310/1/check/openstack-tox-pep8/92327b0/ : SUCCESS in 6m 30s\n- openstack-tox-py27 http://logs.openstack.org/10/668310/1/check/openstack-tox-py27/e19524e/ : SUCCESS in 6m 23s\n- openstack-tox-py36 http://logs.openstack.org/10/668310/1/check/openstack-tox-py36/305539b/ : SUCCESS in 6m 02s\n- openstack-tox-py37 http://logs.openstack.org/10/668310/1/check/openstack-tox-py37/3425230/ : SUCCESS in 6m 59s\n- openstack-tox-functional http://logs.openstack.org/10/668310/1/check/openstack-tox-functional/75126f5/ : SUCCESS in 7m 15s\n- openstack-tox-functional-py36 http://logs.openstack.org/10/668310/1/check/openstack-tox-functional-py36/1d1ce9e/ : SUCCESS in 6m 03s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/10/668310/1/check/placement-nova-tox-functional-py36/37211f7/ : SUCCESS in 12m 07s\n- placement-nested-perfload http://logs.openstack.org/10/668310/1/check/placement-nested-perfload/2b9a025/ : SUCCESS in 17m 02s (non-voting)\n- placement-perfload http://logs.openstack.org/10/668310/1/check/placement-perfload/f8cd8ec/ : SUCCESS in 8m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2901f4f2b8df51677653a516cd131aeb3a4e1c5e","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-02 00:21:14.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9e413f6eac814c35056a8d464fc2640dab20979c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-02 02:47:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/10/668310/1/check/grenade-py3/fed8f99/ : SUCCESS in 1h 01m 16s\n- tempest-full-py3 http://logs.openstack.org/10/668310/1/check/tempest-full-py3/d702d36/ : SUCCESS in 1h 38m 01s\n- openstack-tox-docs http://logs.openstack.org/10/668310/1/check/openstack-tox-docs/db6a2ad/html/ : SUCCESS in 5m 36s\n- openstack-tox-cover http://logs.openstack.org/10/668310/1/check/openstack-tox-cover/ef89193/cover/ : SUCCESS in 5m 28s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/668310/1/check/openstack-tox-lower-constraints/447deae/ : SUCCESS in 5m 13s\n- openstack-tox-pep8 http://logs.openstack.org/10/668310/1/check/openstack-tox-pep8/ab4b87b/ : SUCCESS in 5m 09s\n- openstack-tox-py27 http://logs.openstack.org/10/668310/1/check/openstack-tox-py27/dbc2136/ : SUCCESS in 5m 09s\n- openstack-tox-py36 http://logs.openstack.org/10/668310/1/check/openstack-tox-py36/aaf4eeb/ : SUCCESS in 4m 37s\n- openstack-tox-py37 http://logs.openstack.org/10/668310/1/check/openstack-tox-py37/0671f65/ : SUCCESS in 5m 30s\n- openstack-tox-functional http://logs.openstack.org/10/668310/1/check/openstack-tox-functional/9946921/ : SUCCESS in 5m 04s\n- openstack-tox-functional-py36 http://logs.openstack.org/10/668310/1/check/openstack-tox-functional-py36/87537ef/ : SUCCESS in 5m 08s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/10/668310/1/check/placement-nova-tox-functional-py36/60f3c72/ : SUCCESS in 11m 10s\n- placement-nested-perfload http://logs.openstack.org/10/668310/1/check/placement-nested-perfload/b102994/ : SUCCESS in 17m 46s (non-voting)\n- placement-perfload http://logs.openstack.org/10/668310/1/check/placement-perfload/ee9ea89/ : SUCCESS in 7m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c166e744fa85a48ed712510a90642bd74e42086b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-03 22:14:16.000000000","message":"Abandoned\n\nNo longer needed since predecessor [1] is abandoned.\n\n[1] https://review.opendev.org/#/c/668307/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"566b97fa040779105b547607a1cb9b8f807ffeb9","revisions":{"566b97fa040779105b547607a1cb9b8f807ffeb9":{"kind":"REWORK","_number":1,"created":"2019-06-29 20:53:26.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/10/668310/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/10/668310/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/10/668310/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/10/668310/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/10/668310/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/10/668310/1"}}},"commit":{"parents":[{"commit":"71da565ec0cdebd285d31b35a4fd775846278a6a","subject":"Fix rg-rp mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/71da565ec0cdebd285d31b35a4fd775846278a6a"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 20:51:26.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-06-29 20:51:26.000000000","tz":-300},"subject":"Inline AllocationRequestResource.__copy__ logic","message":"Inline AllocationRequestResource.__copy__ logic\n\nThe fix for story 2006068 via Ifb687698dd1aa434781d06c7f111d8969120bf71\nincluded creating a __copy__ method in AllocationRequestResource to deal\nwith the way _consolidate_allocation_requests was merging\nAllocationRequestResourceZ with the same rp+rc. That smelled a bit of\ntight coupling, so this commit does it a different way: by explicitly\nconstructing the new AllocationRequestResource (without the error-prone\ncopy()ing) directly in _consolidate_allocation_requests.\n\nChange-Id: I5469ce9c8bd35800d095a6026857e00888bcff03\nRelated-Story: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/566b97fa040779105b547607a1cb9b8f807ffeb9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/566b97fa040779105b547607a1cb9b8f807ffeb9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}