)]}'
{"id":"openstack%2Fplacement~668724","triplet_id":"openstack%2Fplacement~master~Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb","project":"openstack/placement","branch":"master","topic":"nested-magic","hashtags":[],"change_id":"Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb","subject":"Manage mappings on AllocationRequest object","status":"MERGED","created":"2019-07-02 18:05:13.000000000","updated":"2019-07-05 09:05:07.000000000","submitted":"2019-07-05 07:25:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":22,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"668724-1562311536739-769ffea3","meta_rev_id":"b5e687a641c8b6386c7f334008dc8ebbd14da03c","_number":668724,"virtual_id_number":668724,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-05 07:25:36.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-07-05 04:45:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2019-07-04 12:36:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2019-07-05 04:45:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-04 10:50:08.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-05 04:45:14.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-07-05 07:25:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8bae829c1458c8b47235a0819dc82eaa35928979","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-02 18:05:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"699f065cc6f3d214b5219731ec14c51522406807","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-02 21:49:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"34827aca7bc754e3e72f2c9ac946400ba0200f9e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-02 21:50:10.000000000","message":"Patch Set 2:\n\nlooks like this might also be a performance inc, not just a cognition inc:\n\nhttp://logs.openstack.org/24/668724/1/check/placement-nested-perfload/ed66989/logs/placement-perf.txt\nhttp://logs.openstack.org/24/668724/1/check/placement-perfload/530e532/logs/placement-perf.txt\n\n(I stopped the test run to upload a new version because of pep8 failures, but the perf jobs had finished)","accounts_in_message":[],"_revision_number":2},{"id":"ca42f6fdfda10281fdd40f49c3debfde30989d24","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-03 00:23:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/24/668724/2/check/grenade-py3/baa1447/ : SUCCESS in 58m 42s\n- tempest-full-py3 http://logs.openstack.org/24/668724/2/check/tempest-full-py3/b1d15b4/ : SUCCESS in 1h 36m 19s\n- openstack-tox-docs http://logs.openstack.org/24/668724/2/check/openstack-tox-docs/b9bc854/html/ : SUCCESS in 4m 54s\n- openstack-tox-cover http://logs.openstack.org/24/668724/2/check/openstack-tox-cover/f7713b8/cover/ : SUCCESS in 5m 35s\n- openstack-tox-lower-constraints http://logs.openstack.org/24/668724/2/check/openstack-tox-lower-constraints/d1c979c/ : SUCCESS in 6m 17s\n- openstack-tox-pep8 http://logs.openstack.org/24/668724/2/check/openstack-tox-pep8/525161d/ : SUCCESS in 4m 51s\n- openstack-tox-py27 http://logs.openstack.org/24/668724/2/check/openstack-tox-py27/91290db/ : SUCCESS in 5m 26s\n- openstack-tox-py36 http://logs.openstack.org/24/668724/2/check/openstack-tox-py36/e4a7862/ : SUCCESS in 5m 56s\n- openstack-tox-py37 http://logs.openstack.org/24/668724/2/check/openstack-tox-py37/444a3d4/ : SUCCESS in 4m 34s\n- openstack-tox-functional http://logs.openstack.org/24/668724/2/check/openstack-tox-functional/40b50c9/ : SUCCESS in 5m 10s\n- openstack-tox-functional-py36 http://logs.openstack.org/24/668724/2/check/openstack-tox-functional-py36/7e7e53a/ : SUCCESS in 4m 58s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/24/668724/2/check/placement-nova-tox-functional-py36/60cf5d1/ : SUCCESS in 9m 51s\n- placement-nested-perfload http://logs.openstack.org/24/668724/2/check/placement-nested-perfload/c7df86e/ : SUCCESS in 14m 57s (non-voting)\n- placement-perfload http://logs.openstack.org/24/668724/2/check/placement-perfload/a2c8588/ : SUCCESS in 7m 58s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a25b9d1e02973bdbc5803c0348d91d67ba3bd3c6","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-03 22:12:46.000000000","message":"Patch Set 2: Code-Review+2\n\n(6 comments)\n\nYup, this is much cleaner.\n\nA few minor things inline, but could be fup\u0027d.","accounts_in_message":[],"_revision_number":2},{"id":"bd9a8b31bed5c1efac98dbcb17af83a30c373644","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-04 08:43:16.000000000","message":"Patch Set 2: Workflow-1\n\n(5 comments)\n\nFixes coming.\n\nDoing these kinds of post-review fixes reminds me of just how critically important useful placement\u0027s fast tests are.","accounts_in_message":[],"_revision_number":2},{"id":"1b959f1f1473ed7101c1fbb6e9e680c41b37a4be","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-04 08:45:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7aa353ea278f37f3cdbd52927a7f479f7b4a6030","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-04 10:06:08.000000000","message":"Patch Set 3: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"a056c6d41b538be6b2fe270a8127ef99be187e01","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-04 10:17:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"51504a9bc51f5ced1156f5c5c4784aa2c44289c4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-04 10:25:51.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"96899002745e8a270ca403428438e723ca8b08fc","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-04 10:26:25.000000000","message":"Patch Set 4:\n\nPS4: I convinced myself to get rid of the defaultdict default","accounts_in_message":[],"_revision_number":4},{"id":"eb9ca46b599f630819508d5fc36852ff3c7695be","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-04 10:50:08.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"c1b7995c9c4771674d09a82a0839220dd5659996","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-07-04 12:27:21.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"24f643c0634e1909aa017a4b06533683fd399649","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-07-04 12:36:18.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"421339850b894be6b4cef80686b9cebb509433d0","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-07-04 12:41:56.000000000","message":"Patch Set 6:\n\nWrongly rebased in PS5 so just reverted it to PS4.\n \nHaving mappings in AllocationRequest seems consistent with the API response so I think this is sane. I\u0027ll come back later for reviewing this in more details.","accounts_in_message":[],"_revision_number":6},{"id":"4f23a7308ec0f09b834d4019b7a8223a8d2c732e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-04 19:24:58.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/24/668724/6/check/grenade-py3/ee3c988/ : SUCCESS in 1h 06m 46s\n- tempest-full-py3 http://logs.openstack.org/24/668724/6/check/tempest-full-py3/b1485ba/ : SUCCESS in 1h 33m 40s\n- openstack-tox-docs http://logs.openstack.org/24/668724/6/check/openstack-tox-docs/ab7e15c/html/ : SUCCESS in 4m 09s\n- openstack-tox-cover http://logs.openstack.org/24/668724/6/check/openstack-tox-cover/7b6c8da/cover/ : SUCCESS in 5m 20s\n- openstack-tox-lower-constraints http://logs.openstack.org/24/668724/6/check/openstack-tox-lower-constraints/ea4f172/ : SUCCESS in 4m 50s\n- openstack-tox-pep8 http://logs.openstack.org/24/668724/6/check/openstack-tox-pep8/8c4fd79/ : SUCCESS in 4m 09s\n- openstack-tox-py27 http://logs.openstack.org/24/668724/6/check/openstack-tox-py27/1fff953/ : SUCCESS in 4m 52s\n- openstack-tox-py36 http://logs.openstack.org/24/668724/6/check/openstack-tox-py36/b18f132/ : SUCCESS in 4m 36s\n- openstack-tox-py37 http://logs.openstack.org/24/668724/6/check/openstack-tox-py37/53d073d/ : SUCCESS in 4m 53s\n- openstack-tox-functional http://logs.openstack.org/24/668724/6/check/openstack-tox-functional/b0a9ab0/ : SUCCESS in 4m 43s\n- openstack-tox-functional-py36 http://logs.openstack.org/24/668724/6/check/openstack-tox-functional-py36/385dc24/ : SUCCESS in 4m 33s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/24/668724/6/check/placement-nova-tox-functional-py36/e9735c8/ : SUCCESS in 11m 22s\n- placement-nested-perfload http://logs.openstack.org/24/668724/6/check/placement-nested-perfload/1a20974/ : SUCCESS in 15m 42s (non-voting)\n- placement-perfload http://logs.openstack.org/24/668724/6/check/placement-perfload/cc38917/ : SUCCESS in 8m 37s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"06332e8fea8b9023a9be12ac1b42c1cd20d33c62","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-07-05 04:45:14.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1\n\n(5 comments)\n\nSome nits within","accounts_in_message":[],"_revision_number":6},{"id":"d22e9860bfcacd730bc0e089a0afd59855a6f065","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-05 04:45:30.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"deb5fb7ce3d9a8da52f818f2068538c93aa79448","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-05 07:25:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"28660570718b792c02f6a5e6ed8f0234c812c274","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-05 07:25:36.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 http://logs.openstack.org/24/668724/6/gate/grenade-py3/0b45246/ : SUCCESS in 1h 04m 22s\n- tempest-full-py3 http://logs.openstack.org/24/668724/6/gate/tempest-full-py3/0da419c/ : SUCCESS in 1h 39m 21s\n- openstack-tox-docs http://logs.openstack.org/24/668724/6/gate/openstack-tox-docs/3a87473/html/ : SUCCESS in 3m 55s\n- openstack-tox-lower-constraints http://logs.openstack.org/24/668724/6/gate/openstack-tox-lower-constraints/0df9a0d/ : SUCCESS in 4m 40s\n- openstack-tox-pep8 http://logs.openstack.org/24/668724/6/gate/openstack-tox-pep8/cb27238/ : SUCCESS in 4m 18s\n- openstack-tox-py27 http://logs.openstack.org/24/668724/6/gate/openstack-tox-py27/44bf33e/ : SUCCESS in 6m 06s\n- openstack-tox-py36 http://logs.openstack.org/24/668724/6/gate/openstack-tox-py36/a9ddbc3/ : SUCCESS in 5m 07s\n- openstack-tox-py37 http://logs.openstack.org/24/668724/6/gate/openstack-tox-py37/61f256a/ : SUCCESS in 6m 13s\n- openstack-tox-functional http://logs.openstack.org/24/668724/6/gate/openstack-tox-functional/193551d/ : SUCCESS in 5m 01s\n- openstack-tox-functional-py36 http://logs.openstack.org/24/668724/6/gate/openstack-tox-functional-py36/0ed3a7c/ : SUCCESS in 4m 30s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/24/668724/6/gate/placement-nova-tox-functional-py36/82c7077/ : SUCCESS in 11m 32s","accounts_in_message":[],"_revision_number":6},{"id":"eeb9f0ca1d997bf25b546b325497254b3a1a3e42","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-05 09:05:07.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nI made a fup to get the naming mistakes: https://review.opendev.org/669301","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"06256d86c71929d697290b2fe05d1654c69ed9f0","revisions":{"0b9d7bd3fba0db85d67ef4cba6f68b7d44c43921":{"kind":"REWORK","_number":1,"created":"2019-07-02 18:05:13.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/24/668724/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/24/668724/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/24/668724/1"}}},"commit":{"parents":[{"commit":"c2f420c2c235db73d7631ee45ad2833ae724b97a","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c2f420c2c235db73d7631ee45ad2833ae724b97a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"subject":"Manage mappings on AllocationRequest object","message":"Manage mappings on AllocationRequest object\n\nThis changes the handling required for creating the \u0027mappings\u0027\noutput in the allocation_requests section of the GET\n/allocation_candidates response.\n\nWhereas before they were tracked as a suffix on the\nAllocationRequestResource object, this became untenable when it\nwas realized (see the linked Story) that sometimes multiple\nrequest groups (and thus suffixes) can consume resources from\nthe same provider and the original implementation did not\naccount for this. Change Ifb687698dd1aa434781d06c7f111d8969120bf71\nprovides a fix for this but it is represents some cognitive and\nmaintenance issues because it associates a vector value with a\nscalar concept. That is: it is illogical for an\nAllocationRequestResource (a representation of single consumption of\na resource) with multiple suffixes doing that consumption.\n\nInstead, a new mappings attribute is added to AllocationRequest.\nThis is probably where it should have been from the start, because\nthe things we want to manage are:\n\n* mappings\n* in an allocation_request\n\nAll existing tests pass. An additional test, borrowed from\nIfb687698dd1aa434781d06c7f111d8969120bf71 , is also included to make\nsure we cover some of the ideas raised in that patch.\n\nChange-Id: Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb\nStory: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0b9d7bd3fba0db85d67ef4cba6f68b7d44c43921"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0b9d7bd3fba0db85d67ef4cba6f68b7d44c43921"}]},"branch":"refs/heads/master"},"ccb8606303b1c30ea9d810a8a75424674f0130b8":{"kind":"REWORK","_number":2,"created":"2019-07-02 21:49:15.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/24/668724/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/24/668724/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/24/668724/2"}}},"commit":{"parents":[{"commit":"c2f420c2c235db73d7631ee45ad2833ae724b97a","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c2f420c2c235db73d7631ee45ad2833ae724b97a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 21:48:36.000000000","tz":60},"subject":"Manage mappings on AllocationRequest object","message":"Manage mappings on AllocationRequest object\n\nThis changes the handling required for creating the \u0027mappings\u0027\noutput in the allocation_requests section of the GET\n/allocation_candidates response.\n\nWhereas before they were tracked as a suffix on the\nAllocationRequestResource object, this became untenable when it\nwas realized (see the linked Story) that sometimes multiple\nrequest groups (and thus suffixes) can consume resources from\nthe same provider and the original implementation did not\naccount for this. Change Ifb687698dd1aa434781d06c7f111d8969120bf71\nprovides a fix for this but it is represents some cognitive and\nmaintenance issues because it associates a vector value with a\nscalar concept. That is: it is illogical for an\nAllocationRequestResource (a representation of single consumption of\na resource) with multiple suffixes doing that consumption.\n\nInstead, a new mappings attribute is added to AllocationRequest.\nThis is probably where it should have been from the start, because\nthe things we want to manage are:\n\n* mappings\n* in an allocation_request\n\nAll existing tests pass. An additional test, borrowed from\nIfb687698dd1aa434781d06c7f111d8969120bf71 , is also included to make\nsure we cover some of the ideas raised in that patch.\n\nChange-Id: Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb\nStory: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/ccb8606303b1c30ea9d810a8a75424674f0130b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/ccb8606303b1c30ea9d810a8a75424674f0130b8"}]},"branch":"refs/heads/master"},"04570ce57ec5a078066cadc1023e3dd10fa62ea6":{"kind":"REWORK","_number":3,"created":"2019-07-04 08:45:34.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/24/668724/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/24/668724/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/24/668724/3"}}},"commit":{"parents":[{"commit":"c2f420c2c235db73d7631ee45ad2833ae724b97a","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c2f420c2c235db73d7631ee45ad2833ae724b97a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-04 08:44:29.000000000","tz":60},"subject":"Manage mappings on AllocationRequest object","message":"Manage mappings on AllocationRequest object\n\nThis changes the handling required for creating the \u0027mappings\u0027\noutput in the allocation_requests section of the GET\n/allocation_candidates response.\n\nWhereas before they were tracked as a suffix on the\nAllocationRequestResource object, this became untenable when it\nwas realized (see the linked Story) that sometimes multiple\nrequest groups (and thus suffixes) can consume resources from\nthe same provider and the original implementation did not\naccount for this. Change Ifb687698dd1aa434781d06c7f111d8969120bf71\nprovides a fix for this but it is represents some cognitive and\nmaintenance issues because it associates a vector value with a\nscalar concept. That is: it is illogical for an\nAllocationRequestResource (a representation of single consumption of\na resource) with multiple suffixes doing that consumption.\n\nInstead, a new mappings attribute is added to AllocationRequest.\nThis is probably where it should have been from the start, because\nthe things we want to manage are:\n\n* mappings\n* in an allocation_request\n\nAll existing tests pass. An additional test, borrowed from\nIfb687698dd1aa434781d06c7f111d8969120bf71 , is also included to make\nsure we cover some of the ideas raised in that patch.\n\nChange-Id: Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb\nStory: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/04570ce57ec5a078066cadc1023e3dd10fa62ea6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/04570ce57ec5a078066cadc1023e3dd10fa62ea6"}]},"branch":"refs/heads/master"},"77a218102f048dd3e122dc4b0aab0e7d9097485d":{"kind":"REWORK","_number":4,"created":"2019-07-04 10:25:51.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/24/668724/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/24/668724/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/24/668724/4"}}},"commit":{"parents":[{"commit":"c2f420c2c235db73d7631ee45ad2833ae724b97a","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c2f420c2c235db73d7631ee45ad2833ae724b97a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-04 10:25:32.000000000","tz":60},"subject":"Manage mappings on AllocationRequest object","message":"Manage mappings on AllocationRequest object\n\nThis changes the handling required for creating the \u0027mappings\u0027\noutput in the allocation_requests section of the GET\n/allocation_candidates response.\n\nWhereas before they were tracked as a suffix on the\nAllocationRequestResource object, this became untenable when it\nwas realized (see the linked Story) that sometimes multiple\nrequest groups (and thus suffixes) can consume resources from\nthe same provider and the original implementation did not\naccount for this. Change Ifb687698dd1aa434781d06c7f111d8969120bf71\nprovides a fix for this but it is represents some cognitive and\nmaintenance issues because it associates a vector value with a\nscalar concept. That is: it is illogical for an\nAllocationRequestResource (a representation of single consumption of\na resource) with multiple suffixes doing that consumption.\n\nInstead, a new mappings attribute is added to AllocationRequest.\nThis is probably where it should have been from the start, because\nthe things we want to manage are:\n\n* mappings\n* in an allocation_request\n\nAll existing tests pass. An additional test, borrowed from\nIfb687698dd1aa434781d06c7f111d8969120bf71 , is also included to make\nsure we cover some of the ideas raised in that patch.\n\nChange-Id: Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb\nStory: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/77a218102f048dd3e122dc4b0aab0e7d9097485d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/77a218102f048dd3e122dc4b0aab0e7d9097485d"}]},"branch":"refs/heads/master"},"b5d74810f305d4ee5258be542eeaf53407187271":{"kind":"REWORK","_number":5,"created":"2019-07-04 12:27:21.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/24/668724/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/24/668724/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/24/668724/5"}}},"commit":{"parents":[{"commit":"f4d3059d9aff2334eac82cfc1d1e06e4fcd727b8","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f4d3059d9aff2334eac82cfc1d1e06e4fcd727b8"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-07-04 06:12:58.000000000","tz":0},"subject":"Manage mappings on AllocationRequest object","message":"Manage mappings on AllocationRequest object\n\nThis changes the handling required for creating the \u0027mappings\u0027\noutput in the allocation_requests section of the GET\n/allocation_candidates response.\n\nWhereas before they were tracked as a suffix on the\nAllocationRequestResource object, this became untenable when it\nwas realized (see the linked Story) that sometimes multiple\nrequest groups (and thus suffixes) can consume resources from\nthe same provider and the original implementation did not\naccount for this. Change Ifb687698dd1aa434781d06c7f111d8969120bf71\nprovides a fix for this but it is represents some cognitive and\nmaintenance issues because it associates a vector value with a\nscalar concept. That is: it is illogical for an\nAllocationRequestResource (a representation of single consumption of\na resource) with multiple suffixes doing that consumption.\n\nInstead, a new mappings attribute is added to AllocationRequest.\nThis is probably where it should have been from the start, because\nthe things we want to manage are:\n\n* mappings\n* in an allocation_request\n\nAll existing tests pass. An additional test, borrowed from\nIfb687698dd1aa434781d06c7f111d8969120bf71 , is also included to make\nsure we cover some of the ideas raised in that patch.\n\nChange-Id: Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb\nStory: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/b5d74810f305d4ee5258be542eeaf53407187271"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/b5d74810f305d4ee5258be542eeaf53407187271"}]},"branch":"refs/heads/master"},"06256d86c71929d697290b2fe05d1654c69ed9f0":{"kind":"REWORK","_number":6,"created":"2019-07-04 12:36:18.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/24/668724/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/24/668724/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/24/668724/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/24/668724/6"}}},"commit":{"parents":[{"commit":"7cadf3e82a290fb6f211d5b1a2712a36c112eed2","subject":"Recreate: incorrect mappings with group_policy\u003dnone","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/7cadf3e82a290fb6f211d5b1a2712a36c112eed2"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-02 17:54:28.000000000","tz":60},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-07-04 09:57:31.000000000","tz":0},"subject":"Manage mappings on AllocationRequest object","message":"Manage mappings on AllocationRequest object\n\nThis changes the handling required for creating the \u0027mappings\u0027\noutput in the allocation_requests section of the GET\n/allocation_candidates response.\n\nWhereas before they were tracked as a suffix on the\nAllocationRequestResource object, this became untenable when it\nwas realized (see the linked Story) that sometimes multiple\nrequest groups (and thus suffixes) can consume resources from\nthe same provider and the original implementation did not\naccount for this. Change Ifb687698dd1aa434781d06c7f111d8969120bf71\nprovides a fix for this but it is represents some cognitive and\nmaintenance issues because it associates a vector value with a\nscalar concept. That is: it is illogical for an\nAllocationRequestResource (a representation of single consumption of\na resource) with multiple suffixes doing that consumption.\n\nInstead, a new mappings attribute is added to AllocationRequest.\nThis is probably where it should have been from the start, because\nthe things we want to manage are:\n\n* mappings\n* in an allocation_request\n\nAll existing tests pass. An additional test, borrowed from\nIfb687698dd1aa434781d06c7f111d8969120bf71 , is also included to make\nsure we cover some of the ideas raised in that patch.\n\nChange-Id: Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb\nStory: #2006068\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/06256d86c71929d697290b2fe05d1654c69ed9f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/06256d86c71929d697290b2fe05d1654c69ed9f0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}