)]}'
{"id":"openstack%2Fplacement~669301","triplet_id":"openstack%2Fplacement~master~I51cbb34ed8f045a1922fea2d1b463c327b0f856c","project":"openstack/placement","branch":"master","topic":"cd/mappings-tidy","hashtags":[],"change_id":"I51cbb34ed8f045a1922fea2d1b463c327b0f856c","subject":"Correct variable use and naming in mappings tests","status":"MERGED","created":"2019-07-05 09:01:49.000000000","updated":"2019-07-06 03:03:31.000000000","submitted":"2019-07-06 03:03:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"669301-1562382211683-13c00058","meta_rev_id":"5a621ff86d721a08b7ef8ad4c32725748623bdf3","_number":669301,"virtual_id_number":669301,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"date":"2019-07-05 13:38:18.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-07-06 03:03:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":2,"date":"2019-07-05 13:36:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-07-06 02:47:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-07-06 02:47:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-05 13:36:48.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-06 02:47:35.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-07-06 03:03:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"efdbbcbbafb2f2442b29687b91d193b340ee1867","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-05 09:01:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e3e6725137fcf17066c2baa2a77408b9e3894268","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-05 10:33:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/01/669301/1/check/openstack-tox-docs/4385a67/html/ : SUCCESS in 4m 57s\n- openstack-tox-cover http://logs.openstack.org/01/669301/1/check/openstack-tox-cover/08d758e/cover/ : SUCCESS in 4m 58s\n- openstack-tox-lower-constraints http://logs.openstack.org/01/669301/1/check/openstack-tox-lower-constraints/814d0da/ : SUCCESS in 7m 28s\n- openstack-tox-pep8 http://logs.openstack.org/01/669301/1/check/openstack-tox-pep8/57a5de9/ : SUCCESS in 3m 49s\n- openstack-tox-py27 http://logs.openstack.org/01/669301/1/check/openstack-tox-py27/6132aca/ : SUCCESS in 6m 57s\n- openstack-tox-py36 http://logs.openstack.org/01/669301/1/check/openstack-tox-py36/c216ea7/ : SUCCESS in 5m 06s\n- openstack-tox-py37 http://logs.openstack.org/01/669301/1/check/openstack-tox-py37/4b08567/ : SUCCESS in 4m 35s\n- openstack-tox-functional http://logs.openstack.org/01/669301/1/check/openstack-tox-functional/e224700/ : SUCCESS in 5m 50s\n- openstack-tox-functional-py36 http://logs.openstack.org/01/669301/1/check/openstack-tox-functional-py36/150eb72/ : SUCCESS in 5m 12s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/01/669301/1/check/placement-nova-tox-functional-py36/7a46451/ : SUCCESS in 11m 21s","accounts_in_message":[],"_revision_number":1},{"id":"1a88ad88b3485854678a0cd92a3b7c0a541d5231","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-05 13:36:48.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4029e8b5b77c0246d166dc0d3840939bd50a65f7","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-05 13:38:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d8c7b44f960daf5dbda382f834a2b35cc9b26daa","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-07-06 02:47:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nstrawberry fields forever","accounts_in_message":[],"_revision_number":1},{"id":"d35b53cd94ad252e2b0019686ef20c15e986e844","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-06 02:47:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a7d878d375a8a63a6835efe510d59a868be475ed","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-06 03:03:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/01/669301/1/gate/openstack-tox-docs/4904a6a/html/ : SUCCESS in 3m 44s\n- openstack-tox-lower-constraints http://logs.openstack.org/01/669301/1/gate/openstack-tox-lower-constraints/063a1b8/ : SUCCESS in 4m 11s\n- openstack-tox-pep8 http://logs.openstack.org/01/669301/1/gate/openstack-tox-pep8/f23e829/ : SUCCESS in 3m 58s\n- openstack-tox-py27 http://logs.openstack.org/01/669301/1/gate/openstack-tox-py27/dd21dd1/ : SUCCESS in 4m 06s\n- openstack-tox-py36 http://logs.openstack.org/01/669301/1/gate/openstack-tox-py36/9b0bb6f/ : SUCCESS in 4m 55s\n- openstack-tox-py37 http://logs.openstack.org/01/669301/1/gate/openstack-tox-py37/6cc767c/ : SUCCESS in 5m 01s\n- openstack-tox-functional http://logs.openstack.org/01/669301/1/gate/openstack-tox-functional/f14a4c5/ : SUCCESS in 5m 09s\n- openstack-tox-functional-py36 http://logs.openstack.org/01/669301/1/gate/openstack-tox-functional-py36/5a691b8/ : SUCCESS in 5m 29s\n- placement-nova-tox-functional-py36 http://logs.openstack.org/01/669301/1/gate/placement-nova-tox-functional-py36/8b6e6ba/ : SUCCESS in 10m 23s","accounts_in_message":[],"_revision_number":1},{"id":"f20e3f4a10c9784ee1d7bec83ba18f576769eaf4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-06 03:03:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d1005782f5f2c6dfbeaf32fecc821c90770108ff","revisions":{"d1005782f5f2c6dfbeaf32fecc821c90770108ff":{"kind":"REWORK","_number":1,"created":"2019-07-05 09:01:49.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/01/669301/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/01/669301/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/669301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/669301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/669301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/01/669301/1"}}},"commit":{"parents":[{"commit":"06256d86c71929d697290b2fe05d1654c69ed9f0","subject":"Manage mappings on AllocationRequest object","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/06256d86c71929d697290b2fe05d1654c69ed9f0"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-05 08:59:56.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-05 08:59:56.000000000","tz":60},"subject":"Correct variable use and naming in mappings tests","message":"Correct variable use and naming in mappings tests\n\nIn review of Iba590d618fa493a4516d41f6b4ad5b5d0a8a07cb some misleading\nnames and ordering of those names were identified. They are fixed\nhere.\n\nChange-Id: I51cbb34ed8f045a1922fea2d1b463c327b0f856c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d1005782f5f2c6dfbeaf32fecc821c90770108ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d1005782f5f2c6dfbeaf32fecc821c90770108ff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}