)]}'
{"id":"openstack%2Fplacement~671249","triplet_id":"openstack%2Fplacement~master~Ic0ff55f00e0312251207fd079cf7b7e98d950c87","project":"openstack/placement","branch":"master","topic":"cd/osx-testing","hashtags":[],"change_id":"Ic0ff55f00e0312251207fd079cf7b7e98d950c87","subject":"Make placement testing easier on osx","status":"MERGED","created":"2019-07-17 12:28:56.000000000","updated":"2019-07-23 12:23:32.000000000","submitted":"2019-07-23 12:23:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"671249-1563884612857-a8feb72e","meta_rev_id":"5a30995ba0e24d8d2d79a33b576c71bebbd4cadb","_number":671249,"virtual_id_number":671249,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2019-07-18 09:40:41.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-07-23 12:23:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":2,"date":"2019-07-18 15:11:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-07-23 10:45:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"date":"2019-07-17 21:57:14.000000000","_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-07-23 10:45:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-17 21:57:14.000000000","updated_by":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"reviewer":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"state":"REVIEWER"},{"updated":"2019-07-18 15:11:48.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-07-23 10:45:03.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-07-23 12:23:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0667fabb71f5662f3cc2a9cb96009c29bf07d843","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-17 12:28:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7b407196ab80c685f7d7a3889cccdc77e4fc54cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-17 14:18:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref http://logs.openstack.org/49/671249/1/check/build-openstack-api-ref/97b64f8/html/ : SUCCESS in 3m 56s\n- grenade-py3 http://logs.openstack.org/49/671249/1/check/grenade-py3/df9f180/ : SUCCESS in 58m 52s\n- tempest-full-py3 http://logs.openstack.org/49/671249/1/check/tempest-full-py3/477596f/ : SUCCESS in 1h 24m 52s\n- openstack-tox-docs http://logs.openstack.org/49/671249/1/check/openstack-tox-docs/8a6087f/html/ : SUCCESS in 6m 47s\n- openstack-tox-cover http://logs.openstack.org/49/671249/1/check/openstack-tox-cover/bdded3d/cover/ : SUCCESS in 5m 07s\n- openstack-tox-lower-constraints http://logs.openstack.org/49/671249/1/check/openstack-tox-lower-constraints/46dbfb0/ : SUCCESS in 6m 50s\n- openstack-tox-pep8 http://logs.openstack.org/49/671249/1/check/openstack-tox-pep8/f76fd48/ : SUCCESS in 5m 40s\n- openstack-tox-py27 http://logs.openstack.org/49/671249/1/check/openstack-tox-py27/70d9ac2/ : SUCCESS in 4m 08s\n- openstack-tox-py36 http://logs.openstack.org/49/671249/1/check/openstack-tox-py36/8c347cc/ : SUCCESS in 4m 12s\n- openstack-tox-py37 http://logs.openstack.org/49/671249/1/check/openstack-tox-py37/434601b/ : SUCCESS in 4m 32s\n- build-openstack-releasenotes http://logs.openstack.org/49/671249/1/check/build-openstack-releasenotes/fac4838/html/ : SUCCESS in 5m 53s\n- openstack-tox-functional http://logs.openstack.org/49/671249/1/check/openstack-tox-functional/9fd43df/ : SUCCESS in 6m 15s\n- openstack-tox-functional-py36 http://logs.openstack.org/49/671249/1/check/openstack-tox-functional-py36/c3a9be0/ : SUCCESS in 5m 28s\n- openstack-tox-functional-py37 http://logs.openstack.org/49/671249/1/check/openstack-tox-functional-py37/55923ff/ : SUCCESS in 5m 01s\n- placement-nova-tox-functional-py37 http://logs.openstack.org/49/671249/1/check/placement-nova-tox-functional-py37/d99cc00/ : SUCCESS in 11m 56s\n- placement-nested-perfload http://logs.openstack.org/49/671249/1/check/placement-nested-perfload/bc79b5d/ : SUCCESS in 16m 36s (non-voting)\n- placement-perfload http://logs.openstack.org/49/671249/1/check/placement-perfload/0b7f232/ : SUCCESS in 8m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"07af2597830b393fcba2cadae872e0abf0fa2eca","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-17 21:41:01.000000000","message":"Patch Set 1: Code-Review+1\n\nThis looks sane to me. I\u0027d like Stephen and/or prometheanfire to ack that you\u0027ve spelled things correctly, then I\u0027ll +2.","accounts_in_message":[],"_revision_number":1},{"id":"eb877ad0bec16e72f16a7c67f84ecb2a3dd1b65f","author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"date":"2019-07-17 21:57:14.000000000","message":"Patch Set 1:\n\nUnfortunately I can\u0027t test this on osx, so not sure how helpful I\u0027d be.\n\nFrom a reqs perspective, this might be ok, I don\u0027t think we\u0027ve encountered this situation before.","accounts_in_message":[],"_revision_number":1},{"id":"92c2334bb49f5dc5148e96be796c1318ad9a6803","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-18 08:39:35.000000000","message":"Patch Set 1:\n\nAssuming you don\u0027t actually need these dependencies for testing, we usually solve this by using \"extras\" and not installing these things by default. However, this also works.\n\nI assume you\u0027ve tested this yourself, Chris? The syntax looks fine but I also can\u0027t test it either. I\u0027m also afraid it might break at some point in the future, though maybe by then it won\u0027t matter","accounts_in_message":[],"_revision_number":1},{"id":"fed150e739166fba069e2d08f46d4cb1f084246b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-18 09:40:41.000000000","message":"Patch Set 1:\n\n\u003e Assuming you don\u0027t actually need these dependencies for testing, we\n \u003e usually solve this by using \"extras\" and not installing these\n \u003e things by default. However, this also works.\n \u003e \n \u003e I assume you\u0027ve tested this yourself, Chris? The syntax looks fine\n \u003e but I also can\u0027t test it either. I\u0027m also afraid it might break at\n \u003e some point in the future, though maybe by then it won\u0027t matter\n\nThey are used for testing in the gate, for the opportunistic db tests (for migration testing): if the drivers and database are present, then mysql and postgresql are testing for the migrations (in addition to sqlite).\n\nI have tested this locally. It works. I borrowed the syntax from: https://opendev.org/openstack/requirements/src/commit/ad878cea6afbb35224ca3e425151268ec9a573fc/global-requirements.txt#L219","accounts_in_message":[],"_revision_number":1},{"id":"737d6c2d18b47656f34789a6ae8cb274502f097f","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-18 15:11:48.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e I borrowed the syntax from: https://opendev.org/openstack/requirements/src/commit/ad878cea6afbb35224ca3e425151268ec9a573fc/global-requirements.txt#L219\n\nAh, okay, precedent wfm.\n\nGiven that, and since Stephen \u0026 prometheanfire didn\u0027t come back with, \"eek, this is definitely broken,\" and since this doesn\u0027t hurt those on other platforms, and since Chris asserts this works for him locally, I\u0027m happy to approve.","accounts_in_message":[],"_revision_number":1},{"id":"778b25d117b41d63f5f359a436bd83aa9d6688aa","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-07-23 10:45:03.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nOkay, let\u0027s do it","accounts_in_message":[],"_revision_number":1},{"id":"69d64553a53e81a197a5aadbeda9175b732aab48","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-23 10:45:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ffc03985a96bf96ac8d6f1a7bf5da59d2ad2ee60","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-23 12:23:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"507dde52cc39bfdf8a65b8aff0fdda2cb04ce670","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-23 12:23:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-ref http://logs.openstack.org/49/671249/1/gate/build-openstack-api-ref/711bb67/html/ : SUCCESS in 4m 26s\n- grenade-py3 http://logs.openstack.org/49/671249/1/gate/grenade-py3/1f96f2c/ : SUCCESS in 59m 32s\n- tempest-full-py3 http://logs.openstack.org/49/671249/1/gate/tempest-full-py3/e2f5c26/ : SUCCESS in 1h 32m 18s\n- openstack-tox-docs http://logs.openstack.org/49/671249/1/gate/openstack-tox-docs/423f1dd/html/ : SUCCESS in 4m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/49/671249/1/gate/openstack-tox-lower-constraints/a71ffd9/ : SUCCESS in 5m 23s\n- openstack-tox-pep8 http://logs.openstack.org/49/671249/1/gate/openstack-tox-pep8/b7ec826/ : SUCCESS in 5m 54s\n- openstack-tox-py27 http://logs.openstack.org/49/671249/1/gate/openstack-tox-py27/a5fb03d/ : SUCCESS in 5m 12s\n- openstack-tox-py36 http://logs.openstack.org/49/671249/1/gate/openstack-tox-py36/fac6832/ : SUCCESS in 3m 46s\n- openstack-tox-py37 http://logs.openstack.org/49/671249/1/gate/openstack-tox-py37/86afac7/ : SUCCESS in 6m 04s\n- build-openstack-releasenotes http://logs.openstack.org/49/671249/1/gate/build-openstack-releasenotes/a60c500/html/ : SUCCESS in 4m 42s\n- openstack-tox-functional http://logs.openstack.org/49/671249/1/gate/openstack-tox-functional/a3aa087/ : SUCCESS in 5m 07s\n- openstack-tox-functional-py36 http://logs.openstack.org/49/671249/1/gate/openstack-tox-functional-py36/fa728dd/ : SUCCESS in 5m 58s\n- openstack-tox-functional-py37 http://logs.openstack.org/49/671249/1/gate/openstack-tox-functional-py37/3d92ed8/ : SUCCESS in 6m 44s\n- placement-nova-tox-functional-py37 http://logs.openstack.org/49/671249/1/gate/placement-nova-tox-functional-py37/788d66c/ : SUCCESS in 12m 55s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"baaaff17b5a57347cc19a896040d8c3ddd6fe8b1","revisions":{"baaaff17b5a57347cc19a896040d8c3ddd6fe8b1":{"kind":"REWORK","_number":1,"created":"2019-07-17 12:28:56.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/49/671249/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/49/671249/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/49/671249/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/49/671249/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/49/671249/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/49/671249/1"}}},"commit":{"parents":[{"commit":"3ba36fb7172ca8355fa29219bc8d0f0282cf834b","subject":"Merge \"Add Python 3 Train unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/3ba36fb7172ca8355fa29219bc8d0f0282cf834b"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-17 12:24:44.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-17 12:24:44.000000000","tz":60},"subject":"Make placement testing easier on osx","message":"Make placement testing easier on osx\n\nPlacement can run just fine on OSX but running the tests can\nbe a bit cumbersome since dev libraries for ssl, postresql,\nand mysql are required (directly or indirectly) by\ntest-requirements.txt, even though for non-gate testing we don\u0027t\nusually need them, and dealing with dynamic libraries is a\nfrequent source of pain and discomfort on OSX.\n\nThis change says \"don\u0027t import SQL drivers for mysql and postgresql\nwhen testing on darwin\".\n\nChange-Id: Ic0ff55f00e0312251207fd079cf7b7e98d950c87\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/baaaff17b5a57347cc19a896040d8c3ddd6fe8b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/baaaff17b5a57347cc19a896040d8c3ddd6fe8b1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}