)]}'
{"id":"openstack%2Fplacement~673335","triplet_id":"openstack%2Fplacement~master~I21680298f98f83d47e8319f01ad714cd96418c26","project":"openstack/placement","branch":"master","topic":"request_log-middleware-last","hashtags":[],"change_id":"I21680298f98f83d47e8319f01ad714cd96418c26","subject":"Clarify the NOTE associated with ordering of middleware","status":"MERGED","created":"2019-07-29 16:35:03.000000000","updated":"2019-09-03 14:23:41.000000000","submitted":"2019-09-03 14:20:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673335-1567520408328-486b088e","meta_rev_id":"58863bcb7f748e4375348d5cfdfa01e675884fb9","_number":673335,"virtual_id_number":673335,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2019-09-03 14:20:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":2,"date":"2019-09-03 10:55:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-28 21:09:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":1,"date":"2019-09-03 10:55:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-28 21:09:43.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-09-03 10:55:45.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-09-03 14:20:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f59387f27c746121c7b72d33c1d9c934606d04be","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-29 16:35:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe33561b8e914111cdc481d230d9fc127834fc28","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-29 17:50:04.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)\n\nThis is helpful. Though I\u0027m not sure if it\u0027s because you explained it in person first :(\n\nAt worst, it\u0027s more accurate and offers more explanation than what was there before.","accounts_in_message":[],"_revision_number":1},{"id":"c1d46268fce3af518caf853c827b5e4e14ba505f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-29 19:29:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/35/673335/1/check/grenade-py3/57207e7/ : SUCCESS in 1h 08m 22s\n- tempest-integrated-placement http://logs.openstack.org/35/673335/1/check/tempest-integrated-placement/6c3e8f7/ : SUCCESS in 1h 26m 54s\n- openstack-tox-docs http://logs.openstack.org/35/673335/1/check/openstack-tox-docs/67d9c89/html/ : SUCCESS in 5m 23s\n- openstack-tox-cover http://logs.openstack.org/35/673335/1/check/openstack-tox-cover/6f4a57e/cover/ : SUCCESS in 5m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/35/673335/1/check/openstack-tox-lower-constraints/621a4bd/ : SUCCESS in 5m 16s\n- openstack-tox-pep8 http://logs.openstack.org/35/673335/1/check/openstack-tox-pep8/15d4bf6/ : SUCCESS in 5m 15s\n- openstack-tox-py27 http://logs.openstack.org/35/673335/1/check/openstack-tox-py27/8c20c6d/ : SUCCESS in 5m 26s\n- openstack-tox-py36 http://logs.openstack.org/35/673335/1/check/openstack-tox-py36/d62c53f/ : SUCCESS in 4m 16s\n- openstack-tox-py37 http://logs.openstack.org/35/673335/1/check/openstack-tox-py37/b5f5d45/ : SUCCESS in 7m 44s\n- openstack-tox-functional http://logs.openstack.org/35/673335/1/check/openstack-tox-functional/30dfbee/ : SUCCESS in 4m 48s\n- openstack-tox-functional-py36 http://logs.openstack.org/35/673335/1/check/openstack-tox-functional-py36/99fe72a/ : SUCCESS in 6m 07s\n- openstack-tox-functional-py37 http://logs.openstack.org/35/673335/1/check/openstack-tox-functional-py37/c46f8ad/ : SUCCESS in 9m 58s\n- placement-nova-tox-functional-py37 http://logs.openstack.org/35/673335/1/check/placement-nova-tox-functional-py37/f4a1cb8/ : SUCCESS in 15m 22s\n- placement-nested-perfload http://logs.openstack.org/35/673335/1/check/placement-nested-perfload/d6a3ee7/ : SUCCESS in 18m 52s (non-voting)\n- placement-perfload http://logs.openstack.org/35/673335/1/check/placement-perfload/a399b06/ : SUCCESS in 7m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"27725b7f1dc8a55fa5c9c674f5268191f1fdbdaa","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-09 13:40:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nNice explanation.","accounts_in_message":[],"_revision_number":1},{"id":"1c0beddbf77940fe30f8227819793e91fec1d35e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-28 09:00:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9c642f748608fed8cfc6fe01a1c78eb6b1604e67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 10:53:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/1d9a88ac849e4c48887a73cc30f301ff : SUCCESS in 1h 05m 44s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/104cde93c47c435ea62437bcc57c8ba1 : SUCCESS in 1h 18m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/28c2377ce4a246e19eabbb1004135b7c : SUCCESS in 5m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3c3662681dc7481e9fde8fd73311e33a : SUCCESS in 6m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dade859cc75146ec88b2763f39be99cb : SUCCESS in 5m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7a5d19f8b60a463e9a57d99650733570 : SUCCESS in 4m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fae24f9e12fd4dc3985de9d8eddb3087 : SUCCESS in 5m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d2a6db1a5890499cbc94c7074fde0259 : SUCCESS in 6m 02s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e27046ce6d2e47afbfcc64d9bc60477c : SUCCESS in 5m 27s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/5d2a8a063dea4ccbab11a9e6a49a1498 : SUCCESS in 5m 46s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/c7bc51fd7b6d44b9bd27d0f981304ea7 : SUCCESS in 6m 14s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/02960c98290c41f2ad36e9fcea3ff26f : SUCCESS in 7m 16s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/f92966920cf94290864a7bf93537223e : SUCCESS in 13m 37s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/2397482321434f2581b6a506e4cc26b7 : SUCCESS in 39m 32s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/9ec0a2123967473abeca5996a71f7254 : SUCCESS in 12m 24s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9e7725e4e1914769a01b62ca34868653 : SUCCESS in 1h 13m 02s","accounts_in_message":[],"_revision_number":2},{"id":"e4b12c28aa4f9a6e587494ebbe425c54ea0cc9f6","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-28 21:09:43.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ccaca8c2a3f0ac8c219e20182f88b7cf3cf909e1","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-09-03 10:55:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nNice","accounts_in_message":[],"_revision_number":2},{"id":"bf5a36cfabb7e5cdc3e30d73f73a55b03d5114cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-03 10:56:03.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e26c651e497f99039cfbee0581a2762ee3ed5d5f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-03 14:20:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/65b0aa8a56ae4466a05f16b0b323fe69 : SUCCESS in 1h 09m 50s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/c5da4c0b2aa04d508a655c2bc6a91f7d : SUCCESS in 1h 25m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dadb368acb1b4a2b9803474a2791c1fd : SUCCESS in 6m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1ea743f8a587477cb4ac536240cad0a7 : SUCCESS in 6m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7a6b14872cf4ea8810beed3cce8d3d5 : SUCCESS in 5m 20s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/65b2ac293fe54ff9bb8fd8350045ef40 : SUCCESS in 5m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aeff21089a6a4ab491e81706a83970da : SUCCESS in 4m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/79f247b794704d7ba362ab8612a2c4f3 : SUCCESS in 5m 43s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/26f06811525943698ff5c8da41aa5c91 : SUCCESS in 5m 04s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/c0cbf306a43a42ba80ef3b3d91611b8a : SUCCESS in 5m 32s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/c61d4c4ec91c470ba30913f1600f8438 : SUCCESS in 6m 58s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/abfe88014735437d9f988d285f77c18c : SUCCESS in 12m 43s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a025b4559b9443b5876560d77150a04b : SUCCESS in 1h 06m 03s","accounts_in_message":[],"_revision_number":2},{"id":"225807f30942201752d6c52201e66437861d3ad1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-03 14:20:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"abf218110ee51ce29b28dd9861d9efa304d6c827","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-03 14:23:41.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eccc3a163cf94ba88bcbad33bf9de4ca : SUCCESS in 1m 52s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"75fb2fe8a364b05ed456ad7fa009e49c47670fb8","revisions":{"41931305dc5214cde4dd58cd69e2a214e9971ae2":{"kind":"REWORK","_number":1,"created":"2019-07-29 16:35:03.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/35/673335/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/35/673335/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/673335/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/673335/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/673335/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/35/673335/1"}}},"commit":{"parents":[{"commit":"71071a79881959d80dff0aa3320a1471b1bd4233","subject":"Do request_log middleware next to last","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/71071a79881959d80dff0aa3320a1471b1bd4233"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-29 16:26:52.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-29 16:34:49.000000000","tz":60},"subject":"Clarify the NOTE associated with ordering of middleware","message":"Clarify the NOTE associated with ordering of middleware\n\nWSGI middleware is a confusing topic for people who are not\nfamiliar with it, so make the NOTE that describes how the\nordering works more clear.\n\nChange-Id: I21680298f98f83d47e8319f01ad714cd96418c26\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/41931305dc5214cde4dd58cd69e2a214e9971ae2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/41931305dc5214cde4dd58cd69e2a214e9971ae2"}]},"branch":"refs/heads/master"},"75fb2fe8a364b05ed456ad7fa009e49c47670fb8":{"kind":"REWORK","_number":2,"created":"2019-08-28 09:00:23.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/35/673335/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/35/673335/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/673335/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/673335/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/673335/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/35/673335/2"}}},"commit":{"parents":[{"commit":"7327f2eeec5bc6c5c2518155627a2bbf6d2516a7","subject":"Merge request log and request id middlewares","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/7327f2eeec5bc6c5c2518155627a2bbf6d2516a7"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-29 16:26:52.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-28 08:59:27.000000000","tz":60},"subject":"Clarify the NOTE associated with ordering of middleware","message":"Clarify the NOTE associated with ordering of middleware\n\nWSGI middleware is a confusing topic for people who are not\nfamiliar with it, so make the NOTE that describes how the\nordering works more clear.\n\nChange-Id: I21680298f98f83d47e8319f01ad714cd96418c26\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/75fb2fe8a364b05ed456ad7fa009e49c47670fb8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/75fb2fe8a364b05ed456ad7fa009e49c47670fb8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}