)]}'
{"id":"openstack%2Fplacement~673750","triplet_id":"openstack%2Fplacement~master~Iaa20e5e92e793b75f7773f86407cdedfb6584dab","project":"openstack/placement","branch":"master","topic":"cd/trait-cache-fup","hashtags":[],"change_id":"Iaa20e5e92e793b75f7773f86407cdedfb6584dab","subject":"Use TraitCache for Trait.get_by_name","status":"MERGED","created":"2019-07-31 07:59:58.000000000","updated":"2019-08-06 05:48:35.000000000","submitted":"2019-08-06 05:48:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673750-1565070515538-b796e31c","meta_rev_id":"61cbb331f73db69dfdb884d5bd88d98bb251bc72","_number":673750,"virtual_id_number":673750,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-06 05:48:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-06 04:20:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2019-07-31 08:28:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-06 04:20:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-31 08:28:45.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-08-06 04:20:38.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-08-06 05:48:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c3abdabf271e93d5c542e5458ac4622386748aca","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-07-31 07:59:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1f362c0949700fc919567c22302f669175b5362d","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-07-31 08:28:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3c178a737ea64220fce70af92abf174bc6c57451","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 11:59:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 http://logs.openstack.org/50/673750/1/check/grenade-py3/3a51162/ : SUCCESS in 59m 49s\n- tempest-integrated-placement http://logs.openstack.org/50/673750/1/check/tempest-integrated-placement/caf9fec/ : SUCCESS in 1h 22m 08s\n- openstack-tox-docs http://logs.openstack.org/50/673750/1/check/openstack-tox-docs/c0f5e52/html/ : SUCCESS in 3m 58s\n- openstack-tox-cover http://logs.openstack.org/50/673750/1/check/openstack-tox-cover/1a13a8d/cover/ : SUCCESS in 6m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/50/673750/1/check/openstack-tox-lower-constraints/c0de98d/ : SUCCESS in 5m 09s\n- openstack-tox-pep8 http://logs.openstack.org/50/673750/1/check/openstack-tox-pep8/14c58b5/ : SUCCESS in 3m 47s\n- openstack-tox-py27 http://logs.openstack.org/50/673750/1/check/openstack-tox-py27/d3cca82/ : SUCCESS in 5m 06s\n- openstack-tox-py36 http://logs.openstack.org/50/673750/1/check/openstack-tox-py36/b95651c/ : SUCCESS in 4m 50s\n- openstack-tox-py37 http://logs.openstack.org/50/673750/1/check/openstack-tox-py37/b0591dd/ : SUCCESS in 5m 14s\n- openstack-tox-functional http://logs.openstack.org/50/673750/1/check/openstack-tox-functional/6bd0483/ : SUCCESS in 4m 31s\n- openstack-tox-functional-py36 http://logs.openstack.org/50/673750/1/check/openstack-tox-functional-py36/0644212/ : SUCCESS in 7m 20s\n- openstack-tox-functional-py37 http://logs.openstack.org/50/673750/1/check/openstack-tox-functional-py37/276571d/ : SUCCESS in 5m 00s\n- placement-nova-tox-functional-py37 http://logs.openstack.org/50/673750/1/check/placement-nova-tox-functional-py37/beaa77f/ : SUCCESS in 10m 17s\n- placement-nested-perfload http://logs.openstack.org/50/673750/1/check/placement-nested-perfload/3f2cf8e/ : SUCCESS in 17m 26s (non-voting)\n- placement-perfload http://logs.openstack.org/50/673750/1/check/placement-perfload/c7af1b4/ : SUCCESS in 7m 41s (non-voting)\n- tempest-ipv6-only http://logs.openstack.org/50/673750/1/check/tempest-ipv6-only/4076fb5/ : SUCCESS in 1h 05m 50s","accounts_in_message":[],"_revision_number":1},{"id":"a29ed1a3632d54c8f0d1818275e69193375610f0","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-06 04:20:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)\n\nLGTM. Unrelated question within.","accounts_in_message":[],"_revision_number":1},{"id":"c0f5ea6569042bb8cd65812ce93c3dac6af111f1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 04:20:49.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4946c2190b27d8250f2d2f8787378e7d0c0bb643","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 05:48:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7187010ff4bf96c934a002d9100c31b290f77c4f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 05:48:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/50/673750/1/gate/grenade-py3/bc3a1de/ : SUCCESS in 57m 17s\n- tempest-integrated-placement https://logs.opendev.org/50/673750/1/gate/tempest-integrated-placement/b04a45c/ : SUCCESS in 1h 22m 21s\n- openstack-tox-docs https://logs.opendev.org/50/673750/1/gate/openstack-tox-docs/486a79d/html/ : SUCCESS in 3m 32s\n- openstack-tox-lower-constraints https://logs.opendev.org/50/673750/1/gate/openstack-tox-lower-constraints/9e5bb54/ : SUCCESS in 4m 16s\n- openstack-tox-pep8 https://logs.opendev.org/50/673750/1/gate/openstack-tox-pep8/390f06a/ : SUCCESS in 3m 35s\n- openstack-tox-py27 https://logs.opendev.org/50/673750/1/gate/openstack-tox-py27/60930e1/ : SUCCESS in 3m 55s\n- openstack-tox-py36 https://logs.opendev.org/50/673750/1/gate/openstack-tox-py36/91e0b05/ : SUCCESS in 3m 53s\n- openstack-tox-py37 https://logs.opendev.org/50/673750/1/gate/openstack-tox-py37/3fa005c/ : SUCCESS in 4m 21s\n- openstack-tox-functional https://logs.opendev.org/50/673750/1/gate/openstack-tox-functional/7147b07/ : SUCCESS in 4m 12s\n- openstack-tox-functional-py36 https://logs.opendev.org/50/673750/1/gate/openstack-tox-functional-py36/6f3012d/ : SUCCESS in 4m 03s\n- openstack-tox-functional-py37 https://logs.opendev.org/50/673750/1/gate/openstack-tox-functional-py37/3bacc38/ : SUCCESS in 4m 39s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/50/673750/1/gate/placement-nova-tox-functional-py37/a30245e/ : SUCCESS in 11m 29s\n- tempest-ipv6-only https://logs.opendev.org/50/673750/1/gate/tempest-ipv6-only/0bf2a80/ : SUCCESS in 58m 34s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a0e2c0273fe7ea6e04c65f96728cc74b5f1815ac","revisions":{"a0e2c0273fe7ea6e04c65f96728cc74b5f1815ac":{"kind":"REWORK","_number":1,"created":"2019-07-31 07:59:58.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/50/673750/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/50/673750/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/50/673750/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/50/673750/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/50/673750/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/50/673750/1"}}},"commit":{"parents":[{"commit":"541052ad5edcdd6328f59d71d94b0ae39879d74a","subject":"Merge \"Extra gabbi tests for same_subtree\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/541052ad5edcdd6328f59d71d94b0ae39879d74a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-31 07:54:13.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-07-31 07:54:13.000000000","tz":60},"subject":"Use TraitCache for Trait.get_by_name","message":"Use TraitCache for Trait.get_by_name\n\nChange Trait.get_by_name to access the TraitCache. This was\nsomething that was intended to be done in the patch that added\nthe cache [1] but was left out.\n\nFor most uses of get_by_name this has little impact: the cache\nwill be cold when the method is called, warmed to satisfy the\nrequest. However, this makes Trait.get_by_name consistent with\nResourceClass.get_by_name.\n\n[1] Ia19ea2b4ecdde25323579edf60ad6269d05e75a2\n\nChange-Id: Iaa20e5e92e793b75f7773f86407cdedfb6584dab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a0e2c0273fe7ea6e04c65f96728cc74b5f1815ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a0e2c0273fe7ea6e04c65f96728cc74b5f1815ac"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}