)]}'
{"id":"openstack%2Fplacement~673991","triplet_id":"openstack%2Fplacement~master~Iec2b235187e4c56a25d5a708d7abead68983e62e","project":"openstack/placement","branch":"master","topic":"cd/de-dict-list-rps","hashtags":[],"change_id":"Iec2b235187e4c56a25d5a708d7abead68983e62e","subject":"_get_all_by_filters_from_db do not cast to list of dict","status":"MERGED","created":"2019-08-01 10:07:03.000000000","updated":"2019-08-08 13:02:39.000000000","submitted":"2019-08-08 13:02:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673991-1565269359585-a273883a","meta_rev_id":"718dccc94be296ac59a05e36e190c1f1dae1e266","_number":673991,"virtual_id_number":673991,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"date":"2019-08-02 07:45:53.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-08-08 13:02:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"recommended":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"all":[{"value":1,"date":"2019-08-06 06:21:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-08-01 13:47:39.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-08-08 10:06:36.000000000","_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-08-08 10:06:36.000000000","_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-01 13:47:39.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-08-06 06:21:38.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-08-08 10:06:36.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-08-08 13:02:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5e7a38824002b4a4c99a687e9ea99f2525d04a2a","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-01 10:07:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b7e4f0d324f336ad3450d3e98664c83e7a7823e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-01 10:12:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f178beed82add8c347073bddb9fb582a36151aa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 11:49:36.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://logs.opendev.org/91/673991/1/check/grenade-py3/fd0e2de/ : SUCCESS in 1h 08m 52s\n- tempest-integrated-placement https://logs.opendev.org/91/673991/1/check/tempest-integrated-placement/0bdfd51/ : SUCCESS in 1h 38m 28s\n- openstack-tox-docs https://logs.opendev.org/91/673991/1/check/openstack-tox-docs/5916bbf/html/ : SUCCESS in 5m 54s\n- openstack-tox-cover https://logs.opendev.org/91/673991/1/check/openstack-tox-cover/0149e2a/ : FAILURE in 7m 27s\n- openstack-tox-lower-constraints https://logs.opendev.org/91/673991/1/check/openstack-tox-lower-constraints/e5cba2f/ : SUCCESS in 6m 50s\n- openstack-tox-pep8 https://logs.opendev.org/91/673991/1/check/openstack-tox-pep8/69e8c7e/ : SUCCESS in 5m 29s\n- openstack-tox-py27 https://logs.opendev.org/91/673991/1/check/openstack-tox-py27/687f507/ : SUCCESS in 5m 52s\n- openstack-tox-py36 https://logs.opendev.org/91/673991/1/check/openstack-tox-py36/1645083/ : SUCCESS in 4m 41s\n- openstack-tox-py37 https://logs.opendev.org/91/673991/1/check/openstack-tox-py37/f373705/ : SUCCESS in 6m 43s\n- openstack-tox-functional https://logs.opendev.org/91/673991/1/check/openstack-tox-functional/cf4729c/ : FAILURE in 6m 21s\n- openstack-tox-functional-py36 https://logs.opendev.org/91/673991/1/check/openstack-tox-functional-py36/478995c/ : FAILURE in 5m 55s\n- openstack-tox-functional-py37 https://logs.opendev.org/91/673991/1/check/openstack-tox-functional-py37/582659a/ : FAILURE in 5m 51s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/91/673991/1/check/placement-nova-tox-functional-py37/26ad4bb/ : SUCCESS in 11m 41s\n- placement-nested-perfload https://logs.opendev.org/91/673991/1/check/placement-nested-perfload/1a449d5/ : SUCCESS in 18m 39s (non-voting)\n- placement-perfload https://logs.opendev.org/91/673991/1/check/placement-perfload/44a16b8/ : SUCCESS in 7m 39s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/91/673991/1/check/tempest-ipv6-only/96a7c52/ : SUCCESS in 59m 10s","accounts_in_message":[],"_revision_number":1},{"id":"b605ba6a75edaa88bdd14838dac2b806e466992b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-01 13:47:39.000000000","message":"Patch Set 1: Code-Review+2\n\ncdent convinced me in [1] that it\u0027s appropriate to sling the sqla-result-thing-that-behaves-dictishly around. Since this passes tests (the func failure is unrelated, addressed by [2]) that clearly works, and is otherwise a lovely \"don\u0027t duplicate a dict\" optimization, so ++.\n\n[1] https://review.opendev.org/673788\n[2] https://review.opendev.org/673964","accounts_in_message":[],"_revision_number":1},{"id":"23379c2db2dcdd644c4ec8397c35e5bdd37b04cd","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-02 07:45:53.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"fb0888736e3b1226ccc87b751fe2f1a0fd1e9d34","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 09:11:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/91/673991/1/check/grenade-py3/eab98ae/ : SUCCESS in 58m 32s\n- tempest-integrated-placement https://logs.opendev.org/91/673991/1/check/tempest-integrated-placement/eeb9924/ : SUCCESS in 1h 22m 15s\n- openstack-tox-docs https://logs.opendev.org/91/673991/1/check/openstack-tox-docs/455df9b/html/ : SUCCESS in 4m 26s\n- openstack-tox-cover https://logs.opendev.org/91/673991/1/check/openstack-tox-cover/e56f030/cover/ : SUCCESS in 8m 00s\n- openstack-tox-lower-constraints https://logs.opendev.org/91/673991/1/check/openstack-tox-lower-constraints/1f34de1/ : SUCCESS in 5m 08s\n- openstack-tox-pep8 https://logs.opendev.org/91/673991/1/check/openstack-tox-pep8/5be2040/ : SUCCESS in 4m 03s\n- openstack-tox-py27 https://logs.opendev.org/91/673991/1/check/openstack-tox-py27/a62bf6c/ : SUCCESS in 6m 02s\n- openstack-tox-py36 https://logs.opendev.org/91/673991/1/check/openstack-tox-py36/2001160/ : SUCCESS in 6m 15s\n- openstack-tox-py37 https://logs.opendev.org/91/673991/1/check/openstack-tox-py37/7b7658b/ : SUCCESS in 7m 57s\n- openstack-tox-functional https://logs.opendev.org/91/673991/1/check/openstack-tox-functional/69757bc/ : SUCCESS in 5m 47s\n- openstack-tox-functional-py36 https://logs.opendev.org/91/673991/1/check/openstack-tox-functional-py36/43437cf/ : SUCCESS in 4m 49s\n- openstack-tox-functional-py37 https://logs.opendev.org/91/673991/1/check/openstack-tox-functional-py37/5a5775a/ : SUCCESS in 6m 17s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/91/673991/1/check/placement-nova-tox-functional-py37/fc0a59d/ : SUCCESS in 12m 51s\n- placement-nested-perfload https://logs.opendev.org/91/673991/1/check/placement-nested-perfload/c44f409/ : SUCCESS in 16m 15s (non-voting)\n- placement-perfload https://logs.opendev.org/91/673991/1/check/placement-perfload/9c72a1a/ : SUCCESS in 8m 32s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/91/673991/1/check/tempest-ipv6-only/27865f5/ : SUCCESS in 53m 18s","accounts_in_message":[],"_revision_number":1},{"id":"137cc11df0be676c55a5821ad052f60ee7a0ce14","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-06 06:21:38.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1b7f505462a2af0fcf857f6c254a7b7f5345b1ae","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-08 10:06:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nIt makes sense. Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"b57b6632a81af033b105a62d8522a12b7a1548ea","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 10:06:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dcebe2cc986ead8f53ca5a8b51b4a341bfab58b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 13:02:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/91/673991/1/gate/grenade-py3/3c257e4/ : SUCCESS in 1h 09m 39s\n- tempest-integrated-placement https://logs.opendev.org/91/673991/1/gate/tempest-integrated-placement/8727b5a/ : SUCCESS in 1h 42m 50s\n- openstack-tox-docs https://logs.opendev.org/91/673991/1/gate/openstack-tox-docs/97fd3d7/html/ : SUCCESS in 4m 42s\n- openstack-tox-lower-constraints https://logs.opendev.org/91/673991/1/gate/openstack-tox-lower-constraints/b6a0720/ : SUCCESS in 6m 13s\n- openstack-tox-pep8 https://logs.opendev.org/91/673991/1/gate/openstack-tox-pep8/4741257/ : SUCCESS in 6m 55s\n- openstack-tox-py27 https://logs.opendev.org/91/673991/1/gate/openstack-tox-py27/2e52f9b/ : SUCCESS in 7m 03s\n- openstack-tox-py36 https://logs.opendev.org/91/673991/1/gate/openstack-tox-py36/21fd0db/ : SUCCESS in 4m 09s\n- openstack-tox-py37 https://logs.opendev.org/91/673991/1/gate/openstack-tox-py37/817d379/ : SUCCESS in 5m 47s\n- openstack-tox-functional https://logs.opendev.org/91/673991/1/gate/openstack-tox-functional/cd90ffc/ : SUCCESS in 4m 51s\n- openstack-tox-functional-py36 https://logs.opendev.org/91/673991/1/gate/openstack-tox-functional-py36/09370c4/ : SUCCESS in 4m 59s\n- openstack-tox-functional-py37 https://logs.opendev.org/91/673991/1/gate/openstack-tox-functional-py37/771d6bb/ : SUCCESS in 6m 11s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/91/673991/1/gate/placement-nova-tox-functional-py37/b778a73/ : SUCCESS in 13m 08s\n- tempest-ipv6-only https://logs.opendev.org/91/673991/1/gate/tempest-ipv6-only/5fcda49/ : SUCCESS in 1h 07m 31s","accounts_in_message":[],"_revision_number":1},{"id":"f6974c0d7899efd6bae000fccd507e33560057df","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 13:02:39.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"069c531b1a0a1aa981aa894e603a15b736e75df5","revisions":{"069c531b1a0a1aa981aa894e603a15b736e75df5":{"kind":"REWORK","_number":1,"created":"2019-08-01 10:07:03.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/91/673991/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/91/673991/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/673991/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/673991/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/673991/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/91/673991/1"}}},"commit":{"parents":[{"commit":"835081ac363a122153323df26c173ddee305801c","subject":"Blacklist sphinx 2.1.0 (autodoc bug)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/835081ac363a122153323df26c173ddee305801c"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 09:51:25.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 09:51:25.000000000","tz":60},"subject":"_get_all_by_filters_from_db do not cast to list of dict","message":"_get_all_by_filters_from_db do not cast to list of dict\n\nThe RowProxy objects in the `res` list are already dict-like,\nso casting them to dict is redundant.\n\nIn an environment with 1623 resource providers, the list\ncomprehension that does the dict-ification contributes 36%\nof the time.\n\nChange-Id: Iec2b235187e4c56a25d5a708d7abead68983e62e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/069c531b1a0a1aa981aa894e603a15b736e75df5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/069c531b1a0a1aa981aa894e603a15b736e75df5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}