)]}'
{"id":"openstack%2Fplacement~674017","triplet_id":"openstack%2Fplacement~master~If937053a8af3f0eecdd90aa807be0abc316d8c4f","project":"openstack/placement","branch":"master","topic":"cd/de-tuple","hashtags":[],"change_id":"If937053a8af3f0eecdd90aa807be0abc316d8c4f","subject":"Remove double join in provider_ids_from_rp_ids","status":"MERGED","created":"2019-08-01 12:26:11.000000000","updated":"2019-08-08 09:18:21.000000000","submitted":"2019-08-07 15:15:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674017-1565190936634-cd85f96c","meta_rev_id":"ebd7da782732ba4a784c1ecef3a78922a9da27d6","_number":674017,"virtual_id_number":674017,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-08-07 15:15:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":2,"date":"2019-08-07 10:26:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-08-07 10:26:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-07 13:07:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-07 13:07:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-06 07:14:51.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-08-06 15:37:13.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-08-07 13:07:17.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-08-07 15:15:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aafa4c57dac7a0cead22d0142dac7dac3823d836","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-01 12:26:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c66fd23abe4f1e5aae8d0e0b136dd77f188b7dfc","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-01 12:26:44.000000000","message":"Patch Set 1:\n\nthis probably needs some pretty thoughtful review","accounts_in_message":[],"_revision_number":1},{"id":"02ff7b9067c538cbc2b0c0d2a2406a7105cabefe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 13:50:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://logs.opendev.org/17/674017/1/check/grenade-py3/81d501a/ : SUCCESS in 57m 50s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/1/check/tempest-integrated-placement/56b2f05/ : SUCCESS in 1h 19m 19s\n- openstack-tox-docs https://logs.opendev.org/17/674017/1/check/openstack-tox-docs/cbca920/html/ : SUCCESS in 4m 20s\n- openstack-tox-cover https://logs.opendev.org/17/674017/1/check/openstack-tox-cover/bb04903/ : FAILURE in 6m 20s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/1/check/openstack-tox-lower-constraints/3eb34c3/ : SUCCESS in 5m 36s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/1/check/openstack-tox-pep8/9874115/ : SUCCESS in 4m 36s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/1/check/openstack-tox-py27/6b9cfca/ : SUCCESS in 5m 35s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/1/check/openstack-tox-py36/b549c94/ : SUCCESS in 4m 24s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/1/check/openstack-tox-py37/ce44e32/ : SUCCESS in 5m 02s\n- openstack-tox-functional https://logs.opendev.org/17/674017/1/check/openstack-tox-functional/5c6dfdc/ : FAILURE in 5m 05s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/1/check/openstack-tox-functional-py36/05d1fc4/ : FAILURE in 4m 56s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/1/check/openstack-tox-functional-py37/dc6c5e6/ : FAILURE in 5m 47s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/1/check/placement-nova-tox-functional-py37/da6a598/ : SUCCESS in 12m 45s\n- placement-nested-perfload https://logs.opendev.org/17/674017/1/check/placement-nested-perfload/d37744d/ : SUCCESS in 15m 53s (non-voting)\n- placement-perfload https://logs.opendev.org/17/674017/1/check/placement-perfload/25cfb41/ : SUCCESS in 8m 36s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/17/674017/1/check/tempest-ipv6-only/a1902a3/ : SUCCESS in 1h 02m 35s","accounts_in_message":[],"_revision_number":1},{"id":"1f214f6c89bb2664f8470ecec5987e8163d713c5","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-01 15:26:32.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"23ff2dc1c56eea9b015dfa90b6a36e223a0bdec2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 21:41:37.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://logs.opendev.org/17/674017/2/check/grenade-py3/379d0d0/ : SUCCESS in 59m 53s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/2/check/tempest-integrated-placement/31c71de/ : SUCCESS in 1h 18m 53s\n- openstack-tox-docs https://logs.opendev.org/17/674017/2/check/openstack-tox-docs/774ef25/html/ : SUCCESS in 6m 14s\n- openstack-tox-cover https://logs.opendev.org/17/674017/2/check/openstack-tox-cover/0c10e1f/ : FAILURE in 6m 42s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/2/check/openstack-tox-lower-constraints/0fc4e7a/ : SUCCESS in 6m 07s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/2/check/openstack-tox-pep8/d152b5b/ : FAILURE in 5m 50s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/2/check/openstack-tox-py27/ace0937/ : SUCCESS in 5m 28s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/2/check/openstack-tox-py36/a63012d/ : SUCCESS in 5m 44s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/2/check/openstack-tox-py37/9212705/ : SUCCESS in 6m 38s\n- openstack-tox-functional https://logs.opendev.org/17/674017/2/check/openstack-tox-functional/e775e34/ : FAILURE in 6m 05s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/2/check/openstack-tox-functional-py36/6bf324d/ : FAILURE in 6m 11s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/2/check/openstack-tox-functional-py37/9fd0fc3/ : FAILURE in 6m 43s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/2/check/placement-nova-tox-functional-py37/d69788c/ : SUCCESS in 12m 55s\n- placement-nested-perfload https://logs.opendev.org/17/674017/2/check/placement-nested-perfload/3a38113/ : SUCCESS in 20m 56s (non-voting)\n- placement-perfload https://logs.opendev.org/17/674017/2/check/placement-perfload/7ae6b17/ : SUCCESS in 7m 53s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/17/674017/2/check/tempest-ipv6-only/644f2a1/ : SUCCESS in 1h 12m 47s","accounts_in_message":[],"_revision_number":2},{"id":"a2839db9e18af3b8f7177f3c7fddfd4b4fde03b1","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-01 21:48:09.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"a1ccd9bb06f5e7ae11db1132d34c951ba6c55eb7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 03:23:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/17/674017/3/check/grenade-py3/15b8f5e/ : SUCCESS in 52m 44s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/3/check/tempest-integrated-placement/2be706d/ : SUCCESS in 1h 42m 21s\n- openstack-tox-docs https://logs.opendev.org/17/674017/3/check/openstack-tox-docs/1c4e5bc/html/ : SUCCESS in 6m 32s\n- openstack-tox-cover https://logs.opendev.org/17/674017/3/check/openstack-tox-cover/f876ba5/cover/ : SUCCESS in 5m 34s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/3/check/openstack-tox-lower-constraints/e41e775/ : SUCCESS in 4m 42s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/3/check/openstack-tox-pep8/3a04d93/ : SUCCESS in 4m 27s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/3/check/openstack-tox-py27/bffb982/ : SUCCESS in 4m 34s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/3/check/openstack-tox-py36/21b55c5/ : SUCCESS in 6m 26s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/3/check/openstack-tox-py37/1073c56/ : SUCCESS in 6m 27s\n- openstack-tox-functional https://logs.opendev.org/17/674017/3/check/openstack-tox-functional/6551458/ : SUCCESS in 5m 33s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/3/check/openstack-tox-functional-py36/6f289d3/ : SUCCESS in 5m 33s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/3/check/openstack-tox-functional-py37/829adf1/ : SUCCESS in 5m 41s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/3/check/placement-nova-tox-functional-py37/0d5d02e/ : SUCCESS in 12m 53s\n- placement-nested-perfload https://logs.opendev.org/17/674017/3/check/placement-nested-perfload/c0f5707/ : SUCCESS in 19m 05s (non-voting)\n- placement-perfload https://logs.opendev.org/17/674017/3/check/placement-perfload/91d2708/ : SUCCESS in 8m 31s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/17/674017/3/check/tempest-ipv6-only/a4ce4fc/ : SUCCESS in 1h 09m 09s","accounts_in_message":[],"_revision_number":3},{"id":"9b147a48464fcc92d40cf1eb723a25e21cb57416","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-02 14:30:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"46e470978498206dbc8bea17df4eb5989e25a7b6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 15:52:16.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://logs.opendev.org/17/674017/4/check/grenade-py3/ca98d0b/ : SUCCESS in 50m 17s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/4/check/tempest-integrated-placement/0b7c9d3/ : SUCCESS in 1h 06m 05s\n- openstack-tox-docs https://logs.opendev.org/17/674017/4/check/openstack-tox-docs/a3026a5/html/ : SUCCESS in 4m 54s\n- openstack-tox-cover https://logs.opendev.org/17/674017/4/check/openstack-tox-cover/44c16bb/cover/ : SUCCESS in 7m 20s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/4/check/openstack-tox-lower-constraints/a2530bf/ : SUCCESS in 6m 03s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/4/check/openstack-tox-pep8/5e768d1/ : SUCCESS in 6m 04s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/4/check/openstack-tox-py27/d036df9/ : SUCCESS in 5m 56s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/4/check/openstack-tox-py36/27c8baa/ : SUCCESS in 5m 00s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/4/check/openstack-tox-py37/6ec1fa0/ : SUCCESS in 5m 38s\n- openstack-tox-functional https://logs.opendev.org/17/674017/4/check/openstack-tox-functional/0d0ef9b/ : SUCCESS in 6m 00s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/4/check/openstack-tox-functional-py36/81498c3/ : SUCCESS in 7m 03s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/4/check/openstack-tox-functional-py37/f516b84/ : SUCCESS in 6m 58s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/4/check/placement-nova-tox-functional-py37/7f8928c/ : SUCCESS in 13m 49s\n- placement-nested-perfload https://logs.opendev.org/17/674017/4/check/placement-nested-perfload/0f5b516/ : SUCCESS in 17m 40s (non-voting)\n- placement-perfload https://logs.opendev.org/17/674017/4/check/placement-perfload/fd59c13/ : SUCCESS in 10m 03s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/17/674017/4/check/tempest-ipv6-only/d332f96/ : POST_FAILURE in 1h 03m 40s","accounts_in_message":[],"_revision_number":4},{"id":"453688b040fc8a2def915d2cd4d538713c918152","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-02 18:13:34.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"9689ce70a02f66dc2b476c9fe7f6e149e0291a2b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 19:33:06.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/17/674017/4/check/grenade-py3/95039f6/ : SUCCESS in 56m 54s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/4/check/tempest-integrated-placement/fcaf438/ : SUCCESS in 1h 17m 25s\n- openstack-tox-docs https://logs.opendev.org/17/674017/4/check/openstack-tox-docs/464bbb5/html/ : SUCCESS in 5m 15s\n- openstack-tox-cover https://logs.opendev.org/17/674017/4/check/openstack-tox-cover/5d10fb3/cover/ : SUCCESS in 6m 24s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/4/check/openstack-tox-lower-constraints/f245c47/ : SUCCESS in 8m 06s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/4/check/openstack-tox-pep8/a1263a8/ : SUCCESS in 6m 43s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/4/check/openstack-tox-py27/400f545/ : SUCCESS in 5m 32s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/4/check/openstack-tox-py36/4575984/ : SUCCESS in 5m 08s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/4/check/openstack-tox-py37/5928ea0/ : SUCCESS in 7m 35s\n- openstack-tox-functional https://logs.opendev.org/17/674017/4/check/openstack-tox-functional/63da539/ : SUCCESS in 7m 56s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/4/check/openstack-tox-functional-py36/9ee78b9/ : SUCCESS in 7m 36s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/4/check/openstack-tox-functional-py37/56f6d5c/ : SUCCESS in 7m 20s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/4/check/placement-nova-tox-functional-py37/ba919f8/ : SUCCESS in 12m 52s\n- placement-nested-perfload https://logs.opendev.org/17/674017/4/check/placement-nested-perfload/f96ecbd/ : SUCCESS in 15m 38s (non-voting)\n- placement-perfload https://logs.opendev.org/17/674017/4/check/placement-perfload/ec5bf09/ : SUCCESS in 7m 36s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/17/674017/4/check/tempest-ipv6-only/a934b64/ : SUCCESS in 1h 02m 00s","accounts_in_message":[],"_revision_number":4},{"id":"85f2e1b0f5d4fad002c9e5aeb67e518738fbf5cd","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-06 07:14:51.000000000","message":"Patch Set 4: Code-Review+2\n\nYeah, good find.","accounts_in_message":[],"_revision_number":4},{"id":"285b664076c088e19b7b6f31f7a3c49ad791a123","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-06 15:37:13.000000000","message":"Patch Set 4: Code-Review+2 Workflow-1\n\n(2 comments)\n\nWe can do the comment/docstring changes in a fup, but I want to wait until that\u0027s at least proposed before merging this one. I can see it slipping through the cracks and future-me making a blunder based on an incorrect assumption as a result.","accounts_in_message":[],"_revision_number":4},{"id":"cad9aaa5c63e72a5f5145ddb8240e263a9bc3b0e","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-06 15:51:11.000000000","message":"Patch Set 4:\n\n\u003e We can do the comment/docstring changes in a fup, but I want to\n \u003e wait until that\u0027s at least proposed before merging this one. I can\n \u003e see it slipping through the cracks and future-me making a blunder\n \u003e based on an incorrect assumption as a result.\n\nMakes sense. Will probably be tomorrow at this point, unless the thing I\u0027m doing right now takes much less time than expected.","accounts_in_message":[],"_revision_number":4},{"id":"f8ad82569712d742e5a226bda5fa5a0fbd3e6969","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 10:26:46.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"e22816a06eee4802bbc3093250b7f8c6aabd37f9","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 10:27:01.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nWith the merge of Change-Id: I8120b30271ecdaf7f557a965102d03f67b6fce85 , the \"magic\" of this is even more confusing. I\u0027ve tried to address it in the doc followup  https://review.opendev.org/675082","accounts_in_message":[],"_revision_number":4},{"id":"5ad714d9f47cd9d6ac206cdf0c223d772df3351a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 12:04:43.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/17/674017/5/check/grenade-py3/561e5eb/ : SUCCESS in 1h 26m 19s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/5/check/tempest-integrated-placement/489a204/ : SUCCESS in 1h 17m 22s\n- openstack-tox-docs https://logs.opendev.org/17/674017/5/check/openstack-tox-docs/a14e635/html/ : SUCCESS in 4m 58s\n- openstack-tox-cover https://logs.opendev.org/17/674017/5/check/openstack-tox-cover/146db79/cover/ : SUCCESS in 7m 06s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/5/check/openstack-tox-lower-constraints/19f4795/ : SUCCESS in 4m 47s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/5/check/openstack-tox-pep8/be1f48e/ : SUCCESS in 4m 21s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/5/check/openstack-tox-py27/fddfc7c/ : SUCCESS in 4m 59s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/5/check/openstack-tox-py36/d273911/ : SUCCESS in 4m 43s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/5/check/openstack-tox-py37/e173fb3/ : SUCCESS in 7m 35s\n- openstack-tox-functional https://logs.opendev.org/17/674017/5/check/openstack-tox-functional/253bc9e/ : SUCCESS in 6m 22s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/5/check/openstack-tox-functional-py36/27d0d42/ : SUCCESS in 6m 09s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/5/check/openstack-tox-functional-py37/34b4168/ : SUCCESS in 6m 21s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/5/check/placement-nova-tox-functional-py37/c70d53a/ : SUCCESS in 11m 56s\n- placement-nested-perfload https://logs.opendev.org/17/674017/5/check/placement-nested-perfload/824af2d/ : SUCCESS in 17m 18s (non-voting)\n- placement-perfload https://logs.opendev.org/17/674017/5/check/placement-perfload/4229b97/ : SUCCESS in 7m 46s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/17/674017/5/check/tempest-ipv6-only/c6ae98b/ : SUCCESS in 1h 03m 18s","accounts_in_message":[],"_revision_number":5},{"id":"d4e9186e2f0a61081cc32f68b4295f802574f829","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-07 13:07:17.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"6072216c0ec6a179f89672f3d5ecfd89eaee6f55","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 13:07:30.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"3da90fc8affed2469adac954b568f3593f6b7308","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 15:15:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"2d77411d9cf4ff5861808e8d1109e6953b927c2b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 15:15:36.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/17/674017/5/gate/grenade-py3/f982f3b/ : SUCCESS in 1h 03m 14s\n- tempest-integrated-placement https://logs.opendev.org/17/674017/5/gate/tempest-integrated-placement/5def66f/ : SUCCESS in 1h 12m 42s\n- openstack-tox-docs https://logs.opendev.org/17/674017/5/gate/openstack-tox-docs/afe22e5/html/ : SUCCESS in 5m 30s\n- openstack-tox-lower-constraints https://logs.opendev.org/17/674017/5/gate/openstack-tox-lower-constraints/da85a56/ : SUCCESS in 6m 38s\n- openstack-tox-pep8 https://logs.opendev.org/17/674017/5/gate/openstack-tox-pep8/94da620/ : SUCCESS in 3m 35s\n- openstack-tox-py27 https://logs.opendev.org/17/674017/5/gate/openstack-tox-py27/a9de11e/ : SUCCESS in 4m 47s\n- openstack-tox-py36 https://logs.opendev.org/17/674017/5/gate/openstack-tox-py36/15ee8ed/ : SUCCESS in 4m 06s\n- openstack-tox-py37 https://logs.opendev.org/17/674017/5/gate/openstack-tox-py37/b0b6748/ : SUCCESS in 6m 41s\n- openstack-tox-functional https://logs.opendev.org/17/674017/5/gate/openstack-tox-functional/54156c7/ : SUCCESS in 6m 28s\n- openstack-tox-functional-py36 https://logs.opendev.org/17/674017/5/gate/openstack-tox-functional-py36/f2b2710/ : SUCCESS in 6m 03s\n- openstack-tox-functional-py37 https://logs.opendev.org/17/674017/5/gate/openstack-tox-functional-py37/70f43ad/ : SUCCESS in 6m 44s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/17/674017/5/gate/placement-nova-tox-functional-py37/cb66d05/ : SUCCESS in 11m 38s\n- tempest-ipv6-only https://logs.opendev.org/17/674017/5/gate/tempest-ipv6-only/fb41175/ : SUCCESS in 1h 05m 55s","accounts_in_message":[],"_revision_number":5},{"id":"41e1ff403fd52e1a8ef3975ce12a9fae256dcfb4","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-08 09:18:21.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"8da825efc93b4379a4cd2edcff54acfad88f76d3","revisions":{"985bffa1f318171cc635b0d6e9ea0dda762ff45b":{"kind":"REWORK","_number":1,"created":"2019-08-01 12:26:11.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/17/674017/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/17/674017/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/17/674017/1"}}},"commit":{"parents":[{"commit":"bb91e84d26f77a768ea3cfd3750451b76035aba7","subject":"Remove ProviderIds namedtuple","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/bb91e84d26f77a768ea3cfd3750451b76035aba7"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 12:17:07.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 12:17:07.000000000","tz":60},"subject":"Remove double join in provider_ids_from_rp_ids","message":"Remove double join in provider_ids_from_rp_ids\n\nprovider_ids_from_rp_ids is only used in _build_provider_summaries.\nIt is passed a collection of usages dict created\n_get_usages_by_provider_tree this has usage information for _all_\nthe providers in the contributing trees, even those providers that\ndo not provide any resources (otherwise we wouldn\u0027t be able to\nbuild a complete summary).\n\nThis means that the list of rp ids passed to provider_ids_from_rp_ids\nincludes all the relevant ips and the returnd data structure can\nitself be used to find root_provider_uuid and parent_provider_uuid,\ninstead of doing the join.\n\nThis speeds up the database query. It is not, however, hugely impactful\nbecause the use of `in` is expensive in both Python and SQL. There\u0027s\nnot a lot we can do about that without significantly restructuring the\ncode.\n\nChange-Id: If937053a8af3f0eecdd90aa807be0abc316d8c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/985bffa1f318171cc635b0d6e9ea0dda762ff45b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/985bffa1f318171cc635b0d6e9ea0dda762ff45b"}]},"branch":"refs/heads/master"},"5dece7144acb3783eb98c06be968727fa96461f7":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-08-01 15:26:32.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/17/674017/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/17/674017/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/17/674017/2"}}},"commit":{"parents":[{"commit":"ffba5fac0d157214150c7a71e487478997725bb7","subject":"Remove ProviderIds namedtuple","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/ffba5fac0d157214150c7a71e487478997725bb7"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 12:17:07.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 15:24:52.000000000","tz":60},"subject":"Remove double join in provider_ids_from_rp_ids","message":"Remove double join in provider_ids_from_rp_ids\n\nprovider_ids_from_rp_ids is only used in _build_provider_summaries.\nIt is passed a collection of usages dict created\n_get_usages_by_provider_tree this has usage information for _all_\nthe providers in the contributing trees, even those providers that\ndo not provide any resources (otherwise we wouldn\u0027t be able to\nbuild a complete summary).\n\nThis means that the list of rp ids passed to provider_ids_from_rp_ids\nincludes all the relevant ips and the returnd data structure can\nitself be used to find root_provider_uuid and parent_provider_uuid,\ninstead of doing the join.\n\nThis speeds up the database query. It is not, however, hugely impactful\nbecause the use of `in` is expensive in both Python and SQL. There\u0027s\nnot a lot we can do about that without significantly restructuring the\ncode.\n\nChange-Id: If937053a8af3f0eecdd90aa807be0abc316d8c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/5dece7144acb3783eb98c06be968727fa96461f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/5dece7144acb3783eb98c06be968727fa96461f7"}]},"branch":"refs/heads/master"},"07ebff7ab10af479ecad082a0e7841531117baad":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-08-01 21:48:09.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/17/674017/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/17/674017/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/17/674017/3"}}},"commit":{"parents":[{"commit":"8626b6517b8e975fbcbd59842b9316608886b6c7","subject":"Remove ProviderIds namedtuple","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/8626b6517b8e975fbcbd59842b9316608886b6c7"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 12:17:07.000000000","tz":60},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-01 21:48:02.000000000","tz":-300},"subject":"Remove double join in provider_ids_from_rp_ids","message":"Remove double join in provider_ids_from_rp_ids\n\nprovider_ids_from_rp_ids is only used in _build_provider_summaries.\nIt is passed a collection of usages dict created\n_get_usages_by_provider_tree this has usage information for _all_\nthe providers in the contributing trees, even those providers that\ndo not provide any resources (otherwise we wouldn\u0027t be able to\nbuild a complete summary).\n\nThis means that the list of rp ids passed to provider_ids_from_rp_ids\nincludes all the relevant ips and the returnd data structure can\nitself be used to find root_provider_uuid and parent_provider_uuid,\ninstead of doing the join.\n\nThis speeds up the database query. It is not, however, hugely impactful\nbecause the use of `in` is expensive in both Python and SQL. There\u0027s\nnot a lot we can do about that without significantly restructuring the\ncode.\n\nChange-Id: If937053a8af3f0eecdd90aa807be0abc316d8c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07ebff7ab10af479ecad082a0e7841531117baad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/07ebff7ab10af479ecad082a0e7841531117baad"}]},"branch":"refs/heads/master"},"34b2d381273c76076f4b1a2d3cd405da92aff33c":{"kind":"REWORK","_number":4,"created":"2019-08-02 14:30:36.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/17/674017/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/17/674017/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/17/674017/4"}}},"commit":{"parents":[{"commit":"d4d9457aa10c3309cae00b40598b3cec8b1c793a","subject":"Use expanding bindparam in provider_ids_from_rp_ids in_","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d4d9457aa10c3309cae00b40598b3cec8b1c793a"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 12:17:07.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-02 14:27:29.000000000","tz":60},"subject":"Remove double join in provider_ids_from_rp_ids","message":"Remove double join in provider_ids_from_rp_ids\n\nprovider_ids_from_rp_ids is only used in _build_provider_summaries.\nIt is passed a collection of usages dict created\n_get_usages_by_provider_tree this has usage information for _all_\nthe providers in the contributing trees, even those providers that\ndo not provide any resources (otherwise we wouldn\u0027t be able to\nbuild a complete summary).\n\nThis means that the list of rp ids passed to provider_ids_from_rp_ids\nincludes all the relevant rps and the returned data structure can\nitself be used to find root_provider_uuid and parent_provider_uuid,\ninstead of doing the join.\n\nThis speeds up the database query. Combined with the expanding\nbindparam in the previous patch, this cleans up provider_ids_from_rp_ids\nnicely.\n\nChange-Id: If937053a8af3f0eecdd90aa807be0abc316d8c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/34b2d381273c76076f4b1a2d3cd405da92aff33c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/34b2d381273c76076f4b1a2d3cd405da92aff33c"}]},"branch":"refs/heads/master"},"8da825efc93b4379a4cd2edcff54acfad88f76d3":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2019-08-07 10:26:46.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/17/674017/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/17/674017/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/17/674017/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/17/674017/5"}}},"commit":{"parents":[{"commit":"0386f5340787091970ebb0c4b96535635a7f405b","subject":"Further optimize _build_provider_summaries","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0386f5340787091970ebb0c4b96535635a7f405b"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-01 12:17:07.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 10:17:16.000000000","tz":60},"subject":"Remove double join in provider_ids_from_rp_ids","message":"Remove double join in provider_ids_from_rp_ids\n\nprovider_ids_from_rp_ids is only used in _build_provider_summaries.\nIt is passed a collection of usages dict created\n_get_usages_by_provider_tree this has usage information for _all_\nthe providers in the contributing trees, even those providers that\ndo not provide any resources (otherwise we wouldn\u0027t be able to\nbuild a complete summary).\n\nThis means that the list of rp ids passed to provider_ids_from_rp_ids\nincludes all the relevant rps and the returned data structure can\nitself be used to find root_provider_uuid and parent_provider_uuid,\ninstead of doing the join.\n\nThis speeds up the database query. Combined with the expanding\nbindparam in the previous patch, this cleans up provider_ids_from_rp_ids\nnicely.\n\nChange-Id: If937053a8af3f0eecdd90aa807be0abc316d8c4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/8da825efc93b4379a4cd2edcff54acfad88f76d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/8da825efc93b4379a4cd2edcff54acfad88f76d3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
