)]}'
{"id":"openstack%2Fplacement~675074","triplet_id":"openstack%2Fplacement~master~I79dac6c83d9c118bd6a66cdc3cd300c3c12af538","project":"openstack/placement","branch":"master","topic":"optimize-_build_provider_summaries","hashtags":[],"change_id":"I79dac6c83d9c118bd6a66cdc3cd300c3c12af538","subject":"Clean up the extend_usages_by_provider_tree method","status":"MERGED","created":"2019-08-07 09:55:29.000000000","updated":"2019-08-07 21:46:55.000000000","submitted":"2019-08-07 21:46:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"675074-1565214415783-d130734a","meta_rev_id":"df4e8ac70c920bd35476223d80adb97114546f0c","_number":675074,"virtual_id_number":675074,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"date":"2019-08-07 09:57:48.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2019-08-07 21:46:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":2,"date":"2019-08-07 19:33:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-08-07 14:25:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":1,"date":"2019-08-07 19:33:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-07 14:25:28.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-08-07 19:33:46.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-08-07 21:46:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7fffcbad0566f074e03fc126275d76c3c5800e24","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 09:55:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a2d86f94d168e29b95d20a92b325fc4391350f6f","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 09:57:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"11aa7c2cd81c118c1291ecf943e37c9ecb395b0c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 11:32:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/74/675074/1/check/grenade-py3/4deb3a0/ : SUCCESS in 57m 19s\n- tempest-integrated-placement https://logs.opendev.org/74/675074/1/check/tempest-integrated-placement/a638899/ : SUCCESS in 1h 24m 17s\n- openstack-tox-docs https://logs.opendev.org/74/675074/1/check/openstack-tox-docs/47d1c10/html/ : SUCCESS in 4m 23s\n- openstack-tox-cover https://logs.opendev.org/74/675074/1/check/openstack-tox-cover/2e724e5/cover/ : SUCCESS in 5m 16s\n- openstack-tox-lower-constraints https://logs.opendev.org/74/675074/1/check/openstack-tox-lower-constraints/c2c1263/ : SUCCESS in 5m 46s\n- openstack-tox-pep8 https://logs.opendev.org/74/675074/1/check/openstack-tox-pep8/dc092b8/ : SUCCESS in 6m 00s\n- openstack-tox-py27 https://logs.opendev.org/74/675074/1/check/openstack-tox-py27/d6cbcc3/ : SUCCESS in 5m 47s\n- openstack-tox-py36 https://logs.opendev.org/74/675074/1/check/openstack-tox-py36/094f5c2/ : SUCCESS in 6m 22s\n- openstack-tox-py37 https://logs.opendev.org/74/675074/1/check/openstack-tox-py37/46afb05/ : SUCCESS in 4m 50s\n- openstack-tox-functional https://logs.opendev.org/74/675074/1/check/openstack-tox-functional/1ac91e8/ : SUCCESS in 5m 31s\n- openstack-tox-functional-py36 https://logs.opendev.org/74/675074/1/check/openstack-tox-functional-py36/485a462/ : SUCCESS in 5m 16s\n- openstack-tox-functional-py37 https://logs.opendev.org/74/675074/1/check/openstack-tox-functional-py37/2d7e37d/ : SUCCESS in 5m 21s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/74/675074/1/check/placement-nova-tox-functional-py37/148da67/ : SUCCESS in 12m 28s\n- placement-nested-perfload https://logs.opendev.org/74/675074/1/check/placement-nested-perfload/59e0c99/ : SUCCESS in 16m 49s (non-voting)\n- placement-perfload https://logs.opendev.org/74/675074/1/check/placement-perfload/bb7a485/ : SUCCESS in 9m 43s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/74/675074/1/check/tempest-ipv6-only/89db493/ : SUCCESS in 1h 00m 02s","accounts_in_message":[],"_revision_number":1},{"id":"ad7b25cb791a3225761b9fdd6e819daa37b9f348","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-07 14:25:28.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"86e5fe48dfaf170e6f2501f73786e86a34b9ead3","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-07 19:33:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nclean refactor plus doc fixup ++","accounts_in_message":[],"_revision_number":1},{"id":"8f70837c78b9802083099cc66ff35972a1b358c4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 19:34:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5cbe54d0c47309a49b545877cc4b7bfe7234fcdf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 21:46:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ce680e695f5f8162b6fe02cf8125365d779a11ae","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 21:46:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/74/675074/1/gate/grenade-py3/2ef9220/ : SUCCESS in 1h 16m 54s\n- tempest-integrated-placement https://logs.opendev.org/74/675074/1/gate/tempest-integrated-placement/05fa346/ : SUCCESS in 1h 26m 02s\n- openstack-tox-docs https://logs.opendev.org/74/675074/1/gate/openstack-tox-docs/e5296b0/html/ : SUCCESS in 5m 25s\n- openstack-tox-lower-constraints https://logs.opendev.org/74/675074/1/gate/openstack-tox-lower-constraints/cf46dea/ : SUCCESS in 6m 11s\n- openstack-tox-pep8 https://logs.opendev.org/74/675074/1/gate/openstack-tox-pep8/cb0f677/ : SUCCESS in 5m 24s\n- openstack-tox-py27 https://logs.opendev.org/74/675074/1/gate/openstack-tox-py27/cc7d03a/ : SUCCESS in 8m 33s\n- openstack-tox-py36 https://logs.opendev.org/74/675074/1/gate/openstack-tox-py36/531ab23/ : SUCCESS in 5m 37s\n- openstack-tox-py37 https://logs.opendev.org/74/675074/1/gate/openstack-tox-py37/642bea4/ : SUCCESS in 5m 21s\n- openstack-tox-functional https://logs.opendev.org/74/675074/1/gate/openstack-tox-functional/b88f834/ : SUCCESS in 10m 22s\n- openstack-tox-functional-py36 https://logs.opendev.org/74/675074/1/gate/openstack-tox-functional-py36/4b46cf7/ : SUCCESS in 5m 52s\n- openstack-tox-functional-py37 https://logs.opendev.org/74/675074/1/gate/openstack-tox-functional-py37/b3a80e9/ : SUCCESS in 8m 38s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/74/675074/1/gate/placement-nova-tox-functional-py37/670b3e9/ : SUCCESS in 11m 37s\n- tempest-ipv6-only https://logs.opendev.org/74/675074/1/gate/tempest-ipv6-only/e05d200/ : SUCCESS in 1h 06m 09s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9820b1bd20469946cd9278478796a09fc0928d40","revisions":{"9820b1bd20469946cd9278478796a09fc0928d40":{"kind":"REWORK","_number":1,"created":"2019-08-07 09:55:29.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/74/675074/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/74/675074/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/74/675074/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/74/675074/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/74/675074/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/74/675074/1"}}},"commit":{"parents":[{"commit":"5883c794f969b8fda14078137704b4dd34919ab0","subject":"Use expanding bindparam in extend_usages_by_provider_tree","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/5883c794f969b8fda14078137704b4dd34919ab0"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 09:50:15.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 09:50:15.000000000","tz":60},"subject":"Clean up the extend_usages_by_provider_tree method","message":"Clean up the extend_usages_by_provider_tree method\n\nIn review of the change [1] that created\nextend_usages_by_provider_tree some issues with the docs and the\nlayout of the code were identified. This change attempts to address\nthem:\n\n* Doc comment on self.usages updated to show more of the content.\n\n* The SQL-half of the extend_usages_by_provider_tree method is\n  extracted to its own function.\n\n[1] I5d05d15d33beb1622a06bde0e32c3f52ba01b448\n\nChange-Id: I79dac6c83d9c118bd6a66cdc3cd300c3c12af538\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9820b1bd20469946cd9278478796a09fc0928d40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9820b1bd20469946cd9278478796a09fc0928d40"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}