)]}'
{"id":"openstack%2Fplacement~675082","triplet_id":"openstack%2Fplacement~master~I4958ba0b208ca457e049875433dc0826eaab8795","project":"openstack/placement","branch":"master","topic":"cd/de-tuple","hashtags":[],"change_id":"I4958ba0b208ca457e049875433dc0826eaab8795","subject":"Improve docs and comments for provider_ids_from_rp_ids","status":"MERGED","created":"2019-08-07 10:26:46.000000000","updated":"2019-08-07 22:10:05.000000000","submitted":"2019-08-07 22:10:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"675082-1565215805039-25fc65c6","meta_rev_id":"f01468c0c793cca83cbf25ca01c732c1401ebce3","_number":675082,"virtual_id_number":675082,"owner":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2019-08-07 22:10:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":2,"date":"2019-08-07 19:35:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":2,"date":"2019-08-07 13:12:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":1,"date":"2019-08-07 19:35:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-07 13:12:59.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-08-07 19:35:48.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-08-07 22:10:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1948ed755e7f302370d0d52cc8afd9babb0dc012","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 10:26:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b7256f672ea18be1cde9aa317ed32ae135fe8ffa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 12:03:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/82/675082/1/check/grenade-py3/743e79a/ : SUCCESS in 1h 03m 13s\n- tempest-integrated-placement https://logs.opendev.org/82/675082/1/check/tempest-integrated-placement/803dd12/ : SUCCESS in 1h 25m 41s\n- openstack-tox-docs https://logs.opendev.org/82/675082/1/check/openstack-tox-docs/1c4f0fc/html/ : SUCCESS in 4m 21s\n- openstack-tox-cover https://logs.opendev.org/82/675082/1/check/openstack-tox-cover/71943d4/cover/ : SUCCESS in 8m 49s\n- openstack-tox-lower-constraints https://logs.opendev.org/82/675082/1/check/openstack-tox-lower-constraints/5ab1936/ : SUCCESS in 4m 57s\n- openstack-tox-pep8 https://logs.opendev.org/82/675082/1/check/openstack-tox-pep8/1585b8f/ : SUCCESS in 5m 09s\n- openstack-tox-py27 https://logs.opendev.org/82/675082/1/check/openstack-tox-py27/add498e/ : SUCCESS in 5m 41s\n- openstack-tox-py36 https://logs.opendev.org/82/675082/1/check/openstack-tox-py36/e475ab4/ : SUCCESS in 6m 25s\n- openstack-tox-py37 https://logs.opendev.org/82/675082/1/check/openstack-tox-py37/458a59a/ : SUCCESS in 5m 24s\n- openstack-tox-functional https://logs.opendev.org/82/675082/1/check/openstack-tox-functional/fec9989/ : SUCCESS in 6m 29s\n- openstack-tox-functional-py36 https://logs.opendev.org/82/675082/1/check/openstack-tox-functional-py36/8e505a5/ : SUCCESS in 4m 32s\n- openstack-tox-functional-py37 https://logs.opendev.org/82/675082/1/check/openstack-tox-functional-py37/b96c3bf/ : SUCCESS in 5m 52s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/82/675082/1/check/placement-nova-tox-functional-py37/2666daf/ : SUCCESS in 16m 23s\n- placement-nested-perfload https://logs.opendev.org/82/675082/1/check/placement-nested-perfload/e531a0f/ : SUCCESS in 15m 32s (non-voting)\n- placement-perfload https://logs.opendev.org/82/675082/1/check/placement-perfload/9285acb/ : SUCCESS in 7m 17s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/82/675082/1/check/tempest-ipv6-only/7e59096/ : SUCCESS in 1h 06m 13s","accounts_in_message":[],"_revision_number":1},{"id":"95d6d3ab4597985d31a226be6d9dbe48a844a8ce","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-07 12:59:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d67c1651e6b298048c72457c59a409055976b9c8","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 13:03:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5684e5ba61d4616a0353754703fd77441582a2cb","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-07 13:07:28.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"fdf19cd8e668bce5ce679624a7f94639fd897998","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-07 13:10:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0e8e8ba2db5a76a75b79cf596f20f1a2deca6651","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-07 13:12:59.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Chris!","accounts_in_message":[],"_revision_number":2},{"id":"a25289284699192cb6cb6546631015003ccda47f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 15:38:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://logs.opendev.org/82/675082/2/check/grenade-py3/1f85af3/ : SUCCESS in 1h 03m 03s\n- tempest-integrated-placement https://logs.opendev.org/82/675082/2/check/tempest-integrated-placement/4127d59/ : SUCCESS in 1h 18m 38s\n- openstack-tox-docs https://logs.opendev.org/82/675082/2/check/openstack-tox-docs/8e7ff57/html/ : SUCCESS in 5m 35s\n- openstack-tox-cover https://logs.opendev.org/82/675082/2/check/openstack-tox-cover/2f9d855/cover/ : SUCCESS in 6m 25s\n- openstack-tox-lower-constraints https://logs.opendev.org/82/675082/2/check/openstack-tox-lower-constraints/32d0543/ : SUCCESS in 8m 00s\n- openstack-tox-pep8 https://logs.opendev.org/82/675082/2/check/openstack-tox-pep8/6c19eac/ : SUCCESS in 6m 28s\n- openstack-tox-py27 https://logs.opendev.org/82/675082/2/check/openstack-tox-py27/38d6213/ : SUCCESS in 7m 21s\n- openstack-tox-py36 https://logs.opendev.org/82/675082/2/check/openstack-tox-py36/b5fbfe3/ : SUCCESS in 7m 39s\n- openstack-tox-py37 https://logs.opendev.org/82/675082/2/check/openstack-tox-py37/6e5cd7b/ : SUCCESS in 9m 56s\n- openstack-tox-functional https://logs.opendev.org/82/675082/2/check/openstack-tox-functional/3f9d5fd/ : SUCCESS in 7m 11s\n- openstack-tox-functional-py36 https://logs.opendev.org/82/675082/2/check/openstack-tox-functional-py36/98c4541/ : SUCCESS in 5m 29s\n- openstack-tox-functional-py37 https://logs.opendev.org/82/675082/2/check/openstack-tox-functional-py37/3765dbb/ : SUCCESS in 10m 59s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/82/675082/2/check/placement-nova-tox-functional-py37/73eaea0/ : SUCCESS in 14m 10s\n- placement-nested-perfload https://logs.opendev.org/82/675082/2/check/placement-nested-perfload/aeaaa08/ : SUCCESS in 15m 29s (non-voting)\n- placement-perfload https://logs.opendev.org/82/675082/2/check/placement-perfload/822ed8b/ : SUCCESS in 9m 11s (non-voting)\n- tempest-ipv6-only https://logs.opendev.org/82/675082/2/check/tempest-ipv6-only/ef9c981/ : SUCCESS in 1h 01m 28s","accounts_in_message":[],"_revision_number":2},{"id":"3fb9c3cf638e76937cde327056e14e9897aeb88d","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-07 19:35:48.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n++ thanks Chris","accounts_in_message":[],"_revision_number":2},{"id":"14f0b489b0512ec4721892c0253be9b9270fffa2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 19:36:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9938a6b4f7cd5d720f4673066d1da1fea136175e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 22:10:04.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://logs.opendev.org/82/675082/2/gate/grenade-py3/81461cf/ : SUCCESS in 58m 34s\n- tempest-integrated-placement https://logs.opendev.org/82/675082/2/gate/tempest-integrated-placement/305b845/ : SUCCESS in 1h 49m 08s\n- openstack-tox-docs https://logs.opendev.org/82/675082/2/gate/openstack-tox-docs/6af38d1/html/ : SUCCESS in 6m 20s\n- openstack-tox-lower-constraints https://logs.opendev.org/82/675082/2/gate/openstack-tox-lower-constraints/d905258/ : SUCCESS in 7m 28s\n- openstack-tox-pep8 https://logs.opendev.org/82/675082/2/gate/openstack-tox-pep8/19dc4e4/ : SUCCESS in 5m 47s\n- openstack-tox-py27 https://logs.opendev.org/82/675082/2/gate/openstack-tox-py27/8782222/ : SUCCESS in 5m 16s\n- openstack-tox-py36 https://logs.opendev.org/82/675082/2/gate/openstack-tox-py36/ce1a45f/ : SUCCESS in 5m 04s\n- openstack-tox-py37 https://logs.opendev.org/82/675082/2/gate/openstack-tox-py37/2cedb77/ : SUCCESS in 7m 20s\n- openstack-tox-functional https://logs.opendev.org/82/675082/2/gate/openstack-tox-functional/435eea3/ : SUCCESS in 6m 48s\n- openstack-tox-functional-py36 https://logs.opendev.org/82/675082/2/gate/openstack-tox-functional-py36/3d67a38/ : SUCCESS in 6m 12s\n- openstack-tox-functional-py37 https://logs.opendev.org/82/675082/2/gate/openstack-tox-functional-py37/6fb639a/ : SUCCESS in 7m 40s\n- placement-nova-tox-functional-py37 https://logs.opendev.org/82/675082/2/gate/placement-nova-tox-functional-py37/b472e34/ : SUCCESS in 13m 19s\n- tempest-ipv6-only https://logs.opendev.org/82/675082/2/gate/tempest-ipv6-only/56c36ee/ : SUCCESS in 1h 06m 28s","accounts_in_message":[],"_revision_number":2},{"id":"c381497f70ac39fb83f8f8fedde510c32fd2e46b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-07 22:10:05.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d65fb81039ae9953883396d6c51611206f89f622","revisions":{"549da6a0d7db5ec53a2f14897fa5cb35a73e74f6":{"kind":"REWORK","_number":1,"created":"2019-08-07 10:26:46.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/82/675082/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/82/675082/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/675082/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/675082/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/675082/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/82/675082/1"}}},"commit":{"parents":[{"commit":"8da825efc93b4379a4cd2edcff54acfad88f76d3","subject":"Remove double join in provider_ids_from_rp_ids","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/8da825efc93b4379a4cd2edcff54acfad88f76d3"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 10:15:21.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 10:24:21.000000000","tz":60},"subject":"Improve docs and comments for provider_ids_from_rp_ids","message":"Improve docs and comments for provider_ids_from_rp_ids\n\nWhen the double join was removed from provider_ids_from_rp_ids [1]\nit became clear that additional docs and commentary were required\nto avoid future confusion over why the new way of using it will\nwork. This adds it.\n\n[1] If937053a8af3f0eecdd90aa807be0abc316d8c4f\n\nChange-Id: I4958ba0b208ca457e049875433dc0826eaab8795\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/549da6a0d7db5ec53a2f14897fa5cb35a73e74f6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/549da6a0d7db5ec53a2f14897fa5cb35a73e74f6"}]},"branch":"refs/heads/master"},"d65fb81039ae9953883396d6c51611206f89f622":{"kind":"REWORK","_number":2,"created":"2019-08-07 13:10:31.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/82/675082/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/82/675082/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/675082/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/675082/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/82/675082/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/82/675082/2"}}},"commit":{"parents":[{"commit":"8da825efc93b4379a4cd2edcff54acfad88f76d3","subject":"Remove double join in provider_ids_from_rp_ids","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/8da825efc93b4379a4cd2edcff54acfad88f76d3"}]}],"author":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 10:15:21.000000000","tz":60},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-07 13:09:10.000000000","tz":60},"subject":"Improve docs and comments for provider_ids_from_rp_ids","message":"Improve docs and comments for provider_ids_from_rp_ids\n\nWhen the double join was removed from provider_ids_from_rp_ids [1]\nit became clear that additional docs and commentary were required\nto avoid future confusion over why the new way of using it will\nwork. This adds it.\n\n[1] If937053a8af3f0eecdd90aa807be0abc316d8c4f\n\nChange-Id: I4958ba0b208ca457e049875433dc0826eaab8795\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d65fb81039ae9953883396d6c51611206f89f622"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d65fb81039ae9953883396d6c51611206f89f622"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}