)]}'
{"placement/objects/research_context.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"127356122a54ba74e30d25caba4b5f8012b3fb12","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    def copy_arr_if_needed(self, arr):"},{"line_number":339,"context_line":"        \"\"\"Copy or return arr, depending on the search context."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        In cases with group_policy\u003disolate where multiple groups request"},{"line_number":342,"context_line":"        amounts from the same resource class, we end up using the same"},{"line_number":343,"context_line":"        AllocationRequestResource more than once when consolidating. So we"},{"line_number":344,"context_line":"        need to make a copy so we don\u0027t overwrite the one used for a"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1e38733b","line":341,"range":{"start_line":341,"start_character":35,"end_line":341,"end_character":42},"updated":"2019-08-09 10:52:25.000000000","message":"none?","commit_id":"7029006ea0b9ca5836562b9832c2e57594cfb0bd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"624bac58c22460dc43e78a4937c333c980046f11","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    def copy_arr_if_needed(self, arr):"},{"line_number":339,"context_line":"        \"\"\"Copy or return arr, depending on the search context."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        In cases with group_policy\u003disolate where multiple groups request"},{"line_number":342,"context_line":"        amounts from the same resource class, we end up using the same"},{"line_number":343,"context_line":"        AllocationRequestResource more than once when consolidating. So we"},{"line_number":344,"context_line":"        need to make a copy so we don\u0027t overwrite the one used for a"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c7f44a8a","line":341,"range":{"start_line":341,"start_character":35,"end_line":341,"end_character":42},"in_reply_to":"7faddb67_1e38733b","updated":"2019-08-09 13:33:05.000000000","message":"none!","commit_id":"7029006ea0b9ca5836562b9832c2e57594cfb0bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8221568d9bdfbe947d9ae909d01fc79e7092bc65","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    def copy_arr_if_needed(self, arr):"},{"line_number":339,"context_line":"        \"\"\"Copy or return arr, depending on the search context."},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        In cases with group_policy\u003disolate where multiple groups request"},{"line_number":342,"context_line":"        amounts from the same resource class, we end up using the same"},{"line_number":343,"context_line":"        AllocationRequestResource more than once when consolidating. So we"},{"line_number":344,"context_line":"        need to make a copy so we don\u0027t overwrite the one used for a"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e73866ef","line":341,"range":{"start_line":341,"start_character":35,"end_line":341,"end_character":42},"in_reply_to":"7faddb67_c7f44a8a","updated":"2019-08-09 13:39:50.000000000","message":"done?\n\ndone!","commit_id":"7029006ea0b9ca5836562b9832c2e57594cfb0bd"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"127356122a54ba74e30d25caba4b5f8012b3fb12","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                returned."},{"line_number":350,"context_line":"        :return: arr or a copy thereof."},{"line_number":351,"context_line":"        \"\"\""},{"line_number":352,"context_line":"        if self.group_policy \u003d\u003d \u0027isolate\u0027:"},{"line_number":353,"context_line":"            return arr"},{"line_number":354,"context_line":"        if arr.resource_class in self.multi_group_rcs:"},{"line_number":355,"context_line":"            return copy.copy(arr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_be6a7f18","line":352,"updated":"2019-08-09 10:52:25.000000000","message":"A a confirmatory step, I changed this to !\u003d and a few tests failed in expected ways (similar to the failures I got when I removed the original copy a few patches back).\n\nNot that we plan to add to group_policy, but this might be more futureproof and bit more communicating of its intent if it was\n\n   !\u003d \u0027none\u0027:\n\nbut that\u0027s just a nit","commit_id":"7029006ea0b9ca5836562b9832c2e57594cfb0bd"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8221568d9bdfbe947d9ae909d01fc79e7092bc65","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                returned."},{"line_number":350,"context_line":"        :return: arr or a copy thereof."},{"line_number":351,"context_line":"        \"\"\""},{"line_number":352,"context_line":"        if self.group_policy \u003d\u003d \u0027isolate\u0027:"},{"line_number":353,"context_line":"            return arr"},{"line_number":354,"context_line":"        if arr.resource_class in self.multi_group_rcs:"},{"line_number":355,"context_line":"            return copy.copy(arr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a7226eb9","line":352,"in_reply_to":"7faddb67_be6a7f18","updated":"2019-08-09 13:39:50.000000000","message":"Good call","commit_id":"7029006ea0b9ca5836562b9832c2e57594cfb0bd"}]}