)]}'
{"id":"openstack%2Fplacement~676471","triplet_id":"openstack%2Fplacement~master~I077eef58a3e89fb402a6cdcb10e4f5688aed3f07","project":"openstack/placement","branch":"master","topic":"_check_same_subtree-sparse-parent-dict","hashtags":[],"change_id":"I077eef58a3e89fb402a6cdcb10e4f5688aed3f07","subject":"DNM: sparse parent dict breaks _check_same_subtree","status":"ABANDONED","created":"2019-08-14 17:35:41.000000000","updated":"2019-09-11 12:00:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2b07f1357ede07be349ebf22e9a75e9a5b59df1c","_number":676471,"virtual_id_number":676471,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-08-14 18:57:51.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 18:57:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ecc7fad038fef5ad431e6b09a05031981a6aa814","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-14 17:35:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d899051c2a54ec3bda478436b4b8e34ffaf4894","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 18:57:51.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/285391a13e70418fb2f00e6dfcda3b17 : SUCCESS in 1h 07m 41s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/7a1ab1f2aecb410589305b5d22c24768 : SUCCESS in 1h 20m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/84a88a997de8494fb95e0e69b46ea007 : SUCCESS in 8m 29s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/905a7445ee9042e1a90ec898dc4cbc3a : FAILURE in 7m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/16d89a76c33244aeb88d4af3b8554421 : FAILURE in 5m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4bd45ad6439f45f087e97656c2524c92 : SUCCESS in 5m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a0bd427634e0444381f420f0b911fc7e : FAILURE in 4m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6d9e3f01500a435db1420fa930d9085d : FAILURE in 6m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/507628183b534be5a768bd459e22ce1d : FAILURE in 4m 36s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/1b89e82a57fb4b5393735f3360ba0bb2 : SUCCESS in 4m 54s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b0ca13a25dda4f17b1f9b0485c8ccab5 : SUCCESS in 5m 10s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/e9bc6144a8744f838e1f5e2b0732a306 : SUCCESS in 4m 41s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/3b3215f854914cef9d0dd7ec010cce9f : SUCCESS in 12m 18s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/02a4d673078147dfa3887dc0d8b45d0b : SUCCESS in 27m 14s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/621b6facff2e44f8a9652cdff07b12f9 : SUCCESS in 11m 33s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b0d1dfd3d6c24d65b488aa4821d21964 : SUCCESS in 1h 20m 04s","accounts_in_message":[],"_revision_number":1},{"id":"644656079b9a098e92985438c91355d8352badc4","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-11 12:00:15.000000000","message":"Abandoned\n\nNo longer needed","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7c2d2b455495cc6d60feae9e292ce94e9373e5b5","revisions":{"7c2d2b455495cc6d60feae9e292ce94e9373e5b5":{"kind":"REWORK","_number":1,"created":"2019-08-14 17:35:41.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/71/676471/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/71/676471/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/71/676471/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/71/676471/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/71/676471/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/71/676471/1"}}},"commit":{"parents":[{"commit":"180167161623fe1264a260fb681c87de6d79c4a2","subject":"Merge \"Use expanding bindparam in get_traits_by_provider_tree\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/180167161623fe1264a260fb681c87de6d79c4a2"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 17:16:12.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 17:35:39.000000000","tz":-300},"subject":"DNM: sparse parent dict breaks _check_same_subtree","message":"DNM: sparse parent dict breaks _check_same_subtree\n\nFollowing the discussion at [1], this patch exercises\n_check_same_subtree with a parent_uuid_by_rp_uuid dict that only\nincludes providers involved in the request. In order to make this work,\nthe delta at [1] is put into place: this makes the recursion to discover\na provider\u0027s ancestry line stop as soon as it hits a provider not\ninvolved in the request.\n\nThis causes one scenario [2] to fail: where there\u0027s a \"hole\" in the\nancestry chain for one of the providers, ancestors on the other side of\nthat hole are not counted in the ancestry line, so same_subtree can\nreturn False when it should have been True.\n\n[1] https://review.opendev.org/#/c/675606/2/placement/objects/allocation_candidate.py@908\n[2] I checked by commenting out that scenario - the rest pass\n\nChange-Id: I077eef58a3e89fb402a6cdcb10e4f5688aed3f07\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/7c2d2b455495cc6d60feae9e292ce94e9373e5b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/7c2d2b455495cc6d60feae9e292ce94e9373e5b5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}