)]}'
{"id":"openstack%2Fplacement~676477","triplet_id":"openstack%2Fplacement~master~Ib498fe29ecb7cefd49cf153de328061c09ef9061","project":"openstack/placement","branch":"master","topic":"_check_same_subtree-sparse-parent-dict","hashtags":[],"change_id":"Ib498fe29ecb7cefd49cf153de328061c09ef9061","subject":"DNM: sparse parent dict breaks same_subtree (part deux)","status":"ABANDONED","created":"2019-08-14 18:01:56.000000000","updated":"2019-09-11 12:00:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"26733ea48279f3f15c54d14b80f03cfd16c696db","_number":676477,"virtual_id_number":676477,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-08-14 20:28:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 20:28:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aa1e4ac57c067e1b4bb5d6084b54578d3d809505","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-14 18:01:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd70ebf113a1189d08af2240800ebec4f643f719","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-14 18:54:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bf5e3c234d4997b077055dffb199f70f06fabcd7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 20:28:13.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/5397a5388701464da7c4df0431777015 : SUCCESS in 1h 12m 50s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/0acf6ef859f74dbd8babc3d58dcd8bab : SUCCESS in 1h 20m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8da0098219f4f828ba4ca9a10450354 : SUCCESS in 3m 47s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4bdcad9bab744a65a0467bc81d6dc26d : FAILURE in 6m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/254369cc93dd46498ded011fbf01cbd3 : FAILURE in 5m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a30580a970544e3aad1ac613e50cd1af : SUCCESS in 4m 05s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d3a7cc2bea3146e68659c5828cd991de : FAILURE in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dbd3d63e7cc44ac4b0e9d07829864ea4 : FAILURE in 5m 43s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1ece7f6d9940422db14b0350a685c6e6 : FAILURE in 4m 30s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/1bcf771175fe496b8735eb9a9ffbafc3 : FAILURE in 4m 20s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/86742445ef3c4dab8d2b09d631be0f7a : FAILURE in 6m 16s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/a6c4991f8f8742f09adff18d0734e9a7 : FAILURE in 5m 10s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/4a01268559394bd794685655f4c59678 : SUCCESS in 10m 49s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/c9524f55391344ba8c646b8c34e30b3b : SUCCESS in 10m 33s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/0d2c08e373734b82a435f8d79ff1ba00 : SUCCESS in 9m 14s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b956a03b73ac45f3bfaac848cb89b290 : SUCCESS in 1h 05m 38s","accounts_in_message":[],"_revision_number":2},{"id":"4f23299e4866c45223fd4af8785fc64ceabcf970","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-11 12:00:00.000000000","message":"Abandoned\n\nNo longer needed","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1205bb9b8b853804dcdfdeb5e7151974ea350c49","revisions":{"0c45e35615b195cf94ab0d11a72b9b9d130dcd16":{"kind":"REWORK","_number":1,"created":"2019-08-14 18:01:56.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/77/676477/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/77/676477/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/676477/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/676477/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/676477/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/77/676477/1"}}},"commit":{"parents":[{"commit":"180167161623fe1264a260fb681c87de6d79c4a2","subject":"Merge \"Use expanding bindparam in get_traits_by_provider_tree\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/180167161623fe1264a260fb681c87de6d79c4a2"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 17:59:55.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 17:59:55.000000000","tz":-300},"subject":"DNM: sparse parent dict breaks _same_subtree (part deux)","message":"DNM: sparse parent dict breaks _same_subtree (part deux)\n\nFollowing the discussion at [1], this patch exercises same_subtree with\na parent_uuid_by_rp_uuid dict that only includes providers involved in\nthe request. In order to make this work, the delta at [1] is put into\nplace: this makes the recursion to discover a provider\u0027s ancestry line\nstop as soon as it hits a provider not involved in the request.\n\nA gabbi test is written to demonstrate the problem: when there\u0027s a\n\"hole\" in the ancestry chain for one of the providers, ancestors on the\nother side of that hole are not counted in the ancestry line, so\nsame_subtree can return False when it should have been True.\n\n[1] https://review.opendev.org/#/c/675606/2/placement/objects/allocation_candidate.py@908\n\nChange-Id: Ib498fe29ecb7cefd49cf153de328061c09ef9061\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0c45e35615b195cf94ab0d11a72b9b9d130dcd16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0c45e35615b195cf94ab0d11a72b9b9d130dcd16"}]},"branch":"refs/heads/master"},"1205bb9b8b853804dcdfdeb5e7151974ea350c49":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2019-08-14 18:54:00.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/77/676477/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/77/676477/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/676477/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/676477/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/77/676477/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/77/676477/2"}}},"commit":{"parents":[{"commit":"9d63593cc4da625c0dfb4aadfa40716c0ea47bf3","subject":"gabbi test for same_subtree with an ancestry hole","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9d63593cc4da625c0dfb4aadfa40716c0ea47bf3"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 17:59:55.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 18:52:13.000000000","tz":-300},"subject":"DNM: sparse parent dict breaks same_subtree (part deux)","message":"DNM: sparse parent dict breaks same_subtree (part deux)\n\nFollowing the discussion at [1], this patch exercises same_subtree with\na parent_uuid_by_rp_uuid dict that only includes providers involved in\nthe request. In order to make this work, the delta at [1] is put into\nplace: this makes the recursion to discover a provider\u0027s ancestry line\nstop as soon as it hits a provider not involved in the request.\n\nThis breaks a gabbi test written previously [2] to demonstrate the\nproblem: when there\u0027s a \"hole\" in the ancestry chain for one of the\nproviders, ancestors on the other side of that hole are not counted in\nthe ancestry line, so same_subtree can return False when it should have\nbeen True.\n\n[1] https://review.opendev.org/#/c/675606/2/placement/objects/allocation_candidate.py@908\n[2] I5062e725d6f29cd997b974a0dad7dc4d0ed2900f\n\nChange-Id: Ib498fe29ecb7cefd49cf153de328061c09ef9061\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/1205bb9b8b853804dcdfdeb5e7151974ea350c49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/1205bb9b8b853804dcdfdeb5e7151974ea350c49"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}