)]}'
{"id":"openstack%2Fplacement~676491","triplet_id":"openstack%2Fplacement~master~I5062e725d6f29cd997b974a0dad7dc4d0ed2900f","project":"openstack/placement","branch":"master","topic":"optimize-_build_provider_summaries","hashtags":[],"change_id":"I5062e725d6f29cd997b974a0dad7dc4d0ed2900f","subject":"gabbi test for same_subtree with an ancestry hole","status":"MERGED","created":"2019-08-14 18:54:00.000000000","updated":"2019-08-16 12:19:26.000000000","submitted":"2019-08-16 12:19:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676491-1565957966545-d21f4b70","meta_rev_id":"bf972d952e20f20b9c3e2871c272ffaac53bda65","_number":676491,"virtual_id_number":676491,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-16 12:19:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"date":"2019-08-16 11:45:10.000000000","_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-16 11:47:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2019-08-16 12:00:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2019-08-16 12:00:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-16 11:47:46.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-08-16 12:00:55.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-08-16 12:19:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5465a82a391eefbef5020e5a2452bbb13cf5c34b","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-14 18:54:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2db384862f0f7ac9b4f2e72732a71956def79ea1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 19:19:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/97797e05c6fb44f6986931fff326c8e5 : SUCCESS in 3m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fb36de2eaadc48d9a68902dd080005e8 : SUCCESS in 4m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9d306c2713a84b21b093210404db49ac : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/617fadb7c3234f07a982a2c957359307 : SUCCESS in 3m 50s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/12a129d203d34fc7b0b1e493cd6ac55e : SUCCESS in 4m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d4585eae022b4464ac5674d398918e35 : SUCCESS in 5m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/610bb2213c1340c1b2af58ee562ee68f : SUCCESS in 4m 35s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c7787e4852f3415ba2746e0460dec145 : SUCCESS in 6m 22s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/589b6a3de4f4462095829399179fd195 : SUCCESS in 5m 38s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/e914836fbaab43838f275a13c6b75c53 : SUCCESS in 5m 05s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/496a987832ac42078844f7cce2749802 : SUCCESS in 13m 06s","accounts_in_message":[],"_revision_number":1},{"id":"d11c20a344e58d21911609fed4277a986c0022a1","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-15 09:05:05.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks for all your efforts on this Eric. Excellent digging.","accounts_in_message":[],"_revision_number":1},{"id":"0f0104f82ebc037f23ec85f3e934c3064f518e82","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-16 09:52:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ed551f89a05a080c339d15dd0c82d8f6952f9368","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 10:06:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ff5a2f7737a744729a5ee3ce549bb386 : SUCCESS in 8m 04s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4c175a4e1eee4fdf8a1b2b7e9292dde0 : SUCCESS in 7m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a7474e98dac6472fb830c4f33e78b654 : SUCCESS in 5m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f87333bf37b3494fb71ac063ae2dd0f3 : SUCCESS in 8m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ccaf130dd5064504832531b90209c16b : SUCCESS in 5m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/13ac3b8ec39246ce8ac5c5fe93ef16b8 : SUCCESS in 5m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/409b6c619b4e423b8e51bbe918a154c4 : SUCCESS in 8m 25s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/27b5b66e6703432cbdd57f419185facb : SUCCESS in 7m 27s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6f3b41548515438e90942ea3fc9cb348 : SUCCESS in 5m 50s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/6d1452e02f684bc3a197eb25a40847dc : SUCCESS in 7m 44s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/a0531e259e404d7b837787fe8dfc140e : SUCCESS in 11m 02s","accounts_in_message":[],"_revision_number":2},{"id":"0065fe76c3e6cb3f70ca4d79ad26b2e0664444b3","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-16 11:45:10.000000000","message":"Patch Set 2:\n\nLooks like PS2 was a trivial manual rebase?","accounts_in_message":[],"_revision_number":2},{"id":"0759b89a71fbe8c6e3560b7b6fb49ae66201b1dd","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-16 11:47:35.000000000","message":"Patch Set 2:\n\n\u003e Looks like PS2 was a trivial manual rebase?\n\nYes, there was a merge conflict.","accounts_in_message":[],"_revision_number":2},{"id":"2b8566664d43ed505d7122256bce7c6a4be4be1b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-16 11:47:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d7bc4fb9085dbf39c5e2d71d53df34043a4ca9f6","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-08-16 12:00:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e49122a8ecc6d61d10ff5e718438b6245e9105ef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 12:01:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ca7903b2268b06b5a9b41e4996909d2ddd6b1612","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 12:19:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"567b2550bc6d62112a61f94cb1aa7ca6916e7bf2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 12:19:26.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/975576b07d9e45a6b391d265a2a835f1 : SUCCESS in 4m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/67aca1dbda6541969a0e338120844058 : SUCCESS in 4m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fee36659aeed435c85f78b09d69e2b5c : SUCCESS in 4m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5891b27c068a47948a08cd80549fc9ae : SUCCESS in 4m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8482ad8db9e748b69974998a716ab782 : SUCCESS in 5m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3dc6c17ee2b0450984a1262207e8f416 : SUCCESS in 5m 16s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/0e0ab3ebbdbe46468344d7b31f3e0679 : SUCCESS in 5m 05s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/fb731ce0704441efbe6b8d1fd32f0b1b : SUCCESS in 5m 13s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/77870baba9a7498faaec40912a44c53a : SUCCESS in 5m 15s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/345d1890bb8f4f4eb93834f1c9e7e0a8 : SUCCESS in 13m 08s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9d256fa6c7f4377ee075555ec8b1f142fe75c445","revisions":{"9d63593cc4da625c0dfb4aadfa40716c0ea47bf3":{"kind":"REWORK","_number":1,"created":"2019-08-14 18:54:00.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/91/676491/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/91/676491/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/676491/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/676491/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/676491/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/91/676491/1"}}},"commit":{"parents":[{"commit":"0e199901df4a039aab566ebba4959c9a5b7e278d","subject":"Fix allocation bug in NUMANetworkFixture","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0e199901df4a039aab566ebba4959c9a5b7e278d"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 18:48:50.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 18:52:06.000000000","tz":-300},"subject":"gabbi test for same_subtree with an ancestry hole","message":"gabbi test for same_subtree with an ancestry hole\n\nBased on the analysis at [1], we need to continue to use fully-populated\nancestry data when calculating same_subtree-ness. This commit introduces\na gabbi test that covers a particular case that can be broken if we\ndon\u0027t do that: where a provider involved in the request has a broken\nancestry path to another provider involved in the request.\n\n[1] https://review.opendev.org/#/c/675606/2/placement/objects/allocation_candidate.py@908\n\nChange-Id: I5062e725d6f29cd997b974a0dad7dc4d0ed2900f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9d63593cc4da625c0dfb4aadfa40716c0ea47bf3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9d63593cc4da625c0dfb4aadfa40716c0ea47bf3"}]},"branch":"refs/heads/master"},"9d256fa6c7f4377ee075555ec8b1f142fe75c445":{"kind":"REWORK","_number":2,"created":"2019-08-16 09:52:29.000000000","uploader":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"ref":"refs/changes/91/676491/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/91/676491/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/676491/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/676491/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/91/676491/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/91/676491/2"}}},"commit":{"parents":[{"commit":"a6e1a19a85cada4a8eea505923033244bc118f88","subject":"Add tests demonstrating overlapping same_subtreeZ","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a6e1a19a85cada4a8eea505923033244bc118f88"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-14 18:48:50.000000000","tz":-300},"committer":{"name":"Chris Dent","email":"cdent@anticdent.org","date":"2019-08-16 09:44:37.000000000","tz":60},"subject":"gabbi test for same_subtree with an ancestry hole","message":"gabbi test for same_subtree with an ancestry hole\n\nBased on the analysis at [1], we need to continue to use fully-populated\nancestry data when calculating same_subtree-ness. This commit introduces\na gabbi test that covers a particular case that can be broken if we\ndon\u0027t do that: where a provider involved in the request has a broken\nancestry path to another provider involved in the request.\n\n[1] https://review.opendev.org/#/c/675606/2/placement/objects/allocation_candidate.py@908\n\nChange-Id: I5062e725d6f29cd997b974a0dad7dc4d0ed2900f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9d256fa6c7f4377ee075555ec8b1f142fe75c445"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/9d256fa6c7f4377ee075555ec8b1f142fe75c445"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}