)]}'
{"id":"openstack%2Fplacement~676530","triplet_id":"openstack%2Fplacement~master~I73efe96c24581ac5c399968440581bc6918ad6c1","project":"openstack/placement","branch":"master","topic":"test","hashtags":[],"change_id":"I73efe96c24581ac5c399968440581bc6918ad6c1","subject":"Add tests demonstrating overlapping same_subtreeZ","status":"MERGED","created":"2019-08-15 00:03:19.000000000","updated":"2019-08-16 08:37:08.000000000","submitted":"2019-08-16 08:37:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676530-1565944628403-de1e3c07","meta_rev_id":"6aa133ab39c13449ad312cec7ebdb0ef3f4cfedb","_number":676530,"virtual_id_number":676530,"owner":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":2,"date":"2019-08-16 08:37:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":2,"date":"2019-08-16 08:03:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"all":[{"value":1,"date":"2019-08-16 08:03:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-15 09:09:24.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-08-16 08:03:57.000000000","updated_by":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"reviewer":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"state":"REVIEWER"},{"updated":"2019-08-16 08:37:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cfd84da2c04c1a1a86655e412abdf9d5d1594a67","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-08-15 00:03:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"16d95d2777c8bf489472e4c596d4cae180506da4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 00:38:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/88f30fe18df34d83ad54f41de8effcd1 : SUCCESS in 3m 58s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9bacd7c11b6f4d1eba36f8287c503282 : SUCCESS in 5m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/479f7914ec4648ca83f6d42457a9010b : SUCCESS in 4m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/707270ed1d7542c0a4aa6807b6718d04 : SUCCESS in 4m 11s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4f8fe8dc9b1648fd99adc7c461e44970 : SUCCESS in 4m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/25ce10a43b0241c28d634f93d592285f : SUCCESS in 4m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/aee9abd4ec3f49f7be30dafbf5377a7a : SUCCESS in 5m 23s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/17f8dd6aa6374606b986da1a5bc72787 : SUCCESS in 4m 46s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/e525ef02a98a4ca395ac79149de2d501 : SUCCESS in 5m 18s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/50a8555acf07496281b76e83962951f3 : SUCCESS in 4m 53s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/171b2ed1e2b44fc8ad9eaae5af0f9f17 : SUCCESS in 13m 10s","accounts_in_message":[],"_revision_number":1},{"id":"ae0e7e69a334598c5729aaee4d8cd9f84b73afc3","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-15 09:09:24.000000000","message":"Patch Set 1: Code-Review+2\n\nYup.\n\nI think this \"discovery\" about same_subtree behavior is going to require some rigorous documentation. It\u0027s sort of natural (or at least I have to fight the inclincation) to assume that same_subtree creates a sort of linked up path when there are \u003e 2 components but it\u0027s not that. If you want that you have to indicate the path with multiple same_subtrees\n\nwhich these tests do, which is good\n\nBut a \"How to use same_subtree for great good\" doc is definitely required.","accounts_in_message":[],"_revision_number":1},{"id":"86567db4e3df7240b51398d2d29e15718cfbbf50","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-16 07:58:15.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"47acea41350d229a6ec6b06c4a27f5a8cc23fd2b","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-16 08:00:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"575fa73b86af7908e6d8dd9f3603ba3ce7ff7df9","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-16 08:03:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\n+W using Chris\u0027s +2 on PS1 since the difference is only the typo fix.","accounts_in_message":[],"_revision_number":2},{"id":"f6a3ad0143d37720bd29284e208046b6c89fa621","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 08:13:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f1bc21b5e26d4ed8ad9191f200afcbd0 : SUCCESS in 4m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3a3bebc1c99042b09fd8ce08582d7063 : SUCCESS in 6m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c2f0de120f884502a1154142e14d8630 : SUCCESS in 5m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b9bc4649cdd64ce88cc12bcc1ad05a91 : SUCCESS in 4m 59s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/185807778a034a028c8fb197af08efc2 : SUCCESS in 4m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ce62011e35a84b1dbf6cc45ed198a672 : SUCCESS in 4m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f43683e3d5ff4d6ab84e1b0c20910b2d : SUCCESS in 5m 23s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c039f30b6cb745b284fdd7fb8e3a718d : SUCCESS in 5m 15s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d80a137a65134f9d8b1dacf757bcec04 : SUCCESS in 5m 20s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/35d35c64009f4cbca7b7fa8446d30899 : SUCCESS in 5m 50s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/16b72db563b1422680b4c5f98b92c334 : SUCCESS in 11m 04s","accounts_in_message":[],"_revision_number":2},{"id":"587f1d3a0cd4cec92142474da4a3b90c8513c4fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 08:13:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f873da5b5527f42c577ac72a9b3a6876bd3b3c41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 08:37:08.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5de1a6a83e6b5b1618e7d7c7fc035ce29448a858","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-16 08:37:08.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dcd0bd118b7249f193bc0b3c4ea5db96 : SUCCESS in 5m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/66ab02534ffd448180f7bd8639fcf799 : SUCCESS in 7m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/44099d99a5424ee7bbf84fa9148fe6ba : SUCCESS in 5m 16s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0f1a29b7d842451b8a1fe32e3dd52444 : SUCCESS in 5m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/aeac90c374c9466bb864868b75864de1 : SUCCESS in 4m 59s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/238335ee0e594fa7a9974717e824df2d : SUCCESS in 5m 24s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/7db3b30e024e45318fa13cd278677e56 : SUCCESS in 8m 23s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/ffbf09f7d83a46a9973f364095c9fa40 : SUCCESS in 6m 00s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/f659013e5a234f7fa3004a2c2a315cdc : SUCCESS in 6m 05s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/e8508683883f47dd801686dae01bb86e : SUCCESS in 12m 08s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a6e1a19a85cada4a8eea505923033244bc118f88","revisions":{"a1b2b3c6cedf0cf8f432b4186b22ddcf2d88e21a":{"kind":"REWORK","_number":1,"created":"2019-08-15 00:03:19.000000000","uploader":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"ref":"refs/changes/30/676530/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/30/676530/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/30/676530/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/30/676530/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/30/676530/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/30/676530/1"}}},"commit":{"parents":[{"commit":"180167161623fe1264a260fb681c87de6d79c4a2","subject":"Merge \"Use expanding bindparam in get_traits_by_provider_tree\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/180167161623fe1264a260fb681c87de6d79c4a2"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-15 00:01:04.000000000","tz":-300},"committer":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-15 00:02:40.000000000","tz":-300},"subject":"Add tests demonstrating overlapping same_subtreeZ","message":"Add tests demonstrating overlapping same_subtreeZ\n\nPursuant to discussions at [1], this commit adds a pair of gabbi tests\ndemonstrating that same_subtree\u003dA,B\u0026same_subtree\u003dB,C does not\nnecessarily act the same as same_subtree\u003dA,B,C.\n\nFoundation of the tests shamelessly purloined from [1].\n\n[1] https://review.opendev.org/#/c/676204/4/placement/tests/functional/gabbits/same-subtree-deep.yaml@29\n\nChange-Id: I73efe96c24581ac5c399968440581bc6918ad6c1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a1b2b3c6cedf0cf8f432b4186b22ddcf2d88e21a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a1b2b3c6cedf0cf8f432b4186b22ddcf2d88e21a"}]},"branch":"refs/heads/master"},"a6e1a19a85cada4a8eea505923033244bc118f88":{"kind":"REWORK","_number":2,"created":"2019-08-16 08:00:44.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/30/676530/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/30/676530/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/30/676530/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/30/676530/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/30/676530/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/30/676530/2"}}},"commit":{"parents":[{"commit":"0e199901df4a039aab566ebba4959c9a5b7e278d","subject":"Fix allocation bug in NUMANetworkFixture","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0e199901df4a039aab566ebba4959c9a5b7e278d"}]}],"author":{"name":"Eric Fried","email":"openstack@fried.cc","date":"2019-08-15 00:01:04.000000000","tz":-300},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-08-16 08:00:38.000000000","tz":0},"subject":"Add tests demonstrating overlapping same_subtreeZ","message":"Add tests demonstrating overlapping same_subtreeZ\n\nPursuant to discussions at [1], this commit adds a pair of gabbi tests\ndemonstrating that same_subtree\u003dA,B\u0026same_subtree\u003dB,C does not\nnecessarily act the same as same_subtree\u003dA,B,C.\n\nFoundation of the tests shamelessly purloined from [1].\n\n[1] https://review.opendev.org/#/c/676204/4/placement/tests/functional/gabbits/same-subtree-deep.yaml@29\n\nChange-Id: I73efe96c24581ac5c399968440581bc6918ad6c1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a6e1a19a85cada4a8eea505923033244bc118f88"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a6e1a19a85cada4a8eea505923033244bc118f88"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}