)]}'
{"id":"openstack%2Fplacement~679385","triplet_id":"openstack%2Fplacement~master~Ie76533c95e298725f8c7493d88552371d9b1cafb","project":"openstack/placement","branch":"master","topic":"refactor-reqgroup-context","hashtags":[],"change_id":"Ie76533c95e298725f8c7493d88552371d9b1cafb","subject":"Refactor initialization of research context","status":"NEW","created":"2019-08-30 07:32:40.000000000","updated":"2019-08-30 13:04:09.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3549ab94270e0eb52b567e74e9da7559d102ef2f","_number":679385,"virtual_id_number":679385,"owner":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":1,"date":"2019-08-30 10:42:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-08-30 07:45:38.000000000","_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"date":"2019-08-30 13:04:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-30 07:45:38.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-08-30 10:42:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-30 13:04:09.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"}],"messages":[{"id":"8fa0d6a9ae9300dcbb19f9953ad1807c07e9cbcf","author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"date":"2019-08-30 07:32:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc9520b14a1b32dfb9089339894fbd1e9506570d","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-08-30 07:45:38.000000000","message":"Patch Set 1:\n\nExcellent idea.\n\nIt\u0027s not immediately clear to me why you\u0027re added from_reqgroup() instead of doing the refactoring in __init__ itself?\n\nAlso, is there a specific reason you defined methods within from_reqgroup rather than using staticmethods or module level functions?","accounts_in_message":[],"_revision_number":1},{"id":"68e81fba6126cf58475bb7b9e71ff326ee3ded26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 10:42:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/4f36ca4145804650befda8c383df90e9 : SUCCESS in 1h 02m 39s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/3bb4316d9d864b19a417f8ba089aeca2 : SUCCESS in 1h 31m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f46885d61f624199a10437aa585236e6 : SUCCESS in 5m 28s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/83b3be733add472088054944d49d4678 : SUCCESS in 5m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/57d3b09d04ba4db3baa401b2ae3e352f : SUCCESS in 6m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/eab80d8d9d504e5188623485e16f2ad4 : SUCCESS in 4m 47s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e42f80893fb3497b8d9f139ed87cb60c : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e5db02d037e34823a5fb3ad156a0eb21 : SUCCESS in 5m 32s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0e7d6768ff404c61beb248434614f627 : SUCCESS in 5m 34s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/e5e63488f26747f99425befc7d174e25 : SUCCESS in 5m 42s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6ffe26dc4e8547a981b832f7dcab7662 : SUCCESS in 5m 39s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/276bc5f9cca449da9ee257251f696720 : SUCCESS in 5m 47s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/3df775cb18cb49a1ace905e45ed05387 : SUCCESS in 14m 16s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/6e8e19c4083d4a12ad0f0e248128f6f3 : SUCCESS in 31m 25s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/3a2424daa19c4d2b8ab668bc3092e0f7 : SUCCESS in 10m 52s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/09991964c07445719e20f064bd4106da : SUCCESS in 1h 04m 46s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"74d7d4d13d4fe8759aee26142cec510581c7022c","revisions":{"74d7d4d13d4fe8759aee26142cec510581c7022c":{"kind":"REWORK","_number":1,"created":"2019-08-30 07:32:40.000000000","uploader":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"ref":"refs/changes/85/679385/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/85/679385/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/85/679385/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/85/679385/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/85/679385/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/85/679385/1"}}},"commit":{"parents":[{"commit":"7e885108916f7243ddab0ac9a27d3a540c070fb1","subject":"Merge \"Get usages in _build_provider_summaries()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/7e885108916f7243ddab0ac9a27d3a540c070fb1"}]}],"author":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-08-28 06:21:21.000000000","tz":0},"committer":{"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","date":"2019-08-30 07:31:24.000000000","tz":0},"subject":"Refactor initialization of research context","message":"Refactor initialization of research context\n\nThe initialize function of RequestGroupSearchContext retrieved and\ncached request-matching providers from database, but there could be\ncases some data processing tasks are done before raising, which is\ninefficient.\n\nTo reorder that data processing, this patch adds a new function,\nfrom_reqgroup(), where we extract that data processings tasks into\nsmaller functions.\n\nChange-Id: Ie76533c95e298725f8c7493d88552371d9b1cafb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/74d7d4d13d4fe8759aee26142cec510581c7022c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/74d7d4d13d4fe8759aee26142cec510581c7022c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}