)]}'
{"id":"openstack%2Fplacement~681634","triplet_id":"openstack%2Fplacement~master~I49e628c87276b5495bca01842f6228742ed49765","project":"openstack/placement","branch":"master","hashtags":[],"change_id":"I49e628c87276b5495bca01842f6228742ed49765","subject":"Un-cap jsonschema for python3.6/3.7 support","status":"MERGED","created":"2019-09-12 02:13:01.000000000","updated":"2019-09-23 20:28:14.000000000","submitted":"2019-09-23 20:26:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"681634-1569270409919-1544dba8","meta_rev_id":"6800ad170595dc2a2ecf9d69c3ab51301a364906","_number":681634,"virtual_id_number":681634,"owner":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},{"value":0,"date":"2019-09-17 16:15:57.000000000","_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-23 20:26:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":2,"date":"2019-09-23 19:07:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":1,"date":"2019-09-20 07:27:56.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":1,"date":"2019-09-20 08:54:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-09-23 10:40:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":1,"date":"2019-09-23 19:07:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"value":0,"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-12 07:43:45.000000000","updated_by":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"reviewer":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"state":"REVIEWER"},{"updated":"2019-09-15 13:47:44.000000000","updated_by":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"reviewer":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"state":"REVIEWER"},{"updated":"2019-09-17 16:15:57.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-09-20 07:27:56.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2019-09-20 08:54:46.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-09-23 10:40:45.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2019-09-23 19:07:02.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2019-09-23 20:26:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"20cb2caee4a37d5796c3afe057195bce2f192c0c","author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"date":"2019-09-12 02:13:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b101999465077361e82b0a18acdea687f669dd1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-12 05:30:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/154c483c730246aa920639d0169b05fb : SUCCESS in 1h 01m 57s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/5ee12f8188b54fef82522793d30fe7e0 : SUCCESS in 1h 24m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b859c11548b342adaa4efdbefd2648a7 : SUCCESS in 4m 49s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/635b82cfa6fc48de97702bf5bbb0e53c : SUCCESS in 6m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/07480c3d5846440a8a2fe79defae078c : SUCCESS in 6m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2da7cd38d1304a96ada4f3c3ad1d3867 : SUCCESS in 4m 08s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b1f5b675299c4187954ab039e4a9b7c0 : FAILURE in 4m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4a948939dad84791b42d38fcc6fcf17f : SUCCESS in 5m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6d9a3dae6199419eb5c09e01902c8a02 : SUCCESS in 5m 22s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/b54daaf8f8504a509944a07ea5976e95 : FAILURE in 4m 54s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/63b540f055504b96ba26c54de29e5029 : SUCCESS in 6m 37s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/afd0e7e9b5404773af52f0a81f2a1fb5 : SUCCESS in 9m 31s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/9059136dd01443aeae52f6b2b2b0eb85 : SUCCESS in 13m 46s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/86065374e7e64d93ad5a0aec3f98f1f8 : SUCCESS in 36m 21s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/8d0f2675feae4b8dad6352289d8a0478 : SUCCESS in 12m 34s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dc5187cd5ac843a2a13b5eefad651819 : SUCCESS in 1h 01m 50s","accounts_in_message":[],"_revision_number":1},{"id":"d3fcf4b1872305aaca273eda724e06ed307939db","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-09-12 07:43:45.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2d3230832ca7ec6da550906c68a5a3395f2e72b8","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-09-12 09:49:04.000000000","message":"Patch Set 1: Code-Review-1\n\nCan you provide more information about how you failed in devstack?\n\nI assume this is probably the right change, but I just tried a devstack and did not get a failure so it would be useful to understand what is going on.\n\nAlso, the commit message needs to be cleaned up as described by Takashi.","accounts_in_message":[],"_revision_number":1},{"id":"56c322ca1f825cd6352e28b449be82aa037dc9e4","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-12 18:48:00.000000000","message":"Patch Set 1:\n\n\u003e I assume this is probably the right change\n\nWell, it concerns me that 3.0.0 was explicitly not possible before, but is now. Do we know why that is? Did it have a bug? Do we need ,!\u003d3.0.0?","accounts_in_message":[],"_revision_number":1},{"id":"a04b76e05c76661c524fe0c8781ead2b3c2d5787","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-16 16:58:58.000000000","message":"Patch Set 1:\n\nI am also unable to install devstack with USE_PYTHON3\u003dTrue. I get the following error:\npip._vendor.pkg_resources.ContextualVersionConflict: (jsonschema 3.0.2 (/usr/local/lib/python3.6/dist-packages), Requirement.parse(\u0027jsonschema\u003c3.0.0,\u003e\u003d2.6.0\u0027), {\u0027openstack-placement\u0027})\nThere is no \u003c3.0.0 jsonschema package for python3","accounts_in_message":[],"_revision_number":1},{"id":"63fa960acb4b644274c6470a6ff76eccf92c6461","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-16 17:00:27.000000000","message":"Patch Set 1:\n\nSorry, I take that back, there is a 2.6.0 package for python3. I had a typo.\nStill don\u0027t know why devstack won\u0027t pick 2.6.0 though.","accounts_in_message":[],"_revision_number":1},{"id":"928b564995d28da00f70e64b667a4d06a9cf8629","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-16 23:40:12.000000000","message":"Patch Set 1: Code-Review-1\n\nThe issue is jsonschema 2.6.0 does not support python 3.6 which is shipped with Ubuntu bionic 18.04. Global requirements removed the \u003c3.0.0 restriction months ago in https://github.com/openstack/requirements/commit/828484138cf4b073583226fca1a23b679f759799\nThis patch should also remove that restriction.","accounts_in_message":[],"_revision_number":1},{"id":"547d1ef9a0e8df699140f0172ae5d23f9c6751aa","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-16 23:52:02.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"c2d0308c59205cc6b3473085370cb59386a1e2cc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 01:26:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/7ad7128de0134cc58cf4fdbebde35963 : SUCCESS in 1h 00m 28s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/c30d7c2fe36c4761b03ccb547e5281b5 : SUCCESS in 1h 20m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b5bac56a1a284e71a7df7f3ccae10973 : SUCCESS in 5m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fa36abf3ade04cacb6f544ad9242778f : SUCCESS in 5m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0153651ebeab43f897d852e33766183b : SUCCESS in 5m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf31bf10878c41fb89db330786af0fb2 : SUCCESS in 3m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/51cb676a5ef944e8ac69b7e6f7bb93d7 : SUCCESS in 4m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/da6298cc2fa649a599d8a5b4e9daa5a9 : SUCCESS in 4m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/32f870ab26594fd9be3d271d7c885ee0 : SUCCESS in 6m 29s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/45981b31bdbf4efcbee54a1442f691f3 : SUCCESS in 4m 58s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f197cc3251d04f94a540b65aa974efb5 : SUCCESS in 5m 18s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/37dbcaad0e3c45bf8d09140b3ac3eef0 : SUCCESS in 5m 35s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/8fefc6313eba4ca9815323c2d9e1bcb4 : FAILURE in 11m 22s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/5779930e6d404ed7b44b9230f28bc391 : SUCCESS in 25m 49s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/bad4c73a979a40289d14a4ff71e457ad : SUCCESS in 10m 54s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/540d61202a62462c91ffca82a1c9f3a4 : SUCCESS in 1h 17m 22s","accounts_in_message":[],"_revision_number":2},{"id":"86466989a5f54184955441c02bf2a7b43d4e7176","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-17 16:15:57.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"ea37119a7d1622b0f1948eb186e9f90f9fe0f878","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 00:48:01.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/bfd11fb825904770857ed561ab9f252b : SUCCESS in 1h 00m 35s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/500f8879c2ba44dca88ac303a5424bd5 : SUCCESS in 1h 16m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/024d3d7996004345854b71e1029b0ece : SUCCESS in 4m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cbe8a426522b4bf8b1c71d50d09c3fbe : SUCCESS in 6m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c7367ccf13724216a701e6ad603a67b8 : SUCCESS in 4m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6cb47591e53449c99c9eb9bee0c93b71 : SUCCESS in 5m 14s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3633ba694d304d83ab8bcb374b9ae445 : SUCCESS in 3m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/234040bb3cc046fe9c62b5a76944758a : SUCCESS in 5m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/823af28941e243778aa5f59bd8ad03bd : SUCCESS in 4m 33s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/675156ca82634753a70e5aa0d72c6091 : SUCCESS in 4m 31s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/272e7c89ee014fb68db0db01514bddb5 : SUCCESS in 7m 28s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/e8b87bac968445ee8663daaed41436fd : SUCCESS in 5m 59s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/8634ace6e137495e82e59bf1a8df26da : SUCCESS in 15m 07s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/17bc2c6eb76947e3ae6bbb5daad2453b : SUCCESS in 37m 52s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/9dcc166c07c842f4a3f91c47e87ee098 : SUCCESS in 14m 01s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3a2337fc1b6a44e4b527218282e33170 : SUCCESS in 1h 01m 35s","accounts_in_message":[],"_revision_number":2},{"id":"9bdd8899f2e759e79fe6615dbc479d21fec2cb51","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-09-20 07:27:56.000000000","message":"Patch Set 2: Code-Review+1\n\nI saw the problem copied by Michael in my python3 devstack. Now building a devstack with a this fix included. I will +2 if this patch clean ups my build","accounts_in_message":[],"_revision_number":2},{"id":"01182479ef22e671b52efb8a4d5e2f7eac73cb34","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-09-20 08:54:46.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"78572e3ca590d94d2873f7ddd76bd0f9ebbe90ae","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2019-09-21 15:31:22.000000000","message":"Patch Set 2:\n\nInteresting. Without this patch I can now build a fresh devstack with python3 in a way that placement is using jsonschema \u003e 3.0.0.  So I\u0027m not sure what is happening.\n\nstack@ubuntu:~$ cat ~/devstack/local.conf \n[[local|localrc]]\nADMIN_PASSWORD\u003dsecret\nDATABASE_PASSWORD\u003d$ADMIN_PASSWORD\nRABBIT_PASSWORD\u003d$ADMIN_PASSWORD\nSERVICE_PASSWORD\u003d$ADMIN_PASSWORD\n\nUSE_PYTHON3\u003dTrue\n\nstack@ubuntu:~$ pip freeze | egrep -e \u0027jsonschema|placement\u0027\nYou are using pip version 9.0.3, however version 19.2.3 is available.\nYou should consider upgrading via the \u0027pip install --upgrade pip\u0027 command.\njsonschema\u003d\u003d3.0.2\n-e git+https://opendev.org/openstack/placement.git@76a5c83c2fd747f57e0e93aadc7d4bb0265afa99#egg\u003dopenstack_placement\nosc-placement\u003d\u003d1.7.0\nstack@ubuntu:~$ grep jsonschema /opt/stack/placement/requirements.txt \njsonschema\u003c3.0.0,\u003e\u003d2.6.0 # MIT","accounts_in_message":[],"_revision_number":2},{"id":"a47ab7268f049d70b0a9a20fed6abc38279fcf70","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-09-23 08:16:43.000000000","message":"Patch Set 2:\n\n\u003e Interesting. Without this patch I can now build a fresh devstack\n \u003e with python3 in a way that placement is using jsonschema \u003e 3.0.0. \n \u003e So I\u0027m not sure what is happening.\n \u003e \n \u003e stack@ubuntu:~$ cat ~/devstack/local.conf\n \u003e [[local|localrc]]\n \u003e ADMIN_PASSWORD\u003dsecret\n \u003e DATABASE_PASSWORD\u003d$ADMIN_PASSWORD\n \u003e RABBIT_PASSWORD\u003d$ADMIN_PASSWORD\n \u003e SERVICE_PASSWORD\u003d$ADMIN_PASSWORD\n \u003e \n \u003e USE_PYTHON3\u003dTrue\n \u003e \n \u003e stack@ubuntu:~$ pip freeze | egrep -e \u0027jsonschema|placement\u0027\n \u003e You are using pip version 9.0.3, however version 19.2.3 is\n \u003e available.\n \u003e You should consider upgrading via the \u0027pip install --upgrade pip\u0027\n \u003e command.\n \u003e jsonschema\u003d\u003d3.0.2\n \u003e -e git+https://opendev.org/openstack/placement.git@76a5c83c2fd747f57e0e93aadc7d4bb0265afa99#egg\u003dopenstack_placement\n \u003e osc-placement\u003d\u003d1.7.0\n \u003e stack@ubuntu:~$ grep jsonschema /opt/stack/placement/requirements.txt\n \u003e jsonschema\u003c3.0.0,\u003e\u003d2.6.0 # MIT\n\nHi, in my devstack with python27, it was built with Stein. I ran unstack.sh first, then built with Master version. I met the error below after running stack.sh.\n\nObtaining file:///opt/stack/placement\nException:\nTraceback (most recent call last):\n  File \"/usr/local/lib/python2.7/dist-packages/pip/basecommand.py\", line 215, in main\n    status \u003d self.run(options, args)\n  File \"/usr/local/lib/python2.7/dist-packages/pip/commands/install.py\", line 335, in run\n    wb.build(autobuilding\u003dTrue)\n  File \"/usr/local/lib/python2.7/dist-packages/pip/wheel.py\", line 749, in build\n    self.requirement_set.prepare_files(self.finder)\n  File \"/usr/local/lib/python2.7/dist-packages/pip/req/req_set.py\", line 380, in prepare_files\n    ignore_dependencies\u003dself.ignore_dependencies))\n  File \"/usr/local/lib/python2.7/dist-packages/pip/req/req_set.py\", line 521, in _prepare_file\n    req_to_install.check_if_exists()\n  File \"/usr/local/lib/python2.7/dist-packages/pip/req/req_install.py\", line 1036, in check_if_exists\n    self.req.name\n  File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\", line 558, in get_distribution\n    dist \u003d get_provider(dist)\n  File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\", line 432, in get_provider\n    return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]\n  File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\", line 968, in require\n    needed \u003d self.resolve(parse_requirements(requirements))\n  File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\", line 859, in resolve\n    raise VersionConflict(dist, req).with_context(dependent_req)\nContextualVersionConflict: (jsonschema 3.0.2 (/usr/local/lib/python2.7/dist-packages), Requirement.parse(\u0027jsonschema\u003c3.0.0,\u003e\u003d2.6.0\u0027), set([\u0027openstack-placement\u0027]))","accounts_in_message":[],"_revision_number":2},{"id":"52b61e6de0d0b501d4ddd06a9c845f53a67452e5","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-09-23 08:22:25.000000000","message":"Patch Set 2:\n\n\u003e \u003e Interesting. Without this patch I can now build a fresh devstack\n \u003e \u003e with python3 in a way that placement is using jsonschema \u003e 3.0.0.\n \u003e \u003e So I\u0027m not sure what is happening.\n \u003e \u003e\n \u003e \u003e stack@ubuntu:~$ cat ~/devstack/local.conf\n \u003e \u003e [[local|localrc]]\n \u003e \u003e ADMIN_PASSWORD\u003dsecret\n \u003e \u003e DATABASE_PASSWORD\u003d$ADMIN_PASSWORD\n \u003e \u003e RABBIT_PASSWORD\u003d$ADMIN_PASSWORD\n \u003e \u003e SERVICE_PASSWORD\u003d$ADMIN_PASSWORD\n \u003e \u003e\n \u003e \u003e USE_PYTHON3\u003dTrue\n \u003e \u003e\n \u003e \u003e stack@ubuntu:~$ pip freeze | egrep -e \u0027jsonschema|placement\u0027\n \u003e \u003e You are using pip version 9.0.3, however version 19.2.3 is\n \u003e \u003e available.\n \u003e \u003e You should consider upgrading via the \u0027pip install --upgrade pip\u0027\n \u003e \u003e command.\n \u003e \u003e jsonschema\u003d\u003d3.0.2\n \u003e \u003e -e git+https://opendev.org/openstack/placement.git@76a5c83c2fd747f57e0e93aadc7d4bb0265afa99#egg\u003dopenstack_placement\n \u003e \u003e osc-placement\u003d\u003d1.7.0\n \u003e \u003e stack@ubuntu:~$ grep jsonschema /opt/stack/placement/requirements.txt\n \u003e \u003e jsonschema\u003c3.0.0,\u003e\u003d2.6.0 # MIT\n \u003e \n \u003e Hi, in my devstack with python27, it was built with Stein. I ran\n \u003e unstack.sh first, then built with Master version. I met the error\n \u003e below after running stack.sh.\n \u003e \n \u003e Obtaining file:///opt/stack/placement\n \u003e Exception:\n \u003e Traceback (most recent call last):\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/basecommand.py\",\n \u003e line 215, in main\n \u003e status \u003d self.run(options, args)\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/commands/install.py\",\n \u003e line 335, in run\n \u003e wb.build(autobuilding\u003dTrue)\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/wheel.py\", line\n \u003e 749, in build\n \u003e self.requirement_set.prepare_files(self.finder)\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/req/req_set.py\",\n \u003e line 380, in prepare_files\n \u003e ignore_dependencies\u003dself.ignore_dependencies))\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/req/req_set.py\",\n \u003e line 521, in _prepare_file\n \u003e req_to_install.check_if_exists()\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/req/req_install.py\",\n \u003e line 1036, in check_if_exists\n \u003e self.req.name\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\",\n \u003e line 558, in get_distribution\n \u003e dist \u003d get_provider(dist)\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\",\n \u003e line 432, in get_provider\n \u003e return working_set.find(moduleOrReq) or require(str(moduleOrReq))[0]\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\",\n \u003e line 968, in require\n \u003e needed \u003d self.resolve(parse_requirements(requirements))\n \u003e File \"/usr/local/lib/python2.7/dist-packages/pip/_vendor/pkg_resources/__init__.py\",\n \u003e line 859, in resolve\n \u003e raise VersionConflict(dist, req).with_context(dependent_req)\n \u003e ContextualVersionConflict: (jsonschema 3.0.2 (/usr/local/lib/python2.7/dist-packages),\n \u003e Requirement.parse(\u0027jsonschema\u003c3.0.0,\u003e\u003d2.6.0\u0027), set([\u0027openstack-placement\u0027]))\n\nAnd that is the reason I submitted https://review.opendev.org/#/c/683283/.","accounts_in_message":[],"_revision_number":2},{"id":"35bca737ef78e288d3a87a93578cc869143c3d62","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-09-23 10:40:45.000000000","message":"Patch Set 2: Code-Review+2\n\nGiven that global requirements doesn\u0027t have any restrictions on jsonschema, and the tests are passing, this seems like a fine change to me.","accounts_in_message":[],"_revision_number":2},{"id":"d8fb47f1604b6e38d68f5fcf7d0aa18fbd64ee78","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-23 13:31:23.000000000","message":"Patch Set 2:\n\nI\u0027m a little leery of this just because 3.0.0 was never permitted, and it was skipped over in global requirements, which leads me to fear that it was somehow buggy and should be blacklisted.\n\nI ran unit \u0026 functional locally with 3.0.0 against py36 and it passes fine, but I guess I would feel better if we had a tempest-y thing that did the same.\n\nI\u0027ve proposed https://review.opendev.org/683956 to do that.","accounts_in_message":[],"_revision_number":2},{"id":"5626fe12396240e7f10307cf31cf58aff5d01fb7","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-23 19:07:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n\u003e I\u0027ve proposed https://review.opendev.org/683956 to do that.\n\nThis succeeded. No further concerns.","accounts_in_message":[],"_revision_number":2},{"id":"815ca76c7dd9b501d047de08d5daf46ae904310f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 19:07:53.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"676e82a195ebdf0fdc03de8cea341ac7ed27f424","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2019-09-23 19:09:20.000000000","message":"Patch Set 2:\n\nActually, it still installed 3.0.2 in the tempest env [1].\n\nOh well. I was probably being overly paranoid anyway.\n\n[1] https://zuul.opendev.org/t/openstack/build/db46735e38a241ce8691a5c5709796e9/log/job-output.txt#9524","accounts_in_message":[],"_revision_number":2},{"id":"69fa54cd14e6aa41f82ba7b160d3876a3c35c50b","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2019-09-23 19:26:56.000000000","message":"Patch Set 2:\n\n\u003e Actually, it still installed 3.0.2 in the tempest env [1].\n \u003e \n \u003e Oh well. I was probably being overly paranoid anyway.\n \u003e \n \u003e [1] https://zuul.opendev.org/t/openstack/build/db46735e38a241ce8691a5c5709796e9/log/job-output.txt#9524\n\nSome other of the many constraint files involved won. In this case I would guess global upper constraints: https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt\n\nUnfortunately we have a bit of a situation where what a human building devstack will see and what CI will see is not always the same.\n\nBut that\u0027s okay: people come along and fix it (like this) and happiness happens.","accounts_in_message":[],"_revision_number":2},{"id":"69225c7f9fc04222a56ac7131034cefccb160bcd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:26:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/92b0b7e6142846949dd6456af52c7780 : SUCCESS in 1h 10m 36s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/2cbf69059aee4fcbbe3698c826a2b8c9 : SUCCESS in 1h 11m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e5061f6f1e454f32b7f5be32437e8e69 : SUCCESS in 7m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cfb55907832a466d9b04a2719d6bbd58 : SUCCESS in 5m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6ab64ebf5335476ca8f78c57400f5827 : SUCCESS in 6m 33s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/120adca69e8d4f70a553614cf6de5a8f : SUCCESS in 6m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/72df36356ed04e1ea998210465daf3e3 : SUCCESS in 4m 43s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fa6bd9ec2c324337ba7beada877be8ad : SUCCESS in 6m 34s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c161c56c416b48ff86af64cd142da335 : SUCCESS in 5m 11s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b572dc5203584e748dfe2cf7a88fefde : SUCCESS in 5m 12s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/f0c9fbd01dd64e5dbcaab82117928ace : SUCCESS in 7m 47s\n- placement-nova-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/198e2654f38049b68bbfbcbd350261ab : SUCCESS in 11m 51s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/44ffaee9899b4073914208c2fba8879c : SUCCESS in 1h 07m 22s","accounts_in_message":[],"_revision_number":2},{"id":"082ef3bd45892a8cc33b1058ecddadfc0de1d48b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:26:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"6800ad170595dc2a2ecf9d69c3ab51301a364906","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-23 20:28:14.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95fd84be43f34fdface8d075e2042ecf : SUCCESS in 1m 01s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"804a11581e54c15399f4d02857b89f2511dc003a","revisions":{"4330de9d74ce134374daa2098c28ebbc2bf55c3d":{"kind":"REWORK","_number":1,"created":"2019-09-12 02:13:01.000000000","uploader":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"ref":"refs/changes/34/681634/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/34/681634/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/34/681634/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/34/681634/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/34/681634/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/34/681634/1"}}},"commit":{"parents":[{"commit":"b49c67c77a4d4a379f015dbc39bcb8a893fc3429","subject":"Merge \"Update setup.cfg to include project_urls\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/b49c67c77a4d4a379f015dbc39bcb8a893fc3429"}]}],"author":{"name":"XiaojueGuan","email":"guanalbertjone@gmail.com","date":"2019-09-12 02:12:31.000000000","tz":480},"committer":{"name":"XiaojueGuan","email":"guanalbertjone@gmail.com","date":"2019-09-12 02:12:31.000000000","tz":480},"subject":"since upper-constraints.txt already upgraded to 3.0.2, and which made me failed in devstack, so it is necessary to change it.","message":"since upper-constraints.txt already upgraded to 3.0.2, and which\nmade me failed in devstack, so it is necessary to change it.\n\nChange-Id: I49e628c87276b5495bca01842f6228742ed49765\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4330de9d74ce134374daa2098c28ebbc2bf55c3d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/4330de9d74ce134374daa2098c28ebbc2bf55c3d"}]},"branch":"refs/heads/master"},"804a11581e54c15399f4d02857b89f2511dc003a":{"kind":"REWORK","_number":2,"created":"2019-09-16 23:52:02.000000000","uploader":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"ref":"refs/changes/34/681634/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/34/681634/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/34/681634/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/34/681634/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/34/681634/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/34/681634/2"}}},"commit":{"parents":[{"commit":"b49c67c77a4d4a379f015dbc39bcb8a893fc3429","subject":"Merge \"Update setup.cfg to include project_urls\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/b49c67c77a4d4a379f015dbc39bcb8a893fc3429"}]}],"author":{"name":"XiaojueGuan","email":"guanalbertjone@gmail.com","date":"2019-09-12 02:12:31.000000000","tz":480},"committer":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2019-09-16 23:51:40.000000000","tz":0},"subject":"Un-cap jsonschema for python3.6/3.7 support","message":"Un-cap jsonschema for python3.6/3.7 support\n\njsonschema \u003c 3.0.0 does not support python3.6 or 3.7 which will cause\nplacement to fail to install on instances using 3.6 (Ubuntu Bionic) or\n3.7.\nGlobal-requirements removed this cap months ago in\nhttps://github.com/openstack/requirements/commit/828484138cf4b073583226fca1a23b679f759799\n\nChange-Id: I49e628c87276b5495bca01842f6228742ed49765\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/804a11581e54c15399f4d02857b89f2511dc003a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/804a11581e54c15399f4d02857b89f2511dc003a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
