)]}'
{"doc/requirements.txt":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7cc9860a4df4bb5c2b90ebeea8bf6a31283c58b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027 # BSD"},{"line_number":6,"context_line":"sphinxcontrib-actdiag\u003e\u003d0.8.5 # BSD"},{"line_number":7,"context_line":"sphinxcontrib-seqdiag\u003e\u003d0.8.4 # BSD"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_a5628a14","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":64},"updated":"2019-12-16 15:48:58.000000000","message":"IIUC we\u0027re still allowed to get rid of this line.","commit_id":"ece3422ecd67a0c35660dac5deab38c24f3a0959"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9718dda1d89d3a614079fd5ff99c4a3aa603e97f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027 # BSD"},{"line_number":6,"context_line":"sphinxcontrib-actdiag\u003e\u003d0.8.5 # BSD"},{"line_number":7,"context_line":"sphinxcontrib-seqdiag\u003e\u003d0.8.4 # BSD"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_87342b4b","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":64},"in_reply_to":"3fa7e38b_a5628a14","updated":"2019-12-17 02:51:59.000000000","message":"Right, will do.","commit_id":"ece3422ecd67a0c35660dac5deab38c24f3a0959"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7cc9860a4df4bb5c2b90ebeea8bf6a31283c58b7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027 # BSD"},{"line_number":6,"context_line":"sphinxcontrib-actdiag\u003e\u003d0.8.5 # BSD"},{"line_number":7,"context_line":"sphinxcontrib-seqdiag\u003e\u003d0.8.4 # BSD"},{"line_number":8,"context_line":"sphinx-feature-classification\u003e\u003d0.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_45671626","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":59},"updated":"2019-12-16 15:48:58.000000000","message":"...but we have to keep this qualifier on this line, for now.","commit_id":"ece3422ecd67a0c35660dac5deab38c24f3a0959"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9718dda1d89d3a614079fd5ff99c4a3aa603e97f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,\u003c2.0.0;python_version\u003d\u003d\u00272.7\u0027 # BSD"},{"line_number":5,"context_line":"sphinx!\u003d1.6.6,!\u003d1.6.7,\u003e\u003d1.6.2,!\u003d2.1.0;python_version\u003e\u003d\u00273.4\u0027 # BSD"},{"line_number":6,"context_line":"sphinxcontrib-actdiag\u003e\u003d0.8.5 # BSD"},{"line_number":7,"context_line":"sphinxcontrib-seqdiag\u003e\u003d0.8.4 # BSD"},{"line_number":8,"context_line":"sphinx-feature-classification\u003e\u003d0.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_672faff5","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":59},"in_reply_to":"3fa7e38b_45671626","updated":"2019-12-17 02:51:59.000000000","message":"Yes, it looks like this is in progress in https://review.opendev.org/#/c/698960/1/openstack_requirements/check.py","commit_id":"ece3422ecd67a0c35660dac5deab38c24f3a0959"}],"test-requirements.txt":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7cc9860a4df4bb5c2b90ebeea8bf6a31283c58b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":9,"context_line":"psycopg2\u003e\u003d2.6.2; sys_platform!\u003d\u0027darwin\u0027 # LGPL/ZPL"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6; sys_platform!\u003d\u0027darwin\u0027 # MIT License"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_e57722d1","side":"PARENT","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":52},"updated":"2019-12-16 15:48:58.000000000","message":"Seems sad that this had to be undone. Do we know why? (I mean, \"the job fails if we don\u0027t,\" sure; but why does it fail, and is there no other way to make it work?)","commit_id":"3eab6acb65456c6c162af36f7cfeed31553dc6d2"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"532ab21223fddfbf1be0007fbed8c514a4f15db7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":9,"context_line":"psycopg2\u003e\u003d2.6.2; sys_platform!\u003d\u0027darwin\u0027 # LGPL/ZPL"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6; sys_platform!\u003d\u0027darwin\u0027 # MIT License"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_08284b83","side":"PARENT","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":52},"in_reply_to":"3fa7e38b_27221704","updated":"2019-12-17 08:11:41.000000000","message":"[later] Since I didn\u0027t want to put such a specific mitigation to requirements check, or because I\u0027m not sure if it is good to port this condition to global-requirements.txt, I left this in the latest PS.","commit_id":"3eab6acb65456c6c162af36f7cfeed31553dc6d2"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9718dda1d89d3a614079fd5ff99c4a3aa603e97f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":9,"context_line":"psycopg2\u003e\u003d2.6.2; sys_platform!\u003d\u0027darwin\u0027 # LGPL/ZPL"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6; sys_platform!\u003d\u0027darwin\u0027 # MIT License"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_27221704","side":"PARENT","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":52},"in_reply_to":"3fa7e38b_e57722d1","updated":"2019-12-17 02:51:59.000000000","message":"Technically I think we (check-requirements) can mitigate the equivalent check [1] to allow projects to add platform conditions.\n\nInstitutionally,  I guess we also can, can\u0027t we?\n\n[1] https://github.com/openstack/requirements/blob/698b571749982f61e65814ca3de489177c14d30e/openstack_requirements/check.py#L96-L103","commit_id":"3eab6acb65456c6c162af36f7cfeed31553dc6d2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bc5cd6487bfe30b6807d21ed4ea375b273b0f4b5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":9,"context_line":"psycopg2\u003e\u003d2.7 # LGPL/ZPL"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_8316b549","line":9,"updated":"2020-01-07 23:02:05.000000000","message":"Coming back to this.\n\nHow about we add a NOTE here acknowledging the problem these cause on osx, referencing Ic0ff55f00e0312251207fd079cf7b7e98d950c87, explaining why we can\u0027t keep that, and indicating how local users can work around it by adding the sys_platform qualifier?","commit_id":"592f6ab484eebe2ead81bd60a5167fd2dc21b911"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"e7333d04e1c9a5b1334625de331b946f22636699","unresolved":false,"context_lines":[{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":8,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":9,"context_line":"psycopg2\u003e\u003d2.7 # LGPL/ZPL"},{"line_number":10,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.4.0 # Apache-2.0"},{"line_number":12,"context_line":"stestr\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_bcc3ce89","line":9,"in_reply_to":"3fa7e38b_8316b549","updated":"2020-01-08 06:52:19.000000000","message":"Good call. Done.","commit_id":"592f6ab484eebe2ead81bd60a5167fd2dc21b911"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6876f76ec7ef58219431d81e97c4972d9a1e1782","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# NOTE(tetsuro): Local testing on osx may have problems to install packages,"},{"line_number":10,"context_line":"# psycopg2 and PYMySQL. You can workaround them using sys_platform qualifier."},{"line_number":11,"context_line":"# See the https://review.opendev.org/#/c/671249/ for details. However, we"},{"line_number":12,"context_line":"# don\u0027t use it here to keep the consistency with global requirements."},{"line_number":13,"context_line":"psycopg2\u003e\u003d2.7 # LGPL/ZPL"},{"line_number":14,"context_line":"PyMySQL\u003e\u003d0.7.6 # MIT License"},{"line_number":15,"context_line":"oslotest\u003e\u003d3.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"3fa7e38b_08de550f","line":12,"updated":"2020-01-08 19:12:18.000000000","message":"++ nice","commit_id":"4e58f8a56b1f78f8ab2f96fb6c8e64e88c651fc3"}]}