)]}'
{"placement/policies/inventory.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"136f1f99dda57d82f58a0756982324e929de9cc4","unresolved":true,"context_lines":[{"line_number":48,"context_line":"deprecated_delete_inventory \u003d policy.DeprecatedRule("},{"line_number":49,"context_line":"    name\u003dDELETE,"},{"line_number":50,"context_line":"    check_str\u003dbase.RULE_ADMIN_API"},{"line_number":51,"context_line":")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"rules \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"bdc3172d_787e41ac","line":51,"updated":"2021-01-21 17:23:33.000000000","message":"As with previous comment RE: ordering. Again, not a serious issue","commit_id":"b4d288aec062e77a65547c360e91863ff00b6b52"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9d150cadf035596a4539be1d51dfb1d549b653a0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"deprecated_delete_inventory \u003d policy.DeprecatedRule("},{"line_number":49,"context_line":"    name\u003dDELETE,"},{"line_number":50,"context_line":"    check_str\u003dbase.RULE_ADMIN_API"},{"line_number":51,"context_line":")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"rules \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"f639c5f8_2e4f7937","line":51,"in_reply_to":"bdc3172d_787e41ac","updated":"2021-01-22 01:26:07.000000000","message":"Done","commit_id":"b4d288aec062e77a65547c360e91863ff00b6b52"}],"placement/tests/functional/gabbits/inventory-legacy-rbac.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4d47c07abd8f5e3adaa0a676beafb97f9e2d09ca","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    x-project-id: *project_id"},{"line_number":18,"context_line":"    accept: application/json"},{"line_number":19,"context_line":"    content-type: application/json"},{"line_number":20,"context_line":"    openstack-api-version: placement latest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tests:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0d10ce13_1f498557","line":20,"updated":"2021-01-26 14:42:17.000000000","message":"Full disclosure - we\u0027re missing the coverage for system-admin, system-reader, and project-reader that gmann wants included in these tests.\n\nEach patch leading up to this one has it. Implementing coverage for those additional personas was giving me 409s, so I hadn\u0027t groked the placement API correctly or something.","commit_id":"7a2a5de6498b0ee4c03ee3ad7410d30bd1b1737b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f6c8035806fc28c8a601653b4a5350d01e726b0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    x-project-id: *project_id"},{"line_number":18,"context_line":"    accept: application/json"},{"line_number":19,"context_line":"    content-type: application/json"},{"line_number":20,"context_line":"    openstack-api-version: placement latest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tests:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fb6b0d06_e1cf1e42","line":20,"in_reply_to":"0d10ce13_1f498557","updated":"2021-01-26 15:03:03.000000000","message":"I imagine you didn\u0027t use a different project and resource provider UUID for each test? If so, that\u0027s going to cause conflicts since everything in a single YAML file runs sequentially in the same environment. If we want to do this then I guess you either need to ensure you delete the resource provider before creating a new one (I don\u0027t think placement uses soft delete so you should be able to use the same UUID after the RP is deleted), or you\u0027ll need to use separate variables. For the latter, you can either configure these in the fixture (see the existing \u0027os.environ\u0027 configuration) or simply use hardcoded UUIDs (with a comment about why you\u0027re doing that, ideally). You could also split these into multiple YAML files but that seems rather tedious?","commit_id":"7a2a5de6498b0ee4c03ee3ad7410d30bd1b1737b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"10847e5b66faec5435992e28a687e9dfdb6e7df0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    x-project-id: *project_id"},{"line_number":18,"context_line":"    accept: application/json"},{"line_number":19,"context_line":"    content-type: application/json"},{"line_number":20,"context_line":"    openstack-api-version: placement latest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tests:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"adca4f93_5db59741","line":20,"in_reply_to":"85c9944c_e81622bc","updated":"2021-01-27 16:42:40.000000000","message":"same nova did what you tried in \u0027Another approach\u0027, in nova unit tests I operated the all persona in single tests on same resource to avoid such 409. did that work?","commit_id":"7a2a5de6498b0ee4c03ee3ad7410d30bd1b1737b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"73bd0e7d53f1af4a645d747810c2602b4a6ab395","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    x-project-id: *project_id"},{"line_number":18,"context_line":"    accept: application/json"},{"line_number":19,"context_line":"    content-type: application/json"},{"line_number":20,"context_line":"    openstack-api-version: placement latest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tests:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"85c9944c_e81622bc","line":20,"in_reply_to":"fb6b0d06_e1cf1e42","updated":"2021-01-26 15:14:54.000000000","message":"The 409s were rather persistent. At that point I started trying to clean up everything in the test and recreate the RP from scratch, which still didn\u0027t work.\n\nAnother thing I\u0027m doing is testing operations in batches (e.g., test that system-admin can create inventories, test that system-reader cannot create inventories, etc.) Another approach I was going to try was setting up the RP then exhaustively testing all operations for a single persona before moving on to the next persona. \n\nWorst case we can break things into separate files for each persona. But, I do agree that seems tedious.","commit_id":"7a2a5de6498b0ee4c03ee3ad7410d30bd1b1737b"}]}