)]}'
{"doc/source/admin/upgrade-notes.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88906b0ff646ef545eec3e31fd8a28678faa4586","unresolved":true,"context_lines":[{"line_number":72,"context_line":"* The placement server side settings in ``nova.conf`` should be moved to a"},{"line_number":73,"context_line":"  separate placement configuration file ``placement.conf``."},{"line_number":74,"context_line":"* The default configuration value of ``[placement]/policy_file`` is changed"},{"line_number":75,"context_line":"  from ``placement-policy.yaml`` to ``policy.yaml`` (This config option is"},{"line_number":76,"context_line":"  changed to :oslo.config:option:`oslo_policy.policy_file` since Train"},{"line_number":77,"context_line":"  release)."},{"line_number":78,"context_line":"* Several tables in the ``nova_api`` database need to be migrated to a new"}],"source_content_type":"text/x-rst","patch_set":4,"id":"494570a7_e4da4a49","line":75,"range":{"start_line":75,"start_character":52,"end_line":75,"end_character":53},"updated":"2020-12-16 10:21:59.000000000","message":"drop the () as it is important information","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b70f276e21fb54c853c9d45f2ef5ea965cdd3800","unresolved":false,"context_lines":[{"line_number":72,"context_line":"* The placement server side settings in ``nova.conf`` should be moved to a"},{"line_number":73,"context_line":"  separate placement configuration file ``placement.conf``."},{"line_number":74,"context_line":"* The default configuration value of ``[placement]/policy_file`` is changed"},{"line_number":75,"context_line":"  from ``placement-policy.yaml`` to ``policy.yaml`` (This config option is"},{"line_number":76,"context_line":"  changed to :oslo.config:option:`oslo_policy.policy_file` since Train"},{"line_number":77,"context_line":"  release)."},{"line_number":78,"context_line":"* Several tables in the ``nova_api`` database need to be migrated to a new"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5b4620f2_5894ffd2","line":75,"range":{"start_line":75,"start_character":52,"end_line":75,"end_character":53},"in_reply_to":"494570a7_e4da4a49","updated":"2020-12-16 16:56:58.000000000","message":"Done","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"}],"doc/source/admin/upgrade-to-stein.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88906b0ff646ef545eec3e31fd8a28678faa4586","unresolved":true,"context_lines":[{"line_number":122,"context_line":"   * If it exists, move ``/etc/nova/placement-policy.yaml`` to"},{"line_number":123,"context_line":"     ``/etc/placement/policy.yaml``. If you wish to use a different filename"},{"line_number":124,"context_line":"     adjust :oslo.config:option:`oslo_policy.policy_file` ("},{"line_number":125,"context_line":"     `placement.policy_file` before Train release)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#. Configure the database migration tool."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"4962b6eb_7dee4924","line":125,"updated":"2020-12-16 10:21:59.000000000","message":"This stain upgrade doc. So I\u0027m not sure we need to talk about Train here","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b70f276e21fb54c853c9d45f2ef5ea965cdd3800","unresolved":true,"context_lines":[{"line_number":122,"context_line":"   * If it exists, move ``/etc/nova/placement-policy.yaml`` to"},{"line_number":123,"context_line":"     ``/etc/placement/policy.yaml``. If you wish to use a different filename"},{"line_number":124,"context_line":"     adjust :oslo.config:option:`oslo_policy.policy_file` ("},{"line_number":125,"context_line":"     `placement.policy_file` before Train release)."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#. Configure the database migration tool."},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"b61c30f8_e44602bb","line":125,"in_reply_to":"4962b6eb_7dee4924","updated":"2020-12-16 16:56:58.000000000","message":"yeah, same I thought while updating it. done","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d9303b71b46deccc892494509b5b3bf95c57eff","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"   * If it exists, move ``/etc/nova/placement-policy.yaml`` to"},{"line_number":123,"context_line":"     ``/etc/placement/policy.yaml``. If you wish to use a different filename"},{"line_number":124,"context_line":"     adjust config option [oslo.config].placement.policy_file."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#. Configure the database migration tool."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"8a9fed83_e23f6a59","line":124,"range":{"start_line":124,"start_character":26,"end_line":124,"end_character":60},"updated":"2020-12-21 18:05:01.000000000","message":"This doesn\u0027t look right. Does\n\n  :oslo.config:option:`oslo_policy.policy_file`\n\nnot work? If not, perhaps try\n\n  ``[oslo_policy] policy_file``\n\nLater: actually, I see you did the former in the previous file so this should work just fine.","commit_id":"93843423b6b0c034b924a070c7f1729c4caa6389"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e7ef887718575b7f5024121e4309ee2566d024a","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"   * If it exists, move ``/etc/nova/placement-policy.yaml`` to"},{"line_number":123,"context_line":"     ``/etc/placement/policy.yaml``. If you wish to use a different filename"},{"line_number":124,"context_line":"     adjust config option [oslo.config].placement.policy_file."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#. Configure the database migration tool."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"90f8d07c_8b1ab599","line":124,"range":{"start_line":124,"start_character":26,"end_line":124,"end_character":60},"in_reply_to":"8a9fed83_e23f6a59","updated":"2020-12-21 18:13:15.000000000","message":"As noted on IRC, this is the stein upgrade doc so we actually want to reference the old config option. We can\u0027t keep using the role since it no longer exists, so we want this to read:\n\n  ``[placement] policy_file``","commit_id":"93843423b6b0c034b924a070c7f1729c4caa6389"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ed3ba1a161e1e49554bc246d427dc8dc68fe99fd","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"   * If it exists, move ``/etc/nova/placement-policy.yaml`` to"},{"line_number":123,"context_line":"     ``/etc/placement/policy.yaml``. If you wish to use a different filename"},{"line_number":124,"context_line":"     adjust config option [oslo.config].placement.policy_file."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#. Configure the database migration tool."},{"line_number":127,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"f5773bb1_a679b185","line":124,"range":{"start_line":124,"start_character":26,"end_line":124,"end_character":60},"in_reply_to":"90f8d07c_8b1ab599","updated":"2020-12-21 18:13:33.000000000","message":"Done","commit_id":"93843423b6b0c034b924a070c7f1729c4caa6389"}],"placement/policy.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88906b0ff646ef545eec3e31fd8a28678faa4586","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        _ENFORCER \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def init(conf, policy_file\u003dNone):"},{"line_number":37,"context_line":"    \"\"\"Init an Enforcer class. Sets the _ENFORCER global.\"\"\""},{"line_number":38,"context_line":"    global _ENFORCER"},{"line_number":39,"context_line":"    if not _ENFORCER:"}],"source_content_type":"text/x-python","patch_set":4,"id":"55678509_1cc34676","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":31},"updated":"2020-12-16 10:21:59.000000000","message":"Is this used outside of the unit test?","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b70f276e21fb54c853c9d45f2ef5ea965cdd3800","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        _ENFORCER \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def init(conf, policy_file\u003dNone):"},{"line_number":37,"context_line":"    \"\"\"Init an Enforcer class. Sets the _ENFORCER global.\"\"\""},{"line_number":38,"context_line":"    global _ENFORCER"},{"line_number":39,"context_line":"    if not _ENFORCER:"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc63c38f_1d08c403","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":31},"in_reply_to":"55678509_1cc34676","updated":"2020-12-16 16:56:58.000000000","message":"not as of no, only in tests.","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e3104c866f2c8e4502536ca2a534302f3671f7ee","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        _ENFORCER \u003d None"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def init(conf, policy_file\u003dNone):"},{"line_number":37,"context_line":"    \"\"\"Init an Enforcer class. Sets the _ENFORCER global.\"\"\""},{"line_number":38,"context_line":"    global _ENFORCER"},{"line_number":39,"context_line":"    if not _ENFORCER:"}],"source_content_type":"text/x-python","patch_set":4,"id":"926b3fac_a47ba7e8","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":31},"in_reply_to":"cc63c38f_1d08c403","updated":"2020-12-16 17:02:13.000000000","message":"the it seems like an unnecessary change to me. Those test could be changed to call policy.Enforcer() directly instead of calling init()","commit_id":"d7612dc7fbef10bb18001f719bf13115c33017c1"}]}