)]}'
{"id":"openstack%2Fplacement~772335","triplet_id":"openstack%2Fplacement~master~I69fe451a4e27ce52e8af01c63a38b5c2c748de38","project":"openstack/placement","branch":"master","topic":"secure-rbac","hashtags":[],"change_id":"I69fe451a4e27ce52e8af01c63a38b5c2c748de38","subject":"WIP: Add fix for fixture","status":"ABANDONED","created":"2021-01-25 12:41:05.000000000","updated":"2021-01-26 13:00:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"04a24a9036a7dc266ec43244f034e8e0643edeb2","_number":772335,"virtual_id_number":772335,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-01-25 18:17:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-25 12:42:35.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2021-01-25 13:40:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ed05ce8e69f29b92ff4718e2accfdfda28bb9875","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 12:41:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"25ba201bc1d548d90e9a19d01a2bf2a3cd717874","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 12:42:35.000000000","message":"Patch Set 1:\n\n@lbragstad: This should fix your issue with the policy fixture. Feel free to roll this into your base patch or rework things as you see fit","accounts_in_message":[],"_revision_number":1},{"id":"7b914cd4090af0ee113c057bf5b1d885a6a0eeee","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 12:42:43.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"e329f4b1668c01c0476e5073e853c7a54a73353e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-25 13:40:36.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8326915ba32045278fe265648d69cb44 : FAILURE in 6m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ae20c30277554fbca17c10199bc10c2b : FAILURE in 6m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fcbb7de7b0ce455c8bce5fe796bdccfd : SUCCESS in 5m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fb36ee5398924f80bcd38e33860b172d : FAILURE in 8m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/640c506028e94becb471611631bbfa6f : FAILURE in 6m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/11cf7ca495ad4df6ab286673a856a102 : FAILURE in 5m 57s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/97620ae6500a48f88500e1e0cbfd31dc : SUCCESS in 12m 41s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/315ddbe5e81c432ca02a480dbe0a9b0c : FAILURE in 6m 31s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/181fc3d8cf584ed18af7b63bfc80f783 : FAILURE in 6m 28s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/6afd68bd7a1a444a856f538ee9ef3476 : FAILURE in 7m 49s\n- placement-nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/0ecd1d57ac5746519e26ba4370f2a5a7 : SUCCESS in 18m 56s","accounts_in_message":[],"_revision_number":1},{"id":"3b45ce7e06f8f3dd54a49381c1b502227a291f50","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 14:43:15.000000000","message":"Patch Set 1:\n\nWeird. If I run this test by itself then the issue goes away, but if you run it as one test then it fails. Something isn\u0027t isolated","accounts_in_message":[],"_revision_number":1},{"id":"c9b1c1de267a7c635a5f287fc393a9b50cbea8bf","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 17:04:49.000000000","message":"Patch Set 1:\n\nOkay, I\u0027m stuck with this. I\u0027ve tried a couple of things and ending up focusing on the global \u0027CONF\u0027 value in \u0027placement/tests/functional/fixtures/gabbits.py\u0027 and trying to make it less global (mainly variations of making it a dict and using the \u0027PROJECT_ID\u0027 os.environ variable as a key to retrieve the correct config). There\u0027s something bleeding across but I can\u0027t isolate it outside of disabling concurrency in the test runner, which doesn\u0027t seem like much of a strategy. I\u0027ll keep trying, but skipping the failing test seems more and more preferable /o\\","accounts_in_message":[],"_revision_number":1},{"id":"8eec1612b05a8d16aa24a7524d76846af328866b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-01-25 17:32:00.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"07e1a726147b9d45cc17feba7d8bc00db81d0d00","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-25 17:47:46.000000000","message":"Patch Set 2:\n\nFurther evidence of this from lbragstad from #openstack-nova just now\n\nhttp://paste.openstack.org/show/801955/","accounts_in_message":[],"_revision_number":2},{"id":"7adec0a362ef76b882d5942884223d5c87e38917","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-25 18:17:59.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/073071d25c5f406bb9c7ec128160854d : FAILURE in 6m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8bb275a5349c434a9d17c5c81ba7b762 : FAILURE in 9m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ce83ba94a16e4902a806f0b7d5ac6a70 : SUCCESS in 4m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/11301416695a472d9139e3953d5dc2ef : SUCCESS in 5m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d56371abe45f47e686c56d5137e73564 : SUCCESS in 6m 35s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b0ae4e9f42ef41c6983fd003e697dcf1 : SUCCESS in 6m 13s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/13c3ff4aeccb44229d95e1b7703c2bdb : SUCCESS in 8m 30s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8b237f5d5ec54ba7a3c03a12e00042f7 : FAILURE in 6m 12s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/726cf4f8f4c640f8b213397237332567 : FAILURE in 5m 38s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/20dc59dcb85b47e491a34bfde1f82ad4 : FAILURE in 5m 58s\n- placement-nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/e5175cf4e37e4f52ae1d91a5532ffcd7 : SUCCESS in 22m 45s","accounts_in_message":[],"_revision_number":2},{"id":"04a24a9036a7dc266ec43244f034e8e0643edeb2","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-26 13:00:22.000000000","message":"Abandoned\n\nThis is squashed into the first policy patch of the series now","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0477e59adf43b7938bb156ee30a2506206893c63","revisions":{"93c8b7813d3da294a74f3cef327c573cf963b230":{"kind":"REWORK","_number":1,"created":"2021-01-25 12:41:05.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/35/772335/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/35/772335/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772335/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772335/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772335/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/35/772335/1"}}},"commit":{"parents":[{"commit":"0a46f6d89602111061d2b88df25437543a71b8dd","subject":"policy: Deprecate \u0027admin_api\u0027 rule","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0a46f6d89602111061d2b88df25437543a71b8dd"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-25 12:34:16.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-25 12:40:45.000000000","tz":0},"subject":"WIP: Add fix for fixture","message":"WIP: Add fix for fixture\n\nWe have a timing issue with the current design of the\n\u0027SecureRBACPolicyFixture\u0027. We initialize the policy fixture as part of\nthe parent \u0027APIFixture\u0027 fixture\u0027s \u0027setUp\u0027 call. We then, in the child\nfixture, modify the configuration. As the policy engine is already\nconfigured, this configuration does nothing.\n\nWe could reload the policy engine or split the \u0027setUp\u0027 function into\nmultiple other functions that we could override, but the simplest\napproach is to simply move the logic into the parent \u0027APIFixture\u0027 and\nconfigure this by way of a class variable.\n\nChange-Id: I69fe451a4e27ce52e8af01c63a38b5c2c748de38\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/93c8b7813d3da294a74f3cef327c573cf963b230"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/93c8b7813d3da294a74f3cef327c573cf963b230"}]},"branch":"refs/heads/master"},"0477e59adf43b7938bb156ee30a2506206893c63":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-01-25 17:32:00.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/35/772335/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/35/772335/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772335/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772335/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772335/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/35/772335/2"}}},"commit":{"parents":[{"commit":"b976af1f3a7645be9088cb29251ea00ac30c19d0","subject":"policy: Deprecate \u0027admin_api\u0027 rule","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/b976af1f3a7645be9088cb29251ea00ac30c19d0"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-25 12:34:16.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@redhat.com","date":"2021-01-25 17:32:00.000000000","tz":0},"subject":"WIP: Add fix for fixture","message":"WIP: Add fix for fixture\n\nWe have a timing issue with the current design of the\n\u0027SecureRBACPolicyFixture\u0027. We initialize the policy fixture as part of\nthe parent \u0027APIFixture\u0027 fixture\u0027s \u0027setUp\u0027 call. We then, in the child\nfixture, modify the configuration. As the policy engine is already\nconfigured, this configuration does nothing.\n\nWe could reload the policy engine or split the \u0027setUp\u0027 function into\nmultiple other functions that we could override, but the simplest\napproach is to simply move the logic into the parent \u0027APIFixture\u0027 and\nconfigure this by way of a class variable.\n\nChange-Id: I69fe451a4e27ce52e8af01c63a38b5c2c748de38\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0477e59adf43b7938bb156ee30a2506206893c63"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/0477e59adf43b7938bb156ee30a2506206893c63"}]},"branch":"refs/heads/master","description":"Rebase"}},"requirements":[],"submit_records":[],"submit_requirements":[]}