)]}'
{"id":"openstack%2Fplacement~772508","triplet_id":"openstack%2Fplacement~master~Ib864606d4cf4a8ecba95386bcc2b8a4bb68f2d17","project":"openstack/placement","branch":"master","topic":"secure-rbac","hashtags":[],"change_id":"Ib864606d4cf4a8ecba95386bcc2b8a4bb68f2d17","subject":"policy: Don\u0027t persist default rule changes in tests","status":"MERGED","created":"2021-01-26 12:24:34.000000000","updated":"2021-02-03 18:36:29.000000000","submitted":"2021-02-03 18:36:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"772508-secure-rbac","meta_rev_id":"d399f6e886cd0b46677f2bf0b654b089a672ed1b","_number":772508,"virtual_id_number":772508,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-03 18:36:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"recommended":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":1,"date":"2021-02-03 18:36:29.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2021-02-03 18:36:29.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2021-02-02 19:01:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-03 18:36:29.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":1,"date":"2021-02-02 19:01:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"reviewers":{"REVIEWER":[{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-26 13:01:03.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2021-01-26 13:01:03.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2021-01-26 13:01:03.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2021-01-26 14:58:12.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-26 19:32:01.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"CC"},{"updated":"2021-01-26 23:18:46.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2021-01-27 19:11:19.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"}],"messages":[{"id":"d81030bf848bc2e79c4d115aa23bc03e05897885","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-26 12:24:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8260ac27bf7afc46fac5569095e9b865697a0bb5","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2021-01-26 13:03:20.000000000","message":"Patch Set 1: Code-Review+2\n\nCrikey. Good sleuthing.\n\nI agree the right place to fix this is oslo.policy, but this is a good workaround that ought not break when/if op is improved.","accounts_in_message":[],"_revision_number":1},{"id":"ac25d7c7442dd6b9febaf922ab8b08154e14de97","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-01-26 14:32:48.000000000","message":"Patch Set 1: Code-Review+1\n\nNice find. I should make a note to ensure other projects are using a similar technique until we have an opportunity to think through oslo.policy changes.","accounts_in_message":[],"_revision_number":1},{"id":"bacef14c372ac561442dd6eee256b4015ae5898f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-26 14:58:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/2f06f2290c6847bd878016252d720eb5 : SUCCESS in 1h 03m 39s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/ff1b07e2a8b54300a3e2044f70862b30 : SUCCESS in 1h 16m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b76594f6e7f845a3ac78e486226387ba : SUCCESS in 7m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/352c0a7f6e704c8b9c5a8bef5158a3cf : SUCCESS in 5m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9dacc636deea46c693cbba792f75a1c5 : SUCCESS in 4m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/49906334068248eb906fca085b7c213a : SUCCESS in 4m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/51fa9238c12f4853bf371e0976f33a87 : SUCCESS in 6m 07s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/407557f6c59840aeaf3fb438a1ceff51 : SUCCESS in 5m 41s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/31c9bc393356455fb76b96cb5fc8e9ff : SUCCESS in 7m 06s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/749afa595f694a81bbd6b79da5af69f3 : SUCCESS in 4m 46s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/97077929119941a4a8639504ffc88a15 : SUCCESS in 7m 23s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/faa66998d07641579cbaeae9559a283f : SUCCESS in 5m 16s\n- placement-nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/feb3d48709e34a60b3598e8a6cc16cbe : SUCCESS in 14m 46s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/7f35a34b407b4cefb8459ac66fbee2c8 : SUCCESS in 23m 16s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/5199d89ee310457fada9574e3f39c638 : SUCCESS in 10m 32s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0af61849dfd94bef8b03062a69edfeeb : SUCCESS in 1h 01m 18s","accounts_in_message":[],"_revision_number":1},{"id":"317ff6626be33a98effef173801cd9f87c8b02e4","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-01-26 19:32:01.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"97d9dd439b16485ee9fb72830648b37bf2a2c064","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-01-26 23:18:46.000000000","message":"Patch Set 1: Code-Review+1\n\n(3 comments)\n\ni think this is correct but without playing with this in an interperter and poking at the global state i cant tell if its a double copy or not.\n\nthis should fix at least this instance of global state sharing.","accounts_in_message":[],"_revision_number":1},{"id":"b5b639fc6e5d386623a4d114e35b28938f4e736b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-27 13:40:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cd2c8f6992fe39103d35edd944ab3aa8d82c3ff8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-01-27 17:35:11.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"9c88f0dd0736121c683b482bcba6f297d1da9aef","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-01-27 19:11:19.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI am not against of this change but we need to modify the note/cmt msg with it is best practice and can be fixed in oslo.policy to be more protective/safer if any future change (where oslo.policy start modifying the self.check_str) can cause the issue.","accounts_in_message":[],"_revision_number":2},{"id":"e8f8946d565434e8ca6f233d76e7ea4f179a81eb","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-27 21:24:43.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bed227c6103f416b5a2404012687d8e9e59aace9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-27 23:38:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/65b6ebbb195d4e9bafde32975a459fe7 : SUCCESS in 1h 05m 22s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/7b2d4ace3bc24d5994dec0eb1d112245 : SUCCESS in 1h 36m 17s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8af5c510e6074d45aa21fcda9622d106 : SUCCESS in 6m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b7df6d9854e64e72b8be27ec39d82233 : SUCCESS in 7m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3f4d8308b104402da86db6dd11ff3d59 : SUCCESS in 4m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/244498cc03a5472095193024154d7846 : SUCCESS in 4m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/713dfb9a76cd4bfe9e080fdd65f3dc92 : SUCCESS in 6m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/172ad62406d34984b4bff69c7ad4b93f : SUCCESS in 7m 13s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77dd433572e2477096d4399d797c6012 : SUCCESS in 7m 30s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6a7ad6028d1a406bb040254d4cb60997 : SUCCESS in 4m 53s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/902fa0a51e1049c9ad9f9b587ea3204d : SUCCESS in 5m 49s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/fe4c996795bc489798b5fd27c3349ce1 : SUCCESS in 5m 19s\n- placement-nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/9a51bb6ce5ee44d9934485b09a42a9ff : SUCCESS in 16m 13s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/859d6c53081849a09d78d6c1b3b04ab7 : SUCCESS in 22m 25s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/a1afd753d5c54281aa4d0b76ffc180e5 : SUCCESS in 11m 30s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4947836cf8e74a0b998cfb1c18833d77 : SUCCESS in 1h 01m 28s","accounts_in_message":[],"_revision_number":2},{"id":"818a1a15e766222a5b93bf7ddc1a58b7a7c22b89","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2021-01-28 12:49:14.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e I am not against of this change but we need to modify the note/cmt msg with it is best practice and can be fixed in oslo.policy to be more protective/safer if any future change (where oslo.policy start modifying the self.check_str) can cause the issue.\n\n\n\nwe can proably fix oslo.policy to make the copy of the rules internally yes\n\nthe other thing we can do in placement the current list_rules methods do the deep copy so that we never retrun pointers ot hte globals just a copy of them.\n\nthat however can be expensive at runtime where we dont expect rules to be modified.\nthis really is only an issue with tests","accounts_in_message":[],"_revision_number":2},{"id":"4868694eb9761ea51b193a0088cee839e781f59b","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-02-02 19:01:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)\n\nlgtm,","accounts_in_message":[],"_revision_number":2},{"id":"a9fbe5495325feff065359be54f02e62249ca96a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 16:19:10.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"769d595ae98a78135c31dcf958de799f8721789a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 18:36:21.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/1df107c89f8844aca05ff7d0b04d5f38 : SUCCESS in 56m 58s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/a9b7263ec5dc4a31aa6659293ef9fe02 : SUCCESS in 1h 15m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e7064d886a8f4d658fa1fc0bfc567981 : SUCCESS in 9m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2ec0b41b7deb401e9c5f7f8091e58e1d : SUCCESS in 6m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7838697c0b5d4b31a5adb922abea2b2a : SUCCESS in 6m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fbe18448ab044d748822e9f1686a29cd : SUCCESS in 4m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5277aaa183274bd8898a921e90b79195 : SUCCESS in 8m 59s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/44b86e466acd405fa8bcccf7246a1e65 : SUCCESS in 5m 34s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/56f2741c69c94ea1863787ebd86c90be : SUCCESS in 5m 36s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/20c956488f1944759440ba9d62a74cb6 : SUCCESS in 5m 58s\n- placement-nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/cb4feeec211c4b50b863dd401483ec5d : SUCCESS in 13m 59s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/985925cb8a474519805ce461d4027368 : SUCCESS in 59m 05s","accounts_in_message":[],"_revision_number":2},{"id":"cb56dc00dc6a6f415f838488b0e9c6282aa19c6b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 18:36:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f9f65994724d7b054e79bdd5fb53415b72e28dc9","revisions":{"c22a19a326a511383e34eed3a8297adfd59fe83e":{"kind":"REWORK","_number":1,"created":"2021-01-26 12:24:34.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/08/772508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/08/772508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/08/772508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/08/772508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/08/772508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/08/772508/1"}}},"commit":{"parents":[{"commit":"eabeb71619056224155b44750bfd5d96f594645e","subject":"policy: Suppress policy deprecation warnings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/eabeb71619056224155b44750bfd5d96f594645e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-26 11:24:23.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-26 11:55:38.000000000","tz":0},"subject":"policy: Don\u0027t persist default rule changes in tests","message":"policy: Don\u0027t persist default rule changes in tests\n\n\u0027oslo.policy\u0027 expects a list of default rules be provided when\ninitialising the enforcer. Unfortunately, it demonstrates a nasty habit\nof modifying these defaults once it has them [1]. This can result in\nconfiguration from one test bleeding through to the next.\n\nResolve this by initialising the enforcer with a copy of the default\nrules, rather than the originals, allowing \u0027oslo.policy\u0027 to do whatever\nit likes to the rules. Ultimately this should probably be fixed in\n\u0027oslo.policy\u0027, which should be either copying the defaults or creating\nnew rules based on these defaults, but that needs some thought and can\nbe done later.\n\n[1] https://github.com/openstack/oslo.policy/blob/3.6.0/oslo_policy/policy.py#L762-L764\n\nChange-Id: Ib864606d4cf4a8ecba95386bcc2b8a4bb68f2d17\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2008556\nTask: 41687\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c22a19a326a511383e34eed3a8297adfd59fe83e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/c22a19a326a511383e34eed3a8297adfd59fe83e"}]},"branch":"refs/heads/master"},"f9f65994724d7b054e79bdd5fb53415b72e28dc9":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-01-27 17:35:11.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/08/772508/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/08/772508/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/08/772508/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/08/772508/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/08/772508/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/08/772508/2"}}},"commit":{"parents":[{"commit":"069583c3cfb58fd283916d1ccd563746b6db1114","subject":"policy: Suppress policy deprecation warnings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/069583c3cfb58fd283916d1ccd563746b6db1114"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-01-26 11:24:23.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-01-27 16:55:20.000000000","tz":0},"subject":"policy: Don\u0027t persist default rule changes in tests","message":"policy: Don\u0027t persist default rule changes in tests\n\n\u0027oslo.policy\u0027 expects a list of default rules be provided when\ninitialising the enforcer. Unfortunately, it demonstrates a nasty habit\nof modifying these defaults once it has them [1]. This can result in\nconfiguration from one test bleeding through to the next.\n\nResolve this by initialising the enforcer with a copy of the default\nrules, rather than the originals, allowing \u0027oslo.policy\u0027 to do whatever\nit likes to the rules. Ultimately this should probably be fixed in\n\u0027oslo.policy\u0027, which should be either copying the defaults or creating\nnew rules based on these defaults, but that needs some thought and can\nbe done later.\n\n[1] https://github.com/openstack/oslo.policy/blob/3.6.0/oslo_policy/policy.py#L762-L764\n\nChange-Id: Ib864606d4cf4a8ecba95386bcc2b8a4bb68f2d17\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nStory: 2008556\nTask: 41687\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f9f65994724d7b054e79bdd5fb53415b72e28dc9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f9f65994724d7b054e79bdd5fb53415b72e28dc9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}