)]}'
{"id":"openstack%2Fplacement~772535","triplet_id":"openstack%2Fplacement~master~I698c1a54334cccfe1827f7d81af76fde667e1bac","project":"openstack/placement","branch":"master","topic":"secure-rbac","hashtags":[],"change_id":"I698c1a54334cccfe1827f7d81af76fde667e1bac","subject":"trivial: Remove TODO in LegacyRBACPolicyFixture","status":"ABANDONED","created":"2021-01-26 14:49:33.000000000","updated":"2021-01-27 17:22:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9dd1d37f30537a69b18ad8c140d8f7f2b52e7e31","_number":772535,"virtual_id_number":772535,"owner":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-01-26 18:31:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2021-01-26 15:03:29.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-26 15:03:29.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-01-26 18:31:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"10358ac2fa94d6a5488d94c2b4fd15f0485f0e08","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-01-26 14:49:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"054a334310f8a539e6ecd605a5dfdb0c73ec5680","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-01-26 15:03:29.000000000","message":"Patch Set 1: Code-Review+2\n\nYup, sensible","accounts_in_message":[],"_revision_number":1},{"id":"29baeeeb8082452c86efd5eaf5310b874c32728e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-26 18:31:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/16aa6c616172472c9009c68a1071991a : SUCCESS in 6m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f15fe254cfd54c9fbc4559ba85ed904b : SUCCESS in 7m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/561e4fdc2ac24d9790f579abe40cd3fb : SUCCESS in 5m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/85c8129c16b1436c9b655036a9ccead0 : SUCCESS in 5m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/199dd07204344269afa9f430b09459d4 : SUCCESS in 7m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/60c11d8c14914979842ee3e549faf2d4 : SUCCESS in 7m 03s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/018c95ac4421488cb54f12cf549a5c59 : SUCCESS in 9m 09s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f18cbf005df64f28b4dbccc93a50c989 : SUCCESS in 6m 41s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/ff8176c66a0044ffbb38326f12aa8da6 : SUCCESS in 7m 28s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c1bc83f8fa314214b0436eacf49e5299 : SUCCESS in 5m 46s\n- placement-nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/03f1661d6afe4a95abc9cd4f77b55d36 : SUCCESS in 15m 14s","accounts_in_message":[],"_revision_number":1},{"id":"6479a9cdaae3e35c92f9801ca144866f9238df5b","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-01-27 17:22:29.000000000","message":"Patch Set 1:\n\nI had to rebase https://review.opendev.org/c/openstack/placement/+/760240/21 anyway, so I rolled this change into it.","accounts_in_message":[],"_revision_number":1},{"id":"9dd1d37f30537a69b18ad8c140d8f7f2b52e7e31","tag":"autogenerated:gerrit:abandon","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-01-27 17:22:36.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"be3d94cb08d75b0cdde9631e465d848a4667cc91","revisions":{"be3d94cb08d75b0cdde9631e465d848a4667cc91":{"kind":"REWORK","_number":1,"created":"2021-01-26 14:49:33.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/35/772535/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/35/772535/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772535/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772535/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/35/772535/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/35/772535/1"}}},"commit":{"parents":[{"commit":"54f4198ce0b019cdc2e3de56e90f0c11d48efb7a","subject":"policy: Deprecate \u0027admin_api\u0027 rule","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/54f4198ce0b019cdc2e3de56e90f0c11d48efb7a"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-01-26 14:45:33.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-01-26 14:45:33.000000000","tz":0},"subject":"trivial: Remove TODO in LegacyRBACPolicyFixture","message":"trivial: Remove TODO in LegacyRBACPolicyFixture\n\nWe originally made a TODO to remove the fixture and just use the\nAPIFixture directly for testing the legacy RBAC scenario. But, keeping\nthe fixture around to be explicit is nice to have and very clear\nregarding its purpose.\n\nWe can remove this once the defaults are updated in oslo.policy directly\nand the deprecated policies are removed from placement.\n\nChange-Id: I698c1a54334cccfe1827f7d81af76fde667e1bac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/be3d94cb08d75b0cdde9631e465d848a4667cc91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/be3d94cb08d75b0cdde9631e465d848a4667cc91"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
