)]}'
{"placement/handlers/resource_provider.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6d09917c103d74f6983efe8ab7876a8a8ccd54f1","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            elif column \u003d\u003d \u0027uniq_resource_providers0name\u0027:"},{"line_number":122,"context_line":"                duplicates.append(f\u0027name: {data[\"name\"]}\u0027)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                duplicates.append(f\u0027{column}: {data[column]}\u0027)"},{"line_number":125,"context_line":"        raise webob.exc.HTTPConflict("},{"line_number":126,"context_line":"            \u0027Conflicting resource provider %(duplicate)s already exists.\u0027 %"},{"line_number":127,"context_line":"            {\u0027duplicate\u0027: \u0027, \u0027.join(duplicates)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca3fe7fd_1ce7a490","line":124,"updated":"2021-03-25 19:49:18.000000000","message":"Hmm, I wonder if there\u0027s a more streamlined way to do this, like maybe:\n\n duplicate \u003d \u0027, \u0027.join(\n     [\u0027%s: %s\u0027 % (key, data[key]) for key in data if key in str(exc.columns)])","commit_id":"ba8228eb048f8be442aa16a8ffec291794b22430"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1a228f040b4a043c078510c278d7dd6e486e4125","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            elif column \u003d\u003d \u0027uniq_resource_providers0name\u0027:"},{"line_number":122,"context_line":"                duplicates.append(f\u0027name: {data[\"name\"]}\u0027)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                duplicates.append(f\u0027{column}: {data[column]}\u0027)"},{"line_number":125,"context_line":"        raise webob.exc.HTTPConflict("},{"line_number":126,"context_line":"            \u0027Conflicting resource provider %(duplicate)s already exists.\u0027 %"},{"line_number":127,"context_line":"            {\u0027duplicate\u0027: \u0027, \u0027.join(duplicates)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"7996a2a3_36e341df","line":124,"in_reply_to":"0a018aa5_5f20fc9f","updated":"2021-03-26 08:59:41.000000000","message":"It also relies on us using a specific naming convention, which isn\u0027t guaranteed. If we\u0027re going to hard code something, it might as well be the specific constraint names rather than the far more abstract constraint naming convention, IMO","commit_id":"ba8228eb048f8be442aa16a8ffec291794b22430"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d5d9adf37caba722dea286b998fe3cc505367f6d","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            elif column \u003d\u003d \u0027uniq_resource_providers0name\u0027:"},{"line_number":122,"context_line":"                duplicates.append(f\u0027name: {data[\"name\"]}\u0027)"},{"line_number":123,"context_line":"            else:"},{"line_number":124,"context_line":"                duplicates.append(f\u0027{column}: {data[column]}\u0027)"},{"line_number":125,"context_line":"        raise webob.exc.HTTPConflict("},{"line_number":126,"context_line":"            \u0027Conflicting resource provider %(duplicate)s already exists.\u0027 %"},{"line_number":127,"context_line":"            {\u0027duplicate\u0027: \u0027, \u0027.join(duplicates)},"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a018aa5_5f20fc9f","line":124,"in_reply_to":"ca3fe7fd_1ce7a490","updated":"2021-03-26 02:18:58.000000000","message":"\u003e Hmm, I wonder if there\u0027s a more streamlined way to do this, like maybe:\n\u003e \n\u003e  duplicate \u003d \u0027, \u0027.join(\n\u003e      [\u0027%s: %s\u0027 % (key, data[key]) for key in data if key in str(exc.columns)])\n\nNevermind, please disregard ^. I realized this wouldn\u0027t work right if columns are subsets of one another like \u0027host\u0027 vs \u0027hostname\u0027.","commit_id":"ba8228eb048f8be442aa16a8ffec291794b22430"}]}