)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"87b49aa068500019f1d3da1ad114d4658f218dee","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adapt to SQLAlchemy 1.4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do to stricter validation in 1.4 we need to fix a query in placement"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"See https://github.com/sqlalchemy/sqlalchemy/issues/6429"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"440e2118_3d9d6a10","line":9,"updated":"2021-05-05 16:24:54.000000000","message":"s/Do/Due/","commit_id":"b9b90fa881c958bfab8824ac3c11a5e8deab2354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"db54d02ce97d099f0d18b084f163733163a8932c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adapt to SQLAlchemy 1.4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do to stricter validation in 1.4 we need to fix a query in placement"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"See https://github.com/sqlalchemy/sqlalchemy/issues/6429"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"192c8565_6737933b","line":9,"in_reply_to":"440e2118_3d9d6a10","updated":"2021-05-06 07:37:10.000000000","message":"Done","commit_id":"b9b90fa881c958bfab8824ac3c11a5e8deab2354"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2ede145bd3fb6ea5b28b750f7d8ba8c898de95d6","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to stricter validation in 1.4 we need to fix a query in placement"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"See https://github.com/sqlalchemy/sqlalchemy/issues/6429"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib0ee1ed0aca494146a0499a61726445ffa7bc9be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a56a6a7_76fecf81","line":11,"updated":"2021-05-18 09:23:55.000000000","message":"thanks for asking this.","commit_id":"680182dddc3ae979e9a9c99d7c0e54d95e880645"}],"placement/objects/resource_provider.py":[{"author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"76a41ac602deb32ed96f2f0137910f2f3140d21d","unresolved":true,"context_lines":[{"line_number":510,"context_line":"    subq_1 \u003d context.session.query(_RP_TBL.c.id)"},{"line_number":511,"context_line":"    subq_1 \u003d subq_1.filter(_RP_TBL.c.root_provider_id.is_(None))"},{"line_number":512,"context_line":"    subq_1 \u003d subq_1.limit(batch_size)"},{"line_number":513,"context_line":"    subq_1 \u003d sa.alias(subq_1, name\u003d\"subq_1\")"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    subq_2 \u003d sa.select([subq_1.c.id]).select_from(subq_1)"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da960563_0e1ad177","line":513,"updated":"2021-05-05 16:47:44.000000000","message":"this is an ORM Query object so should be:\n\n    subq_1 \u003d subq_1.subquery(name\u003d\"subq_1\")","commit_id":"b9b90fa881c958bfab8824ac3c11a5e8deab2354"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"92963bb2b0e897d0e3a1ed564d6e42099023cb26","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    subq_1 \u003d context.session.query(_RP_TBL.c.id)"},{"line_number":511,"context_line":"    subq_1 \u003d subq_1.filter(_RP_TBL.c.root_provider_id.is_(None))"},{"line_number":512,"context_line":"    subq_1 \u003d subq_1.limit(batch_size)"},{"line_number":513,"context_line":"    subq_1 \u003d sa.alias(subq_1, name\u003d\"subq_1\")"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    subq_2 \u003d sa.select([subq_1.c.id]).select_from(subq_1)"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d023fd09_ed4c20e5","line":513,"in_reply_to":"da960563_0e1ad177","updated":"2021-05-06 07:37:00.000000000","message":"Done","commit_id":"b9b90fa881c958bfab8824ac3c11a5e8deab2354"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2ede145bd3fb6ea5b28b750f7d8ba8c898de95d6","unresolved":true,"context_lines":[{"line_number":510,"context_line":"    subq_1 \u003d context.session.query(_RP_TBL.c.id)"},{"line_number":511,"context_line":"    subq_1 \u003d subq_1.filter(_RP_TBL.c.root_provider_id.is_(None))"},{"line_number":512,"context_line":"    subq_1 \u003d subq_1.limit(batch_size)"},{"line_number":513,"context_line":"    subq_1 \u003d subq_1.subquery(name\u003d\"subq_1\")"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    subq_2 \u003d sa.select([subq_1.c.id]).select_from(subq_1)"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b14ededc_7acee588","line":513,"updated":"2021-05-18 09:23:55.000000000","message":"this doesn\u0027t change the usage. LGTM.","commit_id":"680182dddc3ae979e9a9c99d7c0e54d95e880645"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e972b88c7d4c9d75881113563489fdbbdb86c4c","unresolved":true,"context_lines":[{"line_number":510,"context_line":"    subq_1 \u003d context.session.query(_RP_TBL.c.id)"},{"line_number":511,"context_line":"    subq_1 \u003d subq_1.filter(_RP_TBL.c.root_provider_id.is_(None))"},{"line_number":512,"context_line":"    subq_1 \u003d subq_1.limit(batch_size)"},{"line_number":513,"context_line":"    subq_1 \u003d subq_1.subquery(name\u003d\"subq_1\")"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    subq_2 \u003d sa.select([subq_1.c.id]).select_from(subq_1)"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"be47a082_0cdd397e","line":513,"in_reply_to":"b14ededc_7acee588","updated":"2021-05-18 10:32:22.000000000","message":"yep this is what zzzeek recommended \nhttps://github.com/sqlalchemy/sqlalchemy/issues/6429#issuecomment-832847372\nso this looks good to me.","commit_id":"680182dddc3ae979e9a9c99d7c0e54d95e880645"}]}
