)]}'
{"placement/tests/functional/db/test_allocation.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0825ead443d19711ae940326310e11b38b44af75","unresolved":true,"context_lines":[{"line_number":734,"context_line":"        # transaction can fetch the Project created by a racing transaction"},{"line_number":735,"context_line":"        ex \u003d self.assertRaises("},{"line_number":736,"context_line":"            sqla_exc.InvalidRequestError,"},{"line_number":737,"context_line":"            allocation._set_allocations_for_consumer_same_transaction,"},{"line_number":738,"context_line":"            self.context,"},{"line_number":739,"context_line":"            uuidsentinel.consumer1,"},{"line_number":740,"context_line":"            req_data,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bc5f471_b5c03717","line":737,"range":{"start_line":737,"start_character":23,"end_line":737,"end_character":69},"updated":"2021-09-01 17:32:12.000000000","message":"Hm, thinking about this more, if the fix ends up removing the _set_allocations_for_consumer_same_transaction, then this test won\u0027t be able to verify the fix this way. I don\u0027t know yet if it will be removed but just wanted to note it here in case anyone has thoughts.","commit_id":"039b36024dd5b7e2f7e913119c4476e6d3c4c861"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"200052315413bab8c1e5cf962d8741c568316205","unresolved":true,"context_lines":[{"line_number":722,"context_line":"                \u0027consumer_type\u0027: \u0027INSTANCE\u0027,"},{"line_number":723,"context_line":"            }"},{"line_number":724,"context_line":"        }"},{"line_number":725,"context_line":"        req1.body \u003d json.dumps(body1).encode(\u0027utf-8\u0027)"},{"line_number":726,"context_line":"        ctx1 \u003d context.RequestContext("},{"line_number":727,"context_line":"            user_id\u003duuidsentinel.user1, project_id\u003duuidsentinel.project1,"},{"line_number":728,"context_line":"            roles\u003d[\u0027admin\u0027], system_scope\u003d\u0027all\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"93ac75e0_21a47e7b","line":725,"updated":"2021-09-02 09:23:09.000000000","message":"we could use oslo_serialize.jsonutils.dumps_as_bytes() but meh here, it\u0027s the placement repo.","commit_id":"2786060fac6aaa9db26409305ed357e7800396cc"}],"placement/tests/functional/test_allocation.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f45a1c0424ed883e9437b61e4e76112ff6764291","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    project in the same transaction which is inactive due to the previous"},{"line_number":30,"context_line":"    \u0027Duplicate entry\u0027 error."},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(TestAllocationProjectCreateRace, self).setUp()"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Create resource provider and inventory for tests"}],"source_content_type":"text/x-python","patch_set":4,"id":"90d6dded_32877b6e","line":32,"updated":"2021-09-03 14:54:05.000000000","message":"++","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f45a1c0424ed883e9437b61e4e76112ff6764291","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Create resource provider and inventory for tests"},{"line_number":36,"context_line":"        conf \u003d self.conf_fixture.conf"},{"line_number":37,"context_line":"        rp_data \u003d jsonutils.dump_as_bytes({"},{"line_number":38,"context_line":"            \u0027name\u0027: \u0027a provider\u0027,"},{"line_number":39,"context_line":"            \u0027uuid\u0027: uuids.rp,"},{"line_number":40,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":4,"id":"4e19c8a0_2c043606","line":37,"updated":"2021-09-03 14:54:05.000000000","message":"thanks, we create an oslo dependency but meh.","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"31c257d5aa72c30e71c6c80b6ab84dbb0e8861aa","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Create resource provider and inventory for tests"},{"line_number":36,"context_line":"        conf \u003d self.conf_fixture.conf"},{"line_number":37,"context_line":"        rp_data \u003d jsonutils.dump_as_bytes({"},{"line_number":38,"context_line":"            \u0027name\u0027: \u0027a provider\u0027,"},{"line_number":39,"context_line":"            \u0027uuid\u0027: uuids.rp,"},{"line_number":40,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ea61b83_b8953f1d","line":37,"in_reply_to":"4e19c8a0_2c043606","updated":"2021-09-03 16:28:07.000000000","message":"It looks like placement already contains dependency on oslo.serialization before this. Did you mean something else?","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f45a1c0424ed883e9437b61e4e76112ff6764291","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            # Create a resource provider"},{"line_number":56,"context_line":"            url \u003d \u0027/resource_providers\u0027"},{"line_number":57,"context_line":"            resp \u003d client.post(url, data\u003drp_data, headers\u003dself.headers)"},{"line_number":58,"context_line":"            self.assertEqual(200, resp.status_code)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            # Add inventory to the resource provider"},{"line_number":61,"context_line":"            url \u003d \u0027/resource_providers/%s/inventories\u0027 % uuids.rp"}],"source_content_type":"text/x-python","patch_set":4,"id":"6d3c4072_081c6a8e","line":58,"updated":"2021-09-03 14:54:05.000000000","message":"++","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f45a1c0424ed883e9437b61e4e76112ff6764291","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        real_get_project \u003d project_obj.Project.get_by_external_id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        def fake_get_project(cls, ctx, external_id):"},{"line_number":72,"context_line":"            if not hasattr(fake_get_project, \u0027called\u0027):"},{"line_number":73,"context_line":"                proj \u003d project_obj.Project(ctx, external_id\u003dexternal_id)"},{"line_number":74,"context_line":"                proj.create()"},{"line_number":75,"context_line":"                fake_get_project.called \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"16050da0_7b814982","line":72,"updated":"2021-09-03 14:54:05.000000000","message":"better indeed.","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f45a1c0424ed883e9437b61e4e76112ff6764291","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            # Create allocations"},{"line_number":139,"context_line":"            url \u003d \u0027/allocations\u0027"},{"line_number":140,"context_line":"            resp \u003d client.post(url, data\u003dalloc_data, headers\u003dself.headers)"},{"line_number":141,"context_line":"            self.assertEqual(204, resp.status_code)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def test_reshape(self):"},{"line_number":144,"context_line":"        alloc_data \u003d jsonutils.dump_as_bytes({"}],"source_content_type":"text/x-python","patch_set":4,"id":"50f3036f_c618ca58","line":141,"updated":"2021-09-03 14:54:05.000000000","message":"ok, so given we mock in the setUp method, we call again the right method for the first call so here we don\u0027t get the issue.","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f45a1c0424ed883e9437b61e4e76112ff6764291","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            # Create allocations"},{"line_number":174,"context_line":"            url \u003d \u0027/reshaper\u0027"},{"line_number":175,"context_line":"            resp \u003d client.post(url, data\u003dalloc_data, headers\u003dself.headers)"},{"line_number":176,"context_line":"            self.assertEqual(204, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5c0b4c9c_a015e86d","line":176,"updated":"2021-09-03 14:54:05.000000000","message":"ditto","commit_id":"8b000867ca50ca99877fe8819785918aa6f58764"}]}