)]}'
{"id":"openstack%2Fplacement~825501","triplet_id":"openstack%2Fplacement~master~Idc367df609dc8d4874fc329f2317c582b9e06a4d","project":"openstack/placement","branch":"master","topic":"story/2009795","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2022-08-04 07:55:12.000000000","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change","reason_account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2022-08-04 08:31:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idc367df609dc8d4874fc329f2317c582b9e06a4d","subject":"Clarify trait filtering in the API doc","status":"MERGED","created":"2022-01-20 13:28:14.000000000","updated":"2022-08-04 08:33:06.000000000","submitted":"2022-08-04 08:31:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"825501-story/2009795","meta_rev_id":"aa266ee677b27eccec4f57e351637baf6c9a59c1","_number":825501,"virtual_id_number":825501,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-08-04 08:31:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2022-08-04 07:55:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2022-08-04 02:14:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},{"value":2,"date":"2022-08-03 17:50:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2022-08-04 07:55:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-20 13:42:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-20 13:57:38.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2022-08-03 17:50:27.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-08-04 02:14:56.000000000","updated_by":{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},"reviewer":{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},"state":"REVIEWER"}],"messages":[{"id":"0a3816cb2706e842076b9aab3bf02213bd24568a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-01-20 13:28:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cc1aee6eff6f58c11a58977b25847311120d2538","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-01-20 13:42:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/9738f02c4205493997f2735c138c72e2 : SUCCESS in 5m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bc6923b088944e10ac3f993cb210a8b0 : SUCCESS in 5m 45s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cecaed5f6cf04ff8828a28e7f84432aa : SUCCESS in 8m 29s","accounts_in_message":[],"_revision_number":1},{"id":"f2ac4affbacae44be9574f59d419a1cb7b8c61f0","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-01-20 13:57:38.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"157d0f72db9beb262addf702c054fc1b04f39b23","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-01-24 12:18:32.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"59b988f7f5456ce842d7ced8340dc6e1ac749ea7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-03 13:22:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"718c7853918bd14da5c857d82af6149ea3998b25","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-03 13:22:32.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"15dedd722304cbb569f2dac4e71ba25d33c9aede","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-03 13:36:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/800ba17be06b43d5b06dca46d34dcf59\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/43520575ef8047bd947f825b1052c1cc : SUCCESS in 4m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b9a7df766d154b56940e1aa3f6519cac : SUCCESS in 5m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e7d828ea8be8415d83e6050f423592c7 : SUCCESS in 7m 21s","accounts_in_message":[],"_revision_number":2},{"id":"c39acbe8c12325c4e9ba0673cbbd9a8f5463da7d","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-08-03 17:50:27.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"ded6a72675a994c61e0ba4335f6554dc56e83194","author":{"_account_id":33493,"name":"chenwei","display_name":"chenwei","email":"jzpcoming@163.com","username":"chenwei"},"date":"2022-08-04 02:14:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"11a6056f9518928e9834f7d3a6df0b94a4c1942e","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-04 07:55:12.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"823a94feb78d4f829b09c6f9890d50eaafbba750","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 07:55:38.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"912c0f189efe4026963e8f4f6d61562c18f6971f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 08:31:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c641a2c5439642209d029e2bb5244956\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/2ac02ca649be47c3a3d2d732ba961028 : SUCCESS in 7m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9db7b2242e5a4b53a0a4ef9d4cae7e5d : SUCCESS in 4m 59s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3da403bd807340caa3a27b9c77e5e5df : SUCCESS in 7m 48s","accounts_in_message":[],"_revision_number":2},{"id":"1c2b025e9a49e00ee2fbb78c8ce33e77c513ff97","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 08:31:51.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"aa266ee677b27eccec4f57e351637baf6c9a59c1","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-04 08:33:06.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4232411fa8444d8ca9c645ede8c1705e\n\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/ef41596eec8b47449d1bd2f0e24e2b2d : SUCCESS in 48s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4620278e77aa4d598470028973db00f7 : SUCCESS in 49s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"11644979641eb98e336e0e1a40f43301ec5bcb83","revisions":{"89603d6e4c23d68a08760e704b867b6ea9b04452":{"kind":"REWORK","_number":1,"created":"2022-01-20 13:28:14.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/01/825501/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/01/825501/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/825501/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/825501/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/825501/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/01/825501/1"}}},"commit":{"parents":[{"commit":"d48d22ff24535eb5ae947d60fd87a9afb2e7b45d","subject":"Merge \"Spec: support mixing required traits with any traits\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/d48d22ff24535eb5ae947d60fd87a9afb2e7b45d"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2022-01-20 13:18:51.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2022-01-20 13:18:51.000000000","tz":60},"subject":"Clarify trait filtering in the API doc","message":"Clarify trait filtering in the API doc\n\nBased on the spec[1], the user doc[2] and the implementation[3][4]\nthe original intention of trait filtering during allocation\ncandidate query is that the required traits in the unnamed group\nneeds to be provided by the resource providers contributing resources\nto the candidate. So traits on RPs which are in the tree of the\ncandidate but not providing resource to the candidate should be ignored.\n\nThe current API doc is not clear on this and can be misunderstood. So\nthis patch clarifies that doc.\n\n[1] https://docs.openstack.org/placement/latest/specs/train/implemented/2005575-nested-magic-1.html\n[2] https://docs.openstack.org/placement/latest/user/provider-tree.html#filtering-by-traits\n[3] https://github.com/openstack/placement/blob/d48d22ff24535eb5ae947d60fd87a9afb2e7b45d/placement/objects/research_context.py#L745\n[4] https://github.com/openstack/placement/blob/d48d22ff24535eb5ae947d60fd87a9afb2e7b45d/placement/tests/functional/db/test_allocation_candidates.py#L817-L827\n\nStory: #2009795\nTask: #44334\nChange-Id: Idc367df609dc8d4874fc329f2317c582b9e06a4d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/89603d6e4c23d68a08760e704b867b6ea9b04452"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/89603d6e4c23d68a08760e704b867b6ea9b04452"}]},"branch":"refs/heads/master"},"11644979641eb98e336e0e1a40f43301ec5bcb83":{"kind":"REWORK","_number":2,"created":"2022-08-03 13:22:06.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/01/825501/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/01/825501/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/825501/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/825501/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/01/825501/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/01/825501/2"}}},"commit":{"parents":[{"commit":"eb95805e943d542dc89301a286add12de03d66e2","subject":"Merge \"Update placement for os-traits 2.8.0 release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/eb95805e943d542dc89301a286add12de03d66e2"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2022-01-20 13:18:51.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-08-03 13:21:45.000000000","tz":120},"subject":"Clarify trait filtering in the API doc","message":"Clarify trait filtering in the API doc\n\nBased on the spec[1], the user doc[2] and the implementation[3][4]\nthe original intention of trait filtering during allocation\ncandidate query is that the required traits in the unnamed group\nneeds to be provided by the resource providers contributing resources\nto the candidate. So traits on RPs which are in the tree of the\ncandidate but not providing resource to the candidate should be ignored.\n\nThe current API doc is not clear on this and can be misunderstood. So\nthis patch clarifies that doc.\n\n[1] https://docs.openstack.org/placement/latest/specs/train/implemented/2005575-nested-magic-1.html\n[2] https://docs.openstack.org/placement/latest/user/provider-tree.html#filtering-by-traits\n[3] https://github.com/openstack/placement/blob/d48d22ff24535eb5ae947d60fd87a9afb2e7b45d/placement/objects/research_context.py#L745\n[4] https://github.com/openstack/placement/blob/d48d22ff24535eb5ae947d60fd87a9afb2e7b45d/placement/tests/functional/db/test_allocation_candidates.py#L817-L827\n\nStory: #2009795\nTask: #44334\nChange-Id: Idc367df609dc8d4874fc329f2317c582b9e06a4d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/11644979641eb98e336e0e1a40f43301ec5bcb83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/11644979641eb98e336e0e1a40f43301ec5bcb83"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}