)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a692bd6b73b7682b2c0236fa1b1202cb3c21a00b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"686ebab9_94f398a4","updated":"2022-02-08 21:47:58.000000000","message":"Looks good","commit_id":"2d2a8ce7c9ed3291bbbdb6ef0d26fead118406e2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c0aa871281199b2a7f11e0eca6bf82f7f6186df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b99438ca_62848504","updated":"2022-02-08 17:02:52.000000000","message":"recheck bug 1959677","commit_id":"2d2a8ce7c9ed3291bbbdb6ef0d26fead118406e2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"60bc560a8ca8e6d6ecfa682ab929747cd1a60023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"060b184b_40fe86fc","updated":"2022-02-16 15:12:12.000000000","message":"this is strait forward and looks good to me","commit_id":"2d2a8ce7c9ed3291bbbdb6ef0d26fead118406e2"}],"placement/objects/allocation_candidate.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d96d3fcc366e4406148590916b5f4934e1d1b85a","unresolved":true,"context_lines":[{"line_number":102,"context_line":"                # a quick return, but we leave that to future patches for"},{"line_number":103,"context_line":"                # now."},{"line_number":104,"context_line":"                trait_rps \u003d res_ctx.get_provider_ids_having_any_trait("},{"line_number":105,"context_line":"                    rg_ctx.context, rg_ctx.required_trait_map.values())"},{"line_number":106,"context_line":"                if not trait_rps:"},{"line_number":107,"context_line":"                    return set()"},{"line_number":108,"context_line":"            rp_candidates \u003d res_ctx.get_trees_matching_all(rg_ctx, rw_ctx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b945df3d_48637406","line":105,"updated":"2022-02-07 22:50:23.000000000","message":"Not trying to be nitpicking but get_provider_ids_having_any_trait says traits is a \"set\" but values() is not set-like [1]: \"(Values views are not treated as set-like since the entries are generally not unique.)\"\n\n[1] https://docs.python.org/3.6/library/stdtypes.html?highlight\u003ddict%20values#dict.values","commit_id":"0f9db7ee2b66252856454c368d26b70a1f2bbefe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"36ff869009aef150b9c564869052753dfcd43cf7","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                # a quick return, but we leave that to future patches for"},{"line_number":103,"context_line":"                # now."},{"line_number":104,"context_line":"                trait_rps \u003d res_ctx.get_provider_ids_having_any_trait("},{"line_number":105,"context_line":"                    rg_ctx.context, rg_ctx.required_trait_map.values())"},{"line_number":106,"context_line":"                if not trait_rps:"},{"line_number":107,"context_line":"                    return set()"},{"line_number":108,"context_line":"            rp_candidates \u003d res_ctx.get_trees_matching_all(rg_ctx, rw_ctx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b120b1d2_957595b5","line":105,"in_reply_to":"b945df3d_48637406","updated":"2022-02-08 14:51:07.000000000","message":"You are correct. The doc of the SQLA in_ operator, where this value is used, only brings list examples as parameter type but based on the test results it only depends on an iterable type. \n\nI\u0027m going to change the doc of the get_provider_ids_having_any_trait to ask for an iterable only. Logically we don\u0027t need a set as the IN SQL operator does not assume a unique list on the right side.","commit_id":"0f9db7ee2b66252856454c368d26b70a1f2bbefe"}],"placement/objects/research_context.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d96d3fcc366e4406148590916b5f4934e1d1b85a","unresolved":true,"context_lines":[{"line_number":1079,"context_line":"    have ANY of the supplied traits."},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"    :param ctx: Session context to use"},{"line_number":1082,"context_line":"    :param traits: A set of trait internal IDs, at least one of which each"},{"line_number":1083,"context_line":"        provider must have associated with it."},{"line_number":1084,"context_line":"    :raise ValueError: If traits is empty or None."},{"line_number":1085,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"2394153e_1a09b995","line":1082,"updated":"2022-02-07 22:50:23.000000000","message":"set or iterable maybe? Or maybe that\u0027s too pedantic.","commit_id":"0f9db7ee2b66252856454c368d26b70a1f2bbefe"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"36ff869009aef150b9c564869052753dfcd43cf7","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"    have ANY of the supplied traits."},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"    :param ctx: Session context to use"},{"line_number":1082,"context_line":"    :param traits: A set of trait internal IDs, at least one of which each"},{"line_number":1083,"context_line":"        provider must have associated with it."},{"line_number":1084,"context_line":"    :raise ValueError: If traits is empty or None."},{"line_number":1085,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1b28dd94_a402781d","line":1082,"in_reply_to":"2394153e_1a09b995","updated":"2022-02-08 14:51:07.000000000","message":"changed it to iterable.","commit_id":"0f9db7ee2b66252856454c368d26b70a1f2bbefe"}]}