)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7ee5bde184b354530a35ed3bfe5efb1b21190558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"46eb1091_3a341653","updated":"2022-07-07 13:04:04.000000000","message":"Oh, this is interesting. I wonder if this typo meant that it was possible to provide an empty request (for that field) to the API and it was crash and burn? IMO it would be good to add a small test to validate what happened with microversion 1.36 or later as a result of this bug.","commit_id":"fe27662a8dc05a0b5005c96968acf74579de8da1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dd5056fb778964fb9f5c7b20fe63a509f3cc6496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cfcbed2e_814a079e","in_reply_to":"0b28ae5f_f5993430","updated":"2022-07-11 11:59:53.000000000","message":"placement doesn\u0027t really use unit tests. Instead, it uses functional tests with gabbi [1]. These are yaml-formatted tests. You can find them in the \u0027placement/tests/functional/gabbits\u0027 directory. I think you\u0027d want to extend the file in \u0027placement/tests/functional/gabbits/allocations-mappings.yaml\u0027\n\n[1] https://gabbi.readthedocs.io/en/latest/","commit_id":"fe27662a8dc05a0b5005c96968acf74579de8da1"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f768bf69d41417f21096d8de7a49fafe6c38b326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b28ae5f_f5993430","in_reply_to":"46eb1091_3a341653","updated":"2022-07-11 10:24:32.000000000","message":"Thanks for review, but I don\u0027t see any unit test module in placement repo for this schema module.\n\nI haven\u0027t added unit tests for whole module so not sure how could I do that ?\n\nCould you provide any reference which I can follow ?","commit_id":"fe27662a8dc05a0b5005c96968acf74579de8da1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c2cc33622c21cb8fd788e79fd3e55a990e83cf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b1efa9c8_79e7a0fe","in_reply_to":"cfcbed2e_814a079e","updated":"2022-07-11 12:10:02.000000000","message":"For example https://review.opendev.org/c/openstack/placement/+/849348","commit_id":"fe27662a8dc05a0b5005c96968acf74579de8da1"}]}