)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6d9cc53720b620195c1260bac6b977b6f6a67b0","unresolved":true,"context_lines":[{"line_number":13,"context_line":" * resource_providers.uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Story: 2010251"},{"line_number":16,"context_line":"Task: 46118"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia834a991edf8f21ee9bea7f97399cd6c003b54e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e9ee58f7_c9ddd68a","line":16,"updated":"2023-02-25 10:54:39.000000000","message":"we have tecnially swapped back to launchpad for placement by the way but this is fine.\n\nhttps://bugs.launchpad.net/placement","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4c7659161e0e04970099e3e53b04e73b7755ad4f","unresolved":false,"context_lines":[{"line_number":13,"context_line":" * resource_providers.uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Story: 2010251"},{"line_number":16,"context_line":"Task: 46118"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia834a991edf8f21ee9bea7f97399cd6c003b54e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d30a6d00_76c5d8b3","line":16,"in_reply_to":"e9ee58f7_c9ddd68a","updated":"2023-02-27 15:43:54.000000000","message":"Ack","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1780441_d34b5262","updated":"2023-02-23 16:18:07.000000000","message":"Can you remove the downgrade steps? This otherwise seems fine.\n\nIs there any way to flag these warnings in CI via a warnings filter?","commit_id":"aa86380268aca93203bb0612f2782a9db01df1be"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"f4148554c745cce4e9b5909a570880010d4008b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e897ea06_f9299d88","updated":"2023-02-23 13:17:34.000000000","message":"May I kindly ask if you could take a look at this?","commit_id":"aa86380268aca93203bb0612f2782a9db01df1be"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"eb00a7f9fa15efc450b316727571be6cb6f08f3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4cfb8730_323abd32","updated":"2023-03-27 13:57:15.000000000","message":"Could you kindly take another peek at this with RC1 now merged?","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1f52b8322abc247b33b37063c0f0068a9bb0adc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a9e177d7_61c91e4d","updated":"2023-02-27 12:18:28.000000000","message":"Holding off +W until gibi\u0027s had a look or we\u0027re past branching for Antelope","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d61c405988d1f53968a16975d121f4060e3de94e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"788ee04e_01303899","updated":"2023-03-01 09:33:17.000000000","message":"I\u0027m OK with this patch but as said, let\u0027s not make RC1 delivery as risk and wait for https://review.opendev.org/c/openstack/releases/+/875452 to be merged so this patch would be merged on master after branching 2023.1 Antelope.\n","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7500050cd1dc798b65e80780e41425515f40b786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f978e4b_6572d704","updated":"2023-04-12 07:24:14.000000000","message":"LGTM","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8d1410c604161bf4bbc9f732700f22a8e7f8b2ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bfb303ce_b3fa34f1","updated":"2023-04-12 07:59:29.000000000","message":"Now, we\u0027re now in Bobcat so +W.","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4ffd6e077dc7e416aee230d66e6811c9bd4307af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a2960d19_e14dcfd9","updated":"2023-02-24 09:20:04.000000000","message":"Thanks for you quick review. I dropped the downgrade steps now.","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6d9cc53720b620195c1260bac6b977b6f6a67b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0502b892_25471e0d","updated":"2023-02-25 10:54:39.000000000","message":"i think this is fine but it would be nice to fix the missin gunique constratins in a followup. i would be ok backporting the drop of the redundant index but changing form index to unique constrait or adding a unique constarit proably shoudl not be backported so better to keep that in a follow up patch.\n\nstephen gibi does ^ that logic makes sense.\n\nChristain if you dont have time to adress that can you file a launchpad bug for the follow up  UniqueConstraint work.","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a8ee7850236f86cd88e762e5c053f595819682a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cae905b2_6cab996a","updated":"2023-02-27 12:20:26.000000000","message":"i think we are branching for RC1 on thrusday so we should wait until after that is done.","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4c7659161e0e04970099e3e53b04e73b7755ad4f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e3796c7_ffc342b4","in_reply_to":"0502b892_25471e0d","updated":"2023-02-27 15:43:54.000000000","message":"I certainly could, but you seem to have a clear approach on cleaning this up, maybe you should write that one. I certainly would then change the code and push another change ...","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"}],"placement/db/sqlalchemy/alembic/versions/a082b8bb98d0_drop_redundant_indexes_for_unique_.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                    [\u0027resource_provider_id\u0027, \u0027resource_class_id\u0027],"},{"line_number":53,"context_line":"                    unique\u003dFalse)"},{"line_number":54,"context_line":"    op.create_index(\u0027inventories_resource_provider_id_idx\u0027,"},{"line_number":55,"context_line":"                    \u0027inventories\u0027, [\u0027resource_provider_id\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2aa323f_13c0683f","line":55,"updated":"2023-02-23 16:18:07.000000000","message":"We don\u0027t support downgrades in any OpenStack service. Can you drop this?","commit_id":"aa86380268aca93203bb0612f2782a9db01df1be"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"4ffd6e077dc7e416aee230d66e6811c9bd4307af","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    [\u0027resource_provider_id\u0027, \u0027resource_class_id\u0027],"},{"line_number":53,"context_line":"                    unique\u003dFalse)"},{"line_number":54,"context_line":"    op.create_index(\u0027inventories_resource_provider_id_idx\u0027,"},{"line_number":55,"context_line":"                    \u0027inventories\u0027, [\u0027resource_provider_id\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a4ae170f_583e44c9","line":55,"in_reply_to":"e2aa323f_13c0683f","updated":"2023-02-24 09:20:04.000000000","message":"Done","commit_id":"aa86380268aca93203bb0612f2782a9db01df1be"}],"placement/db/sqlalchemy/models.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    __tablename__ \u003d \"resource_providers\""},{"line_number":52,"context_line":"    __table_args__ \u003d ("},{"line_number":53,"context_line":"        Index(\u0027resource_providers_uuid_idx\u0027, \u0027uuid\u0027),"},{"line_number":54,"context_line":"        schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_resource_providers0uuid\u0027),"},{"line_number":55,"context_line":"        Index(\u0027resource_providers_name_idx\u0027, \u0027name\u0027),"},{"line_number":56,"context_line":"        Index(\u0027resource_providers_root_provider_id_idx\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc1ae7e8_fdf2eac5","side":"PARENT","line":53,"updated":"2023-02-23 16:18:07.000000000","message":"So this isn\u0027t needed because it\u0027s a primary key...","commit_id":"5ec38f6d3b76619fac442a85a9b5c73dc606b83a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    __table_args__ \u003d ("},{"line_number":53,"context_line":"        Index(\u0027resource_providers_uuid_idx\u0027, \u0027uuid\u0027),"},{"line_number":54,"context_line":"        schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_resource_providers0uuid\u0027),"},{"line_number":55,"context_line":"        Index(\u0027resource_providers_name_idx\u0027, \u0027name\u0027),"},{"line_number":56,"context_line":"        Index(\u0027resource_providers_root_provider_id_idx\u0027,"},{"line_number":57,"context_line":"              \u0027root_provider_id\u0027),"},{"line_number":58,"context_line":"        Index(\u0027resource_providers_parent_provider_id_idx\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"98a5f5e1_25c17660","side":"PARENT","line":55,"updated":"2023-02-23 16:18:07.000000000","message":"...and this has a unique constraint which is an index itself","commit_id":"5ec38f6d3b76619fac442a85a9b5c73dc606b83a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    __tablename__ \u003d \"inventories\""},{"line_number":80,"context_line":"    __table_args__ \u003d ("},{"line_number":81,"context_line":"        Index(\u0027inventories_resource_provider_id_idx\u0027,"},{"line_number":82,"context_line":"              \u0027resource_provider_id\u0027),"},{"line_number":83,"context_line":"        Index(\u0027inventories_resource_class_id_idx\u0027,"},{"line_number":84,"context_line":"              \u0027resource_class_id\u0027),"},{"line_number":85,"context_line":"        Index(\u0027inventories_resource_provider_resource_class_idx\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"83686880_d61257bc","side":"PARENT","line":82,"updated":"2023-02-23 16:18:07.000000000","message":"This is indexed due to the join, I guess","commit_id":"5ec38f6d3b76619fac442a85a9b5c73dc606b83a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        Index(\u0027inventories_resource_class_id_idx\u0027,"},{"line_number":84,"context_line":"              \u0027resource_class_id\u0027),"},{"line_number":85,"context_line":"        Index(\u0027inventories_resource_provider_resource_class_idx\u0027,"},{"line_number":86,"context_line":"              \u0027resource_provider_id\u0027, \u0027resource_class_id\u0027),"},{"line_number":87,"context_line":"        schema.UniqueConstraint("},{"line_number":88,"context_line":"            \u0027resource_provider_id\u0027, \u0027resource_class_id\u0027,"},{"line_number":89,"context_line":"            name\u003d\u0027uniq_inventories0resource_provider_resource_class\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"92f2b787_fa9b28ad","side":"PARENT","line":86,"updated":"2023-02-23 16:18:07.000000000","message":"Unique constraint from below","commit_id":"5ec38f6d3b76619fac442a85a9b5c73dc606b83a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cecd22cd6cdc59bd082c9092ba08dd8a8397cfd9","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    )"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue, autoincrement\u003dTrue)"},{"line_number":154,"context_line":"    uuid \u003d Column(String(36), index\u003dTrue)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"class Trait(BASE):"}],"source_content_type":"text/x-python","patch_set":2,"id":"e63b013e_0a634acf","side":"PARENT","line":154,"updated":"2023-02-23 16:18:07.000000000","message":"Unique constraint","commit_id":"5ec38f6d3b76619fac442a85a9b5c73dc606b83a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6d9cc53720b620195c1260bac6b977b6f6a67b0","unresolved":true,"context_lines":[{"line_number":111,"context_line":"              \u0027resource_class_id\u0027),"},{"line_number":112,"context_line":"        Index(\u0027allocations_consumer_id_idx\u0027, \u0027consumer_id\u0027)"},{"line_number":113,"context_line":"    )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":116,"context_line":"    resource_provider_id \u003d Column(Integer, nullable\u003dFalse)"},{"line_number":117,"context_line":"    consumer_id \u003d Column(String(36), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b3f5d37_f85a6535","line":114,"updated":"2023-02-25 10:54:39.000000000","message":"technially this table is missing a unique constratit\n\nit shoudl be enforceing \n\nschema.UniqueConstraint(resource_provider_id, resource_class_id, consumer_id)\n\nthat is technially a spereate change","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e6d9cc53720b620195c1260bac6b977b6f6a67b0","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    __tablename__ \u003d \"resource_provider_traits\""},{"line_number":167,"context_line":"    __table_args__ \u003d ("},{"line_number":168,"context_line":"        Index(\u0027resource_provider_traits_resource_provider_trait_idx\u0027,"},{"line_number":169,"context_line":"              \u0027resource_provider_id\u0027, \u0027trait_id\u0027),"},{"line_number":170,"context_line":"    )"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f8237874_d19b2448","line":168,"range":{"start_line":168,"start_character":8,"end_line":168,"end_character":13},"updated":"2023-02-25 10:54:39.000000000","message":"this should also be a unique constrait rather then an index","commit_id":"0a8c7c5a9ebaacdbaafd509155474be1781be6fb"}]}