)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7b41b359c4c383e7f183263fde00c716b6e504a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b12fe9c_842e513f","updated":"2023-06-14 21:15:50.000000000","message":"+1 for now as i would like steph too confim if im correct about the new behavior","commit_id":"d00a9fedd532ecde6516d9c35f0d359d40779b2d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"18e1d82c1641ffe89ca4e910dc2f66ae562ade06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70bee9b5_0b2ff1a5","updated":"2023-06-14 23:38:35.000000000","message":"Looks OK to me","commit_id":"d00a9fedd532ecde6516d9c35f0d359d40779b2d"}],"placement/tests/functional/base.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5f563e349a2331b06cc08e23c8e8c10f64cd1858","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            self.conf_fixture.config("},{"line_number":47,"context_line":"                connection\u003d\u0027sqlite://\u0027,"},{"line_number":48,"context_line":"                group\u003d\u0027placement_database\u0027,"},{"line_number":49,"context_line":"            )"},{"line_number":50,"context_line":"        self.conf_fixture.conf([], default_config_files\u003d[])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.useFixture(policy_fixture.PolicyFixture(self.conf_fixture))"}],"source_content_type":"text/x-python","patch_set":1,"id":"b22b0676_c7f28033","line":49,"updated":"2023-06-13 22:56:43.000000000","message":"What is the effect of doing this vs doing nothing if not USES_DB? Will an error be raised if someone writes a NoDBTestCase but then does a database access in the test?","commit_id":"d00a9fedd532ecde6516d9c35f0d359d40779b2d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d9770029857eee2058be53f67852f38034429291","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            self.conf_fixture.config("},{"line_number":47,"context_line":"                connection\u003d\u0027sqlite://\u0027,"},{"line_number":48,"context_line":"                group\u003d\u0027placement_database\u0027,"},{"line_number":49,"context_line":"            )"},{"line_number":50,"context_line":"        self.conf_fixture.conf([], default_config_files\u003d[])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.useFixture(policy_fixture.PolicyFixture(self.conf_fixture))"}],"source_content_type":"text/x-python","patch_set":1,"id":"81de39bb_5b02d265","line":49,"in_reply_to":"01a518f0_051fd01f","updated":"2023-06-14 23:25:42.000000000","message":"Indirectly, yes. By doing this, we don\u0027t create a database and apply a schema so any accesses of the database will fail. We could make this more explicit and poison the database APIs but it\u0027s potentially overkill?","commit_id":"d00a9fedd532ecde6516d9c35f0d359d40779b2d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"18e1d82c1641ffe89ca4e910dc2f66ae562ade06","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            self.conf_fixture.config("},{"line_number":47,"context_line":"                connection\u003d\u0027sqlite://\u0027,"},{"line_number":48,"context_line":"                group\u003d\u0027placement_database\u0027,"},{"line_number":49,"context_line":"            )"},{"line_number":50,"context_line":"        self.conf_fixture.conf([], default_config_files\u003d[])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.useFixture(policy_fixture.PolicyFixture(self.conf_fixture))"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1c0233c_b2642202","line":49,"in_reply_to":"81de39bb_5b02d265","updated":"2023-06-14 23:38:35.000000000","message":"That is what I thought but I wasn\u0027t sure, thanks. I think it\u0027s OK, I just wanted to make sure I understand before +2\u0027ing. We could enhance things to emit a more explicit error if later on it proves to be too opaque.","commit_id":"d00a9fedd532ecde6516d9c35f0d359d40779b2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7b41b359c4c383e7f183263fde00c716b6e504a8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            self.conf_fixture.config("},{"line_number":47,"context_line":"                connection\u003d\u0027sqlite://\u0027,"},{"line_number":48,"context_line":"                group\u003d\u0027placement_database\u0027,"},{"line_number":49,"context_line":"            )"},{"line_number":50,"context_line":"        self.conf_fixture.conf([], default_config_files\u003d[])"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.useFixture(policy_fixture.PolicyFixture(self.conf_fixture))"}],"source_content_type":"text/x-python","patch_set":1,"id":"01a518f0_051fd01f","line":49,"in_reply_to":"b22b0676_c7f28033","updated":"2023-06-14 21:15:50.000000000","message":"so we are setting the connection url to the sqlite protocoal/driver but not passing a file path to use for the db so i would expect this to be a pasrsing error if we actully tried to use the db connection or for it to use an annomous db like the in memory sqlite db backend.\n\ngiven the existing fixture code i would assume this is the former\n\nhttps://github.com/openstack/placement/blob/master/placement/tests/fixtures.py#L41\n\nso we will get a temporay sqlite db\n\nthe delta is the db will be empty since we do not run \n\nhttps://github.com/openstack/placement/blob/master/placement/tests/fixtures.py#L44-L45\n\nso the schma will not ba applied so any opertions on it would fail","commit_id":"d00a9fedd532ecde6516d9c35f0d359d40779b2d"}]}