)]}'
{"id":"openstack%2Fplacement~938939","triplet_id":"openstack%2Fplacement~stable%2F2024.2~I5475c66fa35958b3dc72c3bab7a7edbdf6c89ce6","project":"openstack/placement","branch":"stable/2024.2","topic":"bug/2070257","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-01-21 15:54:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5475c66fa35958b3dc72c3bab7a7edbdf6c89ce6","subject":"Add a global limit on the number of allocation candidates","status":"MERGED","created":"2025-01-10 17:01:34.000000000","updated":"2025-01-21 15:55:43.000000000","submitted":"2025-01-21 15:54:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"938939-bug/2070257","meta_rev_id":"2718d79b883ddc3d16a516a79c578bd1cf5afd5e","_number":938939,"virtual_id_number":938939,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-01-21 15:54:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2025-01-13 14:49:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2025-01-21 13:57:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2025-01-21 13:57:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-10 18:48:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-01-13 14:49:33.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2025-01-21 13:57:38.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"5b5b340651e52aaece73e69ed1cf39e622a4f416","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-01-10 17:01:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"461970fdcbeb68d392d30feb2ab5ffb70290b9f7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-10 18:48:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a27bb588971443abb0117417129c9902\n\n- grenade https://zuul.opendev.org/t/openstack/build/1e16ad996eeb4f1290cd7a41f02f075f : SUCCESS in 57m 06s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/c26e701632ad43b9a4d228f3eac46445 : SUCCESS in 1h 42m 17s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c6a525a2ae9546ec84f435c4b37ded81 : SUCCESS in 1h 08m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e8c18cfd1fb1415388deff8e19960969 : SUCCESS in 10m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af2150a600de4b3b8dc8e8ef726987b4 : SUCCESS in 4m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/59d8a138b5fa43aea3bf7e9abde481a8 : SUCCESS in 4m 55s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/6e69a5f19b58467286bf92b3e9a5f6f9 : SUCCESS in 5m 03s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/95547ddb2c4c4bbca28b1b85582418d8 : SUCCESS in 5m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/32264d96c072407f96289cd00d4701bc : SUCCESS in 6m 56s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/26ce512363fe4290ba8c63beac72b771 : SUCCESS in 6m 04s\n- openstack-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/f041a849fe474c27a230c5d5b274620b : SUCCESS in 6m 34s\n- placement-nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/bf8ba006f7a4419db34115d6418385ab : SUCCESS in 20m 14s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/524f10a6d4094731ad43d1f9bf651a13 : SUCCESS in 16m 51s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/37a002ff2d904c3ab63a7cecdd13544a : FAILURE in 4m 17s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/822395ac36624a058735c3c4a42d892d : SUCCESS in 49m 51s","accounts_in_message":[],"_revision_number":1},{"id":"00ce76082831f6f894782bd52b78daef7617752c","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-01-13 14:49:33.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"40bf063683a5bf5ef8ee214b6784dfe3178dc392","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-01-13 14:51:08.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"de8723b4dad5030f9eecadad515879b18f363405","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-01-21 13:57:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2081f519e1eb86bc1f386412e4bfa456c297b2f7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-21 13:58:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4e944bbb2e6a2d241790487851a97a944e1d3394","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-21 15:54:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8c0e652e605c430a8d819f95af318c41\n\n- grenade https://zuul.opendev.org/t/openstack/build/4b80d7d717cb45d58f02d752b289ed2d : SUCCESS in 1h 09m 40s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/45ce12a5ca954bc6b087ea20f6f9d405 : SUCCESS in 1h 35m 58s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7a27da2d5aac4cd0a3ddb2d31f1a3fb8 : SUCCESS in 1h 02m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1c279c51fd0546ec97bfb27ff5a2234c : SUCCESS in 4m 20s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6d47f78f033d483fa8ff19e44a9e9575 : SUCCESS in 5m 21s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/f700da679114413a8b0be6b7adfa9712 : SUCCESS in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/60b7152216084069a5bd354f8e9c350f : SUCCESS in 6m 53s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2ffd9de741504319a2ed774b87192fd4 : SUCCESS in 6m 54s\n- openstack-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/db1a743d186b4b1e9017927013460292 : SUCCESS in 8m 34s\n- placement-nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/98e320541ce24efcb3db48a365b101b3 : SUCCESS in 19m 16s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4002f477e74048fcb00578253640b41f : SUCCESS in 51m 33s","accounts_in_message":[],"_revision_number":1},{"id":"6280820335dbb4c8b271907af72311656197eaaa","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-21 15:54:17.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"2718d79b883ddc3d16a516a79c578bd1cf5afd5e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-21 15:55:43.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2606c5c1a9b34c6783b6130e96b71596\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a4becb5ebfbf4991bacca23ea73f911f : SUCCESS in 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f276fc236383c87579cc1ba3bd6fe230570888fc","revisions":{"f276fc236383c87579cc1ba3bd6fe230570888fc":{"kind":"REWORK","_number":1,"created":"2025-01-10 17:01:34.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/39/938939/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/39/938939/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/39/938939/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/39/938939/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/39/938939/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/39/938939/1"}}},"commit":{"parents":[{"commit":"901dc8274a3198c38bd0faa515c729903d5d1e0d","subject":"Update TOX_CONSTRAINTS_FILE for stable/2024.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/901dc8274a3198c38bd0faa515c729903d5d1e0d"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-11-28 19:21:24.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-01-10 17:00:39.000000000","tz":60},"subject":"Add a global limit on the number of allocation candidates","message":"Add a global limit on the number of allocation candidates\n\nWhen a root provider has multiple similar child RPs, i.e. we have a wide\nbut symmetric tree, and the allocation\ncandidate request asks for resources in multiple request groups the\nnumber of possible allocation candidates grows rapidly.\n\n* 1 root, 8 child RPs with 1 unit of resource each\n  a_c requests 6 groups with 1 unit of resource each\n  \u003d\u003e 8*7*6*5*4*3\u003d20160 possible candidates\n\n* 1 root, 8 child RPs with 6 unit of resources each\n  a_c requests 6 groups with 6 unit of resources each\n  \u003d\u003e 8^6\u003d262144 possible candidates\n\nPlacement generates these candidates fully before applying the limit\nparameter provided in the query to be able do a random sampling if\n[placement]randomize_allocation_candidates is True.\n\nPlacement takes excessive time and memory to generates these amount of\nallocation candidates.\n\nTo avoid request timeout or out of memory events this patch introduces a\nnew [placement]max_allocation_candidates config option that is applied\nnot after but *during* the candidate generation loop. So this new option\nacts as a global safety limit.\n\nThe new config option is defaulted to -1, meaning no limit, to keep the\nlegacy behavior, but we suggest to tune that config in environments with\nwide symmetric trees.\n\nPlacement generates the candidates with a depth first approach,\ngathering all candidates for a root before moving to the next root. If\nthe new global limit is applied and hit then it is possible that the\nreturned candidates are from a limited set of root providers. This issue\nwill be handled by a subsequent patch allowing to select from\ndepth-first or breadth-first (round-robin) candidate generation\nstrategy.\n\nRelated-Bug: #2070257\nChange-Id: I5475c66fa35958b3dc72c3bab7a7edbdf6c89ce6\n(cherry picked from commit 9351241f91f80cb7dc45c4c0daab929b5dfc5c4b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f276fc236383c87579cc1ba3bd6fe230570888fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/f276fc236383c87579cc1ba3bd6fe230570888fc"}]},"branch":"refs/heads/stable/2024.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}