)]}'
{"id":"openstack%2Fplacement~938946","triplet_id":"openstack%2Fplacement~stable%2F2023.2~I4f8c8491d21426310a82df7186b7689b2dad253e","project":"openstack/placement","branch":"stable/2023.2","topic":"bug/2070257","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2025-04-11 11:57:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I4f8c8491d21426310a82df7186b7689b2dad253e","subject":"Factor out allocation candidate generation strategy","status":"MERGED","created":"2025-01-10 17:04:14.000000000","updated":"2025-04-11 11:58:37.000000000","submitted":"2025-04-11 11:57:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"938946-bug/2070257","meta_rev_id":"69ffbfdf533282b64ecb39f0c7f598eb76c736f6","_number":938946,"virtual_id_number":938946,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-04-11 11:57:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":2,"date":"2025-04-11 10:18:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2025-02-27 13:14:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":1,"date":"2025-04-11 10:18:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-10 18:20:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-02-27 13:14:40.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2025-04-11 10:18:08.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"7e1726d08ea1a7f1f6dbcb11e605c82ee01225a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2025-01-10 17:04:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fd854bb3046895fd8be351fc933d00be19774769","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-10 18:20:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/65168334bcf74f80a399c4a3561b620b\n\n- grenade https://zuul.opendev.org/t/openstack/build/9997256f78ad4c1faf1808d7f85129ba : SUCCESS in 55m 12s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/b738480bcd894d33bdb894e26b5f6399 : SUCCESS in 1h 12m 19s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3880a81dedf04f45a89b067c061f759e : SUCCESS in 1h 04m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/273ee4e78d7441508decdc7981a9e63b : SUCCESS in 8m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e05777dca8e34a1a87a2a87aa827fbb6 : SUCCESS in 5m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2895b5c169ff47b39c2a212d2f0ca094 : SUCCESS in 4m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f9e6a0ede07540b2b237020f35e9ed54 : SUCCESS in 5m 15s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/294fe2dc62e6449f89bcc230c23ba8e5 : SUCCESS in 5m 23s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/cb9d16f12e914951826ab1c299d77439 : SUCCESS in 4m 54s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/efe285fa9f9744d7ba6c27960ea72f57 : SUCCESS in 7m 52s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f9974af08cae4efe9f4635ff0f644f95 : SUCCESS in 6m 01s\n- openstack-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a0778aa9b177490d80dba61c59298870 : SUCCESS in 6m 00s\n- placement-nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a8f5ebd4c0d242a7bdfe24066b3975c0 : SUCCESS in 18m 57s\n- placement-nested-perfload https://zuul.opendev.org/t/openstack/build/552c23d4267f42ad86f80015529208e3 : FAILURE in 6m 20s (non-voting)\n- placement-perfload https://zuul.opendev.org/t/openstack/build/f7685c486d064d7b84fb470027295237 : FAILURE in 1m 59s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3b623f3798514c6c97a1423d7a99638f : SUCCESS in 59m 34s","accounts_in_message":[],"_revision_number":1},{"id":"bafe3b62b7f9b5494d8cffca263a0cc052621be6","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-02-27 13:14:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c06826e2a7d5cfe56f6b294e9f8a900ec9155506","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2025-04-11 10:18:08.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6757060f107ef9586ed09afbe5faf099ddfd75cd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-11 10:20:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"74578d7fb3221b2747e181dfad45db42fe457b50","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-11 11:57:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/963cc6491f8e476a97071b896587618d\n\n- grenade https://zuul.opendev.org/t/openstack/build/a3af1428a40d4a408e0299fe52884cfa : SUCCESS in 52m 46s\n- tempest-integrated-placement https://zuul.opendev.org/t/openstack/build/dc013b2158d84a598f56521d9550622b : SUCCESS in 1h 32m 45s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/fc6b18a2ac144b83ad2f20599953aa88 : SUCCESS in 52m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a6c1af359c444b95a4e56bf98cd0aac8 : SUCCESS in 4m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8a36b2c567b744b7b4f2aa7e5ebccd24 : SUCCESS in 6m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4c2c243e43c14a93ba0eecadf12bcc95 : SUCCESS in 4m 34s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/8133d8ccd2de47a489ecefb26b2e1804 : SUCCESS in 4m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/37755ef42d914bb882b97947adb74eda : SUCCESS in 7m 46s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/625aaf2564b74fa8a0f94e4a1e3251ca : SUCCESS in 6m 13s\n- openstack-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/21791e30a53c4600bbc19f9e3094aec6 : SUCCESS in 5m 46s\n- placement-nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/0ede34f60fc94fd18f3703d4e3dc1a6f : SUCCESS in 18m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/89e5e6fbe0df4443b570fbdae50485a1 : SUCCESS in 25m 08s","accounts_in_message":[],"_revision_number":1},{"id":"c9772ff07fa9845879d946d630a1f668feb6bc80","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-11 11:57:42.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"69ffbfdf533282b64ecb39f0c7f598eb76c736f6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-04-11 11:58:37.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/50dc907ec21a47b4aed0334c40b71a23\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/362306c967004d3e821ece470debe86c : SUCCESS in 36s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"815dcd8c93921905ecef18836264a9e34d6204f2","revisions":{"815dcd8c93921905ecef18836264a9e34d6204f2":{"kind":"REWORK","_number":1,"created":"2025-01-10 17:04:14.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/46/938946/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/placement","ref":"refs/changes/46/938946/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/placement refs/changes/46/938946/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/placement refs/changes/46/938946/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/placement refs/changes/46/938946/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/placement refs/changes/46/938946/1"}}},"commit":{"parents":[{"commit":"a1db67cdeb8fdc4361d2d8ec6097dc7bfd60e0ba","subject":"Add a global limit on the number of allocation candidates","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/a1db67cdeb8fdc4361d2d8ec6097dc7bfd60e0ba"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2024-12-06 15:47:53.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2025-01-10 17:03:58.000000000","tz":60},"subject":"Factor out allocation candidate generation strategy","message":"Factor out allocation candidate generation strategy\n\nThis is a pure refactor to pull out the logic of assembling an\nallocation candidate.\n\nThe _get_areq_list_generators returns a set of\ngenerators, one per root (anchoring) provider, that can generate all the\nviable candidates for that root by applying a product on the solutions\nfor each request groups.\n\nThe _generate_areq_lists implements the strategy of consuming these\ngenerators. The current behavior is that placement consumes the\ngenerator for the first root fully before moving to the next\n(depth-first).\n\nA later patch will change _generate_areq_lists to be able to apply\ndifferent strategies, like round-robin easily.\n\nRelated-Bug: #2070257\nChange-Id: I4f8c8491d21426310a82df7186b7689b2dad253e\n(cherry picked from commit 04718d65b60e817b5f47c5a3f50e302fe2302dfd)\n(cherry picked from commit 1b0a927203ec779be631e3c61b9d6e4c7231cdec)\n(cherry picked from commit dc4ffdc4f88e5ac5c6b8fecd3d4ec88c12687a57)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/815dcd8c93921905ecef18836264a9e34d6204f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/placement/commit/815dcd8c93921905ecef18836264a9e34d6204f2"}]},"branch":"refs/heads/stable/2023.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}