)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bab5a3993be7035f5592f7efa85b1a23370d7f5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19db0ce6_88692fcf","updated":"2025-11-25 15:08:17.000000000","message":"Proxying Sean\u0027s previous +2","commit_id":"d57a957d520f0d74f6f9adf3e16fffbf27e7ec4a"}],"placement/tests/functional/fixtures/gabbits.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69bd795b889c277b17b8cd3017b2cb509df69988","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def setup_app():"},{"line_number":46,"context_line":"    global CONF  # noqa"},{"line_number":47,"context_line":"    return deploy.loadapp(CONF)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ac9d971c_27bf1d65","line":46,"updated":"2025-11-25 11:50:49.000000000","message":"hum odd that this need a noqa but ok","commit_id":"079e6684b3572eea1e07651cb9c642db4cfb3c69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f2d1b32cd422688a547962cc203e1e901a3f954","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def setup_app():"},{"line_number":46,"context_line":"    global CONF  # noqa"},{"line_number":47,"context_line":"    return deploy.loadapp(CONF)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"84319af3_453b00ac","line":46,"in_reply_to":"2a49ed14_2952aadb","updated":"2025-11-25 13:09:15.000000000","message":"Ah, you\u0027re right: I\u0027d misunderstood this. We only need `global` if we\u0027re wholly overwriting `CONF` and want to avoid shadowing it:\n\n```\nFOO \u003d {}\n\ndef write_foo(x):\n    x[\u0027wow\u0027] \u003d \u0027cool\u0027\n\n\ndef main():\n    global FOO\n    FOO \u003d {\u0027a\u0027: \u0027b\u0027}  # \u003c--- this line\n    write_foo(FOO)\n\n\nif __name__ \u003d\u003d \u0027__main__\u0027:\n    main()\n    print(FOO)\n```","commit_id":"079e6684b3572eea1e07651cb9c642db4cfb3c69"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bab5a3993be7035f5592f7efa85b1a23370d7f5c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def setup_app():"},{"line_number":46,"context_line":"    global CONF  # noqa"},{"line_number":47,"context_line":"    return deploy.loadapp(CONF)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6f84652b_570f3a2a","line":46,"in_reply_to":"84319af3_453b00ac","updated":"2025-11-25 15:08:17.000000000","message":"yepp","commit_id":"079e6684b3572eea1e07651cb9c642db4cfb3c69"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6e73024a95e16b596bb6d7ef0eb89e5ac1bedeee","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def setup_app():"},{"line_number":46,"context_line":"    global CONF  # noqa"},{"line_number":47,"context_line":"    return deploy.loadapp(CONF)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2a49ed14_2952aadb","line":46,"in_reply_to":"ac9d971c_27bf1d65","updated":"2025-11-25 12:14:15.000000000","message":"I think the noqa is for not trying to write to that variable and therefore global is not even needed to read the variable from the global scope.\n\n```\nplacement/tests/functional/fixtures/gabbits.py:46:5: F824 `global CONF` is unused: name is never assigned in scope\n```\n\nSo I suggest not to paper this over but instead remove the global keyword and let the variable scoping properly resolve CONF to be the global one","commit_id":"079e6684b3572eea1e07651cb9c642db4cfb3c69"}]}