)]}'
{"gerrit/acls/openstack/tripleo-puppet-elements.config":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4ddd18eba69c45333c7c4357b6fa9ba9fbde7433","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group diskimage-builder-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group diskimage-builder-core"},{"line_number":4,"context_line":"label-Workflow \u003d -1..+1 group puppet-manager-core"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[access \"refs/tags/*\"]"},{"line_number":7,"context_line":"pushSignedTag \u003d group tripleo-release"}],"source_content_type":"text/x-ini","patch_set":2,"id":"da9df570_b7fc9973","line":4,"updated":"2014-09-27 07:30:48.000000000","message":"You have quite a mixture of groups, the above should be diskimage-builder-core as well.\n\nAnd then you can just use the diskimage-builder.config file instead, remove this file and reference it the projects file","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"11130cc5b0fd4438a28b40b33df3aa6c7162c8d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group diskimage-builder-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group diskimage-builder-core"},{"line_number":4,"context_line":"label-Workflow \u003d -1..+1 group puppet-manager-core"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[access \"refs/tags/*\"]"},{"line_number":7,"context_line":"pushSignedTag \u003d group tripleo-release"}],"source_content_type":"text/x-ini","patch_set":2,"id":"da9df570_6d141ea0","line":4,"in_reply_to":"da9df570_2dd93622","updated":"2014-09-27 15:37:15.000000000","message":"it makes sense indeed, thanks!","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"2c215c76b29ade2918bd3d4fb8833992a30731e3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group diskimage-builder-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group diskimage-builder-core"},{"line_number":4,"context_line":"label-Workflow \u003d -1..+1 group puppet-manager-core"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[access \"refs/tags/*\"]"},{"line_number":7,"context_line":"pushSignedTag \u003d group tripleo-release"}],"source_content_type":"text/x-ini","patch_set":2,"id":"da9df570_adae067f","line":4,"in_reply_to":"da9df570_4a53c038","updated":"2014-09-27 15:22:28.000000000","message":"The original has in all three lines (line 2-4) the same group. Let\u0027s use the same group everywhere - and not two different ones.","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a196c08fc5d407ee58039d84024b4e0e1a9ef73c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group diskimage-builder-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group diskimage-builder-core"},{"line_number":4,"context_line":"label-Workflow \u003d -1..+1 group puppet-manager-core"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[access \"refs/tags/*\"]"},{"line_number":7,"context_line":"pushSignedTag \u003d group tripleo-release"}],"source_content_type":"text/x-ini","patch_set":2,"id":"da9df570_2dd93622","line":4,"in_reply_to":"da9df570_adae067f","updated":"2014-09-27 15:26:34.000000000","message":"Emilien, if you use puppet-manager-core in lines 2 and 3 as well, I\u0027m happy - and I think that\u0027s what was suggested in the other review.","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"961598441697b05d41d3adf87a9aba94d8cc4b3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group diskimage-builder-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group diskimage-builder-core"},{"line_number":4,"context_line":"label-Workflow \u003d -1..+1 group puppet-manager-core"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[access \"refs/tags/*\"]"},{"line_number":7,"context_line":"pushSignedTag \u003d group tripleo-release"}],"source_content_type":"text/x-ini","patch_set":2,"id":"da9df570_4a53c038","line":4,"in_reply_to":"da9df570_b7fc9973","updated":"2014-09-27 14:01:07.000000000","message":"This is the original discussion:\nhttps://review.openstack.org/#/c/120285/8/modules/openstack_project/files/gerrit/acls/openstack/tripleo-puppet-elements.config,cm\n\nI\u0027m not sure now. Maybe Dan can say?","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"2b40e2e6cf6f00c47cb100da959c0a048a15eb39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[access \"refs/heads/*\"]"},{"line_number":2,"context_line":"abandon \u003d group diskimage-builder-core"},{"line_number":3,"context_line":"label-Code-Review \u003d -2..+2 group puppet-manager-core"},{"line_number":4,"context_line":"label-Workflow \u003d -1..+1 group puppet-manager-core"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-ini","patch_set":4,"id":"da9df570_689decbb","line":2,"updated":"2014-09-27 16:58:23.000000000","message":"this line should also be puppet-manager-core","commit_id":"2d75176a95d295d5e8be12bcaa89f1bf08b727fb"}],"gerrit/projects.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4ddd18eba69c45333c7c4357b6fa9ba9fbde7433","unresolved":false,"context_lines":[{"line_number":629,"context_line":"  groups:"},{"line_number":630,"context_line":"    - tripleo"},{"line_number":631,"context_line":"  description: Puppet elements for deployment of OpenStack"},{"line_number":632,"context_line":"  upstream: git://github.com/enovance/tripleo-image-elements.git"},{"line_number":633,"context_line":"- project: openstack/tripleo-specs"},{"line_number":634,"context_line":"  groups:"},{"line_number":635,"context_line":"    - tripleo"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da9df570_d7011d6b","line":632,"updated":"2014-09-27 07:30:48.000000000","message":"Add here instead of the removed acl file:\nacl-config: /home/gerrit2/acls/openstack/diskimage-builder.config","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"961598441697b05d41d3adf87a9aba94d8cc4b3c","unresolved":false,"context_lines":[{"line_number":629,"context_line":"  groups:"},{"line_number":630,"context_line":"    - tripleo"},{"line_number":631,"context_line":"  description: Puppet elements for deployment of OpenStack"},{"line_number":632,"context_line":"  upstream: git://github.com/enovance/tripleo-image-elements.git"},{"line_number":633,"context_line":"- project: openstack/tripleo-specs"},{"line_number":634,"context_line":"  groups:"},{"line_number":635,"context_line":"    - tripleo"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da9df570_6a332414","line":632,"in_reply_to":"da9df570_d7011d6b","updated":"2014-09-27 14:01:07.000000000","message":"it\u0027s a typo, I fix this.","commit_id":"46a752cd6c0aea5f71a344b803cee65b36aecc6d"}],"zuul/layout.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"33ef6045ee3f9507fc5f9901802bdb6a567ecdca","unresolved":false,"context_lines":[{"line_number":2681,"context_line":"  - name: openstack/tripleo-puppet-elements"},{"line_number":2682,"context_line":"    template:"},{"line_number":2683,"context_line":"      - name: merge-check"},{"line_number":2684,"context_line":"      - name: noop-jobs"},{"line_number":2685,"context_line":"      - name: python-jobs"},{"line_number":2686,"context_line":"    check-tripleo:"},{"line_number":2687,"context_line":"      - check-tripleo-novabm-undercloud-precise-nonha"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"baa201ad_23f45986","line":2684,"updated":"2014-10-01 15:37:15.000000000","message":"You don\u0027t need the noop-jobs template since you have another template providing check and gate pipeline jobs now.","commit_id":"1971484a80cddbb20ef3152c82b81ab315a5ae5e"}]}
