)]}'
{"jenkins/jobs/projects.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"25df6268e1a5f09de65b20becf2e81f8ef27205e","unresolved":false,"context_lines":[{"line_number":270,"context_line":"          jobname: \u0027ironic-overcloud-precise-ha\u0027"},{"line_number":271,"context_line":"          type: \u0027overcloud-precise-ha\u0027"},{"line_number":272,"context_line":"          node: \u0027tripleo-precise\u0027"},{"line_number":273,"context_line":"          branch-override: \u0027\u0027"},{"line_number":274,"context_line":"      - \u0027check-tripleo-{jobname}\u0027:"},{"line_number":275,"context_line":"          jobname: \u0027ironic-overcloud-precise-juno\u0027"},{"line_number":276,"context_line":"          type: \u0027overcloud-precise-nonha\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a961159_df12e856","line":273,"updated":"2015-01-16 21:44:35.000000000","message":"Is there a reason this doesn\u0027t use the typical pattern of set branch override to \u0027default\u0027 and switch based on that? I like how it is a bit more explicit and if you handle it wrong things should fail in obvious was \"no known branch default\".","commit_id":"57494108f47c4bfd8e8e0140ea835b10a8ae1ada"}],"jenkins/jobs/tripleo.yaml":[{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"78e388b744a4aac0aeef0f72dce7f377eb3fe06a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          export DEVSTACK_GATE_TIMEOUT\u003d170"},{"line_number":19,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d0"},{"line_number":20,"context_line":"          export DEVSTACK_GATE_EXERCISES\u003d0"},{"line_number":21,"context_line":"          export OVERRIDE_ZUUL_BRANCH\u003d{branch-override}"},{"line_number":22,"context_line":"          sudo chown -hR $(whoami) /opt/git"},{"line_number":23,"context_line":"          function gate_hook {{"},{"line_number":24,"context_line":"              bash -xe /opt/stack/new/tripleo-ci/toci_gate_test.sh"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a961159_c89b90c7","line":21,"updated":"2014-12-18 10:35:31.000000000","message":"I see that in your change, projects.yaml from JJB have branch-override set to empty string.\n\nWouldn\u0027t it be better to export the empty string as default value here in case branch-override does not have a value ?","commit_id":"57494108f47c4bfd8e8e0140ea835b10a8ae1ada"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"cc76171ad4061489fe44641039f2faa47cd1360d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          export DEVSTACK_GATE_TIMEOUT\u003d170"},{"line_number":19,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d0"},{"line_number":20,"context_line":"          export DEVSTACK_GATE_EXERCISES\u003d0"},{"line_number":21,"context_line":"          export OVERRIDE_ZUUL_BRANCH\u003d{branch-override}"},{"line_number":22,"context_line":"          sudo chown -hR $(whoami) /opt/git"},{"line_number":23,"context_line":"          function gate_hook {{"},{"line_number":24,"context_line":"              bash -xe /opt/stack/new/tripleo-ci/toci_gate_test.sh"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a961159_ce133fff","line":21,"updated":"2014-12-22 17:10:16.000000000","message":"No, because JJB will fail to build the jobs if it can\u0027t find a value for branch-override.","commit_id":"57494108f47c4bfd8e8e0140ea835b10a8ae1ada"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"029f98c35ebc51247c8b506c76623cde7e2b7d25","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          export DEVSTACK_GATE_TIMEOUT\u003d170"},{"line_number":19,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d0"},{"line_number":20,"context_line":"          export DEVSTACK_GATE_EXERCISES\u003d0"},{"line_number":21,"context_line":"          export OVERRIDE_ZUUL_BRANCH\u003d{branch-override}"},{"line_number":22,"context_line":"          sudo chown -hR $(whoami) /opt/git"},{"line_number":23,"context_line":"          function gate_hook {{"},{"line_number":24,"context_line":"              bash -xe /opt/stack/new/tripleo-ci/toci_gate_test.sh"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a961159_55742c35","line":21,"in_reply_to":"3a961159_ce133fff","updated":"2014-12-23 09:15:12.000000000","message":"Thanks","commit_id":"57494108f47c4bfd8e8e0140ea835b10a8ae1ada"}]}
