)]}'
{"nodepool/scripts/prepare_node.sh":[{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"d76d9f36cf33e146c6323eb28507a534f67ef39f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PYPY\u003d${PYPY:-false}"},{"line_number":25,"context_line":"ALL_MYSQL_PRIVS\u003d${ALL_MYSQL_PRIVS:-false}"},{"line_number":26,"context_line":"GIT_BASE\u003d${GIT_BASE:-git://git.openstack.org}"},{"line_number":27,"context_line":"SYSTEM_CONFIG_NAME\u003d${SYSTEM_CONFIG_NAME:-\u0027openstack-infra/system-config\u0027}"},{"line_number":28,"context_line":"PROJECT_CONFIG_NAME\u003d${PROJECT_CONFIG_NAME:-\u0027openstack-infra/project-config\u0027}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"export PUPPET_VERSION\u003d${PUPPET_VERSION:-\u00272\u0027}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a890539_b08a6d18","line":27,"updated":"2014-12-06 02:59:49.000000000","message":"Right now this variable isn\u0027t used.","commit_id":"c5f07f98f46e1236322f1bd5efc3a87cea9126b9"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4f6ca826f89ddb7d833d36a1634491970e328138","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PYPY\u003d${PYPY:-false}"},{"line_number":25,"context_line":"ALL_MYSQL_PRIVS\u003d${ALL_MYSQL_PRIVS:-false}"},{"line_number":26,"context_line":"GIT_BASE\u003d${GIT_BASE:-git://git.openstack.org}"},{"line_number":27,"context_line":"SYSTEM_CONFIG_NAME\u003d${SYSTEM_CONFIG_NAME:-\u0027openstack-infra/system-config\u0027}"},{"line_number":28,"context_line":"PROJECT_CONFIG_NAME\u003d${PROJECT_CONFIG_NAME:-\u0027openstack-infra/project-config\u0027}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"export PUPPET_VERSION\u003d${PUPPET_VERSION:-\u00272\u0027}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_eca9ab7c","line":27,"in_reply_to":"3a961159_ec9b6b70","updated":"2014-12-06 17:22:02.000000000","message":"Check grep SYSTEM_CONFIG nodepool/scripts/prepare_node.sh\n\nI does not return any value.","commit_id":"c5f07f98f46e1236322f1bd5efc3a87cea9126b9"},{"author":{"_account_id":6786,"name":"Sergey Lukjanov","email":"me@slukjanov.name","username":"slukjanov"},"change_message_id":"965a5c8121ad87db0b86f701a4b37384dff936f7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PYPY\u003d${PYPY:-false}"},{"line_number":25,"context_line":"ALL_MYSQL_PRIVS\u003d${ALL_MYSQL_PRIVS:-false}"},{"line_number":26,"context_line":"GIT_BASE\u003d${GIT_BASE:-git://git.openstack.org}"},{"line_number":27,"context_line":"SYSTEM_CONFIG_NAME\u003d${SYSTEM_CONFIG_NAME:-\u0027openstack-infra/system-config\u0027}"},{"line_number":28,"context_line":"PROJECT_CONFIG_NAME\u003d${PROJECT_CONFIG_NAME:-\u0027openstack-infra/project-config\u0027}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"export PUPPET_VERSION\u003d${PUPPET_VERSION:-\u00272\u0027}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_ec9b6b70","line":27,"in_reply_to":"5a890539_b08a6d18","updated":"2014-12-06 17:14:09.000000000","message":"Do you mean it\u0027s not set outside of the script atm?","commit_id":"c5f07f98f46e1236322f1bd5efc3a87cea9126b9"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bd50d794770e122b0a8dfecb793d32c6dce1b685","unresolved":false,"context_lines":[{"line_number":52,"context_line":"if [ -f /usr/bin/yum ]; then"},{"line_number":53,"context_line":"    sudo yum -y install wget"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":"wget https://git.openstack.org/cgit/openstack-infra/system-config/plain/install_puppet.sh"},{"line_number":56,"context_line":"sudo bash -xe install_puppet.sh"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"sudo git clone --depth\u003d1 $GIT_BASE/openstack-infra/system-config.git \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_e239cbd8","line":55,"updated":"2015-01-16 22:26:51.000000000","message":"The system config value should probably be used here. As well as the git base which is a little tricky because we grab the plain hosted file and not actually clone it.","commit_id":"c5f07f98f46e1236322f1bd5efc3a87cea9126b9"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bd50d794770e122b0a8dfecb793d32c6dce1b685","unresolved":false,"context_lines":[{"line_number":56,"context_line":"sudo bash -xe install_puppet.sh"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"sudo git clone --depth\u003d1 $GIT_BASE/openstack-infra/system-config.git \\"},{"line_number":59,"context_line":"    /root/system-config"},{"line_number":60,"context_line":"sudo /bin/bash /root/system-config/install_modules.sh"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"set +e"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_0235f7d9","line":59,"updated":"2015-01-16 22:26:51.000000000","message":"This i the other place that the new system config variable should be used.","commit_id":"c5f07f98f46e1236322f1bd5efc3a87cea9126b9"}]}