)]}'
{"jenkins/jobs/infra.yaml":[{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"90e36aae9c877b18dd1fe5c635391ff64e7d6a23","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    publishers:"},{"line_number":25,"context_line":"      - console-log"},{"line_number":26,"context_line":"      - zuul_swift_upload_console_log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- job:"},{"line_number":29,"context_line":"    name: gate-project-config-irc-access"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a961159_dd356cdc","line":26,"updated":"2014-12-16 00:37:11.000000000","message":"This will need to be rebased if https://review.openstack.org/#/c/141942/ gets in first. Would it make sense to have this patch as a dependency?","commit_id":"c87beb8d752a6220f02a28656ff94b8fe4c16f8e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7e3815879e371406c81e82e3af3933df6bff4ad0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    publishers:"},{"line_number":25,"context_line":"      - console-log"},{"line_number":26,"context_line":"      - zuul_swift_upload_console_log"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- job:"},{"line_number":29,"context_line":"    name: gate-project-config-irc-access"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a961159_524c0277","line":26,"in_reply_to":"3a961159_dd356cdc","updated":"2014-12-16 07:00:14.000000000","message":"Ok, I\u0027ll rebase this on top of 141942","commit_id":"c87beb8d752a6220f02a28656ff94b8fe4c16f8e"}],"tox.ini":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"54e26db20298537bc272b26bb6b41e827c93f45f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[testenv:gerrit]"},{"line_number":13,"context_line":"commands \u003d"},{"line_number":14,"context_line":"  {toxinidir}/tools/check_valid_gerrit_config.sh gerrit/acls/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[testenv:projects]"},{"line_number":17,"context_line":"deps \u003d PyYAML"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_303bae9d","line":14,"updated":"2014-12-09 20:44:20.000000000","message":"I wonder whether we should merge this with the next tox environment (and rename it) since both check files in the gerrit subdir.","commit_id":"c3377654aef0fac97cb7262ea686057fe33820fb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"38b5bfc6617a3a805f15b0183f53c2decd68a96b","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[testenv:gerrit]"},{"line_number":13,"context_line":"commands \u003d"},{"line_number":14,"context_line":"  {toxinidir}/tools/check_valid_gerrit_config.sh gerrit/acls/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[testenv:projects]"},{"line_number":17,"context_line":"deps \u003d PyYAML"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_d0034ab6","line":14,"in_reply_to":"3a961159_303bae9d","updated":"2014-12-09 20:46:31.000000000","message":"I thought about it, but I this one does not depend on PyYAML, and I figured it was better to keep it separate, but I can collapse it if you think it\u0027s easier.","commit_id":"c3377654aef0fac97cb7262ea686057fe33820fb"}],"zuul/layout.yaml":[{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"91f8733194d114df147156324e519014bba9ebd2","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    success-message: XML output is unchanged."},{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"  - name: project-gerrit-team-acl"},{"line_number":627,"context_line":"    voting: false"},{"line_number":628,"context_line":"    failure-message: Jenkins XML output has changed."},{"line_number":629,"context_line":"    success-message: Jenkins XML output is unchanged."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a961159_5d35b2f5","line":626,"updated":"2014-12-09 22:12:50.000000000","message":"Let\u0027s have a comment here that right now this job only tests stackforge acls, which is fine for a non-voting job. For this to be turned on to voting, I would like the job to test all acl files, but stackforge is fine to start off with.","commit_id":"537873bfd5ea259fef7e96c4442065dcdfe549a8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"196c5512cec39b14642ecb0c73611b9782ea884b","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    success-message: XML output is unchanged."},{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"  - name: project-gerrit-team-acl"},{"line_number":627,"context_line":"    voting: false"},{"line_number":628,"context_line":"    failure-message: Jenkins XML output has changed."},{"line_number":629,"context_line":"    success-message: Jenkins XML output is unchanged."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a961159_e0aa35d1","line":626,"in_reply_to":"3a961159_5d35b2f5","updated":"2014-12-09 22:18:27.000000000","message":"Done","commit_id":"537873bfd5ea259fef7e96c4442065dcdfe549a8"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"ca974bfecb3eeba92dd62090f2621f363c5da050","unresolved":false,"context_lines":[{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"# Check team ACL for project configs; can apply only"},{"line_number":627,"context_line":"# to certain namespaces (e.g. stackforge only)."},{"line_number":628,"context_line":"  - name: project-gerrit-team-acl"},{"line_number":629,"context_line":"    voting: false"},{"line_number":630,"context_line":"    failure-message: Jenkins XML output has changed."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a961159_f6067b1f","line":627,"updated":"2014-12-10 00:04:41.000000000","message":"Sorry the below comment is more along the lines of what I was thinking.\n\n # Right now this is only evaluating acl files on stackforge projects.","commit_id":"1961ff5061db1b35f9ae86dd72ad9961045b2bad"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"233df07d204c892b7d7e945b9fa560bdce63b96a","unresolved":false,"context_lines":[{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"# Check team ACL for project configs; can apply only"},{"line_number":627,"context_line":"# to certain namespaces (e.g. stackforge only)."},{"line_number":628,"context_line":"  - name: project-gerrit-team-acl"},{"line_number":629,"context_line":"    voting: false"},{"line_number":630,"context_line":"    failure-message: Jenkins XML output has changed."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a961159_0eee8b22","line":627,"in_reply_to":"3a961159_f6067b1f","updated":"2014-12-10 06:05:49.000000000","message":"Done","commit_id":"1961ff5061db1b35f9ae86dd72ad9961045b2bad"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a79e59c090410548a9919339a1e8a93f8e86a26a","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    success-message: XML output is unchanged."},{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"# Right now this is only evaluating acl files on stackforge projects."},{"line_number":627,"context_line":"  - name: project-gerrit-team-acl"},{"line_number":628,"context_line":"    voting: false"},{"line_number":629,"context_line":"    failure-message: Jenkins XML output has changed."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a961159_71b1ae8e","line":626,"updated":"2014-12-10 07:27:47.000000000","message":"I suggest to remove the comment altogether. It does not help us to explain why this job is non-voting.","commit_id":"2172f56ea8bd6268a44b29a2c8963d66a37af6a4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6ce42e460a137ccdbad7097ae8236da3f3f03485","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    success-message: XML output is unchanged."},{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"# Right now this is only evaluating acl files on stackforge projects."},{"line_number":627,"context_line":"  - name: project-gerrit-team-acl"},{"line_number":628,"context_line":"    voting: false"},{"line_number":629,"context_line":"    failure-message: Jenkins XML output has changed."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a961159_1d25d1aa","line":626,"in_reply_to":"3a961159_71b1ae8e","updated":"2014-12-10 14:36:46.000000000","message":"This was Anita\u0027s suggestion. So long as your +1 is not going to cause her -1, I am happy either way.","commit_id":"2172f56ea8bd6268a44b29a2c8963d66a37af6a4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a79e59c090410548a9919339a1e8a93f8e86a26a","unresolved":false,"context_lines":[{"line_number":3361,"context_line":"      - name: infra-puppet-apply-jobs"},{"line_number":3362,"context_line":"    check:"},{"line_number":3363,"context_line":"      - project-config-compare-xml"},{"line_number":3364,"context_line":"      - project-gerrit-team-acl"},{"line_number":3365,"context_line":"      - gate-project-config-layout"},{"line_number":3366,"context_line":"      - gate-project-config-pep8"},{"line_number":3367,"context_line":"      - gate-project-config-bashate"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a961159_11686af4","line":3364,"updated":"2014-12-10 07:27:47.000000000","message":"Please name the job \"project-config-gerrit\" since gerrit is the tox job and project-config the repo.","commit_id":"2172f56ea8bd6268a44b29a2c8963d66a37af6a4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6ce42e460a137ccdbad7097ae8236da3f3f03485","unresolved":false,"context_lines":[{"line_number":3361,"context_line":"      - name: infra-puppet-apply-jobs"},{"line_number":3362,"context_line":"    check:"},{"line_number":3363,"context_line":"      - project-config-compare-xml"},{"line_number":3364,"context_line":"      - project-gerrit-team-acl"},{"line_number":3365,"context_line":"      - gate-project-config-layout"},{"line_number":3366,"context_line":"      - gate-project-config-pep8"},{"line_number":3367,"context_line":"      - gate-project-config-bashate"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a961159_9d19c17b","line":3364,"in_reply_to":"3a961159_11686af4","updated":"2014-12-10 14:36:46.000000000","message":"Done","commit_id":"2172f56ea8bd6268a44b29a2c8963d66a37af6a4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"09adeb699a8d251e1b82d4f23aed811f48eb8b1f","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    success-message: XML output is unchanged."},{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"  - name: project-config-gerrit"},{"line_number":627,"context_line":"    voting: false"},{"line_number":628,"context_line":"    failure-message: Jenkins XML output has changed."},{"line_number":629,"context_line":"    success-message: Jenkins XML output is unchanged."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a961159_30d9c783","line":626,"updated":"2014-12-10 19:07:56.000000000","message":"After IRC discussion, let\u0027s add here - properly intentented (the # should be above the \"-\") - something like the text below if that works for all of you:\n\n\n# TODO(armax): This job is not evaluating all ACL files yet. Make it voting once we evaluate all files and the test passes cleanly.","commit_id":"101269a362eabebb60f97f90753ea2ba01573115"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a421bb511a85ecda41a39aeaf9b1c080817cec08","unresolved":false,"context_lines":[{"line_number":623,"context_line":"    success-message: XML output is unchanged."},{"line_number":624,"context_line":"  - name: project-config-compare-xml"},{"line_number":625,"context_line":"    voting: false"},{"line_number":626,"context_line":"  - name: project-config-gerrit"},{"line_number":627,"context_line":"    voting: false"},{"line_number":628,"context_line":"    failure-message: Jenkins XML output has changed."},{"line_number":629,"context_line":"    success-message: Jenkins XML output is unchanged."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a961159_6be1a499","line":626,"in_reply_to":"3a961159_30d9c783","updated":"2014-12-10 20:01:20.000000000","message":"Done","commit_id":"101269a362eabebb60f97f90753ea2ba01573115"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"51b1bdaa2b8c0121554d3e494b2c070d42fa4a50","unresolved":false,"context_lines":[{"line_number":3360,"context_line":"      - name: infra-puppet-apply-jobs"},{"line_number":3361,"context_line":"    check:"},{"line_number":3362,"context_line":"      - project-config-compare-xml"},{"line_number":3363,"context_line":"      - project-config-gerrit"},{"line_number":3364,"context_line":"      - gate-project-config-layout"},{"line_number":3365,"context_line":"      - gate-project-config-pep8"},{"line_number":3366,"context_line":"      - gate-project-config-bashate"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a961159_d53cf5e4","line":3363,"updated":"2014-12-10 18:57:53.000000000","message":"Anita, what do you think of adding the comment above this line?","commit_id":"101269a362eabebb60f97f90753ea2ba01573115"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a421bb511a85ecda41a39aeaf9b1c080817cec08","unresolved":false,"context_lines":[{"line_number":3360,"context_line":"      - name: infra-puppet-apply-jobs"},{"line_number":3361,"context_line":"    check:"},{"line_number":3362,"context_line":"      - project-config-compare-xml"},{"line_number":3363,"context_line":"      - project-config-gerrit"},{"line_number":3364,"context_line":"      - gate-project-config-layout"},{"line_number":3365,"context_line":"      - gate-project-config-pep8"},{"line_number":3366,"context_line":"      - gate-project-config-bashate"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3a961159_8b19708a","line":3363,"in_reply_to":"3a961159_d53cf5e4","updated":"2014-12-10 20:01:20.000000000","message":"I am assuming that if I add the comment to line 626, I won\u0027t add it here.","commit_id":"101269a362eabebb60f97f90753ea2ba01573115"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4d0735be3743ca52eff67cd25af6c12617209c8e","unresolved":false,"context_lines":[{"line_number":632,"context_line":"  # it voting once we evaluate all files and the test passes cleanly."},{"line_number":633,"context_line":"  - name: project-config-gerrit"},{"line_number":634,"context_line":"    voting: false"},{"line_number":635,"context_line":"    failure-message: Jenkins XML output has changed."},{"line_number":636,"context_line":"    success-message: Jenkins XML output is unchanged."},{"line_number":637,"context_line":"  - name: gate-git-review-python34"},{"line_number":638,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3a961159_6dc02e2b","line":635,"updated":"2014-12-16 18:37:43.000000000","message":"applied at the wrong place. I\u0027ve proposed a fix in https://review.openstack.org/142179","commit_id":"e6573ea7526feda61541c74e89e4ef5d2d12b575"}]}