)]}'
{"nodepool/elements/centos-minimal/packages/centos-7.packages":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"25de5f9964132455f898a788d9600d30765463e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#  packages which we will need to download for a minimal installation for"},{"line_number":3,"context_line":"#  CentOS 6.x"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"audit-libs"},{"line_number":7,"context_line":"basesystem"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a961159_cd4c5ea1","line":4,"updated":"2014-12-11 07:48:43.000000000","message":"This file is named centos-7 but the comment says 6. Which one is right?","commit_id":"a27c1a6eda219d8864e3e65d288a4e20df7e8d82"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3aa582a1e4e0dad4fa96caf37f51ae2df712b374","unresolved":false,"context_lines":[{"line_number":107,"context_line":"yum-metadata-parser"},{"line_number":108,"context_line":"yum-utils"},{"line_number":109,"context_line":"zlib"},{"line_number":110,"context_line":"libffi"},{"line_number":111,"context_line":"libsemanage"},{"line_number":112,"context_line":"libblkid"},{"line_number":113,"context_line":"libmount"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1a930d6b_c7b7eb84","line":110,"updated":"2015-01-23 18:40:12.000000000","message":"Might make more sense to alphabetize this initial list so it will start out more manageable.","commit_id":"28e7b064422307f785eeb34959f5cd3b9243e550"}],"nodepool/elements/infra/element-deps":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"51581a048356cde9b206581594708048f19ff345","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source-repositories"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ba7be1f8_8e39ffda","line":1,"updated":"2015-02-19 22:57:52.000000000","message":"This element also needs to depend on package-installs","commit_id":"e5f8d058219d86fefdc35bcb934a40b6c348b1bc"}],"nodepool/elements/infra/files/authorized_keys":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"9cb6df1b2998b20c8ecccdaafe0b9ea2524c9a93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from\u003d\"puppetmaster.openstack.org\" ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDSLlN41ftgxkNeUi/kATYPwMPjJdMaSbgokSb9PSkRPZE7GeNai60BCfhu+ky8h5eMe70Bpwb7mQ7GAtHGXPNU1SRBPhMuVN9EYrQbt5KSiwuiTXtQHsWyYrSKtB+XGbl2PhpMQ/TPVtFoL5usxu/MYaakVkCEbt5IbPYNg88/NKPixicJuhi0qsd+l1X1zoc1+Fn87PlwMoIgfLIktwaL8hw9mzqr+pPcDIjCFQQWnjqJVEObOcMstBT20XwKj/ymiH+6p123nnlIHilACJzXhmIZIZO+EGkNF7KyXpcBSfv9efPI+VCE2TOv/scJFdEHtDFkl2kdUBYPC0wQ92rp puppet-remote-2014-09-15"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"fa32b979_0b6f1ac6","line":1,"updated":"2015-06-16 00:27:39.000000000","message":"Just a comment.. is there a reason our root key isn\u0027t 4k?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e2df8fc5fc7636262d054d05ee565919d739a140","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from\u003d\"puppetmaster.openstack.org\" ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDSLlN41ftgxkNeUi/kATYPwMPjJdMaSbgokSb9PSkRPZE7GeNai60BCfhu+ky8h5eMe70Bpwb7mQ7GAtHGXPNU1SRBPhMuVN9EYrQbt5KSiwuiTXtQHsWyYrSKtB+XGbl2PhpMQ/TPVtFoL5usxu/MYaakVkCEbt5IbPYNg88/NKPixicJuhi0qsd+l1X1zoc1+Fn87PlwMoIgfLIktwaL8hw9mzqr+pPcDIjCFQQWnjqJVEObOcMstBT20XwKj/ymiH+6p123nnlIHilACJzXhmIZIZO+EGkNF7KyXpcBSfv9efPI+VCE2TOv/scJFdEHtDFkl2kdUBYPC0wQ92rp puppet-remote-2014-09-15"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_c4cf5254","line":1,"updated":"2015-07-03 00:38:59.000000000","message":"Not a good one?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"nodepool/elements/infra/files/sshd_config":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RSAAuthentication yes"},{"line_number":30,"context_line":"PubkeyAuthentication yes"},{"line_number":31,"context_line":"#AuthorizedKeysFile\t%h/.ssh/authorized_keys"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Don\u0027t read the user\u0027s ~/.rhosts and ~/.shosts files"},{"line_number":34,"context_line":"IgnoreRhosts yes"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"baa041b7_6373a681","line":31,"updated":"2015-04-02 17:29:43.000000000","message":"Review is showing a rogue \u0027»\u0027","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"},{"author":{"_account_id":16272,"name":"Clint Adams","email":"clint@gcfm.net","username":"clint"},"change_message_id":"1af33eededece907e2f6664a53f87594388ab22d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Authentication:"},{"line_number":25,"context_line":"LoginGraceTime 120"},{"line_number":26,"context_line":"PermitRootLogin yes"},{"line_number":27,"context_line":"StrictModes yes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RSAAuthentication yes"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_4466e251","line":26,"updated":"2015-07-03 00:48:49.000000000","message":"This could be without-password instead of yes, for redundant safety","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e2df8fc5fc7636262d054d05ee565919d739a140","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Authentication:"},{"line_number":25,"context_line":"LoginGraceTime 120"},{"line_number":26,"context_line":"PermitRootLogin yes"},{"line_number":27,"context_line":"StrictModes yes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RSAAuthentication yes"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_04e9bab6","line":26,"updated":"2015-07-03 00:38:59.000000000","message":"We do; ansible does not.  :/","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"9cb6df1b2998b20c8ecccdaafe0b9ea2524c9a93","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Authentication:"},{"line_number":25,"context_line":"LoginGraceTime 120"},{"line_number":26,"context_line":"PermitRootLogin yes"},{"line_number":27,"context_line":"StrictModes yes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RSAAuthentication yes"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"fa32b979_8b4c8a71","line":26,"updated":"2015-06-16 00:27:39.000000000","message":"eh. We don\u0027t use sudo?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9d5ace3308e785141de9c140837a763c294c46c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Authentication:"},{"line_number":25,"context_line":"LoginGraceTime 120"},{"line_number":26,"context_line":"PermitRootLogin yes"},{"line_number":27,"context_line":"StrictModes yes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RSAAuthentication yes"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_244dde99","line":26,"in_reply_to":"ba3cc151_04e9bab6","updated":"2015-07-03 15:56:45.000000000","message":"We can use ansible with sudo if we want.","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9d5ace3308e785141de9c140837a763c294c46c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Authentication:"},{"line_number":25,"context_line":"LoginGraceTime 120"},{"line_number":26,"context_line":"PermitRootLogin yes"},{"line_number":27,"context_line":"StrictModes yes"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RSAAuthentication yes"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_47980778","line":26,"in_reply_to":"ba3cc151_4466e251","updated":"2015-07-03 15:56:45.000000000","message":"Done","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"9cb6df1b2998b20c8ecccdaafe0b9ea2524c9a93","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Allow client to pass locale environment variables"},{"line_number":73,"context_line":"AcceptEnv LANG LC_*"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Subsystem sftp %%SFTP_LOCATION%%"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Set this to \u0027yes\u0027 to enable PAM authentication, account processing,"},{"line_number":78,"context_line":"# and session processing. If this is enabled, PAM authentication will"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"fa32b979_ab470e4a","line":75,"updated":"2015-06-16 00:27:39.000000000","message":"Crazy idea. Instead of using sed replacement (which is fine) just leave this out, and append it onto the file? Quite a bit simpler than sed -i.","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9d5ace3308e785141de9c140837a763c294c46c5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Allow client to pass locale environment variables"},{"line_number":73,"context_line":"AcceptEnv LANG LC_*"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Subsystem sftp %%SFTP_LOCATION%%"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Set this to \u0027yes\u0027 to enable PAM authentication, account processing,"},{"line_number":78,"context_line":"# and session processing. If this is enabled, PAM authentication will"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_a461ee06","line":75,"in_reply_to":"ba3cc151_84486ab4","updated":"2015-07-03 15:56:45.000000000","message":"Well. not augeas because complexity and I\u0027m not that smart. Not .erb because ruby.\n\nAppending sounds great to me.","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":16272,"name":"Clint Adams","email":"clint@gcfm.net","username":"clint"},"change_message_id":"1af33eededece907e2f6664a53f87594388ab22d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Allow client to pass locale environment variables"},{"line_number":73,"context_line":"AcceptEnv LANG LC_*"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Subsystem sftp %%SFTP_LOCATION%%"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Set this to \u0027yes\u0027 to enable PAM authentication, account processing,"},{"line_number":78,"context_line":"# and session processing. If this is enabled, PAM authentication will"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"ba3cc151_84486ab4","line":75,"in_reply_to":"fa32b979_ab470e4a","updated":"2015-07-03 00:48:49.000000000","message":"why not an augeas lens or .erb template?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"nodepool/elements/infra/install.d/10-puppet":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"baa041b7_23c91e79","line":2,"updated":"2015-04-02 17:29:43.000000000","message":"Update to 2015?","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"}],"nodepool/elements/infra/install.d/15-sshd-config":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"51581a048356cde9b206581594708048f19ff345","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        ;;"},{"line_number":30,"context_line":"esac"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"install -m 0444 -o root -g root $(dirname $0)/../files/sshd_config /etc/ssh/sshd_config"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"sed -i -e \"s,%%SFTP_LOCATION%%,$sftp_location,\" /etc/ssh/sshd_config"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba7be1f8_cb05a915","line":32,"updated":"2015-02-19 22:57:52.000000000","message":"Not a big deal, but there is an install-static element you could depend on and then put this file in static/etc/ssh/sshd_config","commit_id":"e5f8d058219d86fefdc35bcb934a40b6c348b1bc"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"baa041b7_c3a6f2c0","line":2,"updated":"2015-04-02 17:29:43.000000000","message":"Update to 2015?","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e2df8fc5fc7636262d054d05ee565919d739a140","unresolved":false,"context_lines":[{"line_number":39,"context_line":"install -m 0444 -o root -g root $(dirname $0)/../files/sshd_config /etc/ssh/sshd_config"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"sed -i -e \"s,%%SFTP_LOCATION%%,$sftp_location,\" /etc/ssh/sshd_config"},{"line_number":42,"context_line":"echo \"root:foobar\" | chpasswd"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ba3cc151_a4d48eeb","line":42,"updated":"2015-07-03 00:38:59.000000000","message":"Say what now?\n\nWhy should root have a password?  And why should it be this?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9d5ace3308e785141de9c140837a763c294c46c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"install -m 0444 -o root -g root $(dirname $0)/../files/sshd_config /etc/ssh/sshd_config"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"sed -i -e \"s,%%SFTP_LOCATION%%,$sftp_location,\" /etc/ssh/sshd_config"},{"line_number":42,"context_line":"echo \"root:foobar\" | chpasswd"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ba3cc151_8452aa33","line":42,"in_reply_to":"ba3cc151_a4d48eeb","updated":"2015-07-03 15:56:45.000000000","message":"It should not. I was debugging glean. \"oops\" ... I\u0027m \"sorry\" ... I \"won\u0027t do it again\"","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"nodepool/elements/infra/install.d/20-ansible-ssh":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"51581a048356cde9b206581594708048f19ff345","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -o pipefail"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -m 0700 /root/.ssh"},{"line_number":22,"context_line":"install -m 0600 -o root -g root $(dirname $0)/../files/authorized_keys /root/.ssh/authorized_keys"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba7be1f8_ce1cd76d","line":22,"updated":"2015-02-19 22:57:52.000000000","message":"same thing about install-static, then you could just delete this file entirely.","commit_id":"e5f8d058219d86fefdc35bcb934a40b6c348b1bc"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"baa041b7_c394b238","line":2,"updated":"2015-04-02 17:29:43.000000000","message":"Update to 2015?","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"9cb6df1b2998b20c8ecccdaafe0b9ea2524c9a93","unresolved":false,"context_lines":[{"line_number":18,"context_line":"set -eu"},{"line_number":19,"context_line":"set -o pipefail"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -m 0700 /root/.ssh"},{"line_number":22,"context_line":"install -m 0600 -o root -g root $(dirname $0)/../files/authorized_keys /root/.ssh/authorized_keys"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"fa32b979_6b782690","line":21,"updated":"2015-06-16 00:27:39.000000000","message":"Elements don\u0027t need to be idempotent. However, the more idempotent they are, the better they interact with other elements. I suggest adding -p. #notaminusone","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9d5ace3308e785141de9c140837a763c294c46c5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"set -eu"},{"line_number":19,"context_line":"set -o pipefail"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"mkdir -m 0700 /root/.ssh"},{"line_number":22,"context_line":"install -m 0600 -o root -g root $(dirname $0)/../files/authorized_keys /root/.ssh/authorized_keys"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"ba3cc151_e43936f3","line":21,"in_reply_to":"fa32b979_6b782690","updated":"2015-07-03 15:56:45.000000000","message":"YES","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"nodepool/elements/infra/install.d/95-locale-gen":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3aa582a1e4e0dad4fa96caf37f51ae2df712b374","unresolved":false,"context_lines":[{"line_number":18,"context_line":"set -eu"},{"line_number":19,"context_line":"set -o pipefail"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Make the local gods happy"},{"line_number":22,"context_line":"DIST\u003d$(lsb_release -is)"},{"line_number":23,"context_line":"[ -n \"$DIST\" ]"},{"line_number":24,"context_line":"case $DIST in"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a930d6b_a7c01fe1","line":21,"updated":"2015-01-23 18:40:12.000000000","message":"localE?","commit_id":"28e7b064422307f785eeb34959f5cd3b9243e550"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"baa041b7_23211efc","line":2,"updated":"2015-04-02 17:29:43.000000000","message":"Update to 2015","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":24,"context_line":"case $DIST in"},{"line_number":25,"context_line":"    \u0027Ubuntu\u0027|\u0027Debian\u0027)"},{"line_number":26,"context_line":"        locale-gen en_US.UTF-8"},{"line_number":27,"context_line":"        ;;"},{"line_number":28,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"baa041b7_03917af0","line":27,"updated":"2015-04-02 17:29:43.000000000","message":"I don\u0027t know much of anything about Redhat OS\u0027s... is en_US.UTF-8 the default or do we also need a:\n\n\u0027Fedora\u0027|\u0027CentOS\u0027)\n    localedef -c -f UTF-8 -i en_US en_US.UTF-8\n    ;;","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"}],"nodepool/elements/infra/post-install.d/95-rm-system-config":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"baa041b7_4393025c","line":2,"updated":"2015-04-02 17:29:43.000000000","message":"Update to 2015?","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"}],"nodepool/elements/infra/source-repository-system-config":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"a4ec57b8bfd39d6a64dd59f28277940db462a2f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"system-config git /tmp/system-config git://git.openstack.org/openstack-infra/system-config"}],"source_content_type":"application/octet-stream","patch_set":15,"id":"ba8a016a_8e16faef","line":1,"updated":"2015-11-20 20:10:53.000000000","message":"Let\u0027s use GIT_BASE\u003d${GIT_BASE:-git://git.openstack.org}","commit_id":"adee89f7267a9de7b66c497f4fd2f8e747bd4012"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"a85350ce2d2f1ff578264f84c5815cf08d8bdde1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"system-config git /tmp/system-config git://git.openstack.org/openstack-infra/system-config"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"ba8a016a_61a3a050","line":1,"updated":"2015-11-21 01:22:13.000000000","message":"Let\u0027s use GIT_BASE\u003d${GIT_BASE:-git://git.openstack.org}","commit_id":"f3158518dc647b97870779c7bfaf5d1d7b32d54a"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"daa9622cc0bd6ace51511d0ffa69b58f5f2fed73","unresolved":false,"context_lines":[{"line_number":1,"context_line":"system-config git /tmp/system-config git://git.openstack.org/openstack-infra/system-config"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"5a710552_a82375a6","line":1,"in_reply_to":"5a710552_4d5f8341","updated":"2015-12-16 00:27:01.000000000","message":"ok, I see. Thanks for the links.","commit_id":"f3158518dc647b97870779c7bfaf5d1d7b32d54a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"53a21199cafb098605a8cfd6eaff7b4a86015c29","unresolved":false,"context_lines":[{"line_number":1,"context_line":"system-config git /tmp/system-config git://git.openstack.org/openstack-infra/system-config"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"5a710552_4d5f8341","line":1,"in_reply_to":"ba8a016a_61a3a050","updated":"2015-12-16 00:24:06.000000000","message":"This isn\u0027t bash, this file has a specific format: http://docs.openstack.org/developer/diskimage-builder/elements/source-repositories/README.html\n\nIf you want to override the remote you can do that without changing this file: http://docs.openstack.org/developer/diskimage-builder/elements/source-repositories/README.html#override-git-remote","commit_id":"f3158518dc647b97870779c7bfaf5d1d7b32d54a"}],"nodepool/elements/rax-nova-agent/install.d/05-xen-tools":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3aa582a1e4e0dad4fa96caf37f51ae2df712b374","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u0027Ubuntu\u0027|\u0027Debian\u0027)"},{"line_number":29,"context_line":"        # Seriously"},{"line_number":30,"context_line":"        source versions.deb"},{"line_number":31,"context_line":"        dpkg -i $XE_GUEST_UTILITIES_PKG_FILE_amd64"},{"line_number":32,"context_line":"        ;;"},{"line_number":33,"context_line":"    \u0027Fedora\u0027|\u0027CentOS\u0027 | \u0027openSUSE project\u0027)"},{"line_number":34,"context_line":"        source versions.rpm"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a930d6b_678f17cd","line":31,"updated":"2015-01-23 18:40:12.000000000","message":"${XE_GUEST_UTILITIES_PKG_FILE}_amd64 yeah? Although... I can\u0027t find where it ever gets set.","commit_id":"28e7b064422307f785eeb34959f5cd3b9243e550"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3aa582a1e4e0dad4fa96caf37f51ae2df712b374","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        ;;"},{"line_number":33,"context_line":"    \u0027Fedora\u0027|\u0027CentOS\u0027 | \u0027openSUSE project\u0027)"},{"line_number":34,"context_line":"        source versions.rpm"},{"line_number":35,"context_line":"        rpm -Uvh $XE_GUEST_UTILITIES_PKG_FILE_x86_64"},{"line_number":36,"context_line":"        ;;"},{"line_number":37,"context_line":"esac"},{"line_number":38,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1a930d6b_87bde36a","line":35,"updated":"2015-01-23 18:40:12.000000000","message":"And similarly here?","commit_id":"28e7b064422307f785eeb34959f5cd3b9243e550"}],"roles.yaml":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- src: git+git://github.com/emonty/ansible-build-image.git"},{"line_number":3,"context_line":"  version: HEAD"},{"line_number":4,"context_line":"  name: build-image"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"baa041b7_553bb5d1","line":2,"updated":"2015-04-02 17:29:43.000000000","message":"I\u0027m not familiar with the process for creating an openstack-infra project, yet, but it seems like this should be that.","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e2df8fc5fc7636262d054d05ee565919d739a140","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba3cc151_44e342d9","updated":"2015-07-03 00:38:59.000000000","message":"I gather this file is used for testing only.  Given that, I\u0027m not terribly troubled that this is from your personal github repo.  However, maybe /roles.yaml isn\u0027t the right place for this?  Maybe in some directory relating to image build testing?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9d5ace3308e785141de9c140837a763c294c46c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba3cc151_9633a361","in_reply_to":"ba3cc151_44e342d9","updated":"2015-07-03 15:56:45.000000000","message":"roles.yaml is kind of like requirements.txt and modues.env ... it\u0027s where you list roles that should be installed on a system. It\u0027s not for testing only. BUT - it doesn\u0027t belong in this patch.","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"tools/HOW-TO-TEST.rst":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e2df8fc5fc7636262d054d05ee565919d739a140","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  echo \"root:foobar\" | chpasswd"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"into an install element to enable logging in via the web console for debugging"},{"line_number":45,"context_line":"purposes."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"To Test on HP"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba3cc151_e4e5b6db","line":45,"updated":"2015-07-03 00:38:59.000000000","message":"That explains the above.  I\u0027m assuming you forgot to remove it.  This suggests that this might be a dangerous practice as it may increase the likelyhood of someone accidentally uploading a change with this line.  Of course, we need to be watching for people \"accidentally\" doing that on purpose anyway.","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"9cb6df1b2998b20c8ecccdaafe0b9ea2524c9a93","unresolved":false,"context_lines":[{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"There is an ansible playbook, `tools/test-dib-upload.yaml` that requires tip of"},{"line_number":56,"context_line":"ansible git, the new openstack modules from"},{"line_number":57,"context_line":"https://github.com/ansible/ansible-modules-extras/pull/92 ::"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  git clone --recursive git://github.com/ansible/ansible.git"}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa32b979_eb3d16bc","line":56,"updated":"2015-06-16 00:27:39.000000000","message":"Is that still true? Has the needed bit been released now?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"tools/build-base-image.sh":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"c73e9213a7a6aa57ed53cd2816a790d6f5e84e41","unresolved":false,"context_lines":[{"line_number":5,"context_line":"QEMU_IMG_OPTIONS\u003d\"compat\u003d0.10\""},{"line_number":6,"context_line":"export QEMU_IMG_OPTIONS"},{"line_number":7,"context_line":"export DIB_RELEASE"},{"line_number":8,"context_line":"export ELEMENTS_PATH\u003d${ELEMENTS_PATH:-nodepool/elements:/home/mordred/src/openstack/diskimage-builder/elements}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"break\u003dafter-error disk-image-create -n -x --no-tmpfs -o $IMAGE-$DIB_RELEASE $IMAGE-minimal vm infra"}],"source_content_type":"text/x-sh","patch_set":11,"id":"baa041b7_35add1e9","line":8,"updated":"2015-04-02 17:29:43.000000000","message":"Defaulting to a users home directory seems odd to me.","commit_id":"813eab83e899c3e2a6c5e55b9f2700f8126dd87d"}],"tools/test-dib-upload.yaml":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"9cb6df1b2998b20c8ecccdaafe0b9ea2524c9a93","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    - name: ustack"},{"line_number":20,"context_line":"      regions:"},{"line_number":21,"context_line":"      - bj1"},{"line_number":22,"context_line":"      format: raw"},{"line_number":23,"context_line":"    #- name: rax"},{"line_number":24,"context_line":"    #  regions:"},{"line_number":25,"context_line":"    #  - DFW"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa32b979_4b752296","line":22,"updated":"2015-06-16 00:27:39.000000000","message":"This seems arbitrary. Whats the thinking on having ustack in, and the others commented out here?","commit_id":"a9ea0689b3c0bd917c45069e52fd589d4bedf7ea"}],"tools/update-rax-metadata.sh":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"ac672249dcf7b09637f30bf3cd76141aecebd8bf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"export OS_IMAGE_API_VERSION\u003d2"},{"line_number":6,"context_line":"IMAGE\u003d${1:-ubuntu}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"id\u003d$(glance image-list | grep \"Test Infra ${IMAGE}\" | awk \u0027{print $2}\u0027)"},{"line_number":9,"context_line":"glance image-update --property vm_mode\u003dhvm --property xenapi_use_agent\u003dfalse $id"}],"source_content_type":"text/x-sh","patch_set":8,"id":"1a6ced46_c9263e16","line":8,"updated":"2015-03-24 15:30:12.000000000","message":"Same here, this image only shows in nova image list for me.","commit_id":"b5a959b60e59d6b7ae86217c82ffc051efcf2e93"}],"tools/upload-rax.sh":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"432b4960ecdfed7c024c1aec9ce3a942f24a753b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"sudo docker run -v $(pwd):/images emonty/vhd-util convert -s 0 -t 1 -i /images/${IMAGE}.raw -o /images/intermediate.vhd"},{"line_number":10,"context_line":"sudo docker run -v $(pwd):/images emonty/vhd-util convert -s 1 -t 2 -i /images/intermediate.vhd -o /images/${IMAGE}.vhd"},{"line_number":11,"context_line":"swift upload --object-name test-monty-${IMAGE}.vhd images ${IMAGE}.vhd"},{"line_number":12,"context_line":"id\u003d$(glance image-list | grep \"Test Infra ${IMAGE}\" | awk \u0027{print $2}\u0027)"},{"line_number":13,"context_line":"glance image-delete $id"},{"line_number":14,"context_line":"glance task-create --type\u003dimport --input\u003d\u0027{\"import_from\": \"images/test-monty-${IMAGE}.vhd\", \"image_properties\" : {\"name\": \"Test Infra ${IMAGE}\"}}\u0027"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"1a6ced46_a9390243","line":12,"updated":"2015-03-24 15:29:33.000000000","message":"For me on rax this never shows the uploaded image. I notice nova image-list does, however.","commit_id":"b5a959b60e59d6b7ae86217c82ffc051efcf2e93"}]}
