)]}'
{"jenkins/jobs/barbican.yaml":[{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"9093cbf886ef72fdfb3e3c09b1f4b50befaa22a0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          export ENABLED_SERVICES\u003dbarbican,tempest,keystone"},{"line_number":59,"context_line":"          export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":60,"context_line":"          export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":61,"context_line":"          export BARBICAN_USE_DOGTAG\u003dtrue"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"          function pre_test_hook {"},{"line_number":64,"context_line":"              cd /opt/stack/new/barbican/functionaltests"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba7be1f8_993123ef","line":61,"updated":"2015-02-20 18:30:02.000000000","message":"Where is this variable used? I can\u0027t see it in devstack, devstack-gate or the functionaltests scripts in the python-barbicanclient repo.\n\nAlso out of curiosity why are you using nosetests in your run_tests.sh file?","commit_id":"2a7f0282f8fd1f91dee41aaafb4a4fa01ed1dea8"},{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"20494a5f45650f9cea51fa657517b885a9755856","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          export ENABLED_SERVICES\u003dbarbican,tempest,keystone"},{"line_number":59,"context_line":"          export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":60,"context_line":"          export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":61,"context_line":"          export BARBICAN_USE_DOGTAG\u003dtrue"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"          function pre_test_hook {"},{"line_number":64,"context_line":"              cd /opt/stack/new/barbican/functionaltests"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba7be1f8_9a266eb9","line":61,"in_reply_to":"ba7be1f8_993123ef","updated":"2015-02-20 21:09:08.000000000","message":"Hi Anita, this CR is for the Barbican Server, not the client.  The CR that uses this variable has not yet been merged into the repo. [1]\n\nRegarding nosetest use in python-barbicanclient, I was copying from Solum\u0027s gate job, and that\u0027s the runner they\u0027re using. [2]\n\n[1] https://review.openstack.org/#/c/157531/\n[2] http://git.openstack.org/cgit/stackforge/solum/tree/functionaltests/run_tests.sh#n64","commit_id":"2a7f0282f8fd1f91dee41aaafb4a4fa01ed1dea8"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"39e101f2df18e757232590165b9b1944eee2b620","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          export ENABLED_SERVICES\u003dbarbican,tempest,keystone"},{"line_number":59,"context_line":"          export PROJECTS\u003d\"openstack/barbican $PROJECTS\""},{"line_number":60,"context_line":"          export PROJECTS\u003d\"openstack/python-barbicanclient $PROJECTS\""},{"line_number":61,"context_line":"          export BARBICAN_USE_DOGTAG\u003dtrue"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"          function pre_test_hook {"},{"line_number":64,"context_line":"              cd /opt/stack/new/barbican/functionaltests"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba7be1f8_7f02853f","line":61,"in_reply_to":"ba7be1f8_9a266eb9","updated":"2015-02-21 00:56:34.000000000","message":"The patch is merged now, in future when one patch is dependent on the functionality of another patch please use Depends-on: in the commit footer. In this case it would have looked like:\n\n Depends-on: I40dfdbc414dbc4fa07b5a5cbed074e6d340c7778\n\nThen I could have found the variable the patch introduced.","commit_id":"2a7f0282f8fd1f91dee41aaafb4a4fa01ed1dea8"}]}
