)]}'
{"jenkins/jobs/neutron-vpnaas-functional.yaml":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"7734aea5f6f77f0552abf57b6171fb0788a4da95","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      - shell: |"},{"line_number":60,"context_line":"          #!/bin/bash -xe"},{"line_number":61,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":62,"context_line":"          export DEVSTACK_GATE_UNSTACK\u003d1"},{"line_number":63,"context_line":"          export DEVSTACK_GATE_TIMEOUT\u003d120"},{"line_number":64,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d0"},{"line_number":65,"context_line":"          export DEVSTACK_GATE_EXERCISES\u003d0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba7be1f8_40b212e7","line":62,"updated":"2015-02-23 20:53:57.000000000","message":"I don\u0027t see any configuration that would allow devstack-gate to ensure that strongswan is installed via devstack.  Is this capability supported by devstack-gate yet?","commit_id":"5e67da801b866123e3f96dec4fd35309978d3c9f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b1fa91d18e04fe4369263a49f52ee39ad4bbcca6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      - shell: |"},{"line_number":60,"context_line":"          #!/bin/bash -xe"},{"line_number":61,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":62,"context_line":"          export DEVSTACK_GATE_UNSTACK\u003d1"},{"line_number":63,"context_line":"          export DEVSTACK_GATE_TIMEOUT\u003d120"},{"line_number":64,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d0"},{"line_number":65,"context_line":"          export DEVSTACK_GATE_EXERCISES\u003d0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba7be1f8_9be39b04","line":62,"in_reply_to":"ba7be1f8_40b212e7","updated":"2015-02-23 21:18:51.000000000","message":"I was planning on (and please tell me if there is a better way) committing to DevStack changes that would check the localrc/local.conf setting IPSEC_PACKAGE, and to, based on that, do the additional settings.\n\nSpecifically, it would disable apparmor for the charon and stroke apps and would set the device driver to strongswan. \n\nThe thought is that I could then set IPSEC_PACKAGE\u003dstrongswan. If that could be done here, then I wouldn\u0027t need to have different hooks below. Otherwise, I could do it in gate_hook.sh.\n\nWould that be a reasonable approach, or were you thinking of some other way to do this?","commit_id":"5e67da801b866123e3f96dec4fd35309978d3c9f"}],"zuul/layout.yaml":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"319c691aefb895776d5833fdd2cdb1c13f6c97f6","unresolved":false,"context_lines":[{"line_number":652,"context_line":"  - name: ^(gate|check)-tempest-dsvm-networking-odl"},{"line_number":653,"context_line":"    branch: ^(?!stable)"},{"line_number":654,"context_line":"    voting: false"},{"line_number":655,"context_line":"  - name: ^(gate|check)-neutron-vpnaas-dsvm-functional"},{"line_number":656,"context_line":"    files:"},{"line_number":657,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":658,"context_line":"      - \u0027^[^/]*$\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba7be1f8_e22fb1f4","line":655,"updated":"2015-02-27 22:27:59.000000000","message":"I think you\u0027ll want a $ at the end of this line to prevent a partial match from succeeding.","commit_id":"1db3d41c575277ae135b45124fbb029ff9f343a6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"103393422e031a39ef15eafee7b178a108b90a1b","unresolved":false,"context_lines":[{"line_number":652,"context_line":"  - name: ^(gate|check)-tempest-dsvm-networking-odl"},{"line_number":653,"context_line":"    branch: ^(?!stable)"},{"line_number":654,"context_line":"    voting: false"},{"line_number":655,"context_line":"  - name: ^(gate|check)-neutron-vpnaas-dsvm-functional"},{"line_number":656,"context_line":"    files:"},{"line_number":657,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":658,"context_line":"      - \u0027^[^/]*$\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba7be1f8_d1f18496","line":655,"in_reply_to":"ba7be1f8_e22fb1f4","updated":"2015-03-01 18:13:53.000000000","message":"Done","commit_id":"1db3d41c575277ae135b45124fbb029ff9f343a6"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"319c691aefb895776d5833fdd2cdb1c13f6c97f6","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    voting: false"},{"line_number":655,"context_line":"  - name: ^(gate|check)-neutron-vpnaas-dsvm-functional"},{"line_number":656,"context_line":"    files:"},{"line_number":657,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":658,"context_line":"      - \u0027^[^/]*$\u0027"},{"line_number":659,"context_line":"  - name: check-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":660,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba7be1f8_82f0b5ca","line":657,"updated":"2015-02-27 22:27:59.000000000","message":"iirc it\u0027s not necessary to quote regexes.\n\nAlso, what is this supposed to match on?  The match targets will be filenames rooted at the repo, and I don\u0027t see \u0027openswan\u0027 or \u0027strongswan\u0027 paths in the openstack/neutron-vpnaas repo.  I also don\u0027t understand what you\u0027re trying to do in the subsequent match rule.  Consider documenting your intent with a comment to aid both reviewers and future maintainers.","commit_id":"1db3d41c575277ae135b45124fbb029ff9f343a6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"103393422e031a39ef15eafee7b178a108b90a1b","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    voting: false"},{"line_number":655,"context_line":"  - name: ^(gate|check)-neutron-vpnaas-dsvm-functional"},{"line_number":656,"context_line":"    files:"},{"line_number":657,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":658,"context_line":"      - \u0027^[^/]*$\u0027"},{"line_number":659,"context_line":"  - name: check-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":660,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba7be1f8_913e2c28","line":657,"in_reply_to":"ba7be1f8_82f0b5ca","updated":"2015-03-01 18:13:53.000000000","message":"Will add a comment. The intent here is that common tests that should run for any flavor of VPNaaS, would reside in tests/functional/. For the new STrongSwan reference implementation, any tests that are specific to that implementation will be in tests/functional/strongswan/. Likewise, if we have an OpenSwan implementation specific tests, they\u0027ll go in tests/functional/openswan. Since functional tests are only being created now, these directories don\u0027t yet exist.","commit_id":"1db3d41c575277ae135b45124fbb029ff9f343a6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e278934a3f669162c181ab8c66052f6788f2d153","unresolved":false,"context_lines":[{"line_number":654,"context_line":"    voting: false"},{"line_number":655,"context_line":"  - name: ^(gate|check)-neutron-vpnaas-dsvm-functional"},{"line_number":656,"context_line":"    files:"},{"line_number":657,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":658,"context_line":"      - \u0027^[^/]*$\u0027"},{"line_number":659,"context_line":"  - name: check-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":660,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba7be1f8_b14ed0c0","line":657,"in_reply_to":"ba7be1f8_913e2c28","updated":"2015-03-01 18:43:05.000000000","message":"Every occurrence I see has them quoted, so I\u0027ve done the same.\n\nThe commit message also has the file matching info, but I\u0027ve added it here too, for next patch set.","commit_id":"1db3d41c575277ae135b45124fbb029ff9f343a6"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c1d01c4374cb133f1689c76e3ec7b56333cf1df9","unresolved":false,"context_lines":[{"line_number":679,"context_line":"#   OpenSwan specific tests will be in tests/functional/openswan/"},{"line_number":680,"context_line":"#   and common tests will be in tests/functional/."},{"line_number":681,"context_line":"    files:"},{"line_number":682,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":683,"context_line":"      - \u0027^[^/]*$\u0027"},{"line_number":684,"context_line":"  - name: check-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":685,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba7be1f8_71d458bd","line":682,"updated":"2015-03-01 18:46:53.000000000","message":"Shouldn\u0027t you check for \u0027^neutron_vpnaas/tests/functional/openswan/$ ?\n\nSimilar in line 689?\n\nLooking at the current neutron-vpnaas repo, I do not see any such tests but only  ./neutron_vpnaas/tests/functional/test_openswan_driver.py and that one will not match the regex above.","commit_id":"f79693031cef366ffe4e298b9032935b465e44c5"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e2dd01c4396aade49247f3e606eeb1c40fcbc0db","unresolved":false,"context_lines":[{"line_number":679,"context_line":"#   OpenSwan specific tests will be in tests/functional/openswan/"},{"line_number":680,"context_line":"#   and common tests will be in tests/functional/."},{"line_number":681,"context_line":"    files:"},{"line_number":682,"context_line":"      - \u0027^openswan/.*$\u0027"},{"line_number":683,"context_line":"      - \u0027^[^/]*$\u0027"},{"line_number":684,"context_line":"  - name: check-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":685,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba7be1f8_314d809a","line":682,"in_reply_to":"ba7be1f8_71d458bd","updated":"2015-03-01 19:07:24.000000000","message":"Looks like I do need to do the path from the top of the repo. I wasn\u0027t sure.\n\nRegarding the tests... there are tests being developed specifically for strongswan, that will be located in tests/functional/strongswan.\n\nThe test_openswan_driver.py was a sample dummy test module (notice that it\u0027s test cases don\u0027t do anything), that was used when the functional tests were first enabled, so there was something to test.\n\nNow, that we need strongswan specific tests, the desire is to split the functional test area into two.  This file, in a separate neutron-vpnaas commit, will be moved to the openswan subdirectory.","commit_id":"f79693031cef366ffe4e298b9032935b465e44c5"}]}